[Breeze] [Bug 375684] Please improve app status indicators in icon-only task manager

https://bugs.kde.org/show_bug.cgi?id=375684 Eike Hein changed: What|Removed |Added Assignee|h...@kde.org|plasma-devel@kde.org Product|plasmashell

[Breeze] [Bug 375684] Please improve app status indicators in icon-only task manager

https://bugs.kde.org/show_bug.cgi?id=375684 Eike Hein changed: What|Removed |Added CC||h...@kde.org --- Comment #1 from Eike Hein --- Rea

Phabricator Project Organisation - Plasma

Hi Plasma Folks, The current structure of the Plasma project on Phabricator causes a few issues with how we currently prefer to setup Herald rules. It also means that people interested in subcommunities within Plasma aren't able to selectively subscribe to those notifications. This is because the

Phabricator: All repositories registered - upcoming workflow changes

Hi everyone, We've just completed the registration of all mainline repositories (not including Websites or Sysadmin namespaced ones) on Phabricator. Thanks go to Luigi Toscano for providing significant assistance with this process. >From this point forward, communities should be moving away from

[Differential] [Updated] D4301: [System Tray] SNI fallback to context menu on failing Activate

davidedmundson added a comment. In https://phabricator.kde.org/D4301#80882, @subdiff wrote: > One more try with guarding against dangling pointers. Just trying out stuff here. So in case this is utter bullshit please tell me if and why it doesn't work. > > My thinking was the followi

[Differential] [Commented On] D4324: Copy user face icon synchronously

davidk added a comment. In https://phabricator.kde.org/D4324#80955, @broulik wrote: > I think this is just working around the fact that a KCM has no way of postponing the closing/deletion of the dialog when OK is clicked. We have the issue of OK not saving settings properly in vari

[Differential] [Abandoned] D4324: Copy user face icon synchronously

davidk abandoned this revision. davidk added a comment. This needs more changes, will upload again if everything works. REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D4324 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: dav

[Differential] [Updated, 7 lines] D4324: Copy user face icon synchronously

davidk updated this revision to Diff 10658. davidk added a comment. Fix method name REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4324?vs=10657&id=10658 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4324 AFFECTED FILES src/accoun

[Differential] [Commented On] D4324: Copy user face icon synchronously

broulik added a comment. I think this is just working around the fact that a KCM has no way of postponing the closing/deletion of the dialog when OK is clicked. We have the issue of OK not saving settings properly in various other places that use jobs, too. REPOSITORY R128 User Manager R

[Differential] [Updated, 7 lines] D4324: Copy user face icon synchronously

davidk updated this revision to Diff 10657. davidk added a comment. Move the file instead of copying it REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4324?vs=10656&id=10657 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4324 AFFECTE

[Differential] [Updated] D4324: Copy user face icon synchronously

davidk updated the summary for this revision. davidk updated the test plan for this revision. davidk added a reviewer: Plasma. REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D4324 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Request, 7 lines] D4324: Copy user face icon synchronously

davidk created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise the CopyJopb thead will be killed if the user klicks the "OK" button, because kcmshell5 quits. Thus the icon won't get saved. As t

[Differential] [Commented On] D4301: [System Tray] SNI fallback to context menu on failing Activate

anthonyfieroni added a comment. > - Guard code execution in `StatusNotifierItemSource::activate` against deleted `m_statusNotifierItemInterface` by comparing it to the old pointer value You can't do that in this way, do this QPointer snii = m_statusNotifierItemInterface; if (sn

[Differential] [Request, 96 lines] D4323: Implement the DBus org.kde.KeyboardLayouts interface of keyboard kded

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY This change introduces a new class KeyboardLayoutDBusInterface which

[Differential] [Request, 4 lines] D4322: Adjust KeyboardLayout to non-kded DBus service

graesslin created this revision. graesslin added a reviewer: Plasma on Wayland. Restricted Application added a project: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The keyboard layout kded module does also register a dedicated DBus service and a

Re: Review Request 129872: [lookandfeel] Support changing window decoration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129872/ --- (Updated Ян. 28, 2017, 12:18 след обяд) Review request for Plasma, Kai Uw

Re: Review Request 129872: [lookandfeel] Support changing window decoration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129872/ --- (Updated Ян. 28, 2017, 12:02 след обяд) Review request for Plasma, Kai Uw

Re: Review Request 129872: [lookandfeel] Support changing window decoration

> On Ян. 28, 2017, 10:47 преди обяд, Martin Gräßlin wrote: > > kcms/lookandfeel/kcm.cpp, line 362 > > > > > > I don't understand why the group is changed here? Was if wrong before? > > How was it wrong? It does

Re: Review Request 129872: [lookandfeel] Support changing window decoration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129872/#review102292 --- I would have a much better time understanding your change if