anthonyfieroni created this revision.
anthonyfieroni added reviewers: Plasma, Plasma: Design.
anthonyfieroni added subscribers: davidedmundson, hein, subdiff.
anthonyfieroni set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Appli
elvisangelaccio created this revision.
elvisangelaccio added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Ran `uncrustify-kf5` from kde-dev-scripts.
TEST PLAN
Builds; still works.
REPOSITORY
R1
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/730/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Feb 2017 22:31:25 +
Build duration: 5 min 35 sec
CHANGE SET
Revision c1858e3a848a0bcb1d27cae808ce
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/729/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Feb 2017 21:51:34 +
Build duration: 23 min
CHANGE SET
Revision 566bbf7ba6bc43b5f00f43667603b9b50e
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Instead of calling it in response to a
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/52/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Feb 2017 21:49:19 +
Build duration: 6 min 21 sec
CHANGE SET
Revision 566bbf7ba6bc43b5f0
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:566bbf7ba6bc: [kioslave/remote] Fix porting bugs
(authored by elvisangelaccio).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4480?vs=11019&id=11034
REVI
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/728/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Feb 2017 21:08:31 +
Build duration: 5 min 46 sec
CHANGE SET
Revision f0eb59ed931492159a67b2b17b46
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/51/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Feb 2017 21:06:06 +
Build duration: 18 min
CHANGE SET
Revision f0eb59ed931492159a67b2b1
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:8edd0336e67d: Support creation of PlasmaShellSurface
prior to ShellSurface (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4482?vs=11022&id=110
anthonyfieroni added a comment.
Workaround cannot be made, Qt 5.8 counts internal messages e.g.
MouseEventPress internal wants MouseEventRelease intenal, our message can't
mess counting. Will be good when Qt bug is closed :)
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:f0eb59ed9314: [Icon Applet] More sensible minimum height
(authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4477?vs=11010&id=11031
REVI
This revision was automatically updated to reflect the committed changes.
Closed by commit R224:54d43cebcbb0: [Applet] Make "no device available" heading
consistent with other applets (authored by broulik).
REPOSITORY
R224 KDE Connect
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D44
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
R224 KDE Connect
REVISION DETAIL
https://phabricator.kde.org/D4478
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma, apo
mart accepted this revision.
mart added a reviewer: mart.
mart added a comment.
This revision is now accepted and ready to land.
In https://phabricator.kde.org/D4477#83824, @broulik wrote:
> > doesn't this rather suggests more than iconsizes.small
>
> Yes, it needs to, since below the
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
plasmasurface-before-shell-surface-5.9
REVISION DETAIL
https://phabricator.kde.org/D4482
EMAIL PREFERENCES
https://phabric
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
bug/376131
REVISION DETAIL
https://phabricator.kde.org/D4480
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:1a9ece7cd457: Require C++11 through cmake (authored by
graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4486?vs=11025&id=11028
REVISION DETAIL
https://pha
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:16647c3a3c3e: Require Qt 5.7 and remove pre-5.7 code
(authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4485?vs=11024&id=11027
REVISION DETAIL
broulik updated the summary for this revision.
broulik updated this revision to Diff 11026.
broulik added a comment.
- For launchers show all places. There the menu is less likely to become
overly large as there's no window controls in this case.
I looked into KActivitiesStats or KFilePla
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
require-cpp11
REVISION DETAIL
https://phabricator.kde.org/D4486
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: grae
bshah accepted this revision.
bshah added a reviewer: bshah.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
require-qt-5.7
REVISION DETAIL
https://phabricator.kde.org/D4485
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To:
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
This replaces the previous solution to require at least gcc 4.8 which
did not cover clang. As c
mart added a comment.
with this on top of https://codereview.qt-project.org/#/c/184278/ the
situation with Qt 5.8 is definitely improved
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D4482
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
Increases minimum Qt version to 5.7. This allows to drop the pre-5.7
virtual keyboard and vario
graesslin added inline comments.
INLINE COMMENTS
> switchuserdialog.cpp:171
> +{
> +setKeyboardGrabEnabled(false);
> +}
I highly suggest to explicitly xcb_flush here. Otherwise your request to ungrab
the keyboard is racing with your DBus call to screenlocker. There is a chance
that the scr
graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.
REVISION SUMMARY
So far KWin did not support the sequence:
1. Create wl_shell
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R114 Plasma Addons.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
TEST PLAN
- Opened popup, clicked the button in compact re
elvisangelaccio updated this revision to Diff 11019.
elvisangelaccio added a comment.
- Rebased
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4480?vs=11018&id=11019
BRANCH
bug/376131
REVISION DETAIL
https://phabricator.kde.org/D4480
AFFECTE
elvisangelaccio created this revision.
elvisangelaccio added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Commit
https://phabricator.kde.org/R120:72e39f083a103e0887624482d6a0ce8b0556dd5e broke
the
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:55b6011d3b02: [Color Picker] Pick color only on left
click (authored by broulik).
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4479?vs=11016&id=11017
REVIS
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D4479
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailprefere
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R114 Plasma Addons.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Allows to cancel picking with right click
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/50/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Feb 2017 16:07:02 +
Build duration: 14 min
CHANGE SET
Revision 7b1dc9a4bb039ff5ff2a5b71
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/727/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Feb 2017 16:07:28 +
Build duration: 6 min 3 sec
CHANGE SET
Revision 08dff33f72fb734c5317ecf879d8f
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7b1dc9a4bb03: make services disqualification much
stricter (authored by sitter).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4415?vs=10865&id=11015
REV
broulik created this revision.
broulik added reviewers: Plasma, apol.
broulik set the repository for this revision to R224 KDE Connect.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Also ensure that it wraps instead of o
hein accepted this revision.
hein added a reviewer: hein.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4476
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: d
broulik added a comment.
> doesn't this rather suggests more than iconsizes.small
Yes, it needs to, since below the icon you always get a label which we didn't
take into account previously.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4477
EMAIL PRE
mart added a comment.
not sure about this..
doesn't this rather suggests more than iconsizes.small (that semantically
should be the smallest icon that makes sense) isn't scaled correctly for the
high dpi?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D44
davidedmundson updated this revision to Diff 11012.
davidedmundson added a comment.
Fix stupid phab getting itself confused
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4476?vs=11011&id=11012
BRANCH
master
REVISION DETAIL
https://phabricator.
broulik added a comment.
+1
INLINE COMMENTS
> MouseHandler.qml:125
> onDrop: {
> // Reject internal drops.
> +if (event.mimeData.formats.indexOf("text/x-plasmoidservicename")
> >= 0) {
// Reject plasmoid drops, so the containment can handle them.
REPOSITOR
broulik added inline comments.
INLINE COMMENTS
> broulik wrote in MouseHandler.qml:135
> For `onDrop` the URL check is fine. There we would launch the respective
> application and send the URL to it
Nevermind. You did the right thing, and I was already wondering why my comment
showed up on the
davidedmundson updated this revision to Diff 11013.
davidedmundson added a comment.
Trying again to make phab show the same thing
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4476?vs=11012&id=11013
BRANCH
master
REVISION DETAIL
https://phabri
davidedmundson updated this revision to Diff 11011.
davidedmundson added a comment.
update
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4476?vs=11008&id=11011
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4476
AFFECTED FILES
a
Plasma 5.9.1 is out now with a week's worth of updates
https://www.kde.org/announcements/plasma-5.9.1.php
davidedmundson abandoned this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4476
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreute
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Take into account the label's height f
broulik added inline comments.
INLINE COMMENTS
> MouseHandler.qml:135
> -
> -if (event.mimeData.hasUrls) {
> -parent.urlsDropped(event.mimeData.urls);
For `onDrop` the URL check is fine. There we would launch the respective
application and send the URL to it
REPOSIT
> On Feb. 7, 2017, 9:26 a.m., Marco Martin wrote:
> > not sure is a good idea.
> > the tooltips not dismissing anymore if hovered may become quite annoying,
> > which is usually the main complaint on our tooltips.
Well, the tooltip shows the load and frequency on all CPUs and memory
consumptio
davidedmundson added a comment.
In https://phabricator.kde.org/D4416#83780, @cfeck wrote:
> QApplication::desktopFileName() was only added in Qt 5.7, while frameworks
still support Qt 5.6. Please add a Qt version check around the new code.
Done, thanks
REPOSITORY
R289 KNotifica
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:eb39b3514130: [ScrollViewStyle] Evaluate frameVisible
property (authored by subdiff).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4473?vs=1100
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
A previous patch made the task manager only accept drag events which
contained URL lists or i
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/600/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Feb 2017 12:17:52 +
Build duration: 16 min
CHANGE SET
Revision a682b7c586cb9acdff4fad869e97e70241e3
subdiff added a comment.
In https://phabricator.kde.org/D4473#83779, @hein wrote:
> Aye. I think that's weird
I agree.
> Does defaulting the frames to on mean the bottom flash is back too or is
that still fixed?
Still fixed.
> Can't comment on the ramifications of d
guoyunhe closed this revision.
REVISION DETAIL
https://phabricator.kde.org/D3009
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: guoyunhe, #plasma_workspaces, mart
Cc: davidedmundson, mart, plasma-devel, lesliezhai, ali-mohamed,
jensreuterberg, abetts, seb
cfeck added a comment.
QApplication::desktopFileName() was only added in Qt 5.7, while frameworks
still support Qt 5.6. Please add a Qt version check around the new code.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D4416
EMAIL PREFERENCES
https://phabric
hein added a comment.
Aye. I think that's weird, but I'm guessing the Breeze style had no choice
there.
Does defaulting the frames to on mean the bottom flash is back too or is that
still fixed?
Can't comment on the ramifications of defaulting it to on + other themes ...
REPOSITORY
subdiff added a comment.
The scroll indicators **are** the frame component in the Breeze style. So
they get replaced in any other style by the frame specified there. If you take
a look at ScrollViewStyle.qml, the indicators are inside the frame component
and the frame sides just change their
hein abandoned this revision.
hein added a comment.
I'll abandon, I don't really like this approach either.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4475
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, #plasma
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/599/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Feb 2017 11:48:44 +
Build duration: 18 min
CHANGE SET
Revision 5df635d804648b039e64a6b372fb5292abc7
broulik added a comment.
Also, shouldn't any kind of drag raise windows, not just URL drops? I could
for instance want to drag a color from one Inkscape palette to another
INLINE COMMENTS
> MouseHandler.qml:69
>
> +<<< Updated upstream
> +===
conflict markers
> MouseHandler.qml:8
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:d8a1a9eb084b: don't regenerate frames when setting every
property (authored by mart).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4414?vs=1100
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129932/#review102441
---
I agree with Marco.
Furthermore, introducing special toolti
mart updated this revision to Diff 11006.
mart added a comment.
- just use enabledBorders to return as a property
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4414?vs=10861&id=11006
BRANCH
arcpatch-D4414
REVISION DETAIL
https://ph
elvisangelaccio added a comment.
Another possible fix would be to add an empty QUrl to the ark mimeData, i.e.
fixing it from the ark side.
Question is: are we sure ark is the only application affected by the
regression?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabric
hein created this revision.
hein added reviewers: Plasma, broulik, davidedmundson.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma.
REVISION SUMMARY
This is an attempt at a lazy fix for bug 375871, fixing a regression
from
https://phabricator.kde.org/R119
hein added a comment.
Is there some danger in this when using the component with a different theme
that has visible frames?
Should the scroll indicators be tied to frame visibility at all? That seems
dubious to me.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/55/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Feb 2017 11:29:42 +
Build duration: 18 min
CHANGE SET
Revision acae3816b7ae686542bc4dfeac
davidedmundson added inline comments.
INLINE COMMENTS
> mart wrote in framesvg.cpp:136
> it has pendingEnabledBorders because right now the borders are saved only n
> the frame, that we don't know if we can keep it or we'll have to throw it
> away ( or just dereference because some other frames
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/598/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Feb 2017 11:27:46 +
Build duration: 10 min
CHANGE SET
Revision b9f053e3c8152954e2f2c7a5788392447edf
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5df635d80464: Make it possible to change icon themes from
elsewhere in kns (authored by apol).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4317?vs=10633&i
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/49/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Feb 2017 11:13:08 +
Build duration: 6 min 5 sec
CHANGE SET
Revision 08dff33f72fb734c531
Hey,
One of the topics that were put in the Etherpad for the Plasma sprint is the
following:
- get new look&feel: remove it from 5.8? users complain that breaks their
system as it doesn't support dependencies in 5.8 (deps can't be backported
either,as would bump frameworks requirement); now w
guoyunhe closed this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4288
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: guoyunhe, #plasma, mart
Cc: plasma-devel, guoyunhe, #frameworks, lesliezhai, ali-m
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-tests%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/4/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Feb 2017 11:12:48 +
Build duration: 59 sec
CHANGE SET
Revision 3d7ac5614cdd3070b080525243b11
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/54/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Feb 2017 11:11:42 +
Build duration: 6 min 21 sec
CHANGE SET
Revision b9f053e3c8152954e2f2
subdiff updated this revision to Diff 11003.
subdiff added a comment.
Set ScrollArea's frameVisible default to true additional in order to not
change current implementations.
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4473?vs=10997&i
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:acae3816b7ae: [Solid Device Actions KCM] Encode action
file name (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4474?vs=11001&id=11002
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in framesvg.cpp:136
> I'm lost on why we have the pendingEnabledBorders
>
> you have some bugs if you do:
>
> setRepaintBlocked(false);
> setEnabledBorders(Left)
> enabledBorders() /// returns All not Left.
>
> it'll get update
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4474
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailprefer
davidedmundson added inline comments.
INLINE COMMENTS
> framesvg.cpp:136
>
> -FrameData *fd = d->frames[d->prefix];
> -
> -const QString oldKey = d->cacheId(fd, d->prefix);
> -const EnabledBorders oldBorders = fd->enabledBorders;
> -fd->enabledBorders = borders;
> -const QSt
subdiff added a comment.
You mean in Plasma's ScrollArea? Would be ok for me. It's a rather random
deviation from upstream's ScrollView though.
Is this ok for anyone else aswell?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4473
EMAIL PREF
mart added a comment.
what about changing the default to true but still have the binding?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4473
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: subdiff, #plasma, m
hein accepted this revision.
hein added a reviewer: hein.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4401
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: d
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/726/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Feb 2017 10:41:19 +
Build duration: 5 min 38 sec
CHANGE SET
Revision 605fb9acd867e22e171184a08d9d
subdiff added a comment.
Note: This patch changes the default. Since until now the frameVisible
property wasn't evaluated the frames were always shown.
But since QtQuickControls ScrollView (i.e. Plasma Extra Components ScrollArea
aswell) has set frameVisible to false by default, they are
hein added a comment.
IIUI this means scroll indicators are now disabled by default unless a UI
sets frameVisible: true? Marco, is this what you +1'd?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4473
EMAIL PREFERENCES
https://phabricator.kde
broulik added a comment.
-1
I don't get the overflow indicator mark anywhere anymore since frameVisible
is `false` by default for Plasma ScrollView.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4473
EMAIL PREFERENCES
https://phabricator.
broulik created this revision.
broulik added reviewers: Plasma, dfaure.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Allows to put slashes in there.
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:605fb9acd867: [Calculator Runner] Port non-Qalculate
codepath from QtScript to QtQml (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/597/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Feb 2017 10:12:21 +
Build duration: 6 min 26 sec
CHANGE SET
Revision d798319fee1d29e8da301580301a19
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kde-gtk-config%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/44/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Feb 2017 10:13:48 +
Build duration: 1 min 45 sec
CHANGE SET
Revision e8412b5d5772a9705469c94ceeffa953
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kde-gtk-config%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/44/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Feb 2017 10:13:48 +
Build duration: 1 min 45 sec
CHANGE SET
Revision e8412b5d5772a9705469c94ceeffa953
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4473
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: subdiff, #plasma, hein, mart
Cc: pl
subdiff created this revision.
subdiff added reviewers: Plasma, mart, hein.
subdiff added a subscriber: hein.
subdiff set the repository for this revision to R242 Plasma Framework (Library).
subdiff added a project: Plasma.
Restricted Application added subscribers: Frameworks, plasma-devel.
Restric
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/53/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Feb 2017 10:11:58 +
Build duration: 6 min 12 sec
CHANGE SET
Revision d798319fee1d29e8da30
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-tests%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/3/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Feb 2017 10:00:03 +
Build duration: 1 min 5 sec
CHANGE SET
Revision c23e7c0969248de4fcc9
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d798319fee1d: [Task Manager] Enable "Mark applications
that play audio" option only if plasma… (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.k
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/725/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Feb 2017 09:50:41 +
Build duration: 7 min 32 sec
CHANGE SET
Revision a0374d8fffa8649afc8d9c12ba11
1 - 100 of 119 matches
Mail list logo
