graesslin added a subscriber: subdiff.
graesslin added a comment.
@subdiff Can you please try whether this change fixes the problem with your
external keyboard?
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D4617
EMAIL PREFERENCES
https://phabricator.kde.org/setting
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
With this change the ModifierOnlyShortcut starts to track the actual
pressed keys instead using
jsalatas added a reviewer: KTextEditor.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D4538
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: jsalatas, #frameworks, #plasma, #ktexteditor
Cc: plasma-devel, kwrite-devel, lesliezhai,
broulik created this revision.
broulik added reviewers: Plasma, VDG, dfaure, aacid.
broulik set the repository for this revision to R824 Baloo Widgets.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This allows to view me
anthonyfieroni abandoned this revision.
anthonyfieroni added a comment.
https://phabricator.kde.org/D4455
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4587
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ant
Plasma 5.9.2 has now been released
https://www.kde.org/announcements/plasma-5.9.2.php
This revision was automatically updated to reflect the committed changes.
Closed by commit R123:1c77df276e45: Check the background is valid when choosing
background type (authored by davidedmundson).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D4611?vs=11343&id=11344#toc
REPOSITORY
R
broulik accepted this revision.
broulik added a reviewer: broulik.
This revision is now accepted and ready to land.
REPOSITORY
R123 SDDM Configuration Panel (KCM)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4611
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
I rushed in an emergency fix for 5.9.1 that added support for setting
the background type, wh
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:65ddd32d1a78: Split modifier only handling into a
dedicated InputEventSpy (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4578?vs=11239&id=1134
graesslin added inline comments.
INLINE COMMENTS
> subdiff wrote in keyboard_input.cpp:686
> Somewhat unrelated to this diff, but can't we get rid of all these `m_inited`
> conditions by setting up LibInput via `InputRedirection::setupLibInput()` and
> connecting the functions in KeyboardInputR
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/67/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Feb 2017 15:54:14 +
Build duration: 5 min 38 sec
CHANGE SET
Revision dda4d42e891a386c74
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:dda4d42e891a: Fix manually reordering launchers.
(authored by hein).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4608?vs=11337&id=11338
REVISION DETAIL
hein added a comment.
I finally had time to look at this. The approach looks good to me, and I
don't see anything wrong on a quick read. Please rebase as you plammed and I'll
fine-comb it (quicker this time). Thanks!
REVISION DETAIL
https://phabricator.kde.org/D3805
EMAIL PREFERENCES
ht
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
Plasma/5.9
REVISION DETAIL
https://phabricator.kde.org/D4608
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, ivan, da
hein created this revision.
hein added reviewers: Plasma, ivan, davidedmundson.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma.
REVISION SUMMARY
syncLaunchers() is called after drag operations end to write the order
of launchers in the all-capping TasksMo
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
it's possible to do setPath(zipfile path) and open
a compressed package as it was a real on
broulik retitled this revision from "WIP: Media Controls on lock screen" to
"Media Controls on lock screen".
broulik updated the test plan for this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3684
EMAIL PREFERENCES
https://phabricator.kde.org/se
hein added a comment.
In the review comment you write that users of the API can use the MIME data
to decide whether to call setApplicationActions, but in
https://phabricator.kde.org/D4576 you end up manipulating the provided QMenu
instance directly, including code written in awareness of KIO
https://bugs.kde.org/show_bug.cgi?id=348603
Roman Gilg changed:
What|Removed |Added
CC||subd...@gmail.com
--- Comment #2 from Roman Gilg
hein accepted this revision.
hein added a reviewer: hein.
hein added a comment.
This revision is now accepted and ready to land.
Modulo the 'mimeDataCopy' name change we mentioned on IRC.
REPOSITORY
R119 Plasma Desktop
BRANCH
phab/dropmenu
REVISION DETAIL
https://phabricator.kde.org/D4
subdiff updated the summary for this revision.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D4358
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: subdiff, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, ab
subdiff updated this revision to Diff 11333.
subdiff added a comment.
- Now doesn't reverts changes of https://phabricator.kde.org/D3459 anymore
(and supports it in build script instead of adding the symlink directly).
- Doesn't change mode for build scripts anymore.
REPOSITORY
R31 Breeze
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/620/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Feb 2017 14:46:50 +
Build duration: 7 min 59 sec
CHANGE SET
Revision 690e6f2e21fa50e71cda81b31edd5e
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/619/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Feb 2017 14:18:47 +
Build duration: 26 min
CHANGE SET
Revision ad78eed5be08f219b26d0eaf4d0ff16f2f8d
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/71/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Feb 2017 14:18:47 +
Build duration: 22 min
CHANGE SET
Revision 7d214263cae60e488558529344
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:690e6f2e21fa: [ConfigurationContainmentActions] Pass Info
button as context for showAbout (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.or
On Tue, Feb 14, 2017 at 12:34 PM, Kai Uwe Broulik
wrote:
> Hi all,
>
> in July I took over maintainership of Plasma Notifications from Martin
> Klapetek and slowly started revamping them to be suited for the current
> decade, adding productivity features, making them more usable for
> enterprises
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4569
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailprefer
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d67aea401703: [PanelView] Emit
availableScreenRegionChanged in resizeEvent, not when setting… (authored by
broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator
apol updated this revision to Diff 11332.
apol added a comment.
Use the strictly required version of Qt
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4599?vs=11316&id=11332
BRANCH
arcpatch-D4599
REVISION DETAIL
https://phabricator.kde.org/D4599
AFF
apol marked an inline comment as done.
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D4599
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol, #kirigami, mart
Cc: plasma-devel, apol
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ad78eed5be08: [Task Manager] Add "Places" for entries
belonging to a file manager (authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D3815?vs=11026&id=11331#toc
REPOSITORY
subdiff accepted this revision.
subdiff added a reviewer: subdiff.
subdiff added a comment.
This revision is now accepted and ready to land.
Didn't find any obvious issues in code plus tested it on X and Wayland.
INLINE COMMENTS
> keyboard_input.cpp:686
> m_input->processSpies(std::bind(
hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.
Accepted, but please make the minor mods I suggested if you can.
INLINE COMMENTS
> ContextMenu.qml:38
>
> +property bool showAllPlaces
> +
Maybe a dated C++ mindset, but I don't like hav
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4590
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma
On Tuesday 14 February 2017, Kai Uwe Broulik wrote:
> There's no point in me being the maintainer if I'm not consulted. I'll
> still do the occasional bugfixing there as part of my overall Plasma work
> but don't expect any groundbreaking new features [1], I'm tired of
> constantly having to clean
broulik added a comment.
Does it even make sense to show this thing if there's no battery? We already
show a cross on the icon then, don't we? Makes it a bit redundant. On the other
hand it could be confusing to have the option checked but then have it not do
anything – maybe the check box n
broulik added inline comments.
INLINE COMMENTS
> CompactRepresentation.qml:74
> anchors.fill: batteryIcon
> -text: i18nc("battery percentage below battery icon",
> "%1%", percent)
> +text: batteryContainer.hasBattery ? i18nc("battery
davidedmundson added inline comments.
INLINE COMMENTS
> BadgeOverlay.qml:36
> color: theme.backgroundColor
> -width: label.width + units.devicePixelRatio * 2
> +width: Math.max(units.gridUnit, label.width + units.devicePixelRatio
> * 2)
> height: label.height
w
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
if there is no battery don't show 0%, but a - on
the badge. still show the badge to show the option is not broken
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/66/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Feb 2017 12:24:07 +
Build duration: 10 min
CHANGE SET
Revision b0cb9a4c36c62eb679225cea
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-tests%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/5/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Feb 2017 12:23:25 +
Build duration: 6 min 58 sec
CHANGE SET
Revision 15b1d982d8a6a52677a72a8
On Wed, Feb 8, 2017 at 11:39 PM, Łukasz Sawicki wrote:
> However what saddens me the most is the fact that I warned you guys
> about potential issues before Plasma 5.8 release in September. [2].
> Either way it is up to you how are going to solve this "problem". In
> any case, I still plan to work
On Tue, Feb 14, 2017 at 11:10 AM, Marco Martin wrote:
> On Tuesday 14 February 2017, Aleix Pol wrote:
>> Hey Marco, Plasma,
>> I've been investigating the issue I mentioned before leaving the
>> sprint. As you can see, QQC1.Label stops rendering eventually.
>> https://bugreports.qt.io/browse/QTBUG
(Re-sent, sorry BlackBerry Hub keeps insisting to send stupid html emails)
Hi all,
in July I took over maintainership of Plasma Notifications from Martin Klapetek
and slowly started revamping them to be suited for the current decade, adding
productivity features, making them more usable for en
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/753/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Feb 2017 11:18:32 +
Build duration: 14 min
CHANGE SET
Revision 034bf808787540bfae4facee15a54bac15c
Hi all,in July I took over maintainership of Plasma Notifications from Martin Klapetek and slowly started revamping them to be suited for the current decade, adding productivity features, making them more usable for enterprises, etc. My personal highlight is the draggable previews feature I added,
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/753/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Feb 2017 11:18:32 +
Build duration: 14 min
CHANGE SET
Revision 034bf808787540bfae4facee15a54bac15c
drosca added a comment.
Yes.
Latest master
https://phabricator.kde.org/R242:263f119e17df7c24f8372710c555486429b57971 -
broken.
Latest master
https://phabricator.kde.org/R242:263f119e17df7c24f8372710c555486429b57971 with
this change reverted - fixed.
REPOSITORY
R242 Plasma Framewor
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:034bf8087875: Add missing summaries (authored by apol).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D4447?vs=10939&id=11327#toc
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
davidedmundson added a comment.
This shouldn't have any impact to it being pixelated, it just changes where
the texture is stored, it can't make it any smaller.
Are you sure it's definitely this change?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.k
mart added a comment.
i get only a white empty area where the headers should be?
INLINE COMMENTS
> ListViewGallery.qml:21
> import QtQuick 2.0
> +import QtQuick.Controls 2.1
> import QtQuick.Layouts 1.2
we can depend only from Qt 5.7, so would be import QtQuick.Controls 2.0
REPOSITORY
R
On Tuesday 14 February 2017, Aleix Pol wrote:
> Hey Marco, Plasma,
> I've been investigating the issue I mentioned before leaving the
> sprint. As you can see, QQC1.Label stops rendering eventually.
> https://bugreports.qt.io/browse/QTBUG-58852
>
> I'm sending this e-mail because Kirigami.Label an
This revision was automatically updated to reflect the committed changes.
Closed by commit R99:0a7fafc7e2f4: Don't break compatibility with old configs
(authored by elvisangelaccio).
REPOSITORY
R99 KDE Gtk Configuration Tool
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4594?vs=1127
drosca added a comment.
This broke rendering of icons in Quicklaunch plasmoid for me (Sandy Bridge
GPU), you can see on the screenshot that it is pixelated. Also the image
slightly moves during the active animation, as texture atlas is used only when
animation is not running.
I can only se
56 matches
Mail list logo