[Powerdevil] [Bug 358957] laptop won't hybrid-suspend when Plasma is running

2017-02-20 Thread Stuart Morgan
https://bugs.kde.org/show_bug.cgi?id=358957 --- Comment #17 from Stuart Morgan --- I completely understand the volunteer nature of the project, I've been an open source contributor for well over 10 years now. However no-one wants to waste their time working on a solution when there is one alread

[Powerdevil] [Bug 358957] laptop won't hybrid-suspend when Plasma is running

2017-02-20 Thread Martin Gräßlin
https://bugs.kde.org/show_bug.cgi?id=358957 --- Comment #16 from Martin Gräßlin --- > If no-one currently active on the project is able (too busy) or > interested in > implementing this, then please tell us now so that one of us from the > community > can step up and do it instead. we are a co

[Powerdevil] [Bug 358957] laptop won't hybrid-suspend when Plasma is running

2017-02-20 Thread Stuart Morgan
https://bugs.kde.org/show_bug.cgi?id=358957 Stuart Morgan changed: What|Removed |Added CC||stu...@tase.co.uk --- Comment #15 from Stuart M

[Differential] [Commented On] D4689: IconItem: Add roundToIconSize property

2017-02-20 Thread David Edmundson
davidedmundson added a comment. Makes sense and the code is fine +1 from me. I assume you have an intended usage in mind? INLINE COMMENTS > iconitem.h:101 > +/** > + * If set, icon will round the painted size to defined icon sizes > + */ add the line "the default is true" R

Re: KMS backlight ABI proposition

2017-02-20 Thread Thierry Reding
Cc'ing Daniel, Lee and Jingoo, the backlight subsystem maintainers. On 17/02/17 14:58, Martin Peres wrote: > Hey everyone, > > We have been working towards exposing the backlight as a KMS property > instead of relying on the backlight drivers. We have CC:ed the people we > have found to be the mo

Re: KMS backlight ABI proposition

2017-02-20 Thread Daniel Thompson
On 20/02/17 12:46, Martin Peres wrote: +plasma-devel, as suggested by Martin Gräßlin. This reply also adds the current drivers/video/backlight maintainers (I forwarded the original mail to them separately, so I've been pretty brutal with the delete key when quoting the original mail). On

[Differential] [Updated] D4550: Task Manager: Make the icon size configurable for task buttons in a vertical task manager

2017-02-20 Thread Peter Palaga
ppalaga retitled this revision from "Task Manager: Make maximum text lines and minimum line length configurable for task buttons." to "Task Manager: Make the icon size configurable for task buttons in a vertical task manager". ppalaga edited the summary of this revision. ppalaga edited the test p

[Differential] [Updated, 57 lines] D4550: Task Manager: Make maximum text lines and minimum line length configurable for task buttons.

2017-02-20 Thread Peter Palaga
ppalaga updated this revision to Diff 11562. ppalaga added a comment. New or noteworthy about the second iteration: (1) It implements the proposal c) of Eike. (2) There is is just one "Icon size" control in the configuration dialog, instead of two controls in the previous iteration.

[Differential] [Reclaimed] D4550: Task Manager: Make maximum text lines and minimum line length configurable for task buttons.

2017-02-20 Thread Peter Palaga
ppalaga reclaimed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4550 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ppalaga, davidedmundson, hein, broulik Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed,

[Differential] [Abandoned] D4550: Task Manager: Make maximum text lines and minimum line length configurable for task buttons.

2017-02-20 Thread Peter Palaga
ppalaga abandoned this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4550 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ppalaga, davidedmundson, hein, broulik Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed,

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 629 - Still Unstable!

2017-02-20 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/629/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 20 Feb 2017 18:24:46 + Build duration: 5 min 37 sec CHANGE SET Revision cc8c82ac1b43161ac670dfddc7b4af

[Differential] [Closed] D4671: Touchpad KCM: simplify few UI strings

2017-02-20 Thread Luigi Toscano
This revision was automatically updated to reflect the committed changes. Closed by commit R119:cc8c82ac1b43: Touchpad KCM: simplify few UI strings (authored by ltoscano). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4671?vs=11511&id=11561 REVISION D

[Differential] [Updated] D3530: Import plasma-workspace kioslaves

2017-02-20 Thread Elvis Angelaccio
elvisangelaccio removed a dependent revision: D3531: Drop remote ioslave, will be in KIO 5.32. REVISION DETAIL https://phabricator.kde.org/D3530 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, #frameworks, #plasma, dfaure Cc: mart, aacid,

[Differential] [Updated] D3531: Drop remote ioslave, will be in KIO 5.32

2017-02-20 Thread Elvis Angelaccio
elvisangelaccio edited dependencies, added: D4690: Import remote ioslave from plasma-workspace; removed: D3530: Import plasma-workspace kioslaves. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3531 EMAIL PREFERENCES https://phabricator.kde.org/settings/pane

[Differential] [Requested Review] D3531: Drop remote ioslave, will be in KIO 5.32

2017-02-20 Thread Elvis Angelaccio
elvisangelaccio requested review of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3531 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, #plasma, davidedmundson Cc: bshah, lbeltrame, davidedmu

[Differential] [Updated] D3531: Drop remote ioslave, will be in KIO 5.32

2017-02-20 Thread Elvis Angelaccio
elvisangelaccio retitled this revision from "Drop kioslave folder, will be in KIO 5.30" to "Drop remote ioslave, will be in KIO 5.32". elvisangelaccio edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3531 EMAIL PREFERENCES

[Differential] [Updated, 899 lines] D3531: Drop kioslave folder, will be in KIO 5.30

2017-02-20 Thread Elvis Angelaccio
elvisangelaccio updated this revision to Diff 11556. elvisangelaccio added a comment. Only drop `remote:/` REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3531?vs=8573&id=11556 REVISION DETAIL https://phabricator.kde.org/D3531 AFFECTED FILES C

[Differential] [Abandoned] D3530: Import plasma-workspace kioslaves

2017-02-20 Thread Elvis Angelaccio
elvisangelaccio abandoned this revision. elvisangelaccio added a comment. I've decided to keep it simple and only move `remote:/` for now. Please continue in https://phabricator.kde.org/D4690. REVISION DETAIL https://phabricator.kde.org/D3530 EMAIL PREFERENCES https://phabricator.kde.org

[Differential] [Request, 56 lines] D4689: IconItem: Add roundToIconSize property

2017-02-20 Thread David Rosca
drosca created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Disabling this property makes it possible to show icon of arbitrary size. TEST PLAN Test passed REPOSITORY R242 Plas

[Differential] [Updated] D4688: [FrameSvgItemMargins] Don't update on repaintNeeded

2017-02-20 Thread David Rosca
drosca added a comment. Looks fine, but unfortunately it doesn't help with anything, the issue with networkmanager applet delegates is still there. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4688 EMAIL PREFERENCES https://phabricator.kde.or

[Differential] [Accepted] D4688: [FrameSvgItemMargins] Don't update on repaintNeeded

2017-02-20 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4688 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, drosca,

[Differential] [Request, 1 line] D4688: [FrameSvgItemMargins] Don't update on repaintNeeded

2017-02-20 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY FrameSvgItem already updates the margins in response to that. TEST PLAN `FrameSvgItem` has connect(m_frameSvg,

Jenkins-kde-ci: khotkeys master kf5-qt5 » Linux,gcc - Build # 34 - Fixed!

2017-02-20 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khotkeys%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/34/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 20 Feb 2017 15:29:47 + Build duration: 10 min CHANGE SET Revision 0bfbecfc99e4e1939b79bb9be36d8151cb9ad332 by

Jenkins-kde-ci: khotkeys master kf5-qt5 » Linux,gcc - Build # 34 - Fixed!

2017-02-20 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khotkeys%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/34/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 20 Feb 2017 15:29:47 + Build duration: 10 min CHANGE SET Revision 0bfbecfc99e4e1939b79bb9be36d8151cb9ad332 by

[Differential] [Closed] D4687: Add page property that tells if the page is currently selected

2017-02-20 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R169:c5adb75fab0f: Add page property that tells if the page is currently selected (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4687?vs=11548&id=11549#toc REPOSITORY R169 Kir

I've left the VDG group on Phabricator

2017-02-20 Thread Thomas Pfeiffer
Hi everyone, just a heads-up: I have just left the VDG group on Phabricator. This does not mean that I have a problem with the VDG or that I don’t identify as part of it anymore, but I have realized that I simply do not have the time and energy to keep up with the influx Phabricator requests anym

[Differential] [Accepted] D4687: Add page property that tells if the page is currently selected

2017-02-20 Thread Marco Martin
mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > Page.qml:205 > + * > + * Specifies if it's the currently selected page in the window's pages > row. > + */ add @since 2.1 REPOSITORY R169 Kirigami BRANCH

[Differential] [Request, 7 lines] D4687: Add page property that tells if the page is currently selected

2017-02-20 Thread Aleix Pol Gonzalez
apol created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Useful to be able to visually react to the page having the focus REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabric

[Differential] [Commented On] D4667: [applet] Let specify a version for applets private plugins

2017-02-20 Thread Anthony Fieroni
anthonyfieroni added a comment. Move mouse over taskmanager :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4667 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: anthonyfieroni, #plasma, davidedmundson, dfaure, sitter Cc

[Differential] [Accepted] D4671: Touchpad KCM: simplify few UI strings

2017-02-20 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D4671 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ltoscano, subdiff, d

[Differential] [Commented On] D4667: [applet] Let specify a version for applets private plugins

2017-02-20 Thread Harald Sitter
sitter added a comment. Still does not crash. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4667 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: anthonyfieroni, #plasma, davidedmundson, dfaure, sitter Cc: hein, plasma-de

[Differential] [Updated] D4671: Touchpad KCM: simplify few UI strings

2017-02-20 Thread Luigi Toscano
ltoscano added a reviewer: subdiff. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4671 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ltoscano, subdiff Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, a

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 628 - Still Unstable!

2017-02-20 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/628/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 20 Feb 2017 14:24:01 + Build duration: 17 min CHANGE SET Revision 8aa83dff8e0fbb2e682fb7b861cedb490658

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 77 - Still Unstable!

2017-02-20 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/77/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 20 Feb 2017 14:20:26 + Build duration: 5 min 59 sec CHANGE SET Revision 8aa83dff8e0fbb2e682f

[Differential] [Updated, 4 lines] D4683: Use icon center for vertical hitscan on drop.

2017-02-20 Thread Eike Hein
hein updated this revision to Diff 11539. hein added a comment. Remove missed debug. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4683?vs=11537&id=11539 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4683 AFFECTED FILES contain

[Differential] [Closed] D4683: Use icon center for vertical hitscan on drop.

2017-02-20 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R119:c9a7741f2b80: Use icon center for vertical hitscan on drop. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4683?vs=11539&id=11541 REVISI

[Differential] [Accepted] D4683: Use icon center for vertical hitscan on drop.

2017-02-20 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D4683 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma, mart Cc: plasma

[Differential] [Request, 6 lines] D4683: Use icon center for vertical hitscan on drop.

2017-02-20 Thread Eike Hein
hein created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY Previously the delegate center was used, which can cause drops to land in lower grid cells than expected based on the key visual, which is the icon. REPOSITORY R119 Plasma Desktop BRANCH master

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 79 - Still Unstable!

2017-02-20 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/79/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 20 Feb 2017 13:17:14 + Build duration: 14 min CHANGE SET Revision 513ad12b76a96d2919e1bbfa

[Differential] [Closed] D4680: Map StartupWMClass for Chrome apps instead of RegExp'ing the name

2017-02-20 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:513ad12b76a9: Map StartupWMClass for Chrome apps instead of RegExp'ing the name (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4680?vs=11531&id=11535#toc REPOSITORY R1

[Differential] [Request, 1 line] D4681: [Logout Screen] Show suspend button only if supported

2017-02-20 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 376601 FIXED-IN: 5.8.7 TEST PLAN Button still shows up here since I can suspend. Changed value to false in ksmserver and it no longe

Re: KMS backlight ABI proposition

2017-02-20 Thread Martin Peres
+plasma-devel, as suggested by Martin Gräßlin. On 17/02/17 14:58, Martin Peres wrote: Hey everyone, We have been working towards exposing the backlight as a KMS property instead of relying on the backlight drivers. We have CC:ed the people we have found to be the more likely to be interested i

[Differential] [Accepted] D4680: Map StartupWMClass for Chrome apps instead of RegExp'ing the name

2017-02-20 Thread Eike Hein
hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. And I guess the rule is only for apps and not Chrome's .desktop itself which distros may fuck up. OK then ... fine for 5.9 by me. REPOSITORY R120 Plasma Workspace REVISION DETAIL http

[Differential] [Commented On] D4680: Map StartupWMClass for Chrome apps instead of RegExp'ing the name

2017-02-20 Thread Kai Uwe Broulik
broulik added a comment. According to Chromium source code in `shell_integration_linux.cc` in `CreateAppListDesktopShortcut` (called by `CreateShortcuts`) it calls `GetDesktopFileContentsForCommand` which always ends up doing `g_key_file_set_string(key_file, kDesktopEntry, "StartupWMClass",

[Differential] [Updated] D4680: Map StartupWMClass for Chrome apps instead of RegExp'ing the name

2017-02-20 Thread Eike Hein
hein added a comment. How certain are you that .desktop files for Chrome usually specify a StartupWMClass? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4680 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #p

[Differential] [Request, 21 lines] D4680: Map StartupWMClass for Chrome apps instead of RegExp'ing the name

2017-02-20 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We only matched for the "Default" suffix which is the default profile but this breaks when having apps installed in different profiles where t

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 78 - Still Unstable!

2017-02-20 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/78/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 20 Feb 2017 12:07:58 + Build duration: 14 min CHANGE SET Revision 2a3b74df75123678577161e4

[Differential] [Closed] D4573: [kioslave/remote] Fix broken kded module

2017-02-20 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R120:2a3b74df7512: [kioslave/remote] Fix broken kded module (authored by elvisangelaccio). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4573?vs=11231&id=11529

[Differential] [Accepted] D4573: [kioslave/remote] Fix broken kded module

2017-02-20 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.9 REVISION DETAIL https://phabricator.kde.org/D4573 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, #plasma

[Differential] [Commented On] D4648: try harder to make the selected wallpaper visible

2017-02-20 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D4648#87129, @hein wrote: > I've used multiple techniques to do similar "do stuff when positioning is complete". One is using PropertyChange in populate transitions to change a prop when populate is done. > > I think Qt 5.9 will ac

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 627 - Still Unstable!

2017-02-20 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/627/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 20 Feb 2017 11:28:08 + Build duration: 14 min CHANGE SET Revision 151bfb728ce8eed923f8e32ae39e345441af

[Differential] [Commented On] D4667: [applet] Let specify a version for applets private plugins

2017-02-20 Thread Anthony Fieroni
anthonyfieroni added a comment. diff --git a/applets/taskmanager/plugin/backend.h b/applets/taskmanager/plugin/backend.h index 87037c6..ef47344 100644 --- a/applets/taskmanager/plugin/backend.h +++ b/applets/taskmanager/plugin/backend.h @@ -104,6 +104,7 @@ class Backend : pub

[Differential] [Updated] D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

2017-02-20 Thread Kai Uwe Broulik
broulik edited the test plan for this revision. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D4614 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #vdg, dfaure, aacid Cc: ltoscano, davidedmundson, plasma-dev

[Differential] [Updated, 127 lines] D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

2017-02-20 Thread Kai Uwe Broulik
broulik updated this revision to Diff 11528. broulik added a comment. - Drop Message.sh change REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4614?vs=11350&id=11528 REVISION DETAIL https://phabricator.kde.org/D4614 AFFECTED FILES src/CMakeLists.

Minutes Monday Plasma Meeting

2017-02-20 Thread Sebastian Kügler
The meeting today was great. It. Was. Great. It really was! -- sebas http://www.kde.org | http://vizZzion.orgPlasma Meeting minutes 20-02-2017 Present: romangg, d_ed, notmart, Sho_, kbroulik, bshah, sebas romangg: * last week I mainly worked on my SoK project: https://phabricator.kde.org/D453

[Differential] [Closed] D4678: use folderview as default containment

2017-02-20 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R119:151bfb728ce8: use folderview as default containment (authored by mart). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4678?vs=11524&id=11527 REVISION DETAI

[Differential] [Request, 11 lines] D4679: [ConfigView] Honor KIOSK Control Module restrictions

2017-02-20 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. TEST PLAN Placed the following in kdeglobals [KDE Control Module Restrictions] kcm_pulseaudio.desktop=false No longer got

[Differential] [Updated, 47 lines] D4674: StreamRestore: Cache values in writeChanges until receiving change from pa

2017-02-20 Thread David Rosca
drosca updated this revision to Diff 11525. drosca added a comment. Use cache everywhere REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4674?vs=11515&id=11525 BRANCH Plasma/5.9 REVISION DETAIL https://phabricator.kde.org/D4674 AFFE

[Differential] [Accepted] D4675: Applet: Add configure button next to tabbar

2017-02-20 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet BRANCH applet-settings-button (branched from master) REVISION DETAIL https://phabricator.kde.org/D4675 EMAIL PREFERENCES https://phabricator.kde.org/setting

[Differential] [Commented On] D4674: StreamRestore: Cache values in writeChanges until receiving change from pa

2017-02-20 Thread David Rosca
drosca added inline comments. INLINE COMMENTS > streamrestore.cpp:154 > vol.values[channel] = volume; > writeChanges(vol, m_channelMap, m_muted, m_device); > } You can see here what the problem is, I forgot to add the same logic here (it doesn't use cache). REPOSITORY R115 Plasma

[Differential] [Commented On] D4674: StreamRestore: Cache values in writeChanges until receiving change from pa

2017-02-20 Thread David Rosca
drosca added a comment. > why does that make it broke? From QML side, we call: stream.setVolume(0); stream.setMuted(true); and on the C++ side it turns to // Lets say the current state of C++ object is: muted = false, vol = 20 setVolume(0) -> writeChanges(vol = 0

[Differential] [Commented On] D4674: StreamRestore: Cache values in writeChanges until receiving change from pa

2017-02-20 Thread David Edmundson
davidedmundson added a comment. > Fixes correctly muting Notification Sounds stream in KCM when moving slider to 0 value, because in that moment the KCM first sets volume to 0 and then immediately mute to true. Sorry to be a noob, why does that make it broke? REPOSITORY R115 Plas

[Differential] [Accepted] D4678: use folderview as default containment

2017-02-20 Thread Eike Hein
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH phab/folderviewdef REVISION DETAIL https://phabricator.kde.org/D4678 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, hei

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 626 - Still unstable!

2017-02-20 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/626/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 20 Feb 2017 10:24:25 + Build duration: 6 min 20 sec CHANGE SET Revision 239e2be33fa08a703473c6178c39b9

[Differential] [Request, 2 lines] D4678: use folderview as default containment

2017-02-20 Thread Marco Martin
mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY now it's possible to do as the drop menu is unified REPOSITORY R119 Plasma Desktop BRANCH phab/folderviewdef REVISION DETAIL https://phab

[Differential] [Closed] D4576: integrate drop menu and filecopy drop menu

2017-02-20 Thread Marco Martin
mart closed this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4576 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, hein Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed,

[Differential] [Updated] D4576: integrate drop menu and filecopy drop menu

2017-02-20 Thread Marco Martin
mart retitled this revision from "[WIP]: integrate drop menu and filecopy drop menu" to "integrate drop menu and filecopy drop menu". REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D4576 REVISION DETAIL https://phabricator.kde.org/D4576 EMAIL PREFERENCES https://phabricator

[Differential] [Closed] D4620: allow to add application actions on an open menu

2017-02-20 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R241:c1bbe00181b0: allow to add application actions on an open menu (authored by mart). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4620?vs=11521&id=11522 REVISION DETAI

[Differential] [Closed] D4574: [WIP]: unify file drop menu and containment

2017-02-20 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R119:239e2be33fa0: [WIP]: unify file drop menu and containment (authored by mart). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4574?vs=11370&id=11523 REVISION

[Differential] [Updated, 23 lines] D4620: allow to add application actions on an open menu

2017-02-20 Thread Marco Martin
mart updated this revision to Diff 11521. mart added a comment. don't remove separators qmenu collpapses them and previous code might have assert REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4620?vs=11402&id=11521 BRANCH arcpatch-D4620 REVISION DETAI

[Differential] [Request, 24 lines] D4677: Applet: Show info message when no devices found / applications playing audio

2017-02-20 Thread David Rosca
drosca created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY May probably need change of wording a bit REPOSITORY R115 Plasma Audio Volume Applet BRANCH applet-no-streams-msg (branched from master)

[Differential] [Commented On] D4677: Applet: Show info message when no devices found / applications playing audio

2017-02-20 Thread David Rosca
drosca added a comment. F2514343: Spectacle.VEa651.png F2514345: Spectacle.bhc651.png REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D4677 EMAIL PREFERENCES https:

[Differential] [Commented On] D4676: Applet: Remember last active tab

2017-02-20 Thread David Rosca
drosca added a comment. The devices tab is now always visible when user first opens the applet. But in the basic use-case where you have just one output device and you control its volume with global volume shortcuts, you want to adjust volume of applications when you open the applet. So it e

[Differential] [Commented On] D4676: Applet: Remember last active tab

2017-02-20 Thread Bhushan Shah
bshah added a comment. -1, I believe this can be super annoying if it remembers the active tab from last session.. and in general it is more like "magic" behavior. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D4676 EMAIL PREFERENCES https://ph

[Differential] [Updated, 33 lines] D4675: Applet: Add configure button next to tabbar

2017-02-20 Thread David Rosca
drosca updated this revision to Diff 11519. drosca added a comment. Fixed issues REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4675?vs=11516&id=11519 BRANCH applet-settings-button (branched from master) REVISION DETAIL https://phab

[Differential] [Request, 19 lines] D4676: Applet: Remember last active tab

2017-02-20 Thread David Rosca
drosca created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN switched to apps -> restarted plasmashell -> apps was current tab REPOSITORY R115 Plasma Audio Volume Applet BRANCH remember-tab (branched from m

[Differential] [Commented On] D4667: [applet] Let specify a version for applets private plugins

2017-02-20 Thread Eike Hein
hein added a comment. It's worth keeping in mind KDE stuff has never supported runtime updates. Consider e.g. kconf_update, which runs while apps run, and apps can undo its changes on quit. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4667 EMAIL PREFERENC

[Differential] [Commented On] D4600: TaskManager: add icon to cache after painfully querying it over XCB/NETWM.

2017-02-20 Thread Eike Hein
hein added a comment. Yep. The first string is called "Instance" and the second is called "Class". I.e. the latter is supposed to represent the application, the former is supposed to represent a unique instance of it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.

[Differential] [Changed Subscribers] D4675: Applet: Add configure button next to tabbar

2017-02-20 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > main.qml:299 > +Layout.alignment: Qt.AlignBottom > +tooltip: i18n("Configure Volume Settings...") > +iconSource: "configure" Just use plasmoid.action("configure").text > main.qml:300 > +tooltip:

[Differential] [Commented On] D4675: Applet: Add configure button next to tabbar

2017-02-20 Thread David Rosca
drosca added a comment. F2514281: Spectacle.b20805.png REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D4675 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma

[Differential] [Commented On] D4667: [applet] Let specify a version for applets private plugins

2017-02-20 Thread Harald Sitter
sitter added a comment. Provide a diff so we can reproduce? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4667 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: anthonyfieroni, #plasma, davidedmundson, dfaure, sitter Cc: p

[Differential] [Request, 32 lines] D4675: Applet: Add configure button next to tabbar

2017-02-20 Thread David Rosca
drosca created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 365282 FIXED-IN: 5.10 TEST PLAN Clicked button, opened settings REPOSITORY R115 Plasma Audio Volume Applet BRANCH applet-setting

[Differential] [Commented On] D4667: [applet] Let specify a version for applets private plugins

2017-02-20 Thread Anthony Fieroni
anthonyfieroni added a comment. I'm a bit pretty harsh, add other private variable and handcopy newly plugin e.g. sudo cp libtaskmanagerplugin.so $(locate private/taskmanager/libtaskmanagerplugin.so) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4667 EMAIL

[Differential] [Commented On] D4140: Rework playing of volume feedback

2017-02-20 Thread David Rosca
drosca added a comment. Ping. The issue pointed by @broulik have now been fixed, it only plays feedback for volume changes made by the applet. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D4140 EMAIL PREFERENCES https://phabricator.kde.org/set

[Differential] [Abandoned] D4138: Only update mute state after volume change is signalled from PA

2017-02-20 Thread David Rosca
drosca abandoned this revision. drosca added a comment. Replaced with https://phabricator.kde.org/D4674 REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D4138 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosc

[Differential] [Request, 36 lines] D4674: StreamRestore: Cache values in writeChanges until receiving change from pa

2017-02-20 Thread David Rosca
drosca created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY pa_ext_stream_restore have only one function to change all its properties, so we need to cache values between clients changing StreamRestore

[plasmashell] [Bug 370464] On reboot desktop wallpaper settings are forgotten

2017-02-20 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=370464 Harald Sitter changed: What|Removed |Added Product|Plasma Workspace Wallpapers |plasmashell Target Milestone|---

[Plasma Workspace Wallpapers] [Bug 370464] On reboot desktop wallpaper settings are forgotten

2017-02-20 Thread davidblunkett
https://bugs.kde.org/show_bug.cgi?id=370464 --- Comment #1 from davidblunkett --- Anyone? Where are the desktop wallpapers settings stored? I'm pretty sick of this bug and would happily hard-wire the wallpaper at this point... -- You are receiving this mail because: You are the assignee for th

[Differential] [Commented On] D4667: [applet] Let specify a version for applets private plugins

2017-02-20 Thread Harald Sitter
sitter added a comment. You could just build an autotest maybe? 👅 So, let's try with the previously mentioned https://cgit.kde.org/plasma-desktop.git/commit/?h=Plasma/5.9&id=dc17f78ebcc76600040a8d2ef8c57b9a41a8d06e I am doing: git clone --branch Plasma/5.9 kde:plasma-desktop