[Differential] [Request, 41 lines] D4805: Basic keyboard support + fixes to QuickShare plasmoid: Plasma-addons side patch

yuenlim created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Plasma-addons repository side changes for Differential https://phabricator.kde.org/D4803 REPOSITORY R114 Plasma Addons REVISION DETAIL

[Differential] [Commented On] D4803: Basic keyboard support + fixes to QuickShare plasmoid

yuenlim added a comment. Oops, excuse me :( I was trying to add diffs for two repositories into one differential but it looks like that does not work. I'll create one more differential for the changes in plasma-addons then. REPOSITORY R495 Purpose Library REVISION DETAIL

[Differential] [Updated, 8 lines] D4803: Basic keyboard support + fixes to QuickShare plasmoid

yuenlim updated this revision to Diff 11839. yuenlim retitled this revision from "Keyboard support + improvements to QuickShare plasmoid" to "Basic keyboard support + fixes to QuickShare plasmoid". yuenlim edited the summary of this revision. yuenlim added a reviewer: apol. REPOSITORY R495

[Differential] [Commented On] D4491: Let make taskmanager tooltip readable again

jsalatas added a comment. In https://phabricator.kde.org/D4491#89982, @anthonyfieroni wrote: > ElideMiddle on basic regex match for path I like the idea but ElideMiddle doesn't seem to work for me: Seems that it just keeps the left part of the text that it can fit and ignores

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 83 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/83/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 26 Feb 2017 06:56:16 + Build duration: 20 min CHANGE SET Revision

[Differential] [Request, 41 lines] D4803: Keyboard support + improvements to QuickShare plasmoid

yuenlim created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D4803 AFFECTED FILES applets/quickshare/plasmoid/contents/ui/ShareDialog.qml

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 80 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/80/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 26 Feb 2017 06:55:56 + Build duration: 6 min 1 sec CHANGE SET Revision

[Differential] [Updated, 5 lines] D4491: Let make taskmanager tooltip readable again

anthonyfieroni updated this revision to Diff 11837. anthonyfieroni added a comment. ElideMiddle on basic regex match REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4491?vs=11719=11837 REVISION DETAIL https://phabricator.kde.org/D4491 AFFECTED

[Differential] [Commented On] D4491: Let make taskmanager tooltip readable again

anthonyfieroni added inline comments. INLINE COMMENTS > jsalatas wrote in ToolTipInstance.qml:108 > Is it possible to have it always fixed to 2 lines and not just max to 2? > Otherwise having either 1 or 2 line we would end up in unaligned/bad-looking > tooltips (see screenshot), although I

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 636 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/636/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 26 Feb 2017 04:59:54 + Build duration: 7 min 18 sec CHANGE SET Revision

[Differential] [Changed Subscribers] D4491: Let make taskmanager tooltip readable again

jsalatas added inline comments. INLINE COMMENTS > ToolTipInstance.qml:108 > height: undefined > +maximumLineCount: 2 > elide: Text.ElideRight Is it possible to have it always fixed to 2 lines and not just max to 2? Otherwise having either 1 or

[Differential] [Commented On] D4800: [Task Manager] text elide doesn't work for Tooltips

jsalatas added a comment. In https://phabricator.kde.org/D4800#89954, @subdiff wrote: > Removing the undefineds increases the margins between the lines again. @anthonyfieroni had another fix for the elide a few days ago by setting the maximumLineCount property. He hadn't yet pushed it

[Differential] [Abandoned] D4800: [Task Manager] text elide doesn't work for Tooltips

jsalatas abandoned this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4800 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jsalatas, #plasma, #vdg, anthonyfieroni, subdiff Cc: plasma-devel, progwolff, lesliezhai,

[Differential] [Updated] D4800: [Task Manager] text elide doesn't work for Tooltips

subdiff added a comment. Removing the undefineds increases the margins between the lines again. @anthonyfieroni had another fix for the elide a few days ago by setting the maximumLineCount property. He hadn't yet pushed it though. I would go for his solution if it retains the margins. You

[Differential] [Accepted] D4763: [Notifications] Keep popup opened during drag

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4763 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, davidedmundson

[Differential] [Accepted] D4767: Applet: Fix binding loop on ListItem height

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet BRANCH applet-bindingloop (branched from master) REVISION DETAIL https://phabricator.kde.org/D4767 EMAIL PREFERENCES

[Differential] [Accepted] D4770: KCM: Only scroll when mouse is over tabbar

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet BRANCH kcm-scroll2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D4770 EMAIL PREFERENCES

[Differential] [Accepted] D4794: Fix default fixed font in fonts kcm

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D4794 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: fvogt, #plasma,

[Differential] [Accepted] D4781: Add Module class + disable advanced options when module-gconf is not loaded

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Thanks. BTW, I update Neon's packaging (and then Kubuntu copied) to include gconf now. REPOSITORY R115 Plasma Audio Volume Applet BRANCH loaded-modules (branched from

Re: Review Request 123300: Make the dataengine alignment timer more precise

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123300/ --- (Updated Feb. 25, 2017, 11:59 p.m.) Status -- This change has been

[Differential] [Commented On] D4800: [Task Manager] text elide doesn't work for Tooltips

jsalatas added a comment. If you agree, I believe this should be committed to 5.9 branch and not wait until 5.10. Please confirm. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4800 EMAIL PREFERENCES

[Differential] [Request, 3 lines] D4800: [Task Manager] text elide doesn't work for Tooltips

jsalatas created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Seems that `height: undefined` cause the elide not to work in the Tooltip headings TEST PLAN Before F2611512: before.png

[Differential] [Request, 164 lines] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

subdiff created this revision. subdiff added a project: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The ToolButton has a rather odd looking style, which often conflicts with its placement and other lines in

Re: Review Request 126946: Remove specific X11 code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126946/#review102606 --- Patch doesn't apply anymore. - Albert Astals Cid On Feb.

Re: Review Request 127408: Make sure the QPlatformWindow doesn't get initialized prematurely.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127408/#review102603 --- Aleix? - Albert Astals Cid On March 17, 2016, 2:16 a.m.,

Re: Review Request 127409: Make sure we're not forcing the window to be created prematurely

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127409/#review102600 --- What's the status of this? Should it be commited? improved?

[Differential] [Updated] D4794: Fix default fixed font in fonts kcm

fvogt edited the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4794 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: fvogt, #plasma Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed,

[Differential] [Updated] D4794: Fix default fixed font in fonts kcm

fvogt added a reviewer: Plasma. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4794 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: fvogt, #plasma Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

[Differential] [Request, 4 lines] D4794: Fix default fixed font in fonts kcm

fvogt created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Now it is the same as used by plasma-integration. Also adjust the file name in the comment, which was apparently forgotten. TEST PLAN I

[Differential] [Request, 32 lines] D4792: [Kicker] Property for hiding app categories in RootModel

subdiff created this revision. subdiff added a project: Plasma. REVISION SUMMARY With RootModel it is possible to represent pretty much any combination of other Kicker models. What's not yet possible is to show for example exclusively "All Applications" together with "Recent Applications",

[Differential] [Request, 106 lines] D4785: Add a small test application for kcheckpass

graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is just a small tool to help development on kcheckpass. A minimal qtquick gui which uses the Authenticator to test whether the

[Differential] [Updated, 232 lines] D4781: Add Module class + disable advanced options when module-gconf is not loaded

drosca updated this revision to Diff 11810. drosca added a comment. Fix issues REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4781?vs=11802=11810 BRANCH loaded-modules (branched from master) REVISION DETAIL

[Differential] [Changed Subscribers] D4781: Add Module class + disable advanced options when module-gconf is not loaded

broulik added inline comments. INLINE COMMENTS > modulemanager.cpp:83 > +QTimer *updateModulesTimer = new QTimer(this); > +updateModulesTimer->setInterval(500); > +connect(updateModulesTimer, ::timeout, this, > ::updateLoadedModules); singleShot? > modulemanager.cpp:129 > +

[Differential] [Closed] D4784: Quicklaunch: Don't use plasma theme for icons

This revision was automatically updated to reflect the committed changes. Closed by commit R114:d91b43268939: Quicklaunch: Don't use plasma theme for icons (authored by drosca). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4784?vs=11806=11809

[Differential] [Closed] D4782: Quicklaunch: Open context menu on mouse press

This revision was automatically updated to reflect the committed changes. Closed by commit R114:b0436c547873: Quicklaunch: Open context menu on mouse press (authored by drosca). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4782?vs=11804=11808

[Differential] [Accepted] D4782: Quicklaunch: Open context menu on mouse press

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R114 Plasma Addons BRANCH quicklaunch-pressmenu (branched from master) REVISION DETAIL https://phabricator.kde.org/D4782 EMAIL PREFERENCES

[Differential] [Accepted] D4784: Quicklaunch: Don't use plasma theme for icons

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R114 Plasma Addons BRANCH quicklaunch-plasmatheme (branched from master) REVISION DETAIL https://phabricator.kde.org/D4784 EMAIL PREFERENCES

[Differential] [Request, 1 line] D4784: Quicklaunch: Don't use plasma theme for icons

drosca created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Make it consistent with Icon plasmoid REPOSITORY R114 Plasma Addons BRANCH quicklaunch-plasmatheme (branched from master) REVISION

[Differential] [Request, 10 lines] D4782: Quicklaunch: Open context menu on mouse press

drosca created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R114 Plasma Addons BRANCH quicklaunch-pressmenu (branched from master) REVISION DETAIL https://phabricator.kde.org/D4782 AFFECTED FILES

[Differential] [Commented On] D4781: Add Module class + disable advanced options when module-gconf is not loaded

drosca added a comment. F2603222: Screenshot_20170225_100501.png REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D4781 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Request, 231 lines] D4781: Add Module class + disable advanced options when module-gconf is not loaded

drosca created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Options are correctly enabled/disabled according to loaded state of module-gconf REPOSITORY R115 Plasma Audio Volume Applet BRANCH