graesslin added inline comments.
INLINE COMMENTS
> nalvarez wrote in projector.cpp:101-126
> I think it would be acceptable if the cursor is drawn just like it is now, on
> its own layer, even if drawing it without the transformation would make it
> slightly deformed visually.
>
> You just hav
nalvarez added inline comments.
INLINE COMMENTS
> nowicki wrote in projector.cpp:101-126
> The reason for taking over cursor drawing is that when transformation is
> applied the pointer pixmap doesn't match the point where the cursor actually
> hits the windows below it. Since there is no way t
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/116/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 12 Apr 2017 03:05:50 +
Build duration: 15 min
CHANGE SET
Revision 583427c4a1daf98d740b08d7b
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/921/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 12 Apr 2017 02:28:18 +
Build duration: 3 min 33 sec
CHANGE SET
No changes
JUNIT RESULTS
Name:
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/920/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 12 Apr 2017 02:17:17 +
Build duration: 10 min
CHANGE SET
No changes
JUNIT RESULTS
Name: (root
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/848/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 12 Apr 2017 02:06:13 +
Build duration: 9 min 57 sec
CHANGE SET
Revision 9ce65592a57764cec8a0ebae6285
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/709/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 12 Apr 2017 02:05:43 +
Build duration: 9 min 2 sec
CHANGE SET
Revision f71786ef058beab7676d81282b2d3b0
stikonas created this revision.
stikonas added a project: Plasma on Wayland.
Restricted Application added subscribers: Frameworks, plasma-devel.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
On Wayland icons are obtained from desktop files that are named
reverseOrganizat
davidedmundson added inline comments.
INLINE COMMENTS
> ddcutilbrightness.cpp:149
> +
> +ddca_get_vcp_value(m_displayHandleList.at(0),
> + m_descrToVcp_perDisp.at(0)->value("Brightness"),
you should check the return of this == 0
In case of error I would expect retu
dvogel marked 9 inline comments as done.
dvogel added a comment.
Ok, so there is apparently an issue when the screen gets dimmed.
Application: org_kde_powerdevil (org_kde_powerdevil), signal: Segmentation
fault
Using host libthread_db library "/usr/lib/libthread_db.so.1".
[Curre
graesslin added a reviewer: leinir.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D5403
To: graesslin, #kwin, #plasma, leinir
Cc: plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, hardening,
jensreuterberg, abetts, sebas, apol
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
This change ensures that the blocking condition of screen edges is also
honored for touch screen swipe gestures.
TEST PLAN
Only the a
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:3259d5e11326: Cancel popup if the user clicked window
decoration of parent window (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5388?vs=13305
davidedmundson added a comment.
This patch breaks the "Defaults" button as it will reset the index, but
you'll still have your custom changes.
I don't see how this patch solves anything, previously you could edit a
global scheme and the workflow was just as easy; you click Edit, the only
mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
sometimes the downloaded file isn't correctly flushed to
disk, causing corrupted zip files, especially if they come
from
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
Plasma/5.9
REVISION DETAIL
https://phabricator.kde.org/D5401
To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, progwolff, lesliezhai, ali-mohamed, hardening,
davidedmundson added inline comments.
INLINE COMMENTS
> colorscm.cpp:219
> +} else {
> +schemeRemoveButton->setText(i18n("Remove Scheme"));
> +}
and you need to set it to disabled
otherwise if you edit a theme then reset it, you'll now have an option to
davidedmundson created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.
REVISION SUMMARY
The KCM has a context property of the currently set theme index. This is
set before the decorations model is populated, so it
markg added a comment.
I'm just curious. Why is the day name determined in QML (in the lines you
edited, but was there before as well) and on the C++ side?
It smells like a redundancy.
As far as i can tell (only looked for a moment), the dayName on the C++ side
isn't used "in" the C++
mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Allow to edit and save system-wide color schemes.
it saves them in the user home and they will override the global one
the remove button becom
Am 2017-04-11 13:31, schrieb Martin Gräßlin:
Am 11. April 2017 13:13:11 MESZ schrieb Dan Leinir Turthra Jensen
:
On Tuesday, 11 April 2017 11:32:18 BST Martin Gräßlin wrote:
Am 11. April 2017 11:23:01 MESZ schrieb Dan Leinir Turthra Jensen
:
>Heyhey :)
>
>i do rather like the idea of edge ges
fvogt updated this revision to Diff 13325.
fvogt added a comment.
Fixed label capitalization
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5351?vs=13233&id=13325
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5351
AFFECTED FILES
Am 11. April 2017 15:27:54 MESZ schrieb Marco Martin :
>On Tuesday 11 April 2017, Martin Gräßlin wrote:
>> >
>> >or, by default only have gestures on top and bottom edge, and leave
>> >left and
>> >right to applications (which, the user is free to override)
>>
>> on Wayland applications cannot t
On Tuesday 11 April 2017, Martin Gräßlin wrote:
> >
> >or, by default only have gestures on top and bottom edge, and leave
> >left and
> >right to applications (which, the user is free to override)
>
> on Wayland applications cannot take any edge anyway as they don't know
> their position. Which m
broulik added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in notificationsapplet.cpp:54
> I think, corona (witch is parent of containment) is still alive and that's
> why slot is invoked.
Obviously, the corona manages all the containments, we only delete a single
containment, thoug
Am 11. April 2017 15:00:21 MESZ schrieb Marco Martin :
>On Tuesday 11 April 2017, Martin Gräßlin wrote:
>> >is quite annoying when such accidental activations happen. Again,
>this
>> >is
>> >only, specifically, for full screen applications, not for the
>general
>> >case,
>> >where the rest of the
On Tuesday 11 April 2017, Martin Gräßlin wrote:
> >is quite annoying when such accidental activations happen. Again, this
> >is
> >only, specifically, for full screen applications, not for the general
> >case,
> >where the rest of the system is visible.
> >
> > Hope that is an at least marginally
mart added a comment.
+1 from me as well
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D5382
To: jgrulich, #plasma, #vdg
Cc: mart, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
popup-cancel-deco
REVISION DETAIL
https://phabricator.kde.org/D5388
To: graesslin, #kwin, #plasma, mart
Cc: plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, hardening,
jensreu
Am 11. April 2017 13:13:11 MESZ schrieb Dan Leinir Turthra Jensen
:
>On Tuesday, 11 April 2017 11:32:18 BST Martin Gräßlin wrote:
>> Am 11. April 2017 11:23:01 MESZ schrieb Dan Leinir Turthra Jensen
>:
>> >Heyhey :)
>> >
>> >i do rather like the idea of edge gestures, however i would also
>quit
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:650eb5ccbeb5: Include a bottom toolbar for the
application page (authored by apol).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D5339?vs=13323&id=13324#toc
REPOSITORY
R134 Discover Softwar
apol updated this revision to Diff 13323.
apol added a comment.
Adopt changes as suggested by Jens
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5339?vs=13207&id=13323
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5339
A
On Tuesday, 11 April 2017 11:32:18 BST Martin Gräßlin wrote:
> Am 11. April 2017 11:23:01 MESZ schrieb Dan Leinir Turthra Jensen
:
> >Heyhey :)
> >
> >i do rather like the idea of edge gestures, however i would also quite
> >like
> >to keep in mind applications here...
>
> we discussed the propos
Am 11. April 2017 11:23:01 MESZ schrieb Dan Leinir Turthra Jensen
:
>Heyhey :)
>
>i do rather like the idea of edge gestures, however i would also quite
>like
>to keep in mind applications here...
we discussed the proposed implementation at the affenfels sprint. Why did you
not raise this con
apol added a comment.
In https://phabricator.kde.org/D5088#101295, @broulik wrote:
> As soon as I open a qml file in a plasma project it freezes during "Loading
QML imports" eating all RAM and CPU until I kill it.
I'm assuming that's in QtCreator...
Can you please open a bug rep
broulik added a comment.
As soon as I open a qml file in a plasma project it freezes during "Loading
QML imports" eating all RAM and CPU until I kill it.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D5088
To: apol, #plasma, #frameworks, davidedm
Heyhey :)
i do rather like the idea of edge gestures, however i would also quite like
to keep in mind applications here... Specifically, other touch-focused UXes all
have some kind of concept of edges given over to the applications rather than
the system. Windows has the bottom edge, Android
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/708/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 11 Apr 2017 07:45:27 +
Build duration: 35 min
CHANGE SET
Revision 9ffaa15643572ab39d85fef92a19d98cadfc
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/847/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 11 Apr 2017 07:46:07 +
Build duration: 6 min 4 sec
CHANGE SET
Revision 166afb5a24f106edfca0e3dbf556d
drosca added inline comments.
INLINE COMMENTS
> mck182 wrote in DaysCalendar.qml:315
> Now I'm not entirely sure but can the `uiLanguages[0]`
> possibly return null?
It's used exactly the same on the C++ side (without the bounds check), so I
assume it's safe as that code is now over 2 years old
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:a01e4fb69efe: Calendar: Use correct language for month
and day names (authored by drosca).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5345?vs
anthonyfieroni added inline comments.
INLINE COMMENTS
> notificationsapplet.cpp:54
> Q_ASSERT(containment()->corona());
> connect(containment()->corona(),
> &Plasma::Corona::availableScreenRectChanged, this,
> &NotificationsApplet::onScreenChanges);
>
I think, corona (witch is pare
jgrulich updated this revision to Diff 13317.
jgrulich added a comment.
Highlight connection name with bold text and add colon at the end of sentence
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5382?vs=13292&id=13317
BRANCH
pa
43 matches
Mail list logo
