D5452: Handle modifier updates in the same sequence as Wayland does

2017-04-14 Thread Andrius Štikonas
stikonas added a comment. Tested on XWayland 1.19.2 and it works. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5452 To: graesslin, #kwin, #plasma Cc: stikonas, plasma-devel, kwin, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas,

D5452: Handle modifier updates in the same sequence as Wayland does

2017-04-14 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Consider the case that capslock gets pressed and released. In the case of Weston we have a sequence of: 1. Key press event 2. Mod

D5440: Fix losing wallpaper selection when clicking "Apply".

2017-04-14 Thread Eike Hein
hein updated this revision to Diff 13440. hein added a comment. Simplify. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5440?vs=13414&id=13440 BRANCH Plasma/5.9 REVISION DETAIL https://phabricator.kde.org/D5440 AFFECTED FILES wallpapers/i

D5440: Fix losing wallpaper selection when clicking "Apply".

2017-04-14 Thread Eike Hein
hein added a comment. I wasn't sure (and admittedly didn't check) whether the source model does a reset causing the index to revert to 0. I kinda assumed that's why whoever wrote this added restore. If that's not the case yeah I'll just nix it. This code could use a lot of cleanup, much

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 853 - Still Unstable!

2017-04-14 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/853/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 14 Apr 2017 13:34:02 + Build duration: 25 min CHANGE SET Revision 616f57aecf6193efc333174360190549e2

Re: proper use of QFlags

2017-04-14 Thread David Edmundson
>Am I right that the argument `QFlags state` should simply be `State state`? Yes.

D5445: update baloo kcm docbook

2017-04-14 Thread Luigi Toscano
ltoscano added inline comments. INLINE COMMENTS > fvogt wrote in index.docbook:62 > Which current text? This got added. > > I'd phrase it like "Use 'Also index file content' to also index the file > contents additional to the file names". Right, I wanted to say "proposed text", not "current te

D5445: update baloo kcm docbook

2017-04-14 Thread Fabian Vogt
fvogt added inline comments. INLINE COMMENTS > ltoscano wrote in index.docbook:62 > Uh, how is it different from the current text? Which current text? This got added. I'd phrase it like "Use 'Also index file content' to also index the file contents additional to the file names". REPOSITORY

Re: Complex text input in Plasma

2017-04-14 Thread Shinjo Park
Hello list, I was not following this list but the discussion was interesting, so I am adding my opinion/personal mumblings/etc. to this topic. For entering Korean texts, the expectations and requirements of IMs are different from Chinese/Japanese. As most multilingual IM cores are designed by

D5445: update baloo kcm docbook

2017-04-14 Thread Luigi Toscano
ltoscano added inline comments. INLINE COMMENTS > fvogt wrote in index.docbook:62 > That is a bit misleading IMO, "Use 'Also index file content' to only index > the filename or [...]" Uh, how is it different from the current text? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://pha

D5445: update baloo kcm docbook

2017-04-14 Thread Fabian Vogt
fvogt requested changes to this revision. fvogt added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > index.docbook:62 > > +Use Also index file content to only index the > filename or additionally > +the file contents. That is a bit misleading IMO, "Use 'Also

D5445: update baloo kcm docbook

2017-04-14 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5445 To: lueck, #plasma, #documentation, fvogt, mart Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abett

Re: proper use of QFlags

2017-04-14 Thread Marco Martin
On Friday 14 April 2017 08:46:20 René J.V. Bertin wrote: > Hi, > > The QtCurve style fails to build against Qt 5.9.0: it triggers a > compile-time assert in the QFlags class on the function below. > > Am I right that the argument `QFlags state` should simply be `State > state`? can you do a phab

D2365: Add failing test case for selected filter from mimetype

2017-04-14 Thread Elvis Angelaccio
elvisangelaccio abandoned this revision. elvisangelaccio added a comment. Superseded by https://phabricator.kde.org/D5446. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D2365 To: elvisangelaccio, graesslin, dfaure Cc: plasma-devel,

D1813: Fix selected name filter with multiple mimetypes

2017-04-14 Thread Elvis Angelaccio
elvisangelaccio abandoned this revision. elvisangelaccio added a comment. Superseded by https://phabricator.kde.org/D5446. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D1813 To: elvisangelaccio, #plasma Cc: dfaure, graesslin, mart,

D5446: Implement support for selected mime type filters

2017-04-14 Thread Elvis Angelaccio
elvisangelaccio created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY QFileDialog in Qt 5.9 has better support for mimetype filters and introduces the QFileDialog::selectedMimeTypeFilter() method [1].

D5445: update baloo kcm docbook

2017-04-14 Thread Burkhard Lück
lueck created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY bump date+releaseinfo fix wrong gui term add option about file content indexing REPOSITORY R119 Plasma Desktop REVISION DETAIL https://