Re: plasma 5.10 tars

Il giorno Thu, 25 May 2017 23:29:34 +0100 Jonathan Riddell ha scritto: > Plasma 5.10 tars are now available on racnoss for packagers Plasmate was removed from the plasma-sdk tarball, while it was in there for the beta. The commit doing so is also explicitly marked "FEATURE".

D5928: Introducing Night Color - KWin's native blue light filter at nighttime

davidedmundson added a comment. As for your comments: > The first one is, that the fading phases generate much DBus traffic, as you said. To solve this we would need to do the fading in KWin. For that we need timers, at least one. But it would make sense to have two timers, one for

D5928: Introducing Night Color - KWin's native blue light filter at nighttime

davidedmundson added inline comments. INLINE COMMENTS > nightcolor.cpp:52 > + > +Manager::Manager(Platform *platform) > +: QObject(platform), rename the class or the file > nightcolor.cpp:111 > +if (reply.isValid()) { > +comingFromSuspend = reply.value().toBool(); > +

D5976: Remove code to poll the udev events for brightness

broulik added a comment. Writing to sysfs brightness with some wonky bash script is a pretty common thing IMHO but any simplification of brightness code is a good thing. +1 REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D5976 To: bshah, #plasma, broulik Cc:

D5976: Remove code to poll the udev events for brightness

bshah updated this revision to Diff 14860. bshah added a comment. remove workaround added in the https://phabricator.kde.org/D2470 REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5976?vs=14859=14860 BRANCH remove-udevqt REVISION DETAIL

D5976: Remove code to poll the udev events for brightness

bshah added a comment. In https://phabricator.kde.org/D5976#111940, @davidedmundson wrote: > I don't understand, you're saying your removing covering a corner case? Right, yes.. but that corner case is very less likely to happen other then someone writing manually to sysfs file

D5976: Remove code to poll the udev events for brightness

davidedmundson added a comment. I don't understand, you're saying your removing covering a corner case? REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D5976 To: bshah, #plasma, broulik Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai,

D5976: Remove code to poll the udev events for brightness

bshah created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This code watches the device in the sysfs for changes, if device is changed it reads the brightness again and updates it. However that

D5778: [backlighthelper] Remove unreachable code from backlighthelper

bshah abandoned this revision. bshah added a comment. As discussed on IRC earlier, this code is actually used on FreeBSD ports with some more downstream patches. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D5778 To: bshah, #plasma, #freebsd, broulik Cc:

D5974: Wizard: Use emblem-success and emblem-error icons

drosca added a comment. F3765105: Screenshot_20170526_144214.png F3765104: Screenshot_20170526_144335.png REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D5974 To: drosca, #plasma

D5974: Wizard: Use emblem-success and emblem-error icons

drosca created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY task-reject and task-complete icons are not present in Breeze icons. Also add spacing between icon and text REPOSITORY R97 Bluedevil

D5381: Add brightness control using ddcutil lib

This revision was automatically updated to reflect the committed changes. Closed by commit R122:a3a61317ddeb: Add brightness control using ddcutil lib (authored by dvogel, committed by davidedmundson). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE

D5381: Add brightness control using ddcutil lib

davidedmundson accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D5381 To: dvogel, broulik, davidedmundson Cc: strobach, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D5381: Add brightness control using ddcutil lib

dvogel updated this revision to Diff 14854. dvogel added a comment. applied comments from d_ed fixed brightness jumping to previous position after brightness change: see DDCutilBrightness::brightness() CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5381?vs=14843=14854 REVISION

D5973: Always add data sources in SystemMonitorEngine::sourceRequestEvent()

This revision was automatically updated to reflect the committed changes. Closed by commit R120:f060ad5f1ad0: Always add data sources in SystemMonitorEngine::sourceRequestEvent() (authored by elvisangelaccio). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D5381: Add brightness control using ddcutil lib

davidedmundson added a comment. Looks good, I think I just have one comment about a leak, but the docs are confusing, so it's possible I'm wrong. INLINE COMMENTS > ddcutilbrightness.cpp:54 > + > +rc = ddca_create_dispno_display_identifier(iDisp+1, ); // > ddcutil uses 1 paded

Re: plasma 5.10 tars

On Fri, May 26, 2017 at 06:15:34AM +, Antonio Rojas wrote: > El Thu, 25 May 2017 23:29:34 +0100, Jonathan Riddell escribió: > > > Plasma 5.10 tars are now available on racnoss for packagers > > > > Release is due on Tuesday > > > > Jonathan > > Hi, > Signatures are missing. Somewhere

D5973: Always add data sources in SystemMonitorEngine::sourceRequestEvent()

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D5973 To: elvisangelaccio, #plasma, jgrulich, davidedmundson Cc: plasma-devel, ZrenBot, spstarr,

D5973: Always add data sources in SystemMonitorEngine::sourceRequestEvent()

elvisangelaccio edited the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5973 To: elvisangelaccio, #plasma, jgrulich Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D5973: Always add data sources in SystemMonitorEngine::sourceRequestEvent()

elvisangelaccio created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise if we show the plasma-nm applet twice, m_sensors won't be empty and we won't be able to fect the connection speed data.

Re: plasma 5.10 tars

El Thu, 25 May 2017 23:29:34 +0100, Jonathan Riddell escribió: > Plasma 5.10 tars are now available on racnoss for packagers > > Release is due on Tuesday > > Jonathan Hi, Signatures are missing. --Antonio