Re: Plasma 5.11 kickoff meeting

Hello Jonathan, On Thu, Jun 01, 2017 at 04:36:34PM +0100, Jonathan Riddell wrote: > let me know if you have agenda items > > should we try again using the To Do at the Monday meetings or is that > > just not going to happen? Yes, I do have agenda item regarding this. In the Plasma Sprint at

D6059: Add a test that adds a notification and closes it

apol retitled this revision from "Close notifications that don't have a default action by clicking" to "Add a test that adds a notification and closes it". apol removed a reviewer: VDG. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6059 To: apol, #plasma,

D6059: Close notifications that don't have a default action by clicking

apol updated this revision to Diff 15069. apol added a comment. Just add a test REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6059?vs=15052=15069 BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D6059 AFFECTED FILES

D6059: Close notifications that don't have a default action by clicking

apol added a comment. In https://phabricator.kde.org/D6059#113450, @mck182 wrote: > This was discussed at length in https://phabricator.kde.org/D4215 > > What's the reasoning behind this change? The reasoning is Kai complained about it in IRC. If it was decided against I'll

D6059: Close notifications that don't have a default action by clicking

mart added a comment. triggering the action would close the notification anyways, so it may be seen as a consistency between notifications with action and not REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6059 To: apol, #plasma, broulik, #vdg Cc: mart,

D6054: Use explicit flag values or explicit constructor instead of nullptr

This revision was automatically updated to reflect the committed changes. Closed by commit R278:ccbad906db1b: Use explicit flag values or explicit constructor instead of nullptr (authored by kossebau). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE

D6054: Use explicit flag values or explicit constructor instead of nullptr

kossebau added a comment. Checking the diff another time I find it would be even nicer to extend `NET::Property`, `NET::Property2`, `NET::Action` & Co. to have an entry for `0` value, named `NoProperties`, `NoProperties2`, `NoActionFlags` etc. (cmp. e.g. `Qt::ItemFlags`), so those enum

D6061: prototype of kactivity-based most used modules entries

davidedmundson added inline comments. INLINE COMMENTS > ModuleView.cpp:349 > +if (activeModule) { > +KActivities::ResourceInstance::notifyAccessed(QUrl("kcm:" + > activeModule->moduleInfo().service()->storageId()), > +"org.kde.systemsettings"); not "kcm:/" ? >

D6061: prototype of kactivity-based most used modules entries

mart added a comment. more spacing, icons still small, wouldn't go much bigger than that F3773262: Spectacle.L12141.png REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D6061 To: mart, #plasma, #vdg Cc: abetts,

D6061: prototype of kactivity-based most used modules entries

mart updated this revision to Diff 15056. mart added a comment. - more icon spacing REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6061?vs=15055=15056 BRANCH mart/mostUsedModules REVISION DETAIL https://phabricator.kde.org/D6061 AFFECTED

D6061: prototype of kactivity-based most used modules entries

mart added a comment. In https://phabricator.kde.org/D6061#113481, @abetts wrote: > In https://phabricator.kde.org/D6061#113477, @mart wrote: > > > first page look as per vdg suggestion > > F3773242: Spectacle.y10298.png > > > I would

D6061: prototype of kactivity-based most used modules entries

abetts added a comment. In https://phabricator.kde.org/D6061#113477, @mart wrote: > first page look as per vdg suggestion > F3773242: Spectacle.y10298.png I would like to suggest making the system settings icon 512 and the row of 5 icons

D6061: prototype of kactivity-based most used modules entries

mart added a comment. first page look as per vdg suggestion F3773242: Spectacle.y10298.png REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D6061 To: mart, #plasma Cc: plasma-devel, ZrenBot, spstarr, progwolff,

D6061: prototype of kactivity-based most used modules entries

mart added a reviewer: VDG. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D6061 To: mart, #plasma, #vdg Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6061: prototype of kactivity-based most used modules entries

mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY use kactivities to track the most used modules (kcmshell will need to as well) and present them in the start page as 5 big icons TEST PLAN

Re: Plasma 5.11 kickoff meeting

We've a winning time Tuesday 12:00UTC, 13:00BST, 14:00CEST See you in #plasma let me know if you have agenda items Jonathan On 1 June 2017 at 13:50, Jonathan Riddell wrote: > I've set up a poll for a kickoff meeting for 5.11 > > http://doodle.com/poll/5yifyy3q23mk3v8x > >

D6047: WIP: Support XDG v6

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in xdgshell_interface.h:80 > We need the serial Ids here, otherwise it's not very usable; especially as > the pong doesn't have an elapsed time. > > A kjob like API wrapping this might be perfect for here? so storing all the

D6059: Close notifications that don't have a default action by clicking

mck182 added a comment. This was discussed at length in https://phabricator.kde.org/D4215 What's the reasoning behind this change? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6059 To: apol, #plasma, broulik, #vdg Cc: mck182, plasma-devel, ZrenBot,

D6059: Close notifications that don't have a default action by clicking

broulik added a reviewer: VDG. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6059 To: apol, #plasma, broulik, #vdg Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6059: Close notifications that don't have a default action by clicking

apol created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Adds a test REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D6059 AFFECTED FILES

Plasma 5.11 kickoff meeting

I've set up a poll for a kickoff meeting for 5.11 http://doodle.com/poll/5yifyy3q23mk3v8x I plan to go over the todo with everyone who has stuff on it to tidy it up before the meeting We do already have a schedule for 5.11 planned with release in the usual 3.5 months on September 21

D6047: WIP: Support XDG v6

davidedmundson added a comment. Comments for Marco: INLINE COMMENTS > xdgshell_interface.h:80 > > +void ping(); > + We need the serial Ids here, otherwise it's not very usable; especially as the pong doesn't have an elapsed time. A kjob like API wrapping this might be perfect for

D6056: [Run Command] Auto-close on focus loss only if query field is empty

anthonyfieroni added a comment. Does it better to do it like in yakuake https://cgit.kde.org/yakuake.git/tree/app/mainwindow.cpp#n1059 ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6056 To: broulik, #plasma, #vdg Cc: anthonyfieroni, plasma-devel,

D6054: Use explicit flag values or explicit constructor instead of nullptr

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH nonullptrforflagsplease REVISION DETAIL https://phabricator.kde.org/D6054 To: kossebau, #plasma, graesslin, kfunk Cc: plasma-devel, #frameworks, ZrenBot, spstarr,

[kio-extras] [Bug 380417] fish doesn't use User from .ssh/config

https://bugs.kde.org/show_bug.cgi?id=380417 Elvis Angelaccio changed: What|Removed |Added Version|17.04.1 |unspecified

D6056: [Run Command] Auto-close on focus loss only if query field is empty

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY If the user didn't accept any search result or didn't explicitly close it, he or she might still want to tweak the query, e.g. when summing

D6011: let's continue in debug code instead of returning from XRandRConfig::applyKScreenConfig

clutz added a comment. Hi David, there's no bug report for that in the KDE issue tracker (but in our custom one). I adjusted the patch description above. Is that ok for the kind of documentation that you want to have? (I would prefer to send you a new git-patch that contains a complete

D6011: let's continue in debug code instead of returning from XRandRConfig::applyKScreenConfig

clutz edited the summary of this revision. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D6011 To: clutz, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6011: let's continue in debug code instead of returning from XRandRConfig::applyKScreenConfig

clutz edited the summary of this revision. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D6011 To: clutz, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6011: let's continue in debug code instead of returning from XRandRConfig::applyKScreenConfig

clutz edited the summary of this revision. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D6011 To: clutz, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6055: Don't call setDefaultSink/Source when already default

This revision was automatically updated to reflect the committed changes. Closed by commit R115:2509b6bbf507: Don't call setDefaultSink/Source when already default (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

Re: Touchpad KCM

It's not. systemsettings can't run code in the kcm until it's loaded the kcm... at which point it's too late. (well, you could have a kcm_init hook/kded module that throws fake .desktop files in .local/share ...)

D6055: Don't call setDefaultSink/Source when already default

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D6055 To: drosca, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, spstarr, progwolff,

D6055: Don't call setDefaultSink/Source when already default

drosca created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Checked state changes are not correctly handled in default device QtQuickControls checkbox in KCM (changes are applied also for non-user

D6011: let's continue in debug code instead of returning from XRandRConfig::applyKScreenConfig

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. That's exactly the sort of thing I was hoping for. (the analysis, not there being a kernel bug). Can you update the comment and/or the bug report with that information

D6011: let's continue in debug code instead of returning from XRandRConfig::applyKScreenConfig

clutz added a comment. Thanks David for reviewing that. Oh, I already tried to find the underlying bug that causes the inconsistency. The debugging led me from libkscreen to xrandr to libxrandr (XRRGetOutputInfo) to the kernel. Here I noticed the following things: 1. outputInfo =

D6046: Workaround non-interactive file/places view on high dpi in multi monitor scenario

dfaure added a comment. Excellent finding, it helped me reduce further the most annoying Qt bug I'm experiencing right now (in kmail) --> https://bugreports.qt.io/browse/QTBUG-59017 REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D6046 To: broulik, #plasma,