D6145: Massively simplify the class DesktopPortal

jgrulich added a comment. I think I found out why. In documentation [1] all methods starts with capital letter, which in our case they don't. This was obviously working before when I was doing everything manually. Still my question remains about registering additional objects in Inbit.cpp.

D6145: Massively simplify the class DesktopPortal

jgrulich added a comment. I tested it with my test application and it doesn't work. I keep getting following warnings from xdg-desktop-portal: - (/usr/libexec/xdg-desktop-portal:18253): WARNING **: Backend call failed: GDBus.Error:org.freedesktop.DBus.Error.UnknownMethod: No such method

D6145: Massively simplify the class DesktopPortal

apol added a reviewer: jgrulich. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D6145 To: davidedmundson, #plasma, jgrulich Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, m

D6145: Massively simplify the class DesktopPortal

apol added inline comments. INLINE COMMENTS > access.h:32 > public: > -Access(QObject *parent = nullptr); > +Access(QObject *parent); > ~Access(); explicit (and others) REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D61

D6145: Massively simplify the class DesktopPortal

davidedmundson edited the summary of this revision. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D6145 To: davidedmundson, #plasma Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

D6145: Massively simplify the class DesktopPortal

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Only one QObject can occupt a DBus path...but that object can have multiple adaptors, which is how you've structured it anyway. I

D6143: Even on plasma we shouldn't be using plasma icons

davidedmundson added a comment. I mean, if we're an application, we should be only using things loaded from src/styles/org.kde.desktop and not files in src/styles/Plasma REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D6143 To: apol, #kirigami, mart Cc: davided

D6143: Even on plasma we shouldn't be using plasma icons

apol added a comment. In https://phabricator.kde.org/D6143#114962, @davidedmundson wrote: > Why would it be using the Plasma theme then? Kirigami shouldn't AFAIU, that's why I'm setting it to `false`. Am I lost in translation? REPOSITORY R169 Kirigami REVISION DETAIL https:

D6143: Even on plasma we shouldn't be using plasma icons

davidedmundson added a comment. Why would it be using the Plasma theme then? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D6143 To: apol, #kirigami, mart Cc: davidedmundson, plasma-devel, apol, mart

D6143: Even on plasma we shouldn't be using plasma icons

apol created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We want to use the icons for applications rather than for the shell. It should work well with the applications color theme rather than the she

Re: Transient parent for QtWidgets popup menus

On mercoledì 7 giugno 2017 19:56:59 CEST, Elvis Angelaccio wrote: On domenica 28 maggio 2017 10:37:40 CEST, Marco Martin wrote: On Sunday 28 May 2017 10:12:53 Elvis Angelaccio wrote: ... Any idea about drop menus? (i.e. QMenus usually created in some dropEvent() function). Even if they have a

D6141: make shadows work for windows 100%width or height

mvourlakos added a comment. thank u! REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6141 To: mart, #plasma, #kwin, graesslin Cc: mvourlakos, davidedmundson, plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, se

D6141: make shadows work for windows 100%width or height

mart edited the summary of this revision. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6141 To: mart, #plasma, #kwin, graesslin Cc: mvourlakos, davidedmundson, plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, s

D6141: make shadows work for windows 100%width or height

mart added a comment. In https://phabricator.kde.org/D6141#114932, @mvourlakos wrote: > @mart does this fix also https://bugs.kde.org/show_bug.cgi?id=380825 ? yes, that's him, thanks REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6141 To: mart, #plasma, #k

D5729: #379003: Fix National Geographic POTD provider

vitali added a comment. *ping* :) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D5729 To: vitali, sebas Cc: Zren, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6141: make shadows work for windows 100%width or height

mvourlakos added a comment. @mart does this fix also https://bugs.kde.org/show_bug.cgi?id=380825 ? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6141 To: mart, #plasma, #kwin, graesslin Cc: mvourlakos, davidedmundson, plasma-devel, kwin, ZrenBot, spstarr, progwolff,

Re: Transient parent for QtWidgets popup menus

On domenica 28 maggio 2017 10:37:40 CEST, Marco Martin wrote: On Sunday 28 May 2017 10:12:53 Elvis Angelaccio wrote: createWinId(); windowHandle()->setTransientParent(parent()->nativeParentWidget()->windowHan dle()); Does it makes sense? Would it work? As far i know, if a qmenu is passed

D6141: make shadows work for windows 100%width or height

mart added a comment. In https://phabricator.kde.org/D6141#114925, @davidedmundson wrote: > you're written > max(top, bottom, topRight, topLeft) > + > max (left, right) > + > max(bottomLeft, bottomRight, bottom) no, the intention is max(left+right, (max(topL

D6140: Standardize the GlobalHeader height

jensreuterberg added a comment. I have to agree with Marco (inside) although I am currently wearing a striped tanktop and chequered shorts so "good taste" may not apply to me ;) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D6140 To: apol, #kirigami, mart Cc: jens

D6140: Standardize the GlobalHeader height

This revision was automatically updated to reflect the committed changes. Closed by commit R169:247bd7f46a5c: Standardize the GlobalHeader height (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6140?vs=15259&id=15261 REVISION DETAIL http

D6141: make shadows work for windows 100%width or height

davidedmundson added a comment. Investigation sounds sensible, the fix is off. Old code is: max(topLeft,topRight) + max (left, right) + max(bottomLeft, bottomRight) -- What you're saying we want is: max(topLeft,topRight,top) + max (left, right)

D6140: Standardize the GlobalHeader height

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D6140 To: apol, #kirigami, mart Cc: plasma-devel, apol, mart

D6140: Standardize the GlobalHeader height

mart added a comment. In https://phabricator.kde.org/D6140#114909, @apol wrote: > People with good taste: I'm wondering whether the blue thing should actually be outside rather than inside. What do you think? inside. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricat

[Powerdevil] [Bug 378498] Power settings missing scrollbar

https://bugs.kde.org/show_bug.cgi?id=378498 Christoph Feck changed: What|Removed |Added CC||pas...@dhermilly.dk --- Comment #2 from Christ

D6141: make shadows work for windows 100%width or height

mart created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY when a window has 100% width or height (common in the panel), it disables the shadows on the sides (or top/bottom) and since they are used

D6140: Standardize the GlobalHeader height

apol added a comment. People with good taste: I'm wondering whether the blue thing should actually be outside rather than inside. What do you think? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D6140 To: apol, #kirigami, mart Cc: plasma-devel, apol, mart

D6140: Standardize the GlobalHeader height

apol added a comment. Examples Kirigami Gallery on Material F3778197: Spectacle.b20708.png Kirigami Gallery desktop F3778199: Spectacle.M20945.png Discover F3778201: Spectacle.X21052.png

D6140: Standardize the GlobalHeader height

apol created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The size becomes static rather than depending on the header image form factor. Makes sure it has the same height as the list headers REPOSI

D6137: The session is not called KDE

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c1da4a8dce02: The session is not called KDE (authored by sebas). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6137?vs=15253&id=15255 REVISION DETAIL htt

D5747: add pid to plasma window management protocol

sebas closed this revision. sebas added a comment. Issue has been fixed elsewhere, otherwise code is submitted. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5747 To: sebas, #plasma, hein, graesslin Cc: apol, davidedmundson, plasma-devel, #frameworks, ZrenBot, sps

D6137: The session is not called KDE

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH sebas/autostartkcm REVISION DETAIL https://phabricator.kde.org/D6137 To: sebas, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai,

D6137: The session is not called KDE

sebas created this revision. sebas added a project: Plasma. REVISION SUMMARY Kill wrong lingo in autostart kcm, make it more generic TEST PLAN Checked in autostart KCM, new string appears REPOSITORY R119 Plasma Desktop BRANCH sebas/autostartkcm REVISION DETAIL https://phabricator.kde

D6136: The session is not called KDE

sebas abandoned this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6136 To: sebas Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6136: The session is not called KDE

sebas created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Kill wrong lingo, make it more generic REPOSITORY R119 Plasma Desktop BRANCH sebas/autostartkcm REVISION DETAIL https://phabricator.kde.

D3484: Center systemmonitor window properly on multi-screen setup

sebas added inline comments. INLINE COMMENTS > davidedmundson wrote in ksystemactivitydialog.cpp:78 > > > > This doesn't work with scaling > > Yes it does. Right, was actually wondering right after I submitted. In that case, I'm not all that opposed. REPOSITORY R120 Plasma Workspace REVI

D3484: Center systemmonitor window properly on multi-screen setup

davidedmundson added inline comments. INLINE COMMENTS > sebas wrote in ksystemactivitydialog.cpp:78 > This doesn't work with scaling, different font settings or different widget > themes. Hardcoded sizes are a no-no in general. > This doesn't work with scaling Yes it does. REPOSITORY R120 P

D3484: Center systemmonitor window properly on multi-screen setup

sebas added inline comments. INLINE COMMENTS > ksystemactivitydialog.cpp:78 > { > -saveDialogSettings(); > -event->accept(); > -} > - > - > -void KSystemActivityDialog::reject () > -{ > -saveDialogSettings(); > -QDialog::reject(); > -} > - > -void KSystemActivityDialog::saveDialo

D3484: Center systemmonitor window properly on multi-screen setup

valeriymalov updated this revision to Diff 15251. valeriymalov added a comment. So I've decided to revisit this and ended up deleting most of the code, dunno if I went overboard here. Replaced resize and setGeometry calls with sizeHint() for the window. I've also removed call to minimumS

D6133: Make --test mode run without spawning kactivitymanagerd or restarting

apol added a comment. +1 LGTM REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6133 To: davidedmundson, #plasma Cc: apol, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart, lukas

D6134: Test every plasmoid

apol added inline comments. INLINE COMMENTS > test.sh.in:2 > #!/bin/sh > -plasmashell --test "@CMAKE_CURRENT_BINARY_DIR@/testLayout-@plasmoidName@.js" > -kactivitymanagerd stop > +plasmashell --test "@CMAKE_CURRENT_BINARY_DIR@/testLayout-@plasmoidName@.js" just added an extra space there? REP

D6134: Test every plasmoid

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R527 Integration tests for Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D6134 To: davidedmundson, #plasma, mart Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-moham

D6134: Test every plasmoid

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY ShellCorona will now abort in test mode if an applet fails to load, even without a dedicated script, this test will make sure everythi

D6133: Make --test mode run without spawning kactivitymanagerd or restarting

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This allows us to run the plasma-tests repo on your system without it destroying all your real activities. Even though one run tests i

D5910: make shadows work on wayland

mart added a comment. thanks for fixing, sorry about that. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D5910 To: mart, #plasma, hpereiradacosta Cc: rikmills, anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreu

[kio-extras] [Bug 366795] Paste action disabled when copying a local file to smb:// or mtp://

https://bugs.kde.org/show_bug.cgi?id=366795 Sebastian Kügler changed: What|Removed |Added CC||se...@kde.org Assignee|plasma-deve

D5910: make shadows work on wayland

rikmills added a comment. > ! In https://phabricator.kde.org/D5910#114781, @hpereiradacosta wrote: > Working on fixing it. > Just a couple of ifdef missing. The fix you just pushed seems to have done the trick. Thank you. REPOSITORY R31 Breeze REVISION DETAIL https://phabricat

D5910: make shadows work on wayland

hpereiradacosta added a comment. In https://phabricator.kde.org/D5910#114772, @rikmills wrote: > This breaks builds on Neon and Kubuntu CI (Qt 5.7.1) > > http://build.neon.kde.org/job/xenial_unstable_plasma_breeze_bin_amd64/120/console > > 05:10:59 In file included from /workspac

D5910: make shadows work on wayland

rikmills added a comment. This breaks builds on Neon and Kubuntu CI (Qt 5.7.1) http://build.neon.kde.org/job/xenial_unstable_plasma_breeze_bin_amd64/120/console 05:10:59 In file included from /workspace/build/build-qt4/kstyle/moc_breezeshadowhelper.cpp:9:0, 05:10:59

D5889: Keep QIcon::fromTheme in main thread

rikmills added a comment. This breaks build on Neon and Kubuntu CI with Qt 5.7.1 http://build.neon.kde.org/job/xenial_unstable_plasma_breeze_bin_amd64/120/console 05:10:59 In file included from /workspace/build/build-qt4/kstyle/moc_breezeshadowhelper.cpp:9:0, 05:10:59