D4376: Replace long-deprecated getpass(3) call

2017-06-14 Thread A. Wilcox
awilcox abandoned this revision. awilcox added a comment. Since https://phabricator.kde.org/R133:a9c44a10b6a60777bf8ca997d3618e66bbd44baa conv_legacy is no longer an option for kscreenlocker. This patch is no longer necessary as of Plasma 5.10. REPOSITORY R133 KScreenLocker REVISION

D6191: Simplify KNSBackend fetch logic

2017-06-14 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This will go to Plasma/5.10, right? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D6191 To: leinir, apol, #discover_software_store Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai,

D6221: Drop unused dependencies

2017-06-14 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R118:d63149e27caf: Drop unused dependencies (authored by arojas). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6221?vs=15442=15455 REVISION DETAIL

Re: Plasma Vision v 2.0

2017-06-14 Thread Mario Fux
Am Sonntag, 11. Juni 2017, 23:20:52 CEST schrieb Jens Reuterberg: Morning Good vision and thanks everybody for working on it. > Thanks :) > > I tried to find a different, less convuluted way of saying "different > distros" - that also tied in other devices beyond laptops and stationary. > >

D6004: Add method to unlock greeter via consolekit.

2017-06-14 Thread Martin Flöser
graesslin added inline comments. INLINE COMMENTS > tcberner wrote in abstractlocker.cpp:62 > I'm not sure, if we can predictably get the name of the correct "broken" > session from within the script -- of course, the script could just unlock all > the sessions by iterating over them, but that

D5825: kcheckpass: Add support in for non-Linux platforms via kevent.

2017-06-14 Thread René J . V . Bertin
rjvbb added a comment. > Nevertheless OS X is not supported by kscreenlocker and will never be. You got it all wrong, OS X doesn't support kscreenlocking, gna! (If I were still a fanboy I'd add that it's way too kool to support running most kinds of plasma O:^) ) REPOSITORY

D6004: Add method to unlock greeter via consolekit.

2017-06-14 Thread Tobias C. Berner
tcberner added inline comments. INLINE COMMENTS > graesslin wrote in CMakeLists.txt:78 > I would keep this information about the contact. We want to be friendly here > and it's such a touchy topic that I prefer to be very explicit that we do > want to support other solutions. Ok. > graesslin

Re: Touchpad KCM

2017-06-14 Thread Martin Flöser
Am 2017-06-01 01:03, schrieb Aleix Pol: Hey, Anybody knows if it's possible not to show the touchpad KCM at all if it's not available? It's a bit odd to get it but see it all gray with an error saying "touchpad not found". FWIW this is an issue present in the KDE Slimbook. Slimbook could

D3650: lower mouse acceleration limit to 0.0

2017-06-14 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D3650#112888, @apol wrote: > In https://phabricator.kde.org/D3650#80584, @graesslin wrote: > > > According to my comments in the Wayland port: the value 1.0 means no acceleration. Values below 1.0 mean a de-acceleration or a

Re: Next Plasma LTS and openSUSE

2017-06-14 Thread Martin Flöser
Am 2017-05-29 12:56, schrieb David Edmundson: Stealing this LTS thread, there's something from Qt I'd like to copy: Currently, Qt 5.6 LTS is in the _‘strict’_ phase where it only receives selected critical fixes and next it is moving into the ‘_very strict_’ phase. During this final phase, Qt

D5825: kcheckpass: Add support in for non-Linux platforms via kevent.

2017-06-14 Thread Martin Flöser
graesslin added a subscriber: rjvbb. graesslin added a comment. In https://phabricator.kde.org/D5825#112682, @rjvbb wrote: > In https://phabricator.kde.org/D5825#112464, @davidedmundson wrote: > > > OS X is not a supported Plasma platform, BSD is. > > > Just for future

D6004: Add method to unlock greeter via consolekit.

2017-06-14 Thread Martin Flöser
graesslin requested changes to this revision. graesslin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:78 > TYPE RUNTIME > -PURPOSE "Needed for emergency unlock in case that the greeter is broken. > In case your distribution does

D6191: Simplify KNSBackend fetch logic

2017-06-14 Thread Dan Leinir Turthra Jensen
leinir added a comment. Related bug: https://bugs.kde.org/show_bug.cgi?id=380138 REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D6191 To: leinir, apol, #discover_software_store Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,

Re: Plasma Vision v 2.0

2017-06-14 Thread Martin Flöser
Am 2017-06-14 13:37, schrieb Sebastian Kügler: On Fri, 09 Jun 2017 09:40:28 +0200 Jens Reuterberg wrote: Time to get back to the vision. The comments we got were useful, and it seems the discussion is petering out ... that's probably a good sign. I didn't sense any

D6215: Introduce aboutToShow() signal

2017-06-14 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > davidedmundson wrote in dialog.cpp:1368-1370 > You can't move the code from updateVisibility as we need it to work with an > upcasted QQuickWindow::setVisible . > That's probably the main reason you ended up having to change the pointer > type in

[Breeze] [Bug 381196] Make notification popup have rounded corners

2017-06-14 Thread Michael D
https://bugs.kde.org/show_bug.cgi?id=381196 --- Comment #2 from Michael D --- Maybe, but certainly not as rounded as the default window border, window decoration, and buttons. Might be worth doing a user poll to see what is aesthetically preferred. -- You are receiving

[Powerdevil] [Bug 381199] Broken brightness control with kernel module (ex. nvidia-bl)

2017-06-14 Thread Bhushan Shah
https://bugs.kde.org/show_bug.cgi?id=381199 Bhushan Shah changed: What|Removed |Added Latest Commit|https://commits.kde.org/pow |https://commits.kde.org/pow

[Powerdevil] [Bug 381199] Broken brightness control with kernel module (ex. nvidia-bl)

2017-06-14 Thread Bhushan Shah
https://bugs.kde.org/show_bug.cgi?id=381199 Bhushan Shah changed: What|Removed |Added Resolution|--- |FIXED

[Powerdevil] [Bug 381199] Broken brightness control with kernel module (ex. nvidia-bl)

2017-06-14 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=381199 --- Comment #2 from vsnrain@gmail.com --- it returns "raw" -- You are receiving this mail because: You are the assignee for the bug.

[Powerdevil] [Bug 381199] Broken brightness control with kernel module (ex. nvidia-bl)

2017-06-14 Thread Bhushan Shah
https://bugs.kde.org/show_bug.cgi?id=381199 Bhushan Shah changed: What|Removed |Added CC||bhus...@gmail.com Ever

[Powerdevil] [Bug 381199] New: Broken brightness control with kernel module (ex. nvidia-bl)

2017-06-14 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=381199 Bug ID: 381199 Summary: Broken brightness control with kernel module (ex. nvidia-bl) Product: Powerdevil Version: 5.10.0 Platform: Other OS: Linux

D6221: Drop unused dependencies

2017-06-14 Thread Sebastian Kügler
sebas accepted this revision. This revision is now accepted and ready to land. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D6221 To: arojas, #plasma, sebas Cc: plasma-devel, #plasma, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D3051: [applets/notification] Add nullptr check

2017-06-14 Thread Sebastian Kügler
sebas added a comment. Ping? Please submit or abandon... REPOSITORY R120 Plasma Workspace BRANCH notification-add-popup-null REVISION DETAIL https://phabricator.kde.org/D3051 To: graesslin, #plasma, sebas, broulik Cc: mart, sebas, plasma-devel, ZrenBot, spstarr, progwolff,

[Breeze] [Bug 381196] Make notification popup have rounded corners

2017-06-14 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=381196 Kai Uwe Broulik changed: What|Removed |Added CC|

Re: Plasma Vision v 2.0

2017-06-14 Thread Sebastian Kügler
On Fri, 09 Jun 2017 09:40:28 +0200 Jens Reuterberg wrote: > Time to get back to the vision. The comments we got were useful, and it seems the discussion is petering out ... that's probably a good sign. I didn't sense any significant opposition, so I'd suggest we finalize

D6161: Add a integration test suite and fix a signal connect bug when attaching reports

2017-06-14 Thread Bhushan Shah
bshah added a reviewer: Plasma. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6161 To: sitter, #plasma Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

Re: Plasmoid plugin signal handling

2017-06-14 Thread Sebastian Kügler
On Wed, 14 Jun 2017 10:39:04 +0200 Rastislav Marko wrote: > Thank you for the hints, I made the semantics more meaningful (in > fact I have another class named ActiivtyJumper). > > On utorok, 13. júna 2017 16:49:26 CEST Sebastian Kügler wrote: > > > > The signal isn't

D6215: Introduce aboutToShow() signal

2017-06-14 Thread Marco Martin
mart updated this revision to Diff 15446. mart added a comment. don't update the size twice only update the size in setvisible, not in updatevisibility. if this is done in the showEvent instead, it's too late and is possible to see a resize on screen REPOSITORY R242 Plasma

[Breeze] [Bug 381196] New: Make notification popup have rounded corners

2017-06-14 Thread Michael D
https://bugs.kde.org/show_bug.cgi?id=381196 Bug ID: 381196 Summary: Make notification popup have rounded corners Product: Breeze Version: 5.10.1 Platform: Neon Packages OS: Linux Status: UNCONFIRMED

D6212: Don't crash when deleted during network operations

2017-06-14 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes. Closed by commit R169:f3f2622e79b9: Don't crash when deleted during network operations (authored by leinir). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6212?vs=15421=15445

D6191: Simplify KNSBackend fetch logic

2017-06-14 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 15444. leinir added a comment. Upon reviewing prior to merging, i realised that a file was missing from the most recent diff (StandardBackendUpdater did, as suggested, not listen to the resourceRemoved signal, and now does). REPOSITORY R134 Discover

Re: Plasma Vault

2017-06-14 Thread Jonathan Riddell
This could probably do with a blog post or public announcement of some sort, people are starting to ask what it is https://plus.google.com/b/113043070111945110583/113043070111945110583/posts/Q6LMfFvDiBL When I click on a Vault folder nothing happens. I'd expect it to at least start Dolphin

D6215: Introduce aboutToShow() signal

2017-06-14 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > mart wrote in dialog.cpp:1368-1370 > >> this is already done in updateVisibility which is effectively called from > > > > i think it should be safe to remove it from updatevisibility > > hmm, actually not, seems sometimes it needs to be

D6215: Introduce aboutToShow() signal

2017-06-14 Thread Sebastian Kügler
sebas added a comment. I like this, and I'll likely need it in my kscreen OSD code aswell (positioning there is unreliable, and my best guess is that this is the exact same problem @mart is trying to solve here). +1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D6215: Introduce aboutToShow() signal

2017-06-14 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > mart wrote in dialog.cpp:1368-1370 > > You've not really said what problem we're trying to solve with this patch. > > having a pointt in which we are 100% sure of the final size of the dialog to > correctly position it. > if visualparent is set,

Re: Plasmoid plugin signal handling

2017-06-14 Thread Rastislav Marko
Thank you for the hints, I made the semantics more meaningful (in fact I have another class named ActiivtyJumper). On utorok, 13. júna 2017 16:49:26 CEST Sebastian Kügler wrote: > > The signal isn't defined in "Item", you need to create a DBusObject object > in your QML code, then you can add

D6221: Drop unused dependencies

2017-06-14 Thread Antonio Rojas
arojas created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Builds, works REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D6221 AFFECTED FILES CMakeLists.txt To: arojas, #plasma