Re: Plasma Vision v 2.0

On Thu, Jun 15, 2017 at 9:16 PM, Martin Flöser wrote: > Am 2017-06-12 01:19, schrieb Aleix Pol: >> >> On Sun, Jun 11, 2017 at 11:13 PM, Jonathan Riddell >> wrote: >>> >>> >>> Yay, I like it. >>> >>> Across different operating systems? We don't do anything

D6231: Fix DND onto Task Manager for groups, group dialog scrollbar

hein updated this revision to Diff 15485. hein added a comment. One more readonly; I'm out of stuff now. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6231?vs=15484=15485 BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D6231

D6231: Fix DND onto Task Manager for groups, group dialog scrollbar

hein updated this revision to Diff 15484. hein added a comment. Waiting for David leads to more small cleanups. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6231?vs=15483=15484 BRANCH Plasma/5.8 REVISION DETAIL

D6231: Fix DND onto Task Manager for groups, group dialog scrollbar

hein requested review of this revision. hein added a comment. David, you still ok with this updated rev? Sorry, was working in parallel. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6231 To: hein, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, spstarr,

D6231: Fix DND onto Task Manager for groups, group dialog scrollbar

hein updated this revision to Diff 15483. hein added a comment. Properly make room for scrollbar if needed. This was kinda-sorta intended to be there (see contentWidth) but somehow got lost during development. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D6231: Fix DND onto Task Manager for groups, group dialog scrollbar

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D6231 To: hein, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai,

D6231: Fix DND onto Task Manager for groups, group dialog scrollbar

hein updated this revision to Diff 15482. hein added a comment. Set aboutToPopulate always, and before setting the rootIndex. Fixes pre-selecting the active window when moving the dialog from one group to another during drag hover. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D6231: Fix DND onto Task Manager for groups, group dialog scrollbar

hein updated this revision to Diff 15481. hein added a comment. Slightly simpler + better comment. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6231?vs=15480=15481 BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D6231 AFFECTED

D6231: Fix DND onto Task Manager for groups, group dialog scrollbar

hein created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY With this patch drag-hover activation will work for group children, and moving between different group parents while dragging will correctly refresh the dialog contents. BUG:379888 The patch

Re: Plasma Vision v 2.0

On Thursday 15 June 2017 21:16:35 Martin Flöser wrote: > Given that I'm also very uneasy with the formulation of operating > systems. Personally I would like to not see operating systems mentioned > in the vision. Personally - as most know - I wouldn't mind if we would > only support Linux (and

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

This revision was automatically updated to reflect the committed changes. Closed by commit R119:20ba491cb6bd: [Folder View] Pad cellWidth/cellHeight with the extra space (authored by Zren). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

Re: Plasma Vision v 2.0

Am 2017-06-12 01:19, schrieb Aleix Pol: On Sun, Jun 11, 2017 at 11:13 PM, Jonathan Riddell wrote: Yay, I like it. Across different operating systems? We don't do anything on Windows or Mac. Jonathan On Fri, Jun 09, 2017 at 09:40:28AM +0200, Jens Reuterberg wrote:

Re: Plasma Vision v 2.0

Am 2017-06-09 09:40, schrieb Jens Reuterberg: Time to get back to the vision. Plasma Vision 2 Plasma never dictates the user's needs, it only strives to solve them. Plasma never defines what the user should be allowed to do, it only ensures that she can. I'm not too happy with

D6191: Simplify KNSBackend fetch logic

leinir added a comment. In https://phabricator.kde.org/D6191#116635, @apol wrote: > In https://phabricator.kde.org/D6191#116531, @leinir wrote: > > > In https://phabricator.kde.org/D6191#116480, @apol wrote: > > > > > This will go to Plasma/5.10, right? > > > > > > As in,

D6191: Simplify KNSBackend fetch logic

apol added a comment. In https://phabricator.kde.org/D6191#116531, @leinir wrote: > In https://phabricator.kde.org/D6191#116480, @apol wrote: > > > This will go to Plasma/5.10, right? > > > As in, merge this patch into Plasma/5.10 as well as master? I don't see why it would

D6141: make shadows work for windows 100%width or height

mart added a comment. note: this is mutually exclusive with https://phabricator.kde.org/D6164 REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6141 To: mart, #plasma, #kwin, graesslin Cc: luebking, mvourlakos, davidedmundson, plasma-devel, kwin, ZrenBot, spstarr,

D6141: make shadows work for windows 100%width or height

mart added inline comments. INLINE COMMENTS > graesslin wrote in geometry.cpp:2010 > why is the signal moved? hmm, this actually got mixed with https://phabricator.kde.org/D6229, but was not supposed to end up in this one REPOSITORY R108 KWin REVISION DETAIL

Re: Plasma Vision v 2.0

On Friday 09 June 2017 09:40:28 Jens Reuterberg wrote: > Time to get back to the vision. > > Plasma Vision 2 > > Plasma Desktop is a cross device work environment where total trust is put > on the user's capacity to best define her own workflow and preferences. > [...] +1 to the

D6229: geometry shape changes also with no resize

This revision was automatically updated to reflect the committed changes. Closed by commit R108:8190927eafa8: geometry shape changes also with no resize (authored by mart). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6229?vs=15469=15471 REVISION DETAIL

D6214: check window visibility at expose event

This revision was automatically updated to reflect the committed changes. Closed by commit R135:7ace568d2374: check window visibility at expose event (authored by mart). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D6141: make shadows work for windows 100%width or height

graesslin added inline comments. INLINE COMMENTS > geometry.cpp:2010 > } > +emit geometryShapeChanged(this, geometryBeforeUpdateBlocking()); > addRepaintDuringGeometryUpdates(); why is the signal moved? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6141

D6229: geometry shape changes also with no resize

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D6229 To: mart, #plasma, #kwin, graesslin, davidedmundson Cc: plasma-devel, kwin, ZrenBot, spstarr, progwolff,

D6229: geometry shape changes also with no resize

mart created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY the morphingpopup effect was working with notifications only in wayland. looking at what the codepath is, the signal geometryShapeChanged

D6141: make shadows work for windows 100%width or height

mart updated this revision to Diff 15468. mart added a comment. Restricted Application edited projects, added KWin; removed Plasma. - more explicit checking on width/height==0 REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6141?vs=15310=15468 BRANCH master

[Breeze] [Bug 381196] Make notification popup have rounded corners

https://bugs.kde.org/show_bug.cgi?id=381196 --- Comment #4 from Michael D --- Will do. Thanks. -- You are receiving this mail because: You are the assignee for the bug.

D6216: simplify positioning code

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D6216 To: mart, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff,

D6216: simplify positioning code

mart updated this revision to Diff 15464. mart added a comment. use dialog size instead of its mainitem's REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6216?vs=15463=15464 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6216

D6216: simplify positioning code

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in notificationshelper.cpp:294 > I find it odd that we use the contentItem height not the window height which > includes the frame margins. > > Especially given that whole other patch is about making sure the window is >

D6216: simplify positioning code

davidedmundson added a comment. Mostly seems sensible, mine doesn't animate as-is anyway. Just one question. INLINE COMMENTS > notificationshelper.cpp:294 > } else { > -int posY = m_plasmoidScreen.bottom() - cumulativeHeight - >

D6216: simplify positioning code

mart edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6216 To: mart, #plasma Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6215: Make sure size is final after showEvent

mart marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6215 To: mart, #plasma, davidedmundson Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,

D6215: Make sure size is final after showEvent

mart retitled this revision from "Introduce aboutToShow() signal" to "Make sure size is final after showEvent". mart edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6215 To: mart, #plasma, davidedmundson Cc:

D6216: simplify positioning code

mart updated this revision to Diff 15463. mart added a comment. just rely on visibleChanged, abouttoshow dropped REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6216?vs=15430=15463 BRANCH master REVISION DETAIL

D6215: Introduce aboutToShow() signal

mart updated this revision to Diff 15462. mart added a comment. update size in showevent update size in showevent, get rid of aboutToShow signal showing and hiding mainItem (as opposed to its window) had repercussions on the size calculation, giving it a stuttering appearance when

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6188 To: Zren, hein Cc: anthonyfieroni, broulik, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D3051: [applets/notification] Add nullptr check

graesslin abandoned this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3051 To: graesslin, #plasma, sebas, broulik Cc: mart, sebas, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, lukas

D5767: Postpone searches for half a human moment

leinir abandoned this revision. leinir added a comment. Incidentally, because KNS itself will already postpone non-cached searches by one second, the new proposed solution above (to only to this for KNS sources) is already implemented by way of using https://phabricator.kde.org/D6191

D6191: Simplify KNSBackend fetch logic

This revision was automatically updated to reflect the committed changes. Closed by commit R134:efaa09a20543: Simplify KNSBackend fetch logic (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6191?vs=15444=15459 REVISION

D6191: Simplify KNSBackend fetch logic

leinir added a comment. In https://phabricator.kde.org/D6191#116480, @apol wrote: > This will go to Plasma/5.10, right? As in, merge this patch into Plasma/5.10 as well as master? I don't see why it would fail to merge, yeah, i'll do that :) REPOSITORY R134 Discover Software