anthonyfieroni added inline comments.
INLINE COMMENTS
> dialogshadows.cpp:270
> {
> m_shadowPixmaps << q->pixmap(element);
> }
Validate element (hasElement and > 0) or add default pixmap.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6518
Good morning dear KDE contributor
As the registration [1] for the Randa Meetings 2017 ends soon: Sunday, 16th of
September 2017, 23.59 UTC, I wanted to remind you about this years topic:
Make KDE more accessible.
Please help us with this challenge and read more about it [2].
If there are any
davidedmundson added a comment.
What if a theme only has shadow-top, but not right etc.
(or a more likely scenario, they exist, but the metadata has them be 0px big)
What would happen if you have a theme with shadow then switch to one without?
REPOSITORY
R242 Plasma Framework
scarpino created this revision.
Restricted Application added a project: Plasma.
TEST PLAN
built and tested
REPOSITORY
R116 Plasma Network Management Applet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6520
AFFECTED FILES
vpn/l2tp/l2tpadvanced.ui
To: scarpino, jgrulich
mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
some themes don't have a valid shadow, which would lead
to a crash in kwayland, don't even try to render a shadow
if
mart added a comment.
I tried the patch, and i'm getting a crash as well, tough a bit different:
#0 0x7fff39b74cf5 in
KAStatsFavoritesModel::Private::removeOldCachedEntries() const () from
/opt/kde5/qml/org/kde/plasma/private/kicker/libkickerplugin.so
#1 0x7fff39b7377a in
broulik added inline comments.
INLINE COMMENTS
> natgeoprovider.cpp:56
>
> -const QString data = QString::fromUtf8( job->data() );
> +const auto data = QString::fromUtf8( job->data() ).split("\n");
>
Please use `splitRef`
(Makes me wonder why it turns it into a `QString` in the
On Wednesday July 05 2017 10:58:59 Hugo Pereira Da Costa wrote:
>No
>the default is false (no frame):
>
>breeze.kcfg:
>
>
>
>false
>
>
Curious, I've always seen Breeze display the frame, and never activated the
option as far as I can remember. I did notice yesterday that breezerc doesn't
Related to the vision discussion are the lines I've written for Plasma in the
app lifecycle
https://community.kde.org/Policies/Application_Lifecycle/Draft
Plasma is a cross device work environment where trust is put on the users'
capacity to best define her own workflow and preferences.
Ok after much edits and fiddling this is the current one - based on input from
a wealth of sources and people:
-- --
"Plasma is a cross-device work environment by the KDE Community where trust is
put on the user's capacity to best
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
fix-x11-edge-deactivation-5.10
REVISION DETAIL
https://phabricator.kde.org/D6467
To: graesslin, #kwin, #plasma, mart
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai,
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
slideback-ignore-windows-outside-visible-area-5.10
REVISION DETAIL
https://phabricator.kde.org/D6468
To: graesslin, #kwin, #plasma, mart
Cc: plasma-devel, kwin, ZrenBot, progwolff,
On Wednesday July 05 2017 09:55:27 Hugo Pereira Da Costa wrote:
(CC'ing the plasma-devel ML and thus keeping Hugo's full reply as context.)
>On 07/04/2017 11:13 PM, René J.V. Bertin wrote:
>> On Tuesday July 04 2017 20:16:55 Sebastian Kügler wrote:
>>
>> @Kevin: should we continue to CC you?
>>
13 matches
Mail list logo
