D6577: Don't autohide panel if a child window is open

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is meant as a more generic fix for the autohide panels, actually looking to see what transient windows we have open. The

D6554: [Plasma Dialog] Fix flag condition

davidedmundson accepted this revision. davidedmundson added a comment. There's a bunch more q->flags & Qt::Tooltip, if we're going to change one, we should change them all. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6554 To: broulik,

D6573: Babelfish plugin: Allow secure URLs to be translated

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R226 Konqueror REVISION DETAIL https://phabricator.kde.org/D6573 To: marten, #konqueror, #plasma, dfaure Cc: plasma-devel, #dolphin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D6569: [client] Track all created ConnectionThreads and add API to access them

graesslin added a comment. In https://phabricator.kde.org/D6569#123081, @davidedmundson wrote: > I don't think this is necessary. > > The only times we want need to delete the connection ourselves is when client code is creating it via ConnectionThread::fromApplication. If they

D6573: Babelfish plugin: Allow secure URLs to be translated

marten updated this revision to Diff 16361. marten added a comment. Use KParts::BrowserExtension::childObject(part) to test for browser part (needs to be guarded by part!=NULL). Split up the big conditional. Use part->widget() as parent for message boxes. REPOSITORY R226 Konqueror

D6573: Babelfish plugin: Allow secure URLs to be translated

marten marked 2 inline comments as done. REPOSITORY R226 Konqueror REVISION DETAIL https://phabricator.kde.org/D6573 To: marten, #konqueror, #plasma, dfaure Cc: plasma-devel, #dolphin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. Btw, should I bump patches to KWin/KRfb to match this version? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai,

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. @davidedmundson , @graesslin , I cleaned up fake-input handling, fixed autotests. Tested this manually with patched KWin and KRfb version - all works fine (only one screen though). I'm able to retrieve wl_output from native interface as David suggested.

D1231: Add Remote Access interface to KWayland

Kanedias updated this revision to Diff 16359. Kanedias added a comment. some -> const modifiers and typos REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1231?vs=16318=16359 REVISION DETAIL https://phabricator.kde.org/D1231 AFFECTED FILES

D6565: Query supported OpenGL core profile version on X11, GLX

fredrik added a comment. You should use the GLX_MESA_query_renderer extension for this when it is available. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D6565 To: madcatx, graesslin Cc: fredrik, graesslin, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai,

Re: KWin 5.10.3.1 update

On Saturday 08 July 2017, Martin Flöser wrote: > Am 2017-07-07 15:54, schrieb Maximiliano Curia: > > ¡Hola Jonathan! > > > > El 2017-07-03 a las 17:26 +0100, Jonathan Riddell escribió: > >> KWin has received an update to the 5.10.3 release. 5.10.3.1 contains a > >> fix for

D6574: [Logout Dialog] Honor "Offer shutdown options"

This revision was automatically updated to reflect the committed changes. Closed by commit R120:913142c565ec: [Logout Dialog] Honor "Offer shutdown options" (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6574?vs=16351=16357

D6575: [Notes applet] Wrap in FocusScope

This revision was automatically updated to reflect the committed changes. Closed by commit R114:300771464b5a: [Notes applet] Wrap in FocusScope (authored by broulik). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6575?vs=16355=16356 REVISION DETAIL

D6575: [Notes applet] Wrap in FocusScope

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:134 > you've added an extra margin to the bottom. That's the bottomMargin the fontButtons Row originally had. I moved all the margins to the FocusScope and then just anchored the items inside without. REVISION

D6575: [Notes applet] Wrap in FocusScope

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Yep, just wanted to check that I'd understood the goal of the patch. INLINE COMMENTS > main.qml:134 > topMargin: verticalMargins > - > -bottom:

D6572: [kstyle] Change ownership of Wayland objects so that KWin can delete them

davidedmundson accepted this revision. REPOSITORY R31 Breeze BRANCH wayland-shadow-parent REVISION DETAIL https://phabricator.kde.org/D6572 To: graesslin, #kwin, #plasma, hpereiradacosta, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D6569: [client] Track all created ConnectionThreads and add API to access them

davidedmundson added a comment. I don't think this is necessary. The only times we want need to delete the connection ourselves is when client code is creating it via ConnectionThread::fromApplication. If they create it themselves, we don't want to, and there's no need to track it.

D6575: [Notes applet] Wrap in FocusScope

broulik added a comment. Well, it's a lot more compact. All the items that I explicitly checked in the previous code are inside the FocusScope now REVISION DETAIL https://phabricator.kde.org/D6575 To: broulik, #plasma Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai,

D6575: [Notes applet] Wrap in FocusScope

davidedmundson added a comment. Is this any different from the current opacity binding? REVISION DETAIL https://phabricator.kde.org/D6575 To: broulik, #plasma Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6575: [Notes applet] Wrap in FocusScope

broulik updated this revision to Diff 16355. broulik added a comment. - Be explicit about opacity 1 or 0 CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6575?vs=16354=16355 REVISION DETAIL https://phabricator.kde.org/D6575 AFFECTED FILES

D6575: [Notes applet] Wrap in FocusScope

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Allows to leverage FocusScope's activeFocus property to determin whether we the text field or formatting buttons have focus. TEST PLAN

D6574: [Logout Dialog] Honor "Offer shutdown options"

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6574 To: broulik, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D6572: [kstyle] Change ownership of Wayland objects so that KWin can delete them

hpereiradacosta added inline comments. INLINE COMMENTS > hpereiradacosta wrote in breezeshadowhelper.h:187 > Just to make sure (I haven't read the other review request): this change is > because Registry now returns QPointer and not raw pointers ? Correct ? ... ignore. I guess this is just to

D6572: [kstyle] Change ownership of Wayland objects so that KWin can delete them

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. looks good ! INLINE COMMENTS > breezeshadowhelper.h:187 > //* The Wayland shadow manager to create Shadows for Surfaces > (QWindow) > -

D6574: [Logout Dialog] Honor "Offer shutdown options"

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY "maysd" stands for "may shut down" apparently. Kickoff already removed the options in this case but clicking "Logout" yields the new dialog

D6573: Babelfish plugin: Allow secure URLs to be translated

dfaure added a comment. Looks good, just some details. INLINE COMMENTS > plugin_babelfish.cpp:225 > + part->url().scheme().compare(QLatin1String("https"), > Qt::CaseInsensitive) == 0 ) && > +(part->inherits("KHTMLPart") || part->inherits("KWebKitPart"))) { >

D6572: [kstyle] Change ownership of Wayland objects so that KWin can delete them

graesslin added a dependency: D6571: Delete all Wayland connections by plugins prior to own Wayland connection. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D6572 To: graesslin, #kwin, #plasma, hpereiradacosta Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D6569: [client] Track all created ConnectionThreads and add API to access them

graesslin added a dependent revision: D6571: Delete all Wayland connections by plugins prior to own Wayland connection. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6569 To: graesslin, #frameworks, #plasma, #kwin Cc: dfaure, plasma-devel, ZrenBot, progwolff,

D6572: [kstyle] Change ownership of Wayland objects so that KWin can delete them

graesslin added a reviewer: hpereiradacosta. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D6572 To: graesslin, #kwin, #plasma, hpereiradacosta Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6571: Delete all Wayland connections by plugins prior to own Wayland connection

graesslin added a dependency: D6569: [client] Track all created ConnectionThreads and add API to access them. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6571 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening,

D6572: [kstyle] Change ownership of Wayland objects so that KWin can delete them

graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY KWin has a problem that breeze crashes it on tear down if the shadow was created. This is due to breeze destroying the Wayland connection

D6573: Babelfish plugin: Allow secure URLs to be translated

marten created this revision. Restricted Application added a project: Plasma. Restricted Application added subscribers: Dolphin, plasma-devel. REVISION SUMMARY The plugin originally only allows HTTP URLs to be translated. With the increasing use of automatic redirection to HTTPS, this

D6569: [client] Track all created ConnectionThreads and add API to access them

dfaure added a comment. Isn't a mutex needed to protect this data structure that is apparently modified by different threads? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6569 To: graesslin, #frameworks, #plasma, #kwin Cc: dfaure, plasma-devel, ZrenBot,

D6571: Delete all Wayland connections by plugins prior to own Wayland connection

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Some libraries loaded into KWin (e.g. breeze) also have a Wayland connection. If KWin destroyes it's own Wayland connection before the

D6565: Query supported OpenGL core profile version on X11, GLX

madcatx added a comment. Fair enough, I'll give it another go. Would it make sense to follow this with a trivial NULL -> nullptr patch to keep the code in this file consistent? REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D6565 To: madcatx, graesslin Cc:

[Powerdevil] [Bug 382114] Screen not locking on lid close

https://bugs.kde.org/show_bug.cgi?id=382114 Martin Flöser changed: What|Removed |Added Product|kscreenlocker |Powerdevil

D6566: Do not leak XVisualInfo (X11 EGL path)

graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. An alternative could be to use QScopedPointer or std::unique_ptr with XFree as the deleter. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D6566 To:

D6565: Query supported OpenGL core profile version on X11, GLX

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. I highly suggest to use the new context attribute builder I created for KWin. See https://phabricator.kde.org/D6411 INLINE COMMENTS > opengl.cpp:778 > + } else { > +

Re: KWin 5.10.3.1 update

Am 2017-07-07 15:54, schrieb Maximiliano Curia: ¡Hola Jonathan! El 2017-07-03 a las 17:26 +0100, Jonathan Riddell escribió: KWin has received an update to the 5.10.3 release. 5.10.3.1 contains a fix for https://bugs.kde.org/show_bug.cgi?id=381870 Freeze in KWin::checkGLError on startup which

D6569: [client] Track all created ConnectionThreads and add API to access them

graesslin created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is change needed by KWin. KWin has the problem that it destroys its internal Wayland connection (KWin as client

D6568: [Image Wallpaper] Allow dropping images and folders into config dialog

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This allows adding images (for image wallpaper) and folders (for slideshow) by dragging them into the list of images/folder. TEST PLAN

D6565: Query supported OpenGL core profile version on X11, GLX

cfeck added a comment. BUG: 373856 REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D6565 To: madcatx Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6566: Do not leak XVisualInfo (X11 EGL path)

broulik added a comment. Would it make sense to wrap that in a `QScopedPointer` with a custom deleter that calls `XFree`? This way one does not need to remember calling it whenever the function is exited. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D6566

D6567: Do not leak XVisualInfo (GLX path)

madcatx created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY XVisualInfo is not released by get_gl_info_glx() TEST PLAN Leak check with valgrind shows that visinfo is no longer leaking. REPOSITORY

D6566: Do not leak XVisualInfo (X11 EGL path)

madcatx created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY XVisualInfo is not released by get_gl_info_egl TEST PLAN Leak check with valgrind shows that visinfo is no longer leaking. REPOSITORY

D6565: Query supported OpenGL core profile version on X11, GLX

madcatx created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Querying OpenGL version on X11 may return only the highest supported OpenGL version that provides the deprecated functionality. Since Mesa

D6551: [Task Manager] Also respect visible property of configure action

This revision was automatically updated to reflect the committed changes. Closed by commit R119:95efcd389e0e: [Task Manager] Also respect visible property of configure action (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D6552: [Folder View] Replay mouse click so left button containment actions work

broulik updated this revision to Diff 16330. broulik retitled this revision from "RFC: [Folder View] Reply mouse click so left button containment actions work" to "[Folder View] Replay mouse click so left button containment actions work". broulik added a comment. - Use EventGenerator – wow.

D6552: RFC: [Folder View] Reply mouse click so left button containment actions work

broulik added a comment. Sure, I was thinking about that, but couldn't recall the name of it :D I'll have a look REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6552 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D6552: RFC: [Folder View] Reply mouse click so left button containment actions work

hein added a comment. Wouldn't it make more sense to use or extend EventGenerator than introduce a new MouseEventFaker? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6552 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D6551: [Task Manager] Also respect visible property of configure action

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6551 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D6562: Restrict move resize area only on the screen the strut window is on

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY By allowing panels between screens in 5.8 to have a strut we created a "regression" in KWin. KWin always was wrong, just we didn't