Re: Topics for Plasma BoF at Akademy 2017

Am 2017-07-12 06:19, schrieb Bhushan Shah: Hello, On Mon, Jul 10, 2017 at 3:58 PM, Bhushan Shah wrote: Currently room information is not available so we can't book slot but at least we can collect ideas and topics :-) Now room information is available and I've booked a

Re: Topics for Plasma BoF at Akademy 2017

Hello, On Mon, Jul 10, 2017 at 3:58 PM, Bhushan Shah wrote: > Currently room information is not available so we can't book slot but at least > we can collect ideas and topics :-) Now room information is available and I've booked a room 2.3 on Monday for Plasma BoF.

D5034: Add support for x-gvfs style options in fstab

bruns added inline comments. INLINE COMMENTS > fstabstorageaccess.cpp:48 > > +const QStringList = FstabHandling::options(device->device()); > +// GVFS by default doesn't show devices outside of /media, $HOME (and > some other locations) Another useless use of const QList&,

D6634: Require C++14

ivan accepted this revision. ivan added a comment. This revision is now accepted and ready to land. Ignore my comment above, I'm colour-blind today :D REPOSITORY R108 KWin BRANCH cxx-14 REVISION DETAIL https://phabricator.kde.org/D6634 To: graesslin, #plasma, lbeltrame, ivan Cc:

D6634: Require C++14

ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed. It is undefined behaviour to extend std:: namespace in this way. You should go for this instead: #if ... template ... make_unique ... #else using

[Powerdevil] [Bug 382105] Power devil crash dès la sortie de veille

https://bugs.kde.org/show_bug.cgi?id=382105 kristof changed: What|Removed |Added Platform|Other |Mint (Ubuntu based) -- You

D6634: Require C++14

graesslin added a reviewer: lbeltrame. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6634 To: graesslin, #plasma, lbeltrame Cc: plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D6634: Require C++14

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. REVISION SUMMARY KWin already used C++14 constructs in a conditional way. This doesn't make much sense today, it's better to just require C++14.

D6572: [kstyle] Change ownership of Wayland objects so that KWin can delete them

This revision was automatically updated to reflect the committed changes. Closed by commit R31:5328a253ccdc: [kstyle] Change ownership of Wayland objects so that KWin can delete them (authored by graesslin). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE

D6630: [kstyle] Do not delete the Surface for a QWindow

graesslin added a comment. In https://phabricator.kde.org/D6630#124201, @davidedmundson wrote: > Whilst this does make sense based on the current design we are effectively building up dead objects during the lifespan of a window doing show/hide/show. Well it was designed when Qt

D6630: [kstyle] Do not delete the Surface for a QWindow

davidedmundson added a comment. Whilst this does make sense based on the current design we are effectively building up dead objects during the lifespan of a window doing show/hide/show. Someone somewhere should delete it. Assuming everyone follows the same design pattern of following

D6611: Implement support for restricted move area on Wayland

This revision was automatically updated to reflect the committed changes. Closed by commit R108:672cae9a7d36: Implement support for restricted move area on Wayland (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6611?vs=16456=16522

D6562: Restrict move resize area only on the screen the strut window is on

This revision was automatically updated to reflect the committed changes. Closed by commit R108:14c8440f11f9: Restrict move resize area only on the screen the strut window is on (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D6631: Fix compilation with strict libc (such as musl)

mpyne edited the summary of this revision. mpyne removed a reviewer: Frameworks. mpyne changed the repository for this revision from R111 KSysguard Library to R106 KSysguard. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D6631 To: mpyne, #plasma Cc: plasma-devel,

D6455: position the shellsurface immediately

graesslin added a comment. What I don't like about it is that KWin will get and react on two events with one having invalid coordinates. We get an event for the change of x and at that point y might be invalid. KWin will position the window there and that can result in mess (e.g. all

D6630: [kstyle] Do not delete the Surface for a QWindow

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D6630 To: graesslin, #plasma, mart, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D6631: Fix compilation with strict libc (such as musl)

mpyne created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Many of the functions we use implicitly are not part of the C standard library so we have to specific that we're pulling from POSIX, X/Open,

D6630: [kstyle] Do not delete the Surface for a QWindow

graesslin edited the test plan for this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D6630 To: graesslin, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6630: [kstyle] Do not delete the Surface for a QWindow

graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Surface::fromWindow are shared! By deleting the Surface pointer copies in other areas are getting deleted as well. This breaks e.g. KWin

D6630: [kstyle] Do not delete the Surface for a QWindow

graesslin added a reviewer: mart. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D6630 To: graesslin, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6572: [kstyle] Change ownership of Wayland objects so that KWin can delete them

graesslin updated this revision to Diff 16518. graesslin added a comment. Undo arc mess REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6572?vs=16517=16518 BRANCH wayland-shadow-parent REVISION DETAIL https://phabricator.kde.org/D6572 AFFECTED FILES

D6572: [kstyle] Change ownership of Wayland objects so that KWin can delete them

graesslin updated this revision to Diff 16517. graesslin added a comment. - [kstyle] Do not delete the Surface for a QWindow REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6572?vs=16350=16517 BRANCH shadow-no-delete-surface REVISION DETAIL

D6562: Restrict move resize area only on the screen the strut window is on

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH restricted-move-area-multiple-panels REVISION DETAIL https://phabricator.kde.org/D6562 To: graesslin, #kwin, #plasma, mart Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai,

D6611: Implement support for restricted move area on Wayland

mart accepted this revision. This revision is now accepted and ready to land. BRANCH restricted-move-resize-wayland REVISION DETAIL https://phabricator.kde.org/D6611 To: graesslin, #kwin, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D6455: position the shellsurface immediately

mart added a reviewer: graesslin. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6455 To: mart, #plasma, graesslin Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6571: Delete all Wayland connections by plugins prior to own Wayland connection

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH connection-cleanup REVISION DETAIL https://phabricator.kde.org/D6571 To: graesslin, #kwin, #plasma, mart Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D6568: [Image Wallpaper] Allow dropping images and folders into config dialog

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6568 To: broulik, #plasma, #vdg, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D5209: Load translations from KPackage files if bundled

ltoscano added a comment. In https://phabricator.kde.org/D5209#124129, @davidedmundson wrote: > contents/locale/fr/org.kde.blahblah.po > > which is the same as KDE4. I guess you mean contents/locale/fr/org.kde.blahblah.**mo** ? REPOSITORY R242 Plasma Framework (Library)

D5209: Load translations from KPackage files if bundled

davidedmundson added a comment. contents/locale/fr/org.kde.blahblah.po which is the same as KDE4. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5209 To: davidedmundson, #plasma, mart Cc: Zren, plasma-devel, #frameworks, ZrenBot, progwolff,

D5209: Load translations from KPackage files if bundled

Zren added a comment. Oh awesome. Just found out about this. So this would be added in Frameworks 5.37 then? Does this mean: 1. `digitalclock.plasmoid/translations/plasma_applet_org.kde.plasma.digitalclock.po` 2.

D6615: Simplify Alternatives Dialog code

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c32548441d97: Simplify Alternatives Dialog code (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6615?vs=16480=16514 REVISION

D3598: rework kscreen's OSD logic

sebas planned changes to this revision. sebas added inline comments. INLINE COMMENTS > davidedmundson wrote in osd.cpp:38 > you're not getting and look and feel / theming in here. We do get theming, but not the OSD from the Look and Feel package. I feel it's overkill to include this in the

D6628: Fix and normalize license in .desktop files

sebas created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The license is often specificed as (L)GPL, which means v2, while the actual code is usually v2 or v2+. This patch reflects that. TEST PLAN

D6443: [CurrentContainmentActionsModel] Add configurationChanged signal

broulik updated this revision to Diff 16512. broulik added a comment. Connect signal to signal REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6443?vs=16511=16512 REVISION DETAIL https://phabricator.kde.org/D6443 AFFECTED FILES

D5209: Load translations from KPackage files if bundled

This revision was automatically updated to reflect the committed changes. Closed by commit R242:3a0f61b5591d: Load translations from KPackage files if bundled (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D6443: [CurrentContainmentActionsModel] Add configurationChanged signal

broulik updated this revision to Diff 16511. broulik added a comment. Use a separate connect REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6443?vs=16040=16511 REVISION DETAIL https://phabricator.kde.org/D6443 AFFECTED FILES

D6555: [Applet Alternatives] Set applet status to RequiresAttentionStatus while open

broulik abandoned this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6555 To: broulik, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6627: Fix license in metadata.desktop files

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e3bbe82ebfb3: Fix license in metadata.desktop files (authored by sebas). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6627?vs=16507=16508 REVISION

D6627: Fix license in metadata.desktop files

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D6627 To: sebas, #plasma, sitter, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D6627: Fix license in metadata.desktop files

sebas created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The license key is specified as GPL, while the actual code (I checked) in all these cases is licensed under GPL version 2 or later. This

D6626: Session file parser: Support sections and respect the Hidden property

This revision was automatically updated to reflect the committed changes. Closed by commit R123:992143c4bf5a: Session file parser: Support sections and respect the Hidden property (authored by fvogt). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE

D6626: Session file parser: Support sections and respect the Hidden property

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. We should just port this back to KConfig / QSettings sometime. REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH Plasma/5.8 REVISION DETAIL

D6626: Session file parser: Support sections and respect the Hidden property

fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY Some desktop files have multiple sections, but for now we're only interested in [Desktop Entry]. Without this patch, every entry was seen as part of the [Desktop Entry] session, resulting in values

D6608: [PlasmaComponents Menu] Don't crash on null action

This revision was automatically updated to reflect the committed changes. Closed by commit R242:21f954d94dc5: [PlasmaComponents Menu] Don't crash on null action (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D6498: Don't list plasmashell in menus

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6f3f0d85085c: Don't list plasmashell in menus (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6498?vs=16161=16500 REVISION

Re: Plasma Mobile

Hi Martin, On woensdag 5 juli 2017 17:49:27 CEST Martin Stock wrote: > I Love the idea of Plasma Mobile. I would like help the system to be better > and more popular. But I can not find any tutorial for it. Especially to do > Android apps for it. > > Who can help me?

D6615: Simplify Alternatives Dialog code

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D6615 To: davidedmundson, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

Plasma Mobile

Hi there, I Love the idea of Plasma Mobile. I would like help the system to be better and more popular. But I can not find any tutorial for it. Especially to do Android apps for it. Who can help me? Best Martin -- *Windows - was ist das?* Mein Notebook läuft jetzt mit Solus OS

D6608: [PlasmaComponents Menu] Don't crash on null action

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6608 To: broulik, #plasma, davidedmundson Cc: anthonyfieroni, davidedmundson, plasma-devel, #frameworks, ZrenBot,

D6440: [CurrentContainmentActionsModel] Allow making the action about dialog modal

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e5e0e91daa52: [CurrentContainmentActionsModel] Allow making the action about dialog modal (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D6608: [PlasmaComponents Menu] Don't crash on null action

broulik updated this revision to Diff 16491. broulik added a comment. When assigning an action, match the item's visibility and enabled REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6608?vs=16452=16491 REVISION DETAIL

D6612: Honour the NoDisplay attribute of KServices

This revision was automatically updated to reflect the committed changes. Closed by commit R124:85ed16cd4228: Honour the NoDisplay attribute of KServices (authored by fvogt). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6612?vs=16457=16487 REVISION