D6791: Drop the Workspace::slotSwitchWindowFoo methods

2017-07-19 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. BRANCH no-slot-switch-window REVISION DETAIL https://phabricator.kde.org/D6791 To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D6791: Drop the Workspace::slotSwitchWindowFoo methods

2017-07-19 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY They were only delegating into switchWindow(Direction), so let's do the same through std::bind in kwinbindings and delegate to it directly

D6631: Fix compilation with strict libc (such as musl)

2017-07-19 Thread Michael Pyne
mpyne added a comment. In https://phabricator.kde.org/D6631#126366, @bcooksley wrote: > Thanks for the quick fix. > > Getting closer - got a different error this time... > https://build.kde.org/job/Plasma%20ksysguard%20kf5-qt5%20FreeBSDQt5.7/7/ This fix wasn't as quick, I

D6786: [server] Send text input leave if focused surface gets unbound

2017-07-19 Thread Martin Flöser
graesslin created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY As https://phabricator.kde.org/R127:98e5d269a110dca9cae1e4ed2bb3051f02a69bff just for text input. TEST PLAN

D6657: [krunner] First set panel behavior than as panel

2017-07-19 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R120:e967385b0a58: [krunner] First set panel behavior than as panel (authored by graesslin). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6657?vs=16602=16921

D6764: Add font size setting to the digital clock plasmoid

2017-07-19 Thread Chris Holland
Zren added inline comments. INLINE COMMENTS > DigitalClock.qml:473 > italic: plasmoid.configuration.italicText > -pixelSize: 1024 > +pointSize: plasmoid.configuration.fontSize > } We use `font.pixelSize` to avoid the

D6657: [krunner] First set panel behavior than as panel

2017-07-19 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D6657#126858, @davidedmundson wrote: > Doesn't do any harm. > > Was the original intention (before "the qt bug") to have shell surface set all it's states before the window gets mapped? Yes, the complete interface is

D6657: [krunner] First set panel behavior than as panel

2017-07-19 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Doesn't do any harm. Was the original intention (before "the qt bug") to have shell surface set all it's states before the window gets mapped? REPOSITORY R120 Plasma

D6784: Move bitCount from utils to GlxBackend

2017-07-19 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH bitCount-glxbackend REVISION DETAIL https://phabricator.kde.org/D6784 To: graesslin, #plasma, #kwin, davidedmundson Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai,

D6784: Move bitCount from utils to GlxBackend

2017-07-19 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Only used in GlxBackend. Make bitCount constexpr REPOSITORY R108 KWin BRANCH bitcount-constexpr REVISION DETAIL

D6785: Move bitCount from utils to GlxBackend

2017-07-19 Thread Martin Flöser
graesslin added a dependency: D6784: Move bitCount from utils to GlxBackend. REVISION DETAIL https://phabricator.kde.org/D6785 To: graesslin, #kwin, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6784: Move bitCount from utils to GlxBackend

2017-07-19 Thread Martin Flöser
graesslin added a dependent revision: D6785: Move bitCount from utils to GlxBackend. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6784 To: graesslin, #plasma, #kwin Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D6785: Move bitCount from utils to GlxBackend

2017-07-19 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Make bitCount constexpr BRANCH bitcount-constexpr REVISION DETAIL https://phabricator.kde.org/D6785 AFFECTED FILES

D6657: [krunner] First set panel behavior than as panel

2017-07-19 Thread Martin Flöser
graesslin added a comment. ping! Anything speaking against this simple patch to make the situation better? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6657 To: graesslin, #plasma Cc: mart, apol, plasma-devel, ZrenBot, progwolff, lesliezhai,

D6784: Move bitCount from utils to GlxBackend

2017-07-19 Thread Martin Flöser
graesslin updated this revision to Diff 16918. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Fix arc stupidity REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6784?vs=16917=16918 BRANCH bitCount-glxbackend

D6783: Replace Workspace::slotWindowQuickTileFoo by a quickTileWindow with argument

2017-07-19 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Thanks to std::bind we don't need that many different slots to setup the global shortcut connections. Instead we can have one shared

D6776: Don't perform wayland specific fixes when on X

2017-07-19 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R242:a0e5bb3ea70d: Don't perform wayland specific fixes when on X (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D6493: Add KF5WindowSystem to link interface

2017-07-19 Thread Andreas Sturmlechner
This revision was automatically updated to reflect the committed changes. Closed by commit R242:5033a104e226: Add KF5WindowSystem to link interface (authored by asturmlechner). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D6776: Don't perform wayland specific fixes when on X

2017-07-19 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D6776 To: davidedmundson, #plasma, mart Cc: graesslin, plasma-devel,

D6776: Don't perform wayland specific fixes when on X

2017-07-19 Thread David Edmundson
davidedmundson updated this revision to Diff 16911. davidedmundson added a comment. Fixed comment nonsense. Shuffled other code REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6776?vs=16899=16911 BRANCH origin-master (branched from