Plasma and kai uwe win akademy award

2017-07-23 Thread Jonathan Riddell
Plasma has won the akademy award for best application and especially for kai uwe as one of the hardest working and the best looking developer on the team

D6853: Reset most_recently_raised when removing ShellClient

2017-07-23 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:7eb05552ca0d: Reset most_recently_raised when removing ShellClient (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6853?vs=17062&id=17065 REVI

D6853: Reset most_recently_raised when removing ShellClient

2017-07-23 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH unset-most-recently-raised REVISION DETAIL https://phabricator.kde.org/D6853 To: graesslin, #plasma, #kwin, davidedmundson Cc: plasma-devel, kwin, ZrenBot, progwolff, leslie

D6853: Reset most_recently_raised when removing ShellClient

2017-07-23 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY This time without a test case that could trigger a crash as the only reading usage of the variable could luckily not crash. REPOSITORY

D6852: Reset last_active_client when a ShellClient is removed

2017-07-23 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:bd158a632100: Reset last_active_client when a ShellClient is removed (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6852?vs=17060&id=17061 RE

D6852: Reset last_active_client when a ShellClient is removed

2017-07-23 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D6852#127904, @davidedmundson wrote: > there's 3 other differences between removeClient that I think should also be here: yep I know, guess what I will work on next ;-) should_get_focus is btw. currently not yet a prob

D6852: Reset last_active_client when a ShellClient is removed

2017-07-23 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. there's 3 other differences between removeClient that I think should also be here: --- should_get_focus.removeAll(c); (this looks like it could lead to a sim

D6852: Reset last_active_client when a ShellClient is removed

2017-07-23 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The last_active_client is set when an AbstractClient gets activated. For the X11 case the last_active_client was getting reset to nullpt

D6851: Updated to newer version

2017-07-23 Thread Aditya Mehra
Aiix created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Updated to Newer Version Ref https://phabricator.kde.org/T6570 Changelog: 1. added: New conversation model allows visual feedback for sk