hein added a comment.
I'll now run with this revision of the patch for a while, but please look
into the above / reply! :)
REVISION DETAIL
https://phabricator.kde.org/D3805
To: ivan, mart, hein
Cc: Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, se
hein added a comment.
I was on activity 2 and adding some faves on dash from the Recent apps
section, and the second fav I added had the same icon as the first fav I added,
even though it was for a different app. Switching to the first activity and
back to 2 fixed the icon. Could be a Qt Qui
hein added a comment.
No longer crashing!
Remaining concerns after repeating tests:
- The result of the migration is now the superset of all faves, but sorting
is a bit weird (maybe this is the best possible?)
- However it only ends up on my first activity, the other activity was
On Friday, August 4, 2017 7:03:43 PM EDT Aleix Pol wrote:
> On Fri, Aug 4, 2017 at 5:13 PM, Andrew wrote:
> >> > On donderdag 3 augustus 2017 18:45:24 CEST Aleix Pol wrote:
> >> >> On Thu, Aug 3, 2017 at 5:48 PM, Marco Martin wrote:
> >> >>
> >> >>
> >> >> > On Thursday 03 August 2017 11:51:08 Se
On Fri, Aug 4, 2017 at 5:13 PM, Andrew wrote:
>> > On donderdag 3 augustus 2017 18:45:24 CEST Aleix Pol wrote:
>> >> On Thu, Aug 3, 2017 at 5:48 PM, Marco Martin wrote:
>> >>
>> >>
>> >> > On Thursday 03 August 2017 11:51:08 Sebastian Kügler wrote:
>> >>
>> >>
>> >>
>> >> >> Perhaps a nice additi
hein updated this revision to Diff 17739.
hein added a comment.
Fix logic. This was not actually doing what I wanted.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7092?vs=17738&id=17739
BRANCH
master
REVISION DETAIL
https://phabricator.kde.
hein updated this revision to Diff 17738.
hein added a comment.
Fix dumb logic that happened from never actually reading the contents of the
else if condition ;)
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7092?vs=17622&id=17738
BRANCH
maste
hein added a comment.
> I'm possibly wrong, but instead of the new set couldn't you
> if (appDataCache.contains(window) && appDataCache[window].icon.isValid())
I don't understand on multiple levels :)
There's no QIcon::isValid, and even if there was, the icon being in the cache
an
hein updated this revision to Diff 17737.
hein marked 3 inline comments as done.
hein added a comment.
- qDeleteAll the new pointer vector on destruction.
- Add a Q_ASSERT to catch data corruption.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7
hein marked 3 inline comments as done.
hein added inline comments.
INLINE COMMENTS
> davidedmundson wrote in taskgroupingproxymodel.cpp:41
> Cleanup on destruction.
>
> (which sounds like the name of a new Megadeth single)
Will do.
> davidedmundson wrote in taskgroupingproxymodel.cpp:465
> (I
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
Concept seems fine.
I'm possibly wrong, but instead of the new set couldn't you
if (appDataCache.contains(window) && appDataCache[window].icon.isValid())
In wayland you never query anything, only track events.
What actually do you want to do?
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
> on multiscreen systems, the notification dialog gets resized to 0x0
> by someone else (either kwin, notification applet or Qt code)
So which is it?
REPOSIT
davidedmundson added a comment.
Looks good. 1 tiny change needed I think.
Also some code comments on the QVector would be useful for future people.
INLINE COMMENTS
> taskgroupingproxymodel.cpp:41
>
> -QVector> rowMap;
> +QVector *> rowMap;
>
Cleanup on destruction.
(which s
hein added a comment.
Updated description to match commit message because arc is stupid.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D7139
To: hein, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
ab
hein edited the summary of this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D7139
To: hein, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart, lukas
hein updated this revision to Diff 17733.
hein added a comment.
Slightly nicer commit message.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7139?vs=17732&id=17733
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7139
AFFECTED FIL
hein updated this revision to Diff 17732.
hein added a comment.
Forgot to actually drop the blocks updating QPMI's
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7139?vs=17731&id=17732
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org
hein created this revision.
Restricted Application added a project: Plasma.
REVISION SUMMARY
TaskGroupingProxyModel uses a simple QVector> populated
with source model row indices to represent the task group tree. To
implement QAbstractItemModel::parent(), its implementation of index()
enco
> > On donderdag 3 augustus 2017 18:45:24 CEST Aleix Pol wrote:
> >> On Thu, Aug 3, 2017 at 5:48 PM, Marco Martin wrote:
> >>
> >>
> >> > On Thursday 03 August 2017 11:51:08 Sebastian Kügler wrote:
> >>
> >>
> >>
> >> >> Perhaps a nice addition to plasma-sdk? We already have cuttlefish,
> >> >> t
mart marked an inline comment as done.
mart added inline comments.
INLINE COMMENTS
> broulik wrote in dialog.cpp:1045
> So it will never update its size? Shouldn't it be size == oldSize?
ouch, sure, sorry :)
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde
mart updated this revision to Diff 17712.
mart added a comment.
- fix check
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7127?vs=17704&id=17712
BRANCH
arcpatch-D7127
REVISION DETAIL
https://phabricator.kde.org/D7127
AFFECTED FILE
matank added a comment.
I can confrim that mart's patch ( https://phabricator.kde.org/D7127) solves
the issue.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D7071
To: matank, #plasma, davidedmundson
Cc: mart, plasma-devel, davidedmundson, ltoscan
broulik added inline comments.
INLINE COMMENTS
> dialog.cpp:1045
>
> +if (re->size().isEmpty() || re->size() != re->oldSize()) {
> +return;
So it will never update its size? Shouldn't it be size == oldSize?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://ph
Hi,
Is there any class or function available in Qt or KF5 that allows to query the
current state of the mouse on X11 and/or Wayland and that is not based on
internal event handling? Alternatively, is such a function available in a
library that is already used anyway by every application that pu
mart updated this revision to Diff 17706.
mart added a comment.
remove unrelated changes
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6964?vs=17703&id=17706
BRANCH
arcpatch-D6964
REVISION DETAIL
https://phabricator.kde.org/D6964
mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
on multiscreen systems, the notification dialog gets resized to 0x0
right after componentcomplete by someone else (either
mart added a comment.
looking into it, i still think the dialog code is correct.
what happens is that someone external resizes the notification window to 0x0
pixels wide right after the componentcomplete event. if as in this patch the
dialog is resized explicitly in componentcomplete, that
mart updated this revision to Diff 17703.
mart added a comment.
ignore resizes to empty sizes
on multiscreen, it happens that notification windows areresized to 0,0
by somebody else (not dialog code, perhaps kwin, perhaps notification applet
this makes the notification main item los
gregormi added a comment.
> 2. In KInfoCenter the "Module Help" button seems to be broken. E.g. "Help"
on the Memory KCM starts the Help Center at the correct location but the
corresponding "Module Help" button in KInfoCenter opens a Help Center page
titled with "Documentation not Found".
[English Below for everyone]
Tjena,
Jag håller i viss mån med eftersom samma effekt blir gällande på Svenska:
"Made By" på Svenska, "Gjord av", betyder ingenting.
Samtidigt tycker jag att det är ett av dom klassiska problemen som dyker upp i
översättningar i allmänhet. Vi antar att det finns nå
On Fri, Aug 4, 2017 at 11:37 AM, Sebastian Kügler wrote:
> On donderdag 3 augustus 2017 18:45:24 CEST Aleix Pol wrote:
>> On Thu, Aug 3, 2017 at 5:48 PM, Marco Martin wrote:
>>
>>
>> > On Thursday 03 August 2017 11:51:08 Sebastian Kügler wrote:
>>
>>
>>
>> >> Perhaps a nice addition to plasma-sdk
fvogt created this revision.
Restricted Application added a project: Plasma.
REVISION SUMMARY
Avoid running if it detects a text session. This can be overridden by adding
"force_run" as argument.
TEST PLAN
Put pam_kwallet5.so as optional in a global common-session pam file
that is include
fvogt created this revision.
Restricted Application added a project: Plasma.
REVISION SUMMARY
It's a documented side effect that initialization of secure memory in gcrypt
drops privileges if getuid() != geteuid(). This results in breaking setuid
callers, like sudo or su.
TEST PLAN
Can use
fvogt created this revision.
Restricted Application added a project: Plasma.
REVISION SUMMARY
- No cppcheck warnings anymore
- Use snprintf everywhere
- Avoid pointless multiplication with sizeof(char)
- Avoid memory leaks
TEST PLAN
Still builds, works the same as before.
REPOSITORY
On donderdag 3 augustus 2017 18:45:24 CEST Aleix Pol wrote:
> On Thu, Aug 3, 2017 at 5:48 PM, Marco Martin wrote:
>
>
> > On Thursday 03 August 2017 11:51:08 Sebastian Kügler wrote:
>
>
>
> >> Perhaps a nice addition to plasma-sdk? We already have cuttlefish, theme
> >> explorer, and the Look
andreaska closed this task as "Invalid".
TASK DETAIL
https://phabricator.kde.org/T6720
To: plasma-devel, andreaska
Cc: #plasma, #vdg, andreaska, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, lukas
37 matches
Mail list logo
