D7319: [Notifications] Clean up States

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY While I'm usually a huge fan of States, this is done only half-way with States in the compact representation (NotificationIcon) overwriting th

D7319: [Notifications] Clean up States

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7319 To: broulik, #plasma, mck182, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterber

D7319: [Notifications] Clean up States

This revision was automatically updated to reflect the committed changes. Closed by commit R120:8f435a2dbde4: [Notifications] Clean up States (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7319?vs=18168&id=18170 REVISION DETAIL

D7271: optionally show a history of notifications

progwolff marked 2 inline comments as done. progwolff added a comment. so this can be considered accepted? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7271 To: progwolff, #plasma, #vdg Cc: mart, graesslin, davidedmundson, plasma-devel, ZrenBot, progwolff

D7321: Collapse favorites sidebar when empty

hein created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY Users occasionally remove all the favorites with that goal in mind, and while not showing the empty area might have consequences if bug 383302 gets imlemented, I think it's an alright suggestion.

D7321: Collapse favorites sidebar when empty

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > MenuRepresentation.qml:32 > ++ Math.max(units.gridUnit * 14, runnerColumns.width)) > +Layout.maximumWidth: (sideBar.width + (sideBar.width ?

D7321: Collapse favorites sidebar when empty

hein updated this revision to Diff 18175. hein added a comment. Cleanup, and fix some ReferenceErrors I noticed along the way. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7321?vs=18173&id=18175 BRANCH master REVISION DETAIL https://phabricat

D7322: Disable bouncy scrolling.

hein created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY Matches other Plasma scrollable lists (e.g. Kicker's). CCBUG:378042 REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D7322 AFFECTED FILES appl

D7323: Expose Cursor position to DeclarativeScripting

davidedmundson created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. REVISION SUMMARY This allows us to write scripts like mousemark, trackmouse, etc. as declarative scripts. It's exposed as a new object ra

D7322: Disable bouncy scrolling.

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D7322 To: hein, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensr

D7322: Disable bouncy scrolling.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:49fb504149e3: Disable bouncy scrolling. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7322?vs=18176&id=18179 REVISION DETAIL https://

D7321: Collapse favorites sidebar when empty

This revision was automatically updated to reflect the committed changes. Closed by commit R119:eedeb3c2a6b4: Collapse favorites sidebar when empty (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7321?vs=18175&id=18180 REVISION DETAI

D7271: optionally show a history of notifications

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. yes REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D7271 To: progwolff, #plasma, #vdg, davidedmundson Cc: mart, graesslin

D7271: optionally show a history of notifications

progwolff added a comment. thanks! REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D7271 To: progwolff, #plasma, #vdg, davidedmundson Cc: mart, graesslin, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterb

D7271: optionally show a history of notifications

This revision was automatically updated to reflect the committed changes. Closed by commit R120:28d86ab43567: optionally show a history of notifications (authored by progwolff). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7271?vs=18139&id=18185#toc REPOSITORY R120 Plasma Workspace

D6494: Drop unused dependencies KF5WindowSystem and KF5XmlGui

asturmlechner added a comment. So, now that the required change is in plasma-framework 5.37 I guess it would be safe for me to push - and also raise the minimum KF5 version to 5.37? REPOSITORY R118 Plasma SDK BRANCH master REVISION DETAIL https://phabricator.kde.org/D6494 To: asturml

D7304: Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH davidedmundson/xdgv6 REVISION DETAIL https://phabricator.kde.org/D7304 To: davidedmundson, #plasma, dfaure Cc: plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai,

D6568: [Image Wallpaper] Allow dropping images and folders into config dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e73ae4f188da: [Image Wallpaper] Allow dropping images and folders into config dialog (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6568?vs=16338&id=18188#toc REPOSITORY

D7323: Expose Cursor position to DeclarativeScripting

anthonyfieroni added inline comments. INLINE COMMENTS > cursorwrapper.cpp:29-30 > +{ > +connect(Cursor::self(), &Cursor::posChanged, this, > &CursorWrapper::positionChanged); > +Cursor::self()->startCursorTracking(); > +} https://phabricator.kde.org/source/kwin/browse/master/cursor.cpp;

D7323: Expose Cursor position to DeclarativeScripting

davidedmundson added a comment. In retrospect, I don't even want cursor tracking - that's for something else entirely. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7323 To: davidedmundson, #plasma Cc: anthonyfieroni, plasma-devel, kwin, #kwin, ZrenBot, progwolff, le

D7322: Disable bouncy scrolling.

broulik added inline comments. INLINE COMMENTS > GroupDialog.qml:93 > > +boundsBehavior: Flickable.StopAtBounds > +snapMode: ListView.SnapToItem This should be `flickableItem.boundsBehavior` but Plasma's `ScrollView` should do that automatically, I don't see why this s

D5699: Remove obsolete add_dependencies

heikobecker added a comment. Ping? REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde.org/D5699 To: heikobecker, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7239: Drop unused dependency

heikobecker added a reviewer: Frameworks. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D7239 To: heikobecker, #plasma, #frameworks Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7331: Show UI for per screen scaling options on supported platforms

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY X still has a global set scale UI Wayland gets a more normal looking per-screen UI TEST PLAN https://phabricator.kde.org/tag/plasma

D7331: Show UI for per screen scaling options on supported platforms

broulik added inline comments. INLINE COMMENTS > outputconfig.cpp:139 > +mScale->addItem(i18nc("Scale multiplier, show everything at 2 times > normal scale", "2x"), 2); > +connect(mScale, > static_cast(&QComboBox::currentIndexChanged), > +this, &OutputConfig::slo

D7332: Port primary combo box to QComboBox::activated

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Get rid of a bunch of blockSignals calls TEST PLAN Started up, apply button initial state still disabled Changed value. Was fine

D7331: Show UI for per screen scaling options on supported platforms

davidedmundson added a comment. Probably would be better, I was just copying the current code. I'll fix the rest of the KCM, and update this. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D7331 To: davidedmundson Cc: broulik, plasma-devel, ZrenBot, progwolff, les

D7332: Port primary combo box to QComboBox::activated

sebas accepted this revision. sebas added a comment. This revision is now accepted and ready to land. Nice. This code is on its way out though, pending my forever-taking kscreen kcm rewrite. Since that's not going fast, I don't want to block progress on the currently shipped version.

D7331: Show UI for per screen scaling options on supported platforms

sebas added a comment. This UI change should be addressed with the new KScreen KCM, btw. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D7331 To: davidedmundson Cc: sebas, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, ap

D7333: Port OutputConfig away from blockSignals

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Port combo boxes to ::activated instead of currentIndexChanged. QCheckBox was already connected to clicked which involves user inter

D7333: Port OutputConfig away from blockSignals

sebas accepted this revision. This revision is now accepted and ready to land. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D7333 To: davidedmundson, #plasma, sebas Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mar

D7331: Show UI for per screen scaling options on supported platforms

davidedmundson updated this revision to Diff 18200. davidedmundson added a comment. Kai's comments REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7331?vs=18195&id=18200 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7331 AFFECTED FILES

D7331: Show UI for per screen scaling options on supported platforms

sebas accepted this revision. sebas added a comment. This revision is now accepted and ready to land. Nice! :) INLINE COMMENTS > outputconfig.h:71 > QComboBox *mRotation; > +QComboBox *mScale; > QComboBox *mRefreshRate; nullptr; ? == The previous code didn't do this, b

D7257: Set the QtQuick Controls 1 style name explicitly

rikmills added a comment. Is this a result of this change? F3863427: d0cb251738.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7257 To: fvogt, #plasma, mart Cc: rikmills, mart, plasma-devel, ZrenBot, progwolff

D7257: Set the QtQuick Controls 1 style name explicitly

rikmills added a comment. Seems it is. Unsetting that env var and restarting plasmashell makes it go away. Reversing that again make the ugliness shown there come back. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7257 To: fvogt, #plasma, mart C

D7316: Avoid sending data offers from an invalid source.

graesslin added inline comments. INLINE COMMENTS > datadevice_interface.cpp:206 > +if (!otherSelection) { > +return sendClearSelection(); > +} please use a dedicated line for the return here. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7316 To: da

D7323: Expose Cursor position to DeclarativeScripting

graesslin added a comment. In https://phabricator.kde.org/D7323#135959, @davidedmundson wrote: > In retrospect, I don't even want cursor tracking - I was thinking of mousePolling, but that no-ops here anyway. KWin doesn't do mousePolling anymore in "normal" situations. On X11 with

D7323: Expose Cursor position to DeclarativeScripting

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. I'm very concerned about this from a security perspective. This would allow to globally get notifications about the cursor positions and thus destroy one of the design goals

D7323: Expose Cursor position to DeclarativeScripting

graesslin added a subscriber: broulik. graesslin added a comment. Just some more thinking: if the aim is better trackmouse or mousemark extending scripts or effects is the wrong approach. Ideally one would want to use the DRM cursor layer for this. The big disadvantage of trackmouse currently

D7257: Set the QtQuick Controls 1 style name explicitly

fvogt added a comment. openQA found something that looks related as well, but unsetting does not help: https://openqa.opensuse.org/tests/467477#step/systemsettings5/5 I cannot reproduce the issue you have either. Maybe some kind of cache or leftovers from other styles? This change shoul

D7260: System tray icon's context menu isn't updated properly in plasma/x11

i.Dark_Templar added reviewers: Plasma, davidedmundson. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7260 To: i.Dark_Templar, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lu

D7257: Set the QtQuick Controls 1 style name explicitly

rikmills added a comment. I am seeing this in both Neon dev-unstable edition (Xenial base), and Kubuntu's CI packages (Artful base). Another user is also seeing it in the Kubuntu CI builds. In both I have created a new user and tested under that, which should eliminate any caching issue

D7323: Expose Cursor position to DeclarativeScripting

luebking added a comment. 2¢ - you don't have to expose the cursor position for those effects, just a signal that the cursor position changed and the ability to "do some" at the "current" cursor position (which is then resolved by the core) REPOSITORY R108 KWin REVISION DETAIL https://p

D7257: Set the QtQuick Controls 1 style name explicitly

fvogt added a comment. Does it work with `export QT_QUICK_CONTROLS_1_STYLE=Breeze`? I don't know how the style selection of Quick Controls work, maybe someone more knowledgeable in that area could chime in here. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kd

D7257: Set the QtQuick Controls 1 style name explicitly

rikmills added a comment. In https://phabricator.kde.org/D7257#136069, @fvogt wrote: > Does it work with `export QT_QUICK_CONTROLS_1_STYLE=Breeze`? > > I don't know how the style selection of Quick Controls work, maybe someone more knowledgeable in that area could chime in here.

D7257: Set the QtQuick Controls 1 style name explicitly

rikmills added a comment. I don't think it has an effect here, but for completeness just in case, I should mention that both Neon and KDE have a patch to #startkde/startkde.cmake https://packaging.neon.kde.org/plasma/plasma-workspace.git/tree/debian/patches/kubuntu_startkde-qtpath.diff?h

D7336: Migrate Xkb::toQtKey away from KKeyServer

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Turn Xkb into a QObject Reduced dependencies on other classes and allows to emit signal directly instead of emitting a signal on an

D7323: Expose Cursor position to DeclarativeScripting

graesslin added a comment. In https://phabricator.kde.org/D7323#136066, @luebking wrote: > 2¢ - you don't have to expose the cursor position for those effects, just a signal that the cursor position changed and the ability to "do some" at the "current" cursor position (which is then reso

D7323: Expose Cursor position to DeclarativeScripting

davidedmundson added a comment. Security in scripts/effects is an existing problem, Scripts already can do literally anything, from manipulating workspace windows to low level DBus calls...as kwin. It needs solving regardless at a much higher level than restricting what API is available.

D7316: Avoid sending data offers from an invalid source.

davidedmundson updated this revision to Diff 18213. davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. Split into two lines REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7316?vs=18162&id=18213

D7316: Avoid sending data offers from an invalid source.

davidedmundson marked an inline comment as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7316 To: davidedmundson, #plasma Cc: graesslin, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7204: Use cached version isDir()

davidedmundson abandoned this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7204 To: davidedmundson, mart Cc: hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7322: Disable bouncy scrolling.

hein added a comment. > This should be flickableItem.boundsBehavior but Plasma's ScrollView should do that automatically Apparently it doesn't, because scrolling is bouncy unless it's set. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7322 To: hein, #p

D7322: Disable bouncy scrolling.

hein added inline comments. INLINE COMMENTS > broulik wrote in GroupDialog.qml:93 > This should be `flickableItem.boundsBehavior` but Plasma's `ScrollView` > should do that automatically, I don't see why this should be needed. https://cgit.kde.org/plasma-framework.git/plain/src/declarativeimpor