D7481: RFC: Batch window changes events on XCB

graesslin added a comment. Window class is not allowed to change by ICCCM. For desktop file we could decide that we don't monitor changes as it is our own property. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7481 To: davidedmundson, #plasma Cc:

D7469: Use icon chooser in Kicker and Dashboard configuration to select custom icon

dvratil added a comment. > BTW this change will also accidentally fix your blurry icon issue you showed me at Akademy. This change **is** a fix for the blurry icon which accidentally improves the config UI ;-) REPOSITORY R119 Plasma Desktop REVISION DETAIL

D7469: Use icon chooser in Kicker and Dashboard configuration to select custom icon

dvratil updated this revision to Diff 18635. dvratil added a comment. Fix fallback to cfg_icon instead of hardcoded start-here-kde. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7469?vs=18562=18635 REVISION DETAIL

D7469: Use icon chooser in Kicker and Dashboard configuration to select custom icon

broulik added inline comments. INLINE COMMENTS > hein wrote in ConfigGeneral.qml:123 > This isn't OK - it needs to revert to the actual config default. Some distros > change it to their branded icon and are very keen on wanting to override > specifically the default rather than pre-setting a

D7469: Use icon chooser in Kicker and Dashboard configuration to select custom icon

davidedmundson added a comment. > @davidedmundson As Kai Uwe said, this is basically just copy-pasted from KickOff configuration code - do you still want me to change it to 1.x control? No, if Kai says something is fine, it's probably fine. BTW this change will also accidentally fix

D7469: Use icon chooser in Kicker and Dashboard configuration to select custom icon

hein added a comment. Can you also check the following case: 1. Use the old UI to INLINE COMMENTS > ConfigGeneral.qml:123 > +cfg_useCustomButtonImage = false; > +cfg_icon = "start-here-kde"; > +} This isn't OK - it

D7481: RFC: Batch window changes events on XCB

hein added a comment. I'm not sure we only care about the title. First of, icons: libtm usually ignores NET::WMIcon changes. It only looks at them for windows which hit the fallback path of using the WM icon. Of course a malicious window might be particularly likely to fall into that

D7260: System tray icon's context menu isn't updated properly in plasma/x11

davidedmundson added a comment. > Did I miss something? One of us did. I did have to redo your patch manually as the diff here doesn't apply to either 5.10 or master. It's possible I did it wrong, maybe you can update it? The only difference is I did right click -> add panel ->

D7475: Make EffectsHandlerImpl::announceSupportProperty work without X11

graesslin added a comment. In https://phabricator.kde.org/D7475#139003, @luebking wrote: > I take there's no such support announcement on native wayland at all? It's different. We have dedicated protocols for them and those are announced through the Wayland protocol registry.

D7436: kimpanel: change highlight color

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5377b6b03b8d: kimpanel: change highlight color (authored by xuetianweng). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7436?vs=18624=18628 REVISION

D7436: kimpanel: change highlight color

xuetianweng added a comment. That's a bug in breeze. Should be fixed with https://phabricator.kde.org/D7491 REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D7436 REVISION DETAIL https://phabricator.kde.org/D7436 To: xuetianweng, #plasma, guoyunhe Cc: xuetianweng, plasma-devel,

D7436: kimpanel: change highlight color

guoyunhe accepted this revision. guoyunhe added a comment. This revision is now accepted and ready to land. F3874133: Screenshot_20170823_225448.png It looks good. Only one small problem: when hovering mouse on selected candidate, its height will

D7436: kimpanel: change highlight color

xuetianweng edited the summary of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7436 To: xuetianweng, #plasma, guoyunhe Cc: xuetianweng, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7436: kimpanel: change highlight color

xuetianweng updated this revision to Diff 18624. xuetianweng added a comment. Use plasma svg as highlight REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7436?vs=18451=18624 BRANCH arcpatch-D7436 REVISION DETAIL

D7436: kimpanel: change highlight color

xuetianweng commandeered this revision. xuetianweng added a reviewer: guoyunhe. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7436 To: xuetianweng, #plasma, guoyunhe Cc: xuetianweng, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D7475: Make EffectsHandlerImpl::announceSupportProperty work without X11

luebking added a comment. I take there's no such support announcement on native wayland at all? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7475 To: graesslin, #kwin, #plasma, davidedmundson Cc: luebking, davidedmundson, plasma-devel, kwin, ZrenBot, progwolff,

D7078: [server] Fix crash when sending selection to a DDI without a DataSource

graesslin abandoned this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7078 To: graesslin, #kwin, #plasma, #frameworks Cc: cfeck, anthonyfieroni, davidedmundson, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D7474: Remove hard X11 runtime dependency from DBusInterface

This revision was automatically updated to reflect the committed changes. Closed by commit R108:793624b9a73d: Remove hard X11 runtime dependency from DBusInterface (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7474?vs=18579=18613

D7475: Make EffectsHandlerImpl::announceSupportProperty work without X11

This revision was automatically updated to reflect the committed changes. Closed by commit R108:651ea26f3c63: Make EffectsHandlerImpl::announceSupportProperty work without X11 (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D7483: Get rid of warnings about setting both pixel and point sizes

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D7483 To: leinir, #kirigami, mart Cc: plasma-devel, apol, mart

D7481: RFC: Batch window changes events on XCB

graesslin added a comment. @hein, @davidedmundson if the main concern is too often update of title I suggest we implement limiting of updates in KWin. So the batch would happen in KWin, taken away stress from KWin and indirectly also from Plasma. Against updating icons it won't help,

D7475: Make EffectsHandlerImpl::announceSupportProperty work without X11

graesslin added a comment. @luebking I don't really follow you. KWin can only talk with one X server. As the properties are resolved against the one and only X server there is no alignement problem. What might happen in future is that we want to support a crashing XWayland server. In this

D7481: RFC: Batch window changes events on XCB

graesslin added a comment. > The reason the old lib did this and the reason I'm aware of for wanting this is to prevent the TM being ddos'd by a rogue window updating its title thousands of times per second. How are we protected from this on Wayland currently? By ensuring KWin does a

D7481: RFC: Batch window changes events on XCB

graesslin added a comment. In https://phabricator.kde.org/D7481#138822, @broulik wrote: > > Theproblem here is Firefox: that one should be fixed. > > I can also cause trouble with VLC if I have a repeating playlist with a broken file in it, it will continuously cycle between "$title"

D7488: Fix deprecated usage of ecm_install_icons

heikobecker created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Fixes a cmake warning. REPOSITORY R104 KScreen BRANCH master REVISION DETAIL https://phabricator.kde.org/D7488 AFFECTED FILES

D7469: Use icon chooser in Kicker and Dashboard configuration to select custom icon

dvratil added a comment. @hein Tested that, you can still choose an arbitrary image file in the filesystem through the dialog and the image is used correctly @davidedmundson As Kai Uwe said, this is basically just copy-pasted from KickOff configuration code - do you still want me to change

D7486: Handle buffer scales changing dynamically

graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in shell_client.cpp:226 > Explicitly for scale changed? > > Can do, but at that point we may as well have Scene connect to > c->surface(), ::scaleChanged > > which would also work. > > I'm fine with any. that sounds

D7486: Handle buffer scales changing dynamically

davidedmundson added inline comments. INLINE COMMENTS > graesslin wrote in shell_client.cpp:226 > Should we maybe introduce a dedicated signal? Explicitly for scale changed? Can do, but at that point we may as well have Scene connect to c->surface(), ::scaleChanged which would also work.

D7486: Handle buffer scales changing dynamically

graesslin added inline comments. INLINE COMMENTS > shell_client.cpp:226 > +//we need to rebuild our window quads > +emit geometryShapeChanged(this, geom); > +} Should we maybe introduce a dedicated signal? REPOSITORY R108 KWin REVISION DETAIL

D7486: Handle buffer scales changing dynamically

davidedmundson created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. REVISION SUMMARY Currently when a client changes it's buffer size the result is corrupt until we move the window. When a client buffer

D7323: Expose Cursor position to DeclarativeScripting

davidedmundson abandoned this revision. davidedmundson added a comment. I'm not particularly convinced by the arguments, but also don't care enough to argue. Might try solving this a different way at a later date. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7323

D7369: [WIP] Wayland foreign protocol

mart added a comment. now the client part is wrapped too, so no V1 exported (the public facing classes should lose "Unstable" probably) two more tests to check that importing the same exported in two clients works and exporting the same surface two times works as well. thanks to david's

D7369: [WIP] Wayland foreign protocol

mart updated this revision to Diff 18596. mart added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. - Don't call release twice - Correctly set - don't call destroy in the destroyed callback - add a test exporting a surface two times - test

D7485: StreamRestore: Always set channel count to 1

This revision was automatically updated to reflect the committed changes. Closed by commit R115:792248092d25: StreamRestore: Always set channel count to 1 (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D7485: StreamRestore: Always set channel count to 1

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D7485 To: drosca, #plasma, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7485: StreamRestore: Always set channel count to 1

drosca created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is what pavucontrol is doing too. BUG: 383787 FIXED-IN: 5.11 TEST PLAN Works for me (but it worked also before) REPOSITORY

D7481: RFC: Batch window changes events on XCB

hein added a comment. In https://phabricator.kde.org/D7481#138817, @davidedmundson wrote: > We don't want it for Wayland. > > Surfaces are double buffered so all synced. We don't fully do that on the XDG side, but most of that is static anyway Can you explain that more? The

D7475: Make EffectsHandlerImpl::announceSupportProperty work without X11

luebking added a comment. Pretty uninformed consideration: When dealing with X11/wayland hybrids, won't one end up with two property indexes which are hard -if not impossible- to align (because one will be assigned by kwin internally and the other by the casual xwayland server)? Might

D7155: Implement sorting of the device tree items

cfeck requested changes to this revision. cfeck added a comment. This revision now requires changes to proceed. Isaac, do you want to work on the requested changes? REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7155 To: isaact, #plasma, cfeck Cc: cfeck,

D7481: RFC: Batch window changes events on XCB

broulik added a comment. > Theproblem here is Firefox: that one should be fixed. I can also cause trouble with VLC if I have a repeating playlist with a broken file in it, it will continuously cycle between "$title" and "VLC" and cause Plasma to freeze. We can't fix all apps…

D7481: RFC: Batch window changes events on XCB

davidedmundson added a comment. We don't want it for Wayland. Surfaces are double buffered so all synced. We don't fully do that on the XDG side, but most of that is static anyway REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7481 To:

D7481: RFC: Batch window changes events on XCB

hein added a comment. I'm in general for this. It's listed in the TODO file as one of the remaining open tasks for the lib, as the old lib did this but it got dropped along the way. However, I would like it to be implemented as a proxy pass (e.g. in WindowTasksModel) so it can be

D7469: Use icon chooser in Kicker and Dashboard configuration to select custom icon

hein added a comment. This was done intentionally in the past to allow people to pick random images and get the proper kind of URL back to feed into the Image (which isn't used anymore). Can you verify this workflow still works? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D7475: Make EffectsHandlerImpl::announceSupportProperty work without X11

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH effects-announce-support-property-no-x11 REVISION DETAIL https://phabricator.kde.org/D7475 To: graesslin, #kwin, #plasma, davidedmundson Cc: davidedmundson, plasma-devel,

D7481: RFC: Batch window changes events on XCB

graesslin added a comment. In general I'm against this as we would also need the same in KWin and every other user. Theproblem here is Firefox: that one should be fixed. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7481 To: davidedmundson, #plasma Cc:

D7483: Get rid of warnings about setting both pixel and point sizes

leinir created this revision. leinir added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Without this patch, the QML engine complains that both pixel and point sizes are being set, and that it will fall back (correctly, but noisily) to the pixel

D7475: Make EffectsHandlerImpl::announceSupportProperty work without X11

graesslin added a comment. In https://phabricator.kde.org/D7475#138747, @davidedmundson wrote: > I assume this is all to make xwayland socket activated so X11ConnectionChanged will come later. Also. First of all I'm interested in being able to start without X support. >

D7482: Automatic scaling selection

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The generator code is run by the KDED when we don't have a profile for a monitor setup. If we don't have a config this sets the

D7481: RFC: Batch window changes events on XCB

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY In a log from someone talking about high CPU we can see get multiple X events for the same window as multiple events, but directly

D7475: Make EffectsHandlerImpl::announceSupportProperty work without X11

davidedmundson added a comment. I assume this is all to make xwayland socket activated so X11ConnectionChanged will come later. You're going out of your way to make sure we when we do get an X11 connection we register any atoms that had previously called announceSupportProperty. Which

D7474: Remove hard X11 runtime dependency from DBusInterface

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH dbus-interface-no-x11-dependency REVISION DETAIL https://phabricator.kde.org/D7474 To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, ZrenBot, progwolff,

D7476: [Recent Documents Runner] Avoid duplicate results

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 381665 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7476 AFFECTED FILES

D7475: Make EffectsHandlerImpl::announceSupportProperty work without X11

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY announceSupportProperty is called from the effects on startup. It registers the property on the X11 root window. If we would start

D7474: Remove hard X11 runtime dependency from DBusInterface

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY KWin's DBusInterface announces the service name on an X11 root window property. For this it requires a runtime dependency on X11. If we

D7472: Don't elide UserDelegate text when there's only one item

This revision was automatically updated to reflect the committed changes. Closed by commit R120:f7cf3c2a68e6: Don't elide UserDelegate text when there's only one item (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D7473: Remove pointless data copy in lockscreen delegate

This revision was automatically updated to reflect the committed changes. Closed by commit R120:cc8647481095: Remove pointless data copy in lockscreen delegate (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D7078: [server] Fix crash when sending selection to a DDI without a DataSource

davidedmundson added a comment. I'm still against it. Passing unexpectedly invalid pointers about all over the place and then trying to guard them afterwards is an anti pattern that leads to future problems. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7078

D7469: Use icon chooser in Kicker and Dashboard configuration to select custom icon

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in ConfigGeneral.qml:26 > this shouldn't be used in a config module. > > Use QtQuick.Controls 1.x instead That's fine. Fwict this code is from Kickoff and there we have a QQC Button for the icon which inside has a Plasma

D7472: Don't elide UserDelegate text when there's only one item

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D7472 To: davidedmundson, #plasma, broulik Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7473: Remove pointless data copy in lockscreen delegate

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7473 To: davidedmundson, #plasma, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D7472: Don't elide UserDelegate text when there's only one item

davidedmundson updated this revision to Diff 18572. davidedmundson added a comment. Comments REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7472?vs=18570=18572 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7472 AFFECTED FILES

D7472: Don't elide UserDelegate text when there's only one item

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in UserDelegate.qml:141 > We could also just disable eliding and it will overflow? Yes, but it would overflow to the right not over the centre. And if I change the anchor to centre, then I need to set a width. I could do

D7472: Don't elide UserDelegate text when there's only one item

broulik added inline comments. INLINE COMMENTS > UserDelegate.qml:141 > text: wrapper.name > elide: Text.ElideRight > horizontalAlignment: Text.AlignHCenter We could also just disable eliding and it will overflow? > UserList.qml:80 > +//if we only have one

D7078: [server] Fix crash when sending selection to a DDI without a DataSource

graesslin added a comment. I'm still in favor of pushing this one too. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7078 To: graesslin, #kwin, #plasma, #frameworks Cc: cfeck, anthonyfieroni, davidedmundson, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai,

D7473: Remove pointless data copy in lockscreen delegate

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Not sure what I was thinking when I wrote it. TEST PLAN Grepped m is not used in file. Grepped it's not used in any other users of

D7472: Don't elide UserDelegate text when there's only one item

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY In the lock screen the user delegate has to elide the text when there are multiple items next to each other, otherwise it will

D7469: Use icon chooser in Kicker and Dashboard configuration to select custom icon

davidedmundson added inline comments. INLINE COMMENTS > ConfigGeneral.qml:26 > +import org.kde.plasma.core 2.0 as PlasmaCore > +import org.kde.plasma.components 2.0 as PlasmaComponents > + this shouldn't be used in a config module. Use QtQuick.Controls 1.x instead REPOSITORY R119 Plasma

D7469: Use icon chooser in Kicker and Dashboard configuration to select custom icon

broulik added a comment. +1 from me One can also choose a custom icon from file system in the icon dialog REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7469 To: dvratil, #plasma Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,