D7521: [WIP] make use of foreign protocol

luebking added a comment. There's a major pitfall to inter-process modality: In case of a persistent transient (used by several clients), the leader may loose the focus access "forever" (because the modal window remains) Thus and in general, transients should certainly not be

D7521: [WIP] make use of foreign protocol

graesslin added a comment. What I absolutely don't understand is why you want to make it modal. I don't see a reason for this to be modal and the X11 variant where this was used is not modal. E.g. kwallet is not modal, polkit is not modal and a file dialog through a flatpack portal should

D7543: [autotests] Support new way to run the tests without need to install

graesslin planned changes to this revision. graesslin added a comment. I figured out why my GL tests are failing: it's XWayland not starting, so totally unrelated. If I use a vgem device the XWayland starts. INLINE COMMENTS > kwin_wayland_test.h:177 > setenv("QT_QPA_PLATFORM",

[Breeze] [Bug 367696] konsole icon is almost invisible when I use breeze dark theme

https://bugs.kde.org/show_bug.cgi?id=367696 Dr. Chapatin changed: What|Removed |Added Version|5.7.3 |5.10.4 -- You are receiving

[Breeze] [Bug 367696] konsole icon is almost invisible when I use breeze dark theme

https://bugs.kde.org/show_bug.cgi?id=367696 Dr. Chapatin changed: What|Removed |Added Summary|konsole: close tab button |konsole icon is almost

D7521: [WIP] make use of foreign protocol

mart added a comment. it still does some weird hoops to set it modal to the parent, it should probably be set somehow client side but doesn't seem to be yet anything in xdgshell? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7521 To: mart, #plasma, graesslin Cc:

D7369: [WIP] Wayland foreign protocol

mart updated this revision to Diff 18767. mart added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. - get rid of setTransientFor REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7369?vs=18760=18767 BRANCH

D7521: [WIP] make use of foreign protocol

mart updated this revision to Diff 18766. mart added a comment. Restricted Application edited projects, added KWin; removed Plasma. - use WaylandServer::findForeignTransientForSurface REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7521?vs=18761=18766 BRANCH

D7521: [WIP] make use of foreign protocol

mart added a comment. here a different approach, if the other one is better, i can get back to it and add WaylandServer::findForeignForSurface REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7521 To: mart, #plasma, graesslin Cc: graesslin, davidedmundson,

D7369: [WIP] Wayland foreign protocol

mart updated this revision to Diff 18760. mart added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. - add a serverside setTransientFor in xdgshell REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D7543: [autotests] Support new way to run the tests without need to install

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is

D7521: [WIP] make use of foreign protocol

graesslin added inline comments. INLINE COMMENTS > mart wrote in shell_client.cpp:1319 > how could it be done as addtransient/transientfor/settransient are all > protected? what I was thinking of is something like: SurfaceInterface *WaylandServer::findForeignForSurface(SurfaceInterface

D7536: Register klipper DBus interface when in non-standalone mode

davidedmundson marked 2 inline comments as done. davidedmundson added a comment. Ok, I'll test each and report back REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7536 To: davidedmundson, #plasma Cc: graesslin, heikobecker, broulik, plasma-devel, ZrenBot,

D7536: Register klipper DBus interface when in non-standalone mode

graesslin added a comment. There was probably a reason why I did it that way. Unfortunately I don't remember :-( The most obvious would be that the exported scriptable objects don't make sense or won't work in the non standalone mode. E.g. a slot which would crash. REPOSITORY R120 Plasma

D7509: Add a property to hide the PageRow separator matching AbstractListItem.

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D7509 To: hein, mart Cc: davidedmundson, plasma-devel, apol, mart

D6881: [Folder View] Implement Select All shortcut

hein added a comment. Go go go REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6881 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7521: [WIP] make use of foreign protocol

mart added a comment. one way i could do, is to add setters for xdgshell to set transient from there, to then use its tracking, it would depend from xdgshell existing, but that's what the protocol says anyways REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7521 To:

D7398: Don't create QWhatsThis when user presses showContextHelp button

graesslin added a comment. In https://phabricator.kde.org/D7398#139994, @luebking wrote: > Probably to handle internal WhatsThis online help (ie. you click the maximize button of a deco and get the information that this is a maximize button) but I don't know either. > Apparently even

D7398: Don't create QWhatsThis when user presses showContextHelp button

luebking added a comment. Probably to handle internal WhatsThis online help (ie. you click the maximize button of a deco and get the information that this is a maximize button) but I don't know either. Apparently even Lubos was already unsure what this was about. I'm not sure whether

D6047: Support XDG v6

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. First round of review, client api is done. INLINE COMMENTS > registry.h:1275 > + * @param name The name for the removed interface > + * @since 5.25 > + **/

D7537: KDE logout screen - change black icons & texts to white/greyish

mart added a comment. phabricator supports screenshots by itself, that should be used. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7537 To: pekkah, #plasma_workspaces, #plasma, #breeze, mart Cc: mart, bshah, #breeze, pekkah, #plasma_workspaces,

D7395: [tabBox] Move X11 specific event filtering into a dedicated event filter

graesslin added a comment. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7395 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D7524: Disable synced resizing for X11 clients on Xwayland

This revision was automatically updated to reflect the committed changes. Closed by commit R108:6f4c02ce1018: Disable synced resizing for X11 clients on Xwayland (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7524?vs=18709=18755

D7398: Don't create QWhatsThis when user presses showContextHelp button

graesslin added a comment. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7398 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D7374: Move X11 movingClient handling into a dedicated X11EventFilter

graesslin added a comment. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7374 To: graesslin, #kwin, #plasma Cc: mart, broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, lukas

D7356: Support mapping QKeyEvent to xkb_keysym_t

graesslin added a comment. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7356 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D7542: [Notifications Applet] Don't explicitly set Plasmoid.icon

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1b56c4b7a925: [Notifications Applet] Don't explicitly set Plasmoid.icon (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D7542: [Notifications Applet] Don't explicitly set Plasmoid.icon

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Good stuff REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7542 To: broulik, #plasma, davidedmundson Cc: davidedmundson, plasma-devel,

D7542: [Notifications Applet] Don't explicitly set Plasmoid.icon

broulik edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7542 To: broulik, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7542: [Notifications Applet] Don't explicitly set Plasmoid.icon

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We have a compact representation anyway. All it does is change the tooltip icon but more importantly break the notification icon in System

D7537: KDE logout screen - change black icons & texts to white/greyish

pekkah added a comment. In https://phabricator.kde.org/D7537#139913, @bshah wrote: > Can you provide screenshot? Sure. I have opened a new bug issue on KDE Bugzilla. You can find it here: https://bugs.kde.org/show_bug.cgi?id=382264 **Screenshots** I have submitted them

D7537: KDE logout screen - change black icons & texts to white/greyish

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. screenshots are necessary for visual changes INLINE COMMENTS > Logout.qml:140 > name: kuser.fullName > +/*ColorOverlay { > +anchors.fill: parent remove

D7537: KDE logout screen - change black icons & texts to white/greyish

bshah added a comment. Can you provide screenshot? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7537 To: pekkah, #plasma_workspaces, #plasma, #breeze Cc: bshah, #breeze, pekkah, #plasma_workspaces, plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai,

D7537: KDE logout screen - change black icons & texts to white/greyish

pekkah added a reviewer: Breeze. pekkah added a subscriber: Breeze. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7537 To: pekkah, #plasma_workspaces, #plasma, #breeze Cc: #breeze, pekkah, #plasma_workspaces, plasma-devel, #plasma, ZrenBot, progwolff,

D7539: Dolphin - Add autoplay feature for media files

pekkah edited the test plan for this revision. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D7539 To: pekkah, #dolphin, #plasma Cc: #plasma, plasma-devel, #dolphin, pekkah, #konqueror, navarromorales, ZrenBot, firef, andrebarros, progwolff, emmanuelp, lesliezhai,

D7531: Update SurfaceInterface outputs when an output global gets destroyed

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH mart/xdgforeign REVISION DETAIL https://phabricator.kde.org/D7531 To: davidedmundson, #plasma, graesslin Cc: graesslin, anthonyfieroni, plasma-devel, #frameworks, leezu,

D7539: Dolphin - Add autoplay feature for media files

pekkah edited the summary of this revision. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D7539 To: pekkah, #dolphin, #plasma Cc: #plasma, plasma-devel, #dolphin, pekkah, #konqueror, navarromorales, ZrenBot, firef, andrebarros, progwolff, emmanuelp, lesliezhai,

D7539: Dolphin - Add autoplay feature for media files

pekkah edited the summary of this revision. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D7539 To: pekkah, #dolphin, #plasma Cc: #plasma, plasma-devel, #dolphin, pekkah, #konqueror, navarromorales, ZrenBot, firef, andrebarros, progwolff, emmanuelp, lesliezhai,

D7539: Dolphin - Add autoplay feature for media files

pekkah created this revision. pekkah added projects: Plasma, Dolphin. Restricted Application added subscribers: Konqueror, plasma-devel. REVISION SUMMARY **SUMMARY** This code patch attempts to implement a missing autoplay feature to Dolphin file browser for media files (videos and audio

D7521: [WIP] make use of foreign protocol

mart added inline comments. INLINE COMMENTS > graesslin wrote in shell_client.cpp:1319 > I would delegate this to waylandServer, so that there is no need to pass the > foreign global to each ShellClient. how could it be done as addtransient/transientfor/settransient are all protected?

D6443: [CurrentContainmentActionsModel] Add configurationChanged signal

broulik added a comment. Ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6443 To: broulik, #plasma Cc: davidedmundson, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D7538: [MPris Engine] Don't construct QDBusObjectPath in Metadata update

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Creating one from an empty string prints a warning and here we don't actually need a fully-fledged QDBusObjectPath, we can just compare

D7537: KDE logout screen - change black icons & texts to white/greyish

pekkah retitled this revision from "KDE logout window - change black icons & texts to white/greyish" to "KDE logout screen - change black icons & texts to white/greyish". REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7537 To: pekkah, #plasma_workspaces,

D7537: KDE logout window - change black icons & texts to white/greyish

pekkah created this revision. pekkah added a project: Plasma: Workspaces. Restricted Application edited projects, added Plasma; removed Plasma: Workspaces. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The patch partially fixes an issue where all logout-related

D7369: [WIP] Wayland foreign protocol

mart updated this revision to Diff 18744. mart added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. - add a manual test for foreign - remove Unstable from public symbols REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D7536: Register klipper DBus interface when in non-standalone mode

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in klipper.cpp:100 > +1 The header file says > > Q_CLASSINFO("D-Bus Interface", "org.kde.klipper.klipper") right, but that's different to the service name. service.name /some/path interface.name method I'm matching the

D7536: Register klipper DBus interface when in non-standalone mode

broulik added inline comments. INLINE COMMENTS > klipper.cpp:100 > } > + > QDBusConnection::sessionBus().registerService(QStringLiteral("org.kde.klipper")); > +QDBusConnection::sessionBus().registerObject(QStringLiteral("/klipper"), > this, QDBusConnection::ExportScriptableSlots);

D7536: Register klipper DBus interface when in non-standalone mode

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY There's no reason to have different behaviour depending on whether the UI is presented in an applet or not. TEST PLAN Looked in

D7531: Update SurfaceInterface outputs when an output global gets destroyed

davidedmundson updated this revision to Diff 18741. davidedmundson added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. bleh REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7531?vs=18740=18741 BRANCH

D7531: Update SurfaceInterface outputs when an output global gets destroyed

davidedmundson updated this revision to Diff 18740. davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. Update connections better REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D7526: Only run the integration tests if the requirements are met

This revision was automatically updated to reflect the committed changes. Closed by commit R871:00b058db78b2: Only run the integration tests if the requirements are met (authored by heikobecker). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE

D7535: Don't special case file URLs when processing .desktop files

broulik added a comment. Cool. (as a future step I think the `m_isDirCache` look-up should all be done in `isDir()`. Currently it is used in `data()` but places like `lessThan()` use `isDir()` directly, bypassing the cache. And then some other places just read the `IsDir` role on the

D7535: Don't special case file URLs when processing .desktop files

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY At first glance this looks faster, as we skip KIO for a simple stat(), but as the result isn't cached we do file lookups on every

D1699: Limit BasicListItem width and elide text

davidedmundson closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D1699 To: davidedmundson, #plasma, mart Cc: plasma-devel

D6964: Force Plasma style for QQC2 in applets

This revision was automatically updated to reflect the committed changes. Closed by commit R242:ac2434087725: Force Plasma style for QQC2 in applets (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6964?vs=17706=18737

D6964: Force Plasma style for QQC2 in applets

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D6964 REVISION DETAIL https://phabricator.kde.org/D6964 To: mart, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks,

D7476: [Recent Documents Runner] Avoid duplicate results

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9583c7df0492: [Recent Documents Runner] Avoid duplicate results (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7476?vs=18580=18736

D7532: Guard failed testItem creation

This revision was automatically updated to reflect the committed changes. Closed by commit R242:a968892ba9d5: Guard failed testItem creation (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7532?vs=18726=18735

D6693: Install the PlasmaComponents.3/private folder

This revision was automatically updated to reflect the committed changes. Closed by commit R242:a25b628e25aa: Install the PlasmaComponents.3/private folder (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D6693: Install the PlasmaComponents.3/private folder

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6693 To: davidedmundson, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,

D7510: [Service] Use KConfig::SimpleConfig

This revision was automatically updated to reflect the committed changes. Closed by commit R242:5137a988b1f4: [Service] Use KConfig::SimpleConfig (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7510?vs=18673=18733#toc REPOSITORY R242 Plasma Framework (Library)

D7516: Drop remains of "locolor" themes

This revision was automatically updated to reflect the committed changes. Closed by commit R242:b4c1c9cdfa01: Drop remains of "locolor" themes (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7516?vs=18681=18732

D7476: [Recent Documents Runner] Avoid duplicate results

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7476 To: broulik, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D7510: [Service] Use KConfig::SimpleConfig

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7510 To: broulik, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D7524: Disable synced resizing for X11 clients on Xwayland

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH client-no-sync-xwayland REVISION DETAIL https://phabricator.kde.org/D7524 To: graesslin, #kwin, #plasma, mart Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7532: Guard failed testItem creation

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D7532 To: davidedmundson, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot,

D7526: Only run the integration tests if the requirements are met

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R871 DrKonqi BRANCH master REVISION DETAIL https://phabricator.kde.org/D7526 To: heikobecker, #plasma, sitter Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,