D5250: cursors: Make build scripts more generic; build more sizes

2017-09-07 Thread Nathaniel Graham
ngraham added a reviewer: subdiff. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D5250 To: jamesl, #plasma, subdiff Cc: kvermette, subdiff, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7716: Support filepaths with accents

2017-09-07 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > davidedmundson wrote in sddmauthhelper.cpp:228 > in my case I need to change the locale of my helper, not just subprocesses, > which means I need to set it before I extract args from the user. Maybe it could still be done by

D7260: System tray icon's context menu isn't updated properly in plasma/x11

2017-09-07 Thread Christoph Feck
cfeck added a comment. David, can you test again? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7260 To: i.Dark_Templar, #plasma, davidedmundson Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D7648: Fix ksysguard not starting on plasmoid click

2017-09-07 Thread Mladen Milinkovic
maxrd2 added a comment. In https://phabricator.kde.org/D7648#142638, @davidedmundson wrote: > Thanks, but do you know why the apps datasource doesn't have that entry after a while? I've managed to get some more insight into original problem. It seems that after some system

D7726: Fix ignoring of certain popup windows by the windowmapper

2017-09-07 Thread Fabian Vogt
fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY At least on vivaldi 1.11, plasma-browser-extension broke popups as the windowmapper page replaced the entire content and the popup closed itself shortly thereafter. Those popups have type ===

D6591: XdgV6 - Kwin side

2017-09-07 Thread Martin Flöser
graesslin requested changes to this revision. graesslin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > shell_client.cpp:222 > + > +connect(static_cast *>(m_xdgShellSurface->global()), ::pingDelayed, > +m_xdgShellSurface, [this](qint32

[Breeze] [Bug 363147] Breeze cursors should have more sizes (patch included)

2017-09-07 Thread Roman Gilg
https://bugs.kde.org/show_bug.cgi?id=363147 --- Comment #18 from Roman Gilg --- Hi Brennan, from my side the patch worked. It felt though like there were some performance issues when using the many sizes (since it loops through them), but that might be also in my imagination.

D3805: Per-activity favorites (Final, again?)

2017-09-07 Thread Ivan Čukić
ivan updated this revision to Diff 19283. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3805?vs=19263=19283 REVISION DETAIL https://phabricator.kde.org/D3805 AFFECTED FILES CMakeLists.txt applets/kicker/CMakeLists.txt applets/kicker/package/contents/code/tools.js

D7669: Make AbstractEglBackend a QObject

2017-09-07 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:01ddbe7d751a: Make AbstractEglBackend a QObject (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7669?vs=19117=19282 REVISION DETAIL

D7698: Pass EGL information from AbstractEglBackend to Platform instead of query

2017-09-07 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:9381411b9112: Pass EGL information from AbstractEglBackend to Platform instead of query (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D7713: [tabbox] Properly check whether two windows belong to same application

2017-09-07 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:5d9027b110be: [tabbox] Properly check whether two windows belong to same application (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D7712: Delay syncing internal window geometry to end of cycle

2017-09-07 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:e0f95fd913b6: Delay syncing internal window geometry to end of cycle (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7712?vs=19249=19279#toc REPOSITORY R108 KWin

Re: Videoconference between KDE community and Purism regarding Librem5

2017-09-07 Thread Matthias Klumpp
Just to make sure this message gets through to all the mailinglists (I dropped some of the CCs, because the list was rejecting this, and I also don't know if Zlatan is subscribed to plasma-devel & co.), since some people didn't get the next yet apparently This is our meeting place:

D6764: Add font size setting to the digital clock plasmoid

2017-09-07 Thread David Edmundson
davidedmundson added a comment. > i don't think i like the idea of adding yet another setting on this already rather fragile code I think this explains why you haven't had a review, this existing code is already sketchy as-is :/ But we should be trying to fix that not just all of us

D7723: [ListItemBase] Use section instead of disabled menu item

2017-09-07 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R115:31fed95b4de6: [ListItemBase] Use section instead of disabled menu item (authored by broulik). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D6764: Add font size setting to the digital clock plasmoid

2017-09-07 Thread Diego Gangl
januz added a comment. //PING// Hey guys, the beta is starting next week. Any chance we can still land this or https://phabricator.kde.org/D6813 for 5.11? REVISION DETAIL https://phabricator.kde.org/D6764 To: januz, #plasma, #vdg Cc: ngraham, Zren, mart, plasma-devel, ZrenBot,

D3805: Per-activity favorites (Final, again?)

2017-09-07 Thread Eike Hein
hein added a comment. Test failure using Kicker: 1. Right-click menu entry -> Show favorite in -> All activities 2. Verify it's shown on both activities 3. Be in activity 1, right-click the favorite, click the checkbox item for activity 2, favorite disappears from activity 1 as

D7724: [ListItemBase] Open options menu on right click

2017-09-07 Thread Kai Uwe Broulik
broulik added a comment. We have *both* now. The visual menu button and the "non-discoverable" context menu accessible through right-clicking the entire area REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D7724 To: broulik, #plasma, #vdg, drosca

D7724: [ListItemBase] Open options menu on right click

2017-09-07 Thread David Rosca
drosca added a comment. We're back to the context menu discussion. But to me, this feels weird, the context menu should be opened under cursor. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D7724 To: broulik, #plasma, #vdg, drosca Cc:

D7724: [ListItemBase] Open options menu on right click

2017-09-07 Thread Kai Uwe Broulik
broulik updated this revision to Diff 19275. broulik added a comment. - Also highlight menu button while context menu is open REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7724?vs=19274=19275 REVISION DETAIL

D7724: [ListItemBase] Open options menu on right click

2017-09-07 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN The menu is still attached to the menu button regardless of where I click but I don't neccessarily need to aim for that tiny button anymore.

D7716: Support filepaths with accents

2017-09-07 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > apol wrote in sddmauthhelper.cpp:228 > I just realized we have something similar in samba-mounter for the exact same > reason: > https://cgit.kde.org/samba-mounter.git/tree/src/helper/sambahelper.cpp#n49 > > In this case we're forwarding

D7723: [ListItemBase] Use section instead of disabled menu item

2017-09-07 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D7723 To: broulik, #plasma, drosca, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7723: [ListItemBase] Use section instead of disabled menu item

2017-09-07 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It's meant to be a section so be one TEST PLAN F3901868: Screenshot_20170907_165556.png REPOSITORY

D7716: Support filepaths with accents

2017-09-07 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > sddmauthhelper.cpp:228 > +int main(int argc, char **argv) { > +qputenv("LANG", "C.UTF-8"); > +return KAuth::HelperSupport::helperMain(argc, argv, > "org.kde.kcontrol.kcmsddm", new SddmAuthHelper()); I just realized we have something similar

D7722: Disable DDCUtil by default

2017-09-07 Thread Jonathan Riddell
This revision was automatically updated to reflect the committed changes. Closed by commit R122:687587ea7cbc: Disable DDCUtil by default (authored by jriddell). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7722?vs=19271=19272 REVISION DETAIL

Re: Plasma 5.11 repos

2017-09-07 Thread Ivan Čukić
> Is plasma-vault ready for inclusion? Yes please Cheers, Ivan

Re: ddcutil .deb

2017-09-07 Thread Jonathan Riddell
I've disabled it by default for the Plasma 5.11 release Any contributions or suggestions for how to make it stable and releaseable very welcome. 5.12 is due at the end of January and is to be an LTS so it would be great to have it working for then. Jonathan On Tue, Sep 05, 2017 at

D7722: Disable DDCUtil by default

2017-09-07 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R122 Powerdevil BRANCH master REVISION DETAIL https://phabricator.kde.org/D7722 To: jriddell, #plasma, dvogel, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7722: Disable DDCUtil by default

2017-09-07 Thread Jonathan Riddell
jriddell added reviewers: Plasma, dvogel. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D7722 To: jriddell, #plasma, dvogel Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7722: Disable DDCUtil by default

2017-09-07 Thread Jonathan Riddell
jriddell created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Disable DDCUtil by default TEST PLAN built it, checked powerdevilupowerbackend.so depends REPOSITORY R122 Powerdevil BRANCH master

[Powerdevil] [Bug 381387] display brightness is increased when come back from closed lid

2017-09-07 Thread Sebastian Kügler
https://bugs.kde.org/show_bug.cgi?id=381387 Sebastian Kügler changed: What|Removed |Added Assignee|plasma-devel@kde.org|plasma-b...@kde.org -- You

D6591: XdgV6 - Kwin side

2017-09-07 Thread David Edmundson
davidedmundson added a comment. Ping. Even if I now can't merge till 5.11 splits, it'd be nice to have this approved. There's still a lot of work to be done on top of this, which is currently blocked. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6591 To:

D7669: Make AbstractEglBackend a QObject

2017-09-07 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH abstract-egl-backend-qobject REVISION DETAIL https://phabricator.kde.org/D7669 To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, bwowk, ZrenBot,

D7698: Pass EGL information from AbstractEglBackend to Platform instead of query

2017-09-07 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH egl-backend-to-platform REVISION DETAIL https://phabricator.kde.org/D7698 To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, ZrenBot, progwolff,

D3805: Per-activity favorites (Final, again?)

2017-09-07 Thread Ivan Čukić
ivan added a comment. p.s. This is how I restart everything: kquitapp5 plasmashell; kactivitymanagerd stop; touch ~/.config/kactivitymanagerd-statsrc; make install -j8 && (echo "DELETE FROM ResourceLink;" | sqlite3 ~/.local/share/kactivitymanagerd/resources/database) && rm

D3805: Per-activity favorites (Final, again?)

2017-09-07 Thread Ivan Čukić
ivan updated this revision to Diff 19263. ivan added a comment. Another one to test: - fixed a small bug related to fav adding - added debugging output for easier testing (when you encounter a bug, send me an email with plasma output) CHANGES SINCE LAST UPDATE