D7831: Use a different key for font DPI on X and Wayland

2017-09-15 Thread Eike Hein
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH randa/accessibility REVISION DETAIL https://phabricator.kde.org/D7831 To: davidedmundson, #plasma, hein Cc: hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7830: Use a separate config value for Wayland font DPI

2017-09-15 Thread Eike Hein
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH randa/accessibility REVISION DETAIL https://phabricator.kde.org/D7830 To: davidedmundson, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jens

D7831: Use a different key for font DPI on X and Wayland

2017-09-15 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R119:fbbdfa100128: Use a different key for font DPI on X and Wayland (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7831?vs=19546&id

D7830: Use a separate config value for Wayland font DPI

2017-09-15 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R120:abf54a0a8c44: Use a separate config value for Wayland font DPI (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7830?vs=19545&id=19551#toc REPOSITORY R120 Plasma

D7834: Sync XRDB DPI to the platform specific setting

2017-09-15 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Even though this sets up the X rdb, we want to use the value the user has set to use when under wayland - as X apps will be scaled by

D7835: Don't show scrollbar steppers

2017-09-15 Thread Elvis Angelaccio
elvisangelaccio created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY They were re-added in commit https://phabricator.kde.org/R98:01a86601804222929441c0c1c8bb0db6d4ee2769 without explaining why (we don'

D7835: Don't show scrollbar steppers

2017-09-15 Thread Elvis Angelaccio
elvisangelaccio added a comment. Before: F3911870: Before.png After: F3911872: After.png REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D7835 To: elvisangelaccio, #plas

D7836: Fix background-image warning

2017-09-15 Thread Elvis Angelaccio
elvisangelaccio created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This fixes the following warning: Gtk-WARNING **: Theme parsing error: gtk.css:3139:22: Not a valid image It was changed by

D7834: Sync XRDB DPI to the platform specific setting

2017-09-15 Thread Martin Flöser
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D7834 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreute

D7834: Sync XRDB DPI to the platform specific setting

2017-09-15 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R119:b47a841f6f9b: Sync XRDB DPI to the platform specific setting (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7834?vs=19554&id=19

D7842: Split out the X11 mouse event filtering for EffectsHandlerImpl

2017-09-15 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY This change introduces a dedicated X11EventFilter for the mouse interception on X11. The filter gets created together with the start o

D7842: Split out the X11 mouse event filtering for EffectsHandlerImpl

2017-09-15 Thread David Edmundson
davidedmundson added a comment. Code does what it says but one comment 1. I would move the m_mouseInterceptionWindow code with it, that way we have RAII on that window, and less X specific things in the EffectsHandler. Logically it's grouped 2. do we even need that fake window given w

D7842: Split out the X11 mouse event filtering for EffectsHandlerImpl

2017-09-15 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D7842#146171, @davidedmundson wrote: > Code does what it says but one comment > > 1. I would move the m_mouseInterceptionWindow code with it, that way we have RAII on that window, and less X specific things in the EffectsHandl

D7843: Move XFixes cursor change tracking into the x11 standalone platform

2017-09-15 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY A dedicated X11EventFilter is added and created from the X11Cursor in case we have XFixes. This means some more X11 specific code is now

New widgets to plasma

2017-09-15 Thread Martin Kostolný
Hi, I'd like to add some of my widgets to official widget bundle in plasma. Namely: - redshift-control (https://github.com/kotelnik/plasma-applet-redshift-control) - active-window-control (https://github.com/kotelnik/plasma-applet-active-window-control) (maybe other if it makes sense) I realize

Re: New widgets to plasma

2017-09-15 Thread David Edmundson
Cool widgets, I've heard some users using them - Thanks for helping build the Plasma base. >There were some requests from users of various distributions to add these widgets as official projects. This would allow them to reach more distros -> users. I think that's a problem in itself. The whole b

D7842: Split out the X11 mouse event filtering for EffectsHandlerImpl

2017-09-15 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. ok. Also note that I made a comment about the (untouched) wayland code. REPOSITORY R108 KWin BRANCH effects-mouse-x11-filter REVISION DETAIL https://phabricator.

D7842: Split out the X11 mouse event filtering for EffectsHandlerImpl

2017-09-15 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D7842#146206, @davidedmundson wrote: > ok. > > Also note that I made a comment about the (untouched) wayland code. thanks for the hint, I hadn't noticed it before. Yeah, looks wrong, I guess it evolved or something like

Re: New widgets to plasma

2017-09-15 Thread Martin Kostolný
Thanks, David, for quick answer. I agree basically with everything you said. My aim is to keep up with Plasma versioning and it would be really helpful for me not to support multiple versions of Plasma with latest version of widget. That is why I find perfect to join kdeplasma-addons. Actually

D7842: Split out the X11 mouse event filtering for EffectsHandlerImpl

2017-09-15 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:0c6fdeef2db4: Split out the X11 mouse event filtering for EffectsHandlerImpl (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7842?vs=19571&id=1

D7845: Fix position where removeEffectsOverrideCursor is called

2017-09-15 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Should be when there is no more an effect which overrides the cursor, not unconditionally. REP