pgkos added a comment.
@anthonyfieroni my first version of the diff changed only the tray icon QML
file, but I think that it is better to fix it in the plasma framework, as that
function is used in multiple other places and there is the same problem with
wrongly sized icons on hidpi
anthonyfieroni added a comment.
So, Kai is right, it roundToIconSize only round size independent from dpi.
Then when it used, it should be multiplyed by dpi.
REVISION DETAIL
https://phabricator.kde.org/D7849
To: pgkos, #plasma
Cc: anthonyfieroni, broulik, #frameworks, davidedmundson,
pgkos added a comment.
@broulik consider this case:
The tray icons' size is defined by default in
`org.kde.plasma.private.systemtray/contents/config/main.xml` to `smallMedium`,
which means 22 pixels on a 96-dpi screen. On a 192-dpi screen, the icons' real
size is 44 pixels.
Now, in
broulik added a comment.
I don't understand this. RoundToIconSize is supposed to round down and that's
it. If I pass it 100 px because I'm on a high dpi screen, it will still return
100. Only if I pass it e.g. 34 it will change it to 32.
REVISION DETAIL
https://phabricator.kde.org/D7849
pgkos updated this revision to Diff 19612.
pgkos added a comment.
Fixed the previous diff.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7849?vs=19592=19612
REVISION DETAIL
https://phabricator.kde.org/D7849
AFFECTED FILES
src/declarativeimports/core/units.cpp
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
effects-remove-override-cursor-position
REVISION DETAIL
https://phabricator.kde.org/D7845
To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, bwowk,
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
The implementation of grabXKeyboard checks whether the passed in arg
is XCB_WINDOW_NONE and
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
The xStackingOrder unlike indicated by it's name is relevant for both
X11 and Wayland and
