D7871: Properly update the visible (icon) name when the caption changes

broulik added inline comments. INLINE COMMENTS > client.cpp:1449 > if (!s[i].isPrint()) > s[i] = QChar(u' '); > +const bool changed = (s != cap_normal); (Oh! I just spotted why that guy on reddit back a while had KWin add loads of spaces to the title of its windows

D7870: Don't crash if a client (legally) uses a deleted global

graesslin added inline comments. INLINE COMMENTS > anthonyfieroni wrote in blur_interface.cpp:49 > I don't get that. So your patch is quite enough, treat this note as a noise :) The cast method here is only called from callbacks. Wayland works by having a global callback table where one just

D7870: Don't crash if a client (legally) uses a deleted global

anthonyfieroni added inline comments. INLINE COMMENTS > davidedmundson wrote in blur_interface.cpp:49 > I'm not going to get a callback on a resource if the resource doesn't exist. > (Libwayland would have already crashed if that happens) > > That's not what we're guarding against here. I

D7870: Don't crash if a client (legally) uses a deleted global

graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. What surprises me is that BlurManager recreates for Output changes. That sounds like a bug in KWin (or an area which could be improved). REPOSITORY R127 KWayland BRANCH

D7870: Don't crash if a client (legally) uses a deleted global

davidedmundson marked 2 inline comments as done. davidedmundson added inline comments. INLINE COMMENTS > anthonyfieroni wrote in blur_interface.cpp:49 > QPointer itself can determine that resource is deleted but QPointer* acts > like every normal pointer e.g. it can be dangling. So if unbind is

D7870: Don't crash if a client (legally) uses a deleted global

anthonyfieroni added inline comments. INLINE COMMENTS > blur_interface.cpp:49 > static Private *cast(wl_resource *r) { > -return reinterpret_cast(wl_resource_get_user_data(r)); > +auto blurManager = >

D7871: Properly update the visible (icon) name when the caption changes

graesslin created this revision. graesslin added reviewers: KWin, Plasma, hein. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY It was possible that we performed an early exit when the caption changes and this

D7870: Don't crash if a client (legally) uses a deleted global

davidedmundson updated this revision to Diff 19645. davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. Mem leak in test REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7870?vs=19644=19645

D7870: Don't crash if a client (legally) uses a deleted global

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY There is a race condition in the following situation: -

D7868: Don't scale cursor hotspot differently to cursor

This revision was automatically updated to reflect the committed changes. Closed by commit R108:4238218b7629: Dont scale cursor hotspot differently to cursor (authored by davidedmundson). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7868?vs=19635=19643

D7868: Don't scale cursor hotspot differently to cursor

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7868 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening,

D7836: Fix background-image warning

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R98 Breeze for Gtk BRANCH Plasma/5.11 REVISION DETAIL https://phabricator.kde.org/D7836 To: elvisangelaccio, davidedmundson, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7794: create the whole plugin structure in the build directory

This revision was automatically updated to reflect the committed changes. Closed by commit R169:c90968f1f8dc: create the whole plugin structure in the build directory (authored by mart). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7794?vs=19638=19639

D7794: create the whole plugin structure in the build directory

apol accepted this revision. REPOSITORY R169 Kirigami BRANCH arcpatch-D7794 REVISION DETAIL https://phabricator.kde.org/D7794 To: mart, #kirigami, dfaure, sitter, apol Cc: apol, plasma-devel, mart, hein

D7794: create the whole plugin structure in the build directory

mart updated this revision to Diff 19638. mart added a comment. - lowercase REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7794?vs=19637=19638 BRANCH arcpatch-D7794 REVISION DETAIL https://phabricator.kde.org/D7794 AFFECTED FILES

D7794: create the whole plugin structure in the build directory

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY R169 Kirigami BRANCH arcpatch-D7794 REVISION DETAIL https://phabricator.kde.org/D7794 To: mart, #kirigami, dfaure, sitter, apol Cc: apol, plasma-devel,

D7794: create the whole plugin structure in the build directory

mart updated this revision to Diff 19637. mart added a comment. - remove dead code REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7794?vs=19636=19637 BRANCH arcpatch-D7794 REVISION DETAIL https://phabricator.kde.org/D7794 AFFECTED FILES

D7794: create the whole plugin structure in the build directory

mart updated this revision to Diff 19636. mart added a comment. - get rid of GLOB REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7794?vs=19473=19636 BRANCH arcpatch-D7794 REVISION DETAIL https://phabricator.kde.org/D7794 AFFECTED FILES

Minutes Monday Plasma Hangout

Meeting minutes and log from today's weekly: accessiblity, wayland, design, it has all the goodies. -- sebas http://www.kde.org | http://vizZzion.orgPlasma Meeting 18 Sept 2017 Present: notmart, Sho, d_ed, sebas, jensreut, fvogt notmart: * At randa meeting, was mostly about accessibility **

D7868: Don't scale cursor hotspot differently to cursor

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. REVISION SUMMARY In the DRM plugin the cursor is currently is drawn at the native size given.

D7794: create the whole plugin structure in the build directory

mart added inline comments. INLINE COMMENTS > apol wrote in CMakeLists.txt:33 > Why do you need to GLOB? can't you just copy the whole directory over with > all of the styles/controls inside? if instead of the GLOB i put in the copy command directly the directory name, it seems to not

D7794: create the whole plugin structure in the build directory

mart added a comment. In https://phabricator.kde.org/D7794#145371, @apol wrote: > Also you maybe can move this code into the tests subdirectory, so it only needs to be run in `BUILD_TESTING`. > > I am not sure if this is going to work but I agree that if it has any opportunity then

D7819: Add extra visual indicator for Checkbox/Radio keyboard focus

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D7819 To: davidedmundson, #plasma, #vdg, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,