D7795: plasma-nm: vpn: openconnect: pkcs11: add support for separate pin value

2017-09-19 Thread Thorsten Bonhagen
thorstenb added a comment. In have no idea about a sync from NM-openconnect plugin. Most code of NM-openconnect plugin is no longer in use. I my opinion it was for forking a openconnect command line process. Looks like most parts of NM-openconnect plugin are obsolete because of libopenconnec

D7795: plasma-nm: vpn: openconnect: pkcs11: add support for separate pin value

2017-09-19 Thread Jan Grulich
jgrulich added a comment. One thing which is not clear to me is where did you get NM_OPENCONNECT_KEY_PIN? All the NM_OPENCONNECT_KEY_* values are synced from NM-openconnect plugin and I don't see anything like that in that NM plugin. We also don't set anything like that in the editor, which

D7757: Use real-time scheduling policy for kwin_wayland

2017-09-19 Thread Christoph Feck
cfeck added a comment. I was about to suggest that it should queue lower than "real" realtime processes, but reading the description, this was actually taken care of using the lowest priority. +1 to this feature. I think Windows also favors GUI processes over background processes, so ha

D7757: Use real-time scheduling policy for kwin_wayland

2017-09-19 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D7757#146952, @tcberner wrote: > Looks good to me. Sorry for the timeout :) The ping was more meant to other (Linux) developers on whether there is agreement that we should try making KWin a real time process ;-) REPOSITOR

D7757: Use real-time scheduling policy for kwin_wayland

2017-09-19 Thread Tobias C . Berner
tcberner accepted this revision. tcberner added a comment. This revision is now accepted and ready to land. Looks good to me. Sorry for the timeout :) REPOSITORY R108 KWin BRANCH wayland-realtime REVISION DETAIL https://phabricator.kde.org/D7757 To: graesslin, #kwin, #plasma, tcberner

D7356: Support mapping QKeyEvent to xkb_keysym_t

2017-09-19 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:a17c85a9eab5: Support mapping QKeyEvent to xkb_keysym_t (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7356?vs=18254&id=19675 REVISION DETAIL

D7757: Use real-time scheduling policy for kwin_wayland

2017-09-19 Thread Martin Flöser
graesslin added a comment. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7757 To: graesslin, #kwin, #plasma Cc: tcberner, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7740: Move SceneOpenGL into a dedicated plugin

2017-09-19 Thread Martin Flöser
graesslin added a comment. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7740 To: graesslin, #kwin, #plasma Cc: bshah, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D7877: Don't recreate kwayland blurmanager on screen size changes

2017-09-19 Thread Martin Flöser
graesslin accepted this revision. graesslin added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > blur.cpp:94 > + > +void BlurEffect::updateTexture() { > +delete target; nitpick: position of { REPOSITORY R108 KWin REVISION DETAIL https://phabricator.

D7870: Don't crash if a client (legally) uses a deleted global

2017-09-19 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. davidedmundson marked an inline comment as done. Closed by commit R127:eaac3948f149: Don't crash if a client (legally) uses a deleted global (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDAT

D7877: Don't recreate kwayland blurmanager on screen size changes

2017-09-19 Thread David Edmundson
davidedmundson edited the summary of this revision. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7877 To: davidedmundson, #plasma Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D7877: Don't recreate kwayland blurmanager on screen size changes

2017-09-19 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. REVISION SUMMARY Instead of calling reconfigure() on screen size changes, which deletes and recreates

D7817: Remaining accessibility on Plasma PA

2017-09-19 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R115:f5a5fd9f5b37: Remaining accessibility on Plasma PA (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7817?vs=19523&id=19668#toc REPOSITORY R115 Plasma Audio Volume

D7816: Put tabbar in focus chain

2017-09-19 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R115:6250f7e85e9a: Put tabbar in focus chain (authored by davidedmundson). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7816?vs=19522&id=19667 REVI

D7819: Add extra visual indicator for Checkbox/Radio keyboard focus

2017-09-19 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R242:ee2b12be0456: Add extra visual indicator for Checkbox/Radio keyboard focus (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kd