ngraham created this revision.
ngraham added reviewers: Discover Software Store, apol.
ngraham added a project: Discover Software Store.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
BUG: 384913
Pad the Back button'
ngraham retitled this revision from "Remove launch feature from hamburger
button" to "Remove launch feature from hamburger button and restore to the
toolbar".
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D7905
To: ngraham, apol, #discover_software_sto
ngraham created this revision.
ngraham added reviewers: apol, Discover Software Store.
ngraham added a project: Discover Software Store.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
BUG: 384914
Make the Launch feat
ngraham created this revision.
ngraham added reviewers: apol, Discover Software Store.
ngraham added a project: Discover Software Store.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
BUG: 384912
Change back button '
apol added a comment.
Thanks! this bothered me in the past :)
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D7890
To: valeriymalov, #plasma, davidedmundson
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, mart
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:76b276056e0c: Unhide autohidden panel when using global
menu (authored by davidedmundson).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7883?vs=19684&id=
davidedmundson added a comment.
> Hmm, should we perhaps have the applet be Active if a menu is available and
Passive if there is none?
We could. Not sure it acheives much.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7883
To: david
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c25de336d548: Error out if the device returns a negative
number of buttons (authored by aacid).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7900?vs=19714&
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7900
To: aacid, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
aacid created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
btnx[1] is reporting a negative number of buttons in my machine (-87) so
ignore it instead of crashing (once we have negative buttons things qu
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
I don't understand the original logic.
s_allResources contai
broulik added inline comments.
INLINE COMMENTS
> workspace.cpp:381
> +
> +xcb_change_property(connection(), XCB_PROP_MODE_APPEND, rootWindow(),
> atoms->kwin_running,
> +atoms->kwin_running, 32, 1, &data);
`kwinApp()->x11Connection()`?
> workspace.cpp:397
> +
> +
graesslin added a dependent revision: D7897: Move X11 specific Workspace
initialization code into dedicated method.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D7856
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
This is required to start KWin/Wayland without XWayland support or
delayed XWayland support.
T
graesslin added a dependency: D7856: Make xstacking order dirty handling work
without X11.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D7897
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed,
hardening, jensreuterb
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.
Thanks for looking into this. Plasma/5.11 branch pls
INLINE COMMENTS
> appmenuapplet.cpp:216
> +//any transient window is showing
> +setStatus(Plasma::Types::PassiveStatus
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
composite-no-flush
REVISION DETAIL
https://phabricator.kde.org/D7892
To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliez
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
Otherwise it crashes for the first window being created in a
KWin/Wayland without XWayland supp
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
Otherwise KWin crashes when operating without XWayland support.
REPOSITORY
R108 KWin
BRANCH
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:f3b45a33ece2: add size hint to KScreen KCM (authored by
valeriymalov, committed by davidedmundson).
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7890?vs=19697&id=
valeriymalov added a comment.
Not really
REPOSITORY
R104 KScreen
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7890
To: valeriymalov, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
davidedmundson added a comment.
Do you have commit access?
REPOSITORY
R104 KScreen
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7890
To: valeriymalov, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, a
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:1783fda30eee: Make sure OpenGL Context is valid before
deleting shader (authored by davidedmundson).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7888?vs=19698&id=19
graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.
Feel free to push either of the two revisions.
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7888
To: davidedmundson, #plasma, graesslin
Cc:
davidedmundson updated this revision to Diff 19698.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
No done()
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7888?vs=19693&id=19698
BRANCH
master
REVISION D
davidedmundson added inline comments.
INLINE COMMENTS
> graesslin wrote in scene_opengl.cpp:1191-1194
> best would be if we knew that the context is current. But that's
> unfortunately wishful thinking.
>
> My suggestion would be to do your option 1:
>
> > makeOpenGLContextCurrent() but then d
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R104 KScreen
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7890
To: valeriymalov, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreut
graesslin added inline comments.
INLINE COMMENTS
> davidedmundson wrote in scene_opengl.cpp:1191-1194
> changed is called from a timer, so we can be pretty confident that we're
> called mid-doing anything else, but I'm happy to do something else?
>
> to be clear are you suggesting we:
>
> - ma
valeriymalov created this revision.
valeriymalov added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This should help kcmshell opening this kcm
at a reasonable size without forcing it
REPOSITORY
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:403f60929f11: Don't crash if a client (legally) uses
deleted global contrast manager (authored by davidedmundson).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7
davidedmundson added inline comments.
INLINE COMMENTS
> graesslin wrote in scene_opengl.cpp:1191-1194
> This combination also looks dangerous. If the context was already current it
> might disable it for another user inside KWin.
changed is called from a timer, so we can be pretty confident tha
sebas abandoned this revision.
sebas added a comment.
Ow, see, I was exporting a different XDG_RUNTIME_DIR in my login procedure. I
guess removing that fixes the problem as well. :)
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D7882
To: sebas, #plasma
Cc:
graesslin added a comment.
In https://phabricator.kde.org/D7882#147153, @sebas wrote:
> That's happening when I start startplasmacompositor by hand, and it's
annoying as fuck.
AFAIR you are a Debian user, so am I and I don't need to do that. I also
start it from console. Seriousl
graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> scene_opengl.cpp:1191-1194
> +makeOpenGLContextCurrent();
> +delete m_lanczosFilter;
> +m_lanczosFilter =
sebas added a comment.
That's happening when I start startplasmacompositor by hand, and it's
annoying as fuck. Sure, I can add that to my login script, but it's literally
the only thing that I have to do to make plasma/wayland come up. Everything
else works. (Also, we do create XDG_CONFIG_HO
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7885
To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff,
lesliezh
graesslin added a comment.
-1 from my side. This is a clear bug in whatever is used in the login
process. If XDG_RUNTIME_DIR is not created we might have a thousand more things
which don't work as expected. I rather have KWin bail out early on that one
than have to hunt down all the things w
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.
REVISION SUMMARY
Deleting the lanczos filter deletes it's GLShader, this calls
glDeleteProgram
g
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
There is a race condition in the following situation:
- S
sebas added a reviewer: Plasma.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D7882
To: sebas, #plasma
Cc: palimaka, plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This sets a transient parent on the shown menus, meaning a panel knows
to stay open whilst it
davidedmundson abandoned this revision.
REPOSITORY
R110 KScreen Library
REVISION DETAIL
https://phabricator.kde.org/D6027
To: davidedmundson, #plasma, sebas
Cc: sebas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, apol, mart
sebas resigned from this revision.
sebas added a comment.
Please abandon, I've already fixed this in master.
REPOSITORY
R110 KScreen Library
REVISION DETAIL
https://phabricator.kde.org/D6027
To: davidedmundson, #plasma, sebas
Cc: sebas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-m
sebas created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
kwin_wayland wants to put the wayland socket file into XDG_RUNTIME_DIR,
but it doesn't make sure this directory exists. It expects the login
44 matches
Mail list logo
