D7943: Explicitely unset QtQuickControls desktop style for non-QApplications

arojas added a comment. In https://phabricator.kde.org/D7943#148121, @davidedmundson wrote: > Revert what? The move of the style setting from startkde to plasma-integration REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D

D7943: Explicitely unset QtQuickControls desktop style for non-QApplications

davidedmundson added a comment. Revert what? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D7943 To: arojas, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D7943: Explicitely unset QtQuickControls desktop style for non-QApplications

arojas added a comment. This change would also fix the crashes if the style was set in startkde as it used to, does it make sense to revert the change or you prefer to leave it where it is? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde

D7943: Explicitely unset QtQuickControls desktop style for non-QApplications

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. I see, shame we're not still using kinit. Patch makes sense. Thanks REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kd

D7943: Explicitely unset QtQuickControls desktop style for non-QApplications

arojas added a comment. In https://phabricator.kde.org/D7943#148093, @davidedmundson wrote: > I don't see why we should be unsetting anything if a user has explicitly gone out of their way to set it. > > We're not doing it from startkde anymore. It's not the user who sets it,

D7943: Explicitely unset QtQuickControls desktop style for non-QApplications

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. I don't see why we should be unsetting anything if a user has explicitly gone out of their way to set it. We're not doing it from startkde anymore. REPOSITORY

D7943: Explicitely unset QtQuickControls desktop style for non-QApplications

arojas created this revision. arojas added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY QGuiApplications will crash if the QtQuickControls style (either 1 or 2) is set to desktop, so

D7843: Move XFixes cursor change tracking into the x11 standalone platform

graesslin edited the test plan for this revision. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7843 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7942: Create a dedicated X11Filter for Client sync events and move it to X11 platform

graesslin added a dependency: D7843: Move XFixes cursor change tracking into the x11 standalone platform. REVISION DETAIL https://phabricator.kde.org/D7942 To: graesslin, #kwin, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7843: Move XFixes cursor change tracking into the x11 standalone platform

graesslin added a dependent revision: D7942: Create a dedicated X11Filter for Client sync events and move it to X11 platform. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7843 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-moha

D7942: Create a dedicated X11Filter for Client sync events and move it to X11 platform

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY On Wayland we have the sync disabled as it doesn't work properly. This allows us to also move the

D7843: Move XFixes cursor change tracking into the x11 standalone platform

graesslin updated this revision to Diff 19802. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Fix crash on startup - cursor is created before Workspace, so the filter creation needs to be delayed REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D7941: use Kirigami Theme for colors

mart added reviewers: Plasma, Kirigami, hein. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D7941 To: mart, #plasma, #kirigami, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7941: use Kirigami Theme for colors

mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY it makes possible to use kirigami's color sets REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH mart/kirigamiintegration REVISION

D7939: ColorSet concept in Theme

mart added a reviewer: hein. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D7939 To: mart, #kirigami, hein Cc: plasma-devel, apol, mart, hein

D7940: plugin loaded by kirigami to use KColorScheme and KIconLoader

mart added reviewers: Plasma, Kirigami, hein. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D7940 To: mart, #plasma, #kirigami, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ma

D7940: plugin loaded by kirigami to use KColorScheme and KIconLoader

mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY plugin to load icons and colors from high tier frameworks as KWidgetAddons and KiconThemes TEST PLAN loaded correctly: it will probably have

D7938: Drop useless XCB_DESTROY_NOTIFY from big event switch statement

This revision was automatically updated to reflect the committed changes. Closed by commit R108:8aa7bb28c876: Drop useless XCB_DESTROY_NOTIFY from big event switch statement (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7938?vs=19795&id=

D7939: ColorSet concept in Theme

mart added a comment. F3921580: Spectacle.F26086.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D7939 To: mart Cc: plasma-devel, apol, mart, hein

D7939: ColorSet concept in Theme

mart added a reviewer: Kirigami. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D7939 To: mart, #kirigami Cc: plasma-devel, apol, mart, hein

D7939: ColorSet concept in Theme

mart created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Theme is now an attached property rather than a singleton (in 2.2 import) a "colorSet" property can be defined on it and all its color propert

D7938: Drop useless XCB_DESTROY_NOTIFY from big event switch statement

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH xcb-drop-destroy REVISION DETAIL https://phabricator.kde.org/D7938 To: graesslin, #kwin, #plasma, broulik Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed

D7938: Drop useless XCB_DESTROY_NOTIFY from big event switch statement

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY It just returned false, but that's also the default handling. REPOSITORY R108 KWin BRANCH x

D7936: Don't set QQC Style in startkde

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6bbb0c794da8: Don't set QQC Style in startkde (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7936?vs=19784&id=19793 REVISION

D7936: Don't set QQC Style in startkde

This revision was automatically updated to reflect the committed changes. Closed by commit R120:72aa5a795e52: Merge branch 'Plasma/5.11' (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7936?vs=19784&id=19794#toc REPOSITORY R120 Plasma Workspace CHANGES SIN

D7935: Set QtQuickControls theme in QPT

This revision was automatically updated to reflect the committed changes. Closed by commit R135:1781d60b230c: Set QtQuickControls theme in QPT (authored by davidedmundson). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7935?v

D7937: Don't reload background contrast effect on screen resize

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D7937 To: davidedmundson, #plasma, graesslin Cc: graesslin, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, ali-moh

D7937: Don't reload background contrast effect on screen resize

davidedmundson updated this revision to Diff 19791. davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed KWin. for REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7937?vs=19788&id=19791 BRANCH master REVISION DETAIL

D7937: Don't reload background contrast effect on screen resize

graesslin added inline comments. INLINE COMMENTS > contrast.cpp:79 > +} > +foreach (EffectWindow *window, effects->stackingOrder()) > +updateContrastRegion(window); please no foreach in new code, please use range-based for. (Reason: I don't trust Qt to keep it after there was a

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

mart added a comment. could them even be merged in the same hidden kcm called "expert settings that you shouldn't use like, ever"? and maybe giving a nice colr palette of red on red :p REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7934 To: davidedmundson,

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

graesslin added a comment. Out from experience with the KWin Compositing kcm: hide it well, add more warnings and hide it even more. No matter how much you warn against the settings users will change them. Even if it tells them it's the wrong setting for their system and it's going to break

D7845: Fix position where removeEffectsOverrideCursor is called

This revision was automatically updated to reflect the committed changes. Closed by commit R108:27d06a1d4c1b: Fix position where removeEffectsOverrideCursor is called (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7845?vs=19580&id=19790

D7760: Move XRenderUtils init/cleanup into X11 standalone platform

This revision was automatically updated to reflect the committed changes. Closed by commit R108:551a6246a897: Move XRenderUtils init/cleanup into X11 standalone platform (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7760?vs=19361&id=1978

D7937: Don't reload background contrast effect on screen resize

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. REVISION SUMMARY Similar to the Blur patch. Arguably rven less reason as this doesn't have a texture

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

sebas added a comment. Thinking of it, wouldn't it make total sense to have this as a QtQuick-only KCM, i.e. using KQuickAddons::ConfigModule? INLINE COMMENTS > qtquicksettings.desktop:13 > +X-KDE-Weight=60 > + > +Name=Plasma Renderer License key would be nice. REPOSITORY R119 Plasma Des

D7936: Don't set QQC Style in startkde

gladhorn accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D7936 To: davidedmundson, #plasma, gladhorn Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreute

D7935: Set QtQuickControls theme in QPT

gladhorn accepted this revision. gladhorn added a comment. This revision is now accepted and ready to land. It would be very nice if things didn't crash when using qguiapplication and the style, but I guess that's unrelated to this patch. REPOSITORY R135 Integration for Qt applications in P

D7936: Don't set QQC Style in startkde

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY As now it is set by our QPT REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETA

D7935: Set QtQuickControls theme in QPT

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Currently we set QT_QUICK_CONTROLS_STYLE in startkde. This causes problems as we're settin

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

sebas added a comment. Maybe not put it in systemsettings, but tell users to run kcmshell to open it? That really hides it well though, also defeating the purpose... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7934 To: davidedmundson, #plasma Cc: sebas, b

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

davidedmundson updated this revision to Diff 19780. davidedmundson added a comment. Apparently I'm not good at spelliing REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7934?vs=19778&id=19780 BRANCH master REVISION DETAIL https://phabricator.kde

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

davidedmundson added a comment. In https://phabricator.kde.org/D7934#147847, @sebas wrote: > Can we hide this even more, given that it's an utter expert setting? Any idea where though? One of my next goals was to make Plasmashell set to use the software renderering if it dete

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

sebas added a comment. Can we hide this even more, given that it's an utter expert setting? INLINE COMMENTS > qtquicksettings.desktop:14 > + > +Name=Plasma Rendererer > + I think you forgot a few "er", it should be Plasma Renderererererererer, no? ;-) REPOSITORY R119 Plasma Desktop REVIS

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

davidedmundson added a comment. F3921193: Spectacle.n23639.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7934 To: davidedmundson, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

broulik added inline comments. INLINE COMMENTS > kcmqtquicksettings.cpp:53 > + > +connect(m_ui->backendCombo, static_cast (QComboBox::*)(int)>(&QComboBox::currentIndexChanged), this, static_cast (KCMQtQuickSettingsModule::*)()>(&KCMQtQuickSettingsModule::changed)); > +connect(m_ui->render

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Does what you imagine it would. It's akin to KWin's compositor settings, designed to be hidde

D7871: Properly update the visible (icon) name when the caption changes

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH fix-visible-name REVISION DETAIL https://phabricator.kde.org/D7871 To: graesslin, #kwin, #plasma, hein, davidedmundson Cc: grahamperrin, broulik, plasma-devel, kwin, bwowk,