D5928: Introducing Night Color - KWin's native blue light filter at nighttime

2017-10-12 Thread Roman Gilg
subdiff added a comment. In https://phabricator.kde.org/D5928#154584, @davidedmundson wrote: > If you're busy, tell me and I'll make those minor changes I want and follow this up. Thanks for the offer, but I should be able to do it myself early enough before next release. Would

D8265: Change kcm header "Select Login Theme" to "Configure the SDDM Login Manager"

2017-10-12 Thread Nathaniel Graham
ngraham added a comment. Oh right of course, because the title becomes the commit message. I'll remember in the future. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D8265 To: aspotashev, plasma-devel, davidedmundson, ngraham Cc: rkflx,

D8265: Change kcm header "Select Login Theme" to "Configure the SDDM Login Manager"

2017-10-12 Thread Henrik Fehlauer
rkflx added a comment. @ngraham: It's probably okay since David already worded it that way, but next time I'd suggest to review the commit message more carefully ;) REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D8265 To: aspotashev,

D8268: Fix placement of KSplash

2017-10-12 Thread Martin Flöser
graesslin added a comment. This needs additional testing for "normal" OSD windows. I'm not sure whether it affects them. It shouldn't or better said: if they are it's a bug somewhere else. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8268 To: graesslin, #kwin,

D8268: Fix placement of KSplash

2017-10-12 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY In a bug report there was a reference that on multi-screen KSplash is not placed correctly. I

Re: Wayland showstoppers wiki page

2017-10-12 Thread David Edmundson
> Er what? I'm not even aware anybody is waiting for my input. If there was > anything on reviewboard during my vacations it probably never reached me. > My frameworks mailing list folder still has 1500 unread mails :-( > https://phabricator.kde.org/D1231

D8265: Change kcm header "Select Login Theme" to "Configure the SDDM Login Manager"

2017-10-12 Thread Nathaniel Graham
ngraham added a comment. Hmm, probably should have waited until David could sign off too, since he had an outstanding request-for-changes review. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D8265 To: aspotashev, plasma-devel,

D8265: Change kcm header "Select Login Theme" to "Configure the SDDM Login Manager"

2017-10-12 Thread Alexander Potashev
This revision was automatically updated to reflect the committed changes. Closed by commit R123:3b71872c87f2: Change kcm header Select Login Theme to Configure the SDDM Login Manager (authored by aspotashev). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE

D8265: Change kcm header "Select Login Theme" to "Configure the SDDM Login Manager"

2017-10-12 Thread Nathaniel Graham
ngraham accepted this revision. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D8265 To: aspotashev, plasma-devel, davidedmundson, ngraham Cc: ngraham, davidedmundson, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D8265: Change kcm header "Select Login Theme" to "Configure the SDDM Login Manager"

2017-10-12 Thread Alexander Potashev
aspotashev updated this revision to Diff 20652. aspotashev added a comment. update to "Configure Login Manager" REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8265?vs=20643=20652 BRANCH kcm-header-sddm REVISION DETAIL

Re: Linux Pro Magazine article about Wayland adoption

2017-10-12 Thread Martin Flöser
Hi Bruce, sorry for the late reply, I only spotted your note right now. I'm the Wayland maintainer in Plasma. Am 2017-10-09 23:43, schrieb Bruce Byfield: Hi: I'm preparing an article on distros' adoption of Wayland. I was hoping to have answers to a few questions: - What is the state of

Re: Wayland showstoppers wiki page

2017-10-12 Thread Martin Flöser
Am 2017-10-12 17:33, schrieb Martin Flöser: Am 2017-10-12 13:48, schrieb David Edmundson: I've added some things, that I think are essential. I think we should track assignment on the existing phabricator tasks list. Note there's also the bugzilla keyword "wayland" for searching over all our

D7369: Wayland foreign protocol

2017-10-12 Thread Martin Flöser
graesslin accepted this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7369 To: mart, #plasma, #kwin, davidedmundson, graesslin Cc: davidedmundson, graesslin, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed,

D8264: Fix build of breeze-icons on the Android CI

2017-10-12 Thread Kevin Funk
kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. That comment could be a bit more verbose and better placed (i.e. move it next to `set(BINARY_ICONS_RESOURCE_OPTION_DEFAULT OFF)` and make it something along "When cross-compiling qrcAlias

Re: Wayland showstoppers wiki page

2017-10-12 Thread Martin Flöser
Am 2017-10-12 13:48, schrieb David Edmundson: I've added some things, that I think are essential. I think we should track assignment on the existing phabricator tasks list. Note there's also the bugzilla keyword "wayland" for searching over all our software. I'm glad you're more on the fence

D8265: Change kcm header "Select Login Theme" to "Configure the SDDM Login Manager"

2017-10-12 Thread Nathaniel Graham
ngraham added a comment. Frankly the term "login manager" won't mean much to most people either, but I agree that we shouldn't hardcode the name of a particular one in the UI, since this is a modular component. "Configure Login Manager" sounds good to me. REPOSITORY R123 SDDM

D8264: Fix build of breeze-icons on the Android CI

2017-10-12 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 20648. apol added a comment. Address Kevin's comments REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8264?vs=20641=20648 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8264 AFFECTED FILES

D8266: Fix QFile::copy warning when the colors file doesn't exist

2017-10-12 Thread David Faure
dfaure created this revision. dfaure added reviewers: mart, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY There is no need to even look for a "Default.colors" file when using the default color scheme,

Re: vaults feedback

2017-10-12 Thread Tomaz Canabrava
On Thu, Oct 12, 2017 at 3:56 PM, Ivan Čukić wrote: > Cool. Thanks for the link :) > > I'll have to write some docs for the wiki though, some people seem to > think it is a replacement or not needed in the case of full-drive > encryption. > Ah, but it is. I have a full drive

Re: vaults feedback

2017-10-12 Thread Ivan Čukić
Cool. Thanks for the link :) I'll have to write some docs for the wiki though, some people seem to think it is a replacement or not needed in the case of full-drive encryption. Cheers, Ivan On Thursday, 12 October 2017, Jonathan Riddell wrote: > seems good so far > >

D8252: Make calendar pin persistent across sessions

2017-10-12 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D8252 To: davidedmundson, #plasma, broulik Cc: graesslin, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai,

D8265: Change kcm header "Select Login Theme" to "Configure the SDDM Login Manager"

2017-10-12 Thread Alexander Potashev
aspotashev added a comment. "Configure Login Manager" sounds OK? REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D8265 To: aspotashev, plasma-devel, davidedmundson Cc: davidedmundson, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8264: Fix build of breeze-icons on the Android CI

2017-10-12 Thread Kevin Funk
kfunk requested changes to this revision. kfunk added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:23 > +if (CMAKE_CROSSCOMPILING) > +set(GENERATE_ICONS_DEFAULT OFF) > +else() Better: `GENERATE_ICONS_DEFAULT` ->

Linux Pro Magazine article about Wayland adoption

2017-10-12 Thread Bruce Byfield
Hi: I'm preparing an article on distros' adoption of Wayland. I was hoping to have answers to a few questions: - What is the state of Wayland development in Plasma? - Are there any obstacles in Plasma or perhaps Qt that prevent Wayland from being used by average users in KDE? - How will the

D8265: Change kcm header "Select Login Theme" to "Configure the SDDM Login Manager"

2017-10-12 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. I don't want to put "SDDM" in the UI. It won't mean anything to most people. Login theme -> login manager makes sense though. REPOSITORY R123 SDDM

D8265: Change kcm header "Select Login Theme" to "Configure the SDDM Login Manager"

2017-10-12 Thread Alexander Potashev
aspotashev created this revision. aspotashev added a reviewer: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY Change kcm header "Select Login Theme" to "Configure the SDDM Login Manager" because it's not only about the theme, you can also setup autologin and

D8252: Make calendar pin persistent across sessions

2017-10-12 Thread David Edmundson
davidedmundson updated this revision to Diff 20642. davidedmundson added a comment. Fix config REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8252?vs=20640=20642 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8252 AFFECTED FILES

D8264: Fix build of breeze-icons on the Android CI

2017-10-12 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Frameworks, Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY At the moment we are compiling the tool against android then trying to execute it, which

D8252: Make calendar pin persistent across sessions

2017-10-12 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > main.xml:69 > + > + Whether the popup should close when another window is > activated > + false You got it the wrong way round now, it implies that `true` means it should close REPOSITORY R120 Plasma Workspace REVISION DETAIL

D8252: Make calendar pin persistent across sessions

2017-10-12 Thread David Edmundson
davidedmundson updated this revision to Diff 20640. davidedmundson added a comment. Include systray REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8252?vs=20612=20640 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8252 AFFECTED

D7369: Wayland foreign protocol

2017-10-12 Thread Marco Martin
mart updated this revision to Diff 20639. mart marked 7 inline comments as done. mart added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. - more documentation REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

Re: Plasma Team Communication & Development Practices [MUST READ]

2017-10-12 Thread David Edmundson
On 9 Oct 2017 10:59, "Marco Martin" wrote: On Sun, Oct 8, 2017 at 12:01 PM, David Edmundson wrote: > Martin, > > don't go out of your way to get offended, most of the criticisms (of which > certainly 1 part is valid) are directed at a few certain

D7369: Wayland foreign protocol

2017-10-12 Thread Marco Martin
mart updated this revision to Diff 20638. mart added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. - documentation++ - name the methods exportTopLevel/importTopLevel REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D8261: Change kcm header "Screen Locking Timeouts" to "Configure Screen Locking"

2017-10-12 Thread Alexander Potashev
This revision was automatically updated to reflect the committed changes. Closed by commit R133:2f90a9137ba2: Change kcm header Screen Locking Timeouts to Configure Screen Locking (authored by aspotashev). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE

Re: Wayland showstoppers wiki page

2017-10-12 Thread David Edmundson
I've added some things, that I think are essential. I think we should track assignment on the existing phabricator tasks list. Note there's also the bugzilla keyword "wayland" for searching over all our software. I'm glad you're more on the fence about the EGL stream support. I switched one of

D8252: Make calendar pin persistent across sessions

2017-10-12 Thread David Edmundson
davidedmundson planned changes to this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8252 To: davidedmundson, #plasma Cc: graesslin, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8261: Change kcm header "Screen Locking Timeouts" to "Configure Screen Locking"

2017-10-12 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R133 KScreenLocker BRANCH kcm-header-screenlock REVISION DETAIL https://phabricator.kde.org/D8261 To: aspotashev, plasma-devel, broulik Cc: ZrenBot, progwolff, lesliezhai, ali-mohamed,

D5928: Introducing Night Color - KWin's native blue light filter at nighttime

2017-10-12 Thread David Edmundson
davidedmundson added a comment. If you're busy, tell me and I'll make those minor changes I want and follow this up. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5928 To: subdiff, #kwin Cc: ngraham, leezu, behrmann, cfeck, graesslin, davidedmundson, plasma-devel,

D8261: Change kcm header "Screen Locking Timeouts" to "Configure Screen Locking"

2017-10-12 Thread Alexander Potashev
aspotashev created this revision. aspotashev added a reviewer: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY Change kcm header "Screen Locking Timeouts" to "Configure Screen Locking" because it's not only about timeouts: you can also set the background

vaults feedback

2017-10-12 Thread Jonathan Riddell
seems good so far https://www.reddit.com/r/kde/comments/75ua55/kde_plasma_511_vaults_thank_you_so_much/

Re: Plasma 5.12 goal: let's get Wayland ready!

2017-10-12 Thread Marco Martin
On Wed, Oct 11, 2017 at 5:20 PM, Martin Flöser wrote: >> yep, i like it and i'll try! >> some times tough some help is needed to even figure out where the problem >> is... >> for tme the thing that makes my laptop unusable with wayland is a very bad >> flicker in many qwidget

D5928: Introducing Night Color - KWin's native blue light filter at nighttime

2017-10-12 Thread Roman Gilg
subdiff added a comment. In https://phabricator.kde.org/D5928#154362, @ngraham wrote: > What's the status of this patch? There is some minor problem @davidedmundson pointed to. When I've finished the thesis I currently need to work on, I'll look into that, rebase on current

D8251: Fix DRM EGL crash regression

2017-10-12 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R108:3d619c995b88: Fix DRM EGL crash regression (authored by davidedmundson). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8251?vs=20611=20629 REVISION DETAIL

D8260: [LauncherTasksModel] Try resolving absolute path to applications: URL before adding launcher

2017-10-12 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, hein, ngraham, mvourlakos. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This way when a third party like pinning or dragging from Kickoff sends an

D8258: [Task Tools] Treat applications: and respective absolute path equal in launcherUrlsMatch

2017-10-12 Thread Kai Uwe Broulik
broulik updated this revision to Diff 20627. broulik added a comment. - Use same approach as `appDataFromUrl` (ie. `KDesktopFile::isDesktopFile` and then `KDesktopFile fileName` REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8258?vs=20625=20627

D8257: [StartupTasksModel] Try resolving startup application id to applications: URL

2017-10-12 Thread Kai Uwe Broulik
broulik edited the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8257 To: broulik, #plasma, hein, ngraham, mvourlakos Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8258: [Task Tools] Treat applications: and respective absolute path equal in launcherUrlsMatch

2017-10-12 Thread Kai Uwe Broulik
broulik edited the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8258 To: broulik, #plasma, hein, ngraham, mvourlakos Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8258: [Task Tools] Treat applications: and respective absolute path equal in launcherUrlsMatch

2017-10-12 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, hein, ngraham, mvourlakos. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik edited the test plan for this revision. broulik updated this revision to Diff 20627. broulik

D8257: [StartupTasksModel] Try resolving startup application id to applications: URL

2017-10-12 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, hein, ngraham, mvourlakos. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik edited the test plan for this revision. REVISION SUMMARY CCBUG: 385594 TEST PLAN This