D8380: Modernize: use nullptr

This revision was automatically updated to reflect the committed changes. Closed by commit R104:33f7c637d737: Modernize: use nullptr (authored by mlaurent). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8380?vs=21009=21148#toc REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

D8344: Add physicalSize to the Screens API

bshah added a comment. In https://phabricator.kde.org/D8344#158566, @graesslin wrote: > Maybe there is no need to have that method static? > > Sorry about the build failure... Yeah, going by that theory, will put patch in phab in moment. REPOSITORY R108 KWin REVISION

D8344: Add physicalSize to the Screens API

graesslin added a comment. In https://phabricator.kde.org/D8344#158553, @bshah wrote: > > This breaks the build.. will fix it however. > > Tricky, the method using `m_physicalSize` is static method, would it cause any issue if I make `m_physicalSize` also static? Maybe there

D8405: Allow to set "domain-suffix-match" in Wi-Fi settings

jgrulich requested changes to this revision. jgrulich added a comment. This revision now requires changes to proceed. This looks good, you will just need to update it to reflect requested changes in your other review. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D8402: Support "domain-suffix-match" in Security8021xSetting

jgrulich requested changes to this revision. jgrulich added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > security8021xsetting.h:66 > > +void setDomain(const QString ); > +QString domain() const; Usually these methods are named according to property

D8424: Folder View location properties: Improve visual layout

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Thanks for the patch! Can you push this or do you need someone to push for you? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8424 To: marten, #plasma,

D8344: Add physicalSize to the Screens API

bshah added a comment. > This breaks the build.. will fix it however. Tricky, the method using `m_physicalSize` is static method, would it cause any issue if I make `m_physicalSize` also static? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8344 To: graesslin,

D8344: Add physicalSize to the Screens API

bshah added inline comments. INLINE COMMENTS > hwcomposer_backend.cpp:197 > static const qreal factor = 25.4; > - o->setPhysicalSize(QSizeF(qreal(pixel.width() * 1000) / > qreal(attr_values[2]) * factor, > - qreal(pixel.height() * 1000) / >

D1230: GBM remote access support for KWin

Kanedias added a comment. In https://phabricator.kde.org/D1230#158542, @ngraham wrote: > With https://phabricator.kde.org/D6186 merged, is this now ready to go in? Yes, just waits for @graesslin's final review :) REPOSITORY R108 KWin REVISION DETAIL

D1231: Add Remote Access interface to KWayland

ngraham added a comment. Is this mergeable? @graesslin? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc: ngraham, alexeymin, #frameworks, davidedmundson, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai,

D1230: GBM remote access support for KWin

ngraham added a comment. With https://phabricator.kde.org/D6186 merged, is this now ready to go in? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson Cc: ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson, plasma-devel,

D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

ngraham added a comment. What's next for this? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D4193 To: arichardson, #plasma Cc: ngraham, krzyc, anthonyfieroni, elvisangelaccio, graesslin, plasma-devel, ZrenBot, progwolff,

D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

ngraham added a comment. What's next for this? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3829 To: xuetianweng, davidedmundson Cc: ngraham, knambiar, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D4979: Add places:/ KIO slave

ngraham added a comment. What's the status of this patch? Are changes required to proceed? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4979 To: broulik, #plasma, hein, dfaure Cc: ngraham, elvisangelaccio, plasma-devel, ZrenBot, progwolff, lesliezhai,

D6799: Apply maximize effect to full screen changes

ngraham added a comment. Can we land this? It's a nice little polish change. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6799 To: broulik, #plasma, graesslin, #vdg Cc: ngraham, plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7424: Very slightly increase text contrast for the default Breeze color scheme

ngraham edited the summary of this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7424 To: ngraham, hpereiradacosta, jensreuterberg, jriddell, kvermette, #vdg Cc: januz, progwolff, broulik, sebas, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

Kirigami/qmake problems (updated)

Hi, sorry for spamming but in my last message i was missing some information. I'm trying to build an application using Kirigami, but i'm stuck with a few issues, and i thought maybe you could help me figure out what's wrong, since i lack experience. I'm using qmake and QtCreator to deploy the

D7424: Very slightly increase text contrast for the default Breeze color scheme

ngraham edited the test plan for this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7424 To: ngraham, hpereiradacosta, jensreuterberg, jriddell, kvermette, #vdg Cc: januz, progwolff, broulik, sebas, plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D7424: Very slightly increase text contrast for the default Breeze color scheme

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7424 To: ngraham, hpereiradacosta, jensreuterberg, jriddell, kvermette, #vdg Cc: januz, progwolff, broulik, sebas, plasma-devel,

D7424: Very slightly increase text contrast for the default Breeze color scheme

ngraham updated this revision to Diff 21144. ngraham added a comment. Reduce intensity of the change; don't touch almost-white colors, and only slightly darken the dark grays REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7424?vs=18419=21144 BRANCH

D8380: Modernize: use nullptr

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R104 KScreen BRANCH remove_unsed_variable REVISION DETAIL https://phabricator.kde.org/D8380 To: mlaurent, afiestas, sebas, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7047: Wallpaper blur background filling effect feature

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. It occurs to me that only the "Scaled, Keep Proportions" and "Centered" positioning modes require any kind of background effect or color. With other positioning modes, the

Fwd: Kirigami/qmake deployment on Android problems

Hi, I've been trying for the past two days to get my Kirigami application up and working on Android. It all works fine in the desktop, but when i try to deploy it to an android device the application dies. I'm using qmake, because with cmake i haven't been able to get pass this error:

D7424: Very slightly increase text contrast for the default Breeze color scheme

ngraham planned changes to this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7424 To: ngraham, hpereiradacosta, jensreuterberg, jriddell, kvermette, #vdg Cc: januz, progwolff, broulik, sebas, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D7246: Tooltips in Breeze theme

ngraham added a comment. @McPain, any update? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain, #breeze, #plasma, graesslin Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D7747: Added an extra fuzzytime setting - Hobbit Time

jayturner added a comment. In https://phabricator.kde.org/D7747#158471, @ngraham wrote: > @davidedmundson, is "kobbit" good enough? I don't know the history of "kandalf" here. I think the Hobbit books are in public domain nowadays? REPOSITORY R114 Plasma Addons REVISION

D7747: Added an extra fuzzytime setting - Hobbit Time

ngraham added a comment. @davidedmundson, is "kobbit" good enough? I don't know the history of "kandalf" here. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D7747 To: jayturner, ngraham Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff,

D7747: Added an extra fuzzytime setting - Hobbit Time

jayturner added a comment. In https://phabricator.kde.org/D7747#158466, @ngraham wrote: > @jayturner, do you have commit access? No, sorry REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D7747 To: jayturner, ngraham Cc: ngraham, davidedmundson,

D7747: Added an extra fuzzytime setting - Hobbit Time

ngraham added a comment. @jayturner, do you have commit access? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D7747 To: jayturner, ngraham Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D7747: Added an extra fuzzytime setting - Hobbit Time

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Hilarious. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D7747 To: jayturner, ngraham Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff,

D7849: Fix the tray icon scaling on HiDPI screens

ngraham added a comment. Any chance we can reach some kind of consensus here? REVISION DETAIL https://phabricator.kde.org/D7849 To: pgkos, #plasma Cc: ngraham, anthonyfieroni, broulik, #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D8362: Added setting to toggle drawing of title bar separator

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. https://phabricator.kde.org/tag/vdg/ seems MIA. @broulik, I propose we land this in a week or two if nobody else objects. REPOSITORY R31 Breeze BRANCH titlebar-highlight REVISION

[kio-extras] [Bug 375840] MTP connection crashes after few minutes on several phones

https://bugs.kde.org/show_bug.cgi?id=375840 --- Comment #7 from Michał Walenciak --- some output from kdeinit5: kamera.kio: KameraProtocol::~KameraProtocol() kf5.kio.core: Refilling KProtocolInfoFactory cache in the hope to find "stash" qt.accessibility.core: Cannot create

[kio-extras] [Bug 375840] MTP connection crashes after few minutes on several phones

https://bugs.kde.org/show_bug.cgi?id=375840 Michał Walenciak changed: What|Removed |Added CC||kice...@gmail.com ---

D7999: Drop workaround for QQC1 QGuiApplication crashes

arojas added a comment. In https://phabricator.kde.org/D7999#158351, @arojas wrote: > Ping, can this go in? AFAIK the QGUIApplication crashes only happen now when explicitely setting the QQC*2* style to org.kde.desktop, which is unrelated to this change (and should be properly fixed

D8421: Port the dict applet to KF5 and QtQuick 2

davidedmundson added a comment. Cool, thanks! > Adding dict applet to desktop, works. Have you added it to the panel? INLINE COMMENTS > main.qml:20 > +placeholderText: i18n("Enter word to define here") > +// If this was widgets, I'd use QFontMetrics... > +

D7999: Drop workaround for QQC1 QGuiApplication crashes

arojas added a comment. Ping, can this go in? AFAIK the QGUIApplication crashes only happen now when explicitely setting the QQC*2* style to org.kde.desktop, which is unrelated to this change (and should be properly fixed instead of worked around here IMO) REPOSITORY R135 Integration for

D8419: Dict Engine: improve error handling.

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.11 REVISION DETAIL https://phabricator.kde.org/D8419 To: dfaure, #plasma, davidedmundson Cc: plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai,

D8424: Folder View location properties: Improve visual layout

marten created this revision. marten added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The current appearance of this dialogue: F5443493: folderview-properties-location_BEFORE.png

D8405: Allow to set "domain-suffix-match" in Wi-Fi settings

Martchus added a comment. When doing that I'm getting the following error: > Unhandled Exception ("PhabricatorEdgeCycleException") > Graph cycle detected (type=5, cycle=PHID-DREV-pkm36mw773wvsopfgiic, PHID-DREV-4dp34miciioa53ocgthf, PHID-DREV-pkm36mw773wvsopfgiic). So I'll better

[kwrited] [Bug 386067] New: Use seperate notifications for each message

https://bugs.kde.org/show_bug.cgi?id=386067 Bug ID: 386067 Summary: Use seperate notifications for each message Product: kwrited Version: 5.11.1 Platform: Neon Packages OS: Linux Status: UNCONFIRMED

D8421: Port the dict applet to KF5 and QtQuick 2

dfaure created this revision. dfaure added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY My wife was missing this applet, after migrating to Plasma 5. Therefore I had to learn how to write

D8320: Dictionary Engine: fix synchronization issues.

This revision was automatically updated to reflect the committed changes. Closed by commit R114:02d8fbfb1928: Dictionary Engine: fix synchronization issues. (authored by dfaure). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8320?vs=20832=21125

D8419: Dict Engine: improve error handling.

dfaure created this revision. dfaure added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Instead of returning "\n\n" when the word doesn't exist, return a proper readable string so users know

D8397: Align logout screen action buttons to the top

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8397 To: aleksejshilin, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,