D7747: Added an extra fuzzytime setting - Hobbit Time

jensreuterberg added a comment. Just throwing this in: Hobbit is a tricky one - remember that most for example fantasy games etc translate to "halfling" (I feel randomly disappointed there aren't more D&D players in this crowd) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabr

D8561: [d_ptr] Do not harsh destroy QThread

ivan added a comment. While I like the idea behind the patch, I'd rather have what David proposed. Namely, d_ptr is a smart pointer, but I don't think it should be this smart - creating specializations for different types' destructors should not really be a part of it. REPOSITORY R161 KAc

D8602: [platforms/drm] Restore previous mode if an atomic test fails

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH drm-store-last-good-mode REVISION DETAIL https://phabricator.kde.org/D8602 To: graesslin, #kwin, #plasma, subdiff, davidedmundson Cc: davidedmundson, ngraham, plasma-devel,

D8627: [platforms/drm] Properly adjust cursor position on a rotated output

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. I think there's still work to do, but we may as well merge this and base any new changes on top of that. REPOSITORY R108 KWin BRANCH drm-cursor-position-rotate REVISIO

D8561: [d_ptr] Do not harsh destroy QThread

anthonyfieroni updated this revision to Diff 21830. REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8561?vs=21603&id=21830 REVISION DETAIL https://phabricator.kde.org/D8561 AFFECTED FILES src/service/Resources.cpp src/service/Resources_

D8638: Remove DataModel::roleNameToId

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY It is unused and returned `-1` whereas `SortFilterModel` would return `Qt::DisplayRole

D8639: Optimize SortFilterModel role names

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY - Reserve m_roleIds - Avoid double lookup contains+value but use default value argume

D8639: Optimize SortFilterModel role names

broulik edited the summary of this revision. broulik edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8639 To: broulik, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreut

D8561: [d_ptr] Do not harsh destroy QThread

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Thanks for fixing REPOSITORY R161 KActivity Manager Service REVISION DETAIL https://phabricator.kde.org/D8561 To: anthonyfieroni, #plasma, davidedmundson, ivan Cc: plas

D8617: Folder View previews dialogue: Improve visual layout

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8617 To: marten, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8639: Optimize SortFilterModel role names

mwolff accepted this revision. mwolff added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > datamodel.h:141 > protected: > -int roleNameToId(const QString &name); //FIXME TODO KF6: This should > have been const. > +int roleNameToId(const QString &nam

D8638: Remove DataModel::roleNameToId

mwolff accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8638 To: broulik, #plasma, mwolff Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterber

D8639: Optimize SortFilterModel role names

broulik added inline comments. INLINE COMMENTS > mwolff wrote in datamodel.h:141 > why was that kf6 note there? Probably someone added it who thought it could not be changed because you can't for exported classes but this isn't. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL h

D7747: Added an extra fuzzytime setting - Hobbit Time

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. You never know until you ask; there may be more overlap than you think. ;-) Halfling indeed seems safer than Kobbit. REPOSITORY R114 Plasma Addons REVISION DETAIL https

D7747: Added an extra fuzzytime setting - Hobbit Time

jayturner added a comment. I'll make the changes when I get to computer :) I personally don't have an opinion on what it gets called REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D7747 To: jayturner, ngraham Cc: jensreuterberg, broulik, ngraham, davidedmundso

D7747: Added an extra fuzzytime setting - Hobbit Time

jayturner updated this revision to Diff 21834. jayturner added a comment. Changed kobbit to halfling REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7747?vs=19334&id=21834 REVISION DETAIL https://phabricator.kde.org/D7747 AFFECTED FILES applets/f

D8493: Make Folder View screen aware

amantia updated this revision to Diff 21837. amantia added a comment. - add unit tests for different scenarios of foldermodel and screenmapper usage on multiple screens - connect screenMappingChanged to invalidateFilter - as addMapping is called from withing filterAcceptRows, make it possi

D8493: Make Folder View screen aware

amantia updated this revision to Diff 21838. amantia added a comment. remove unimplemented method REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8493?vs=21837&id=21838 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8493 AFFECTED FI

D8617: Folder View previews dialogue: Improve visual layout

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ad5f2e332708: Folder View previews dialogue: Improve visual layout (authored by marten). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8617?vs=21768&id=2183

D8598: FolderView: position files at drop event target position

amantia added a comment. I didn't tested the code yet, but in general looks good for me. INLINE COMMENTS > foldermodel.cpp:181 > +if (!m_dropTargetPositions.isEmpty()) { > +qDebug() << "clearing drop target positions after timeout:" << > m_dropTargetPositions; > +

D8641: FormLayout

mart created this revision. mart added reviewers: Plasma, Kirigami. Restricted Application added projects: Plasma, Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Add a new component called FormLayout, which aims to behave similar to Qwidget's QFormLayout:

D8641: FormLayout

mart added a reviewer: hein. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D8641 To: mart, #plasma, #kirigami, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein

D8641: FormLayout

mart added a comment. F5470164: Spectacle.TJ9696.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D8641 To: mart, #plasma, #kirigami, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts

D8641: FormLayout

mart edited the summary of this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D8641 To: mart, #plasma, #kirigami, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein

D8641: FormLayout

davidedmundson added inline comments. INLINE COMMENTS > FormLayout.qml:8 > + > +Control { > +id: root Why do we inherit from Control? > FormLayout.qml:20 > +columnSpacing: Kirigami.Units.smallSpacing > +anchors { > +left: parent.left this can be taller than the

D8641: FormLayout

ngraham added a comment. Do we have top have that giant banner on top of the sidebar list? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D8641 To: mart, #plasma, #kirigami, hein Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed

D7747: Added an extra fuzzytime setting - Hobbit Time

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D7747 To: jayturner, ngraham Cc: jensreuterberg, broulik, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-moh

D8460: Refactor kcm_input to enable having multiple backends.

xuetianweng abandoned this revision. xuetianweng added a comment. To be split into small patches. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8460 To: xuetianweng, subdiff, davidedmundson, ngraham, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D8460: Refactor kcm_input to enable having multiple backends.

xuetianweng reclaimed this revision. xuetianweng added a comment. .. Sorry click on the wrong one. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8460 To: xuetianweng, subdiff, davidedmundson, ngraham, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D8168: kcm_input: Refactor the code and add support for libinput under X11

xuetianweng abandoned this revision. xuetianweng added a comment. Being split into small patches REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8168 To: xuetianweng, davidedmundson, mart Cc: subdiff, ngraham, plasma-devel, leezu, ZrenBot, alexeymin, progwolff

D7747: Added an extra fuzzytime setting - Hobbit Time

jayturner added a comment. ✈️ REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D7747 To: jayturner, ngraham Cc: jensreuterberg, broulik, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, abetts, sebas, apol, mart

D8641: FormLayout

colomar added a comment. In https://phabricator.kde.org/D8641#164016, @ngraham wrote: > Do we have top have that giant banner on top of the sidebar list? This review request is about the form layout you see on the right, the sidebar has nothing to do with it. It's just in the scre

D8493: Make Folder View screen aware

mlaurent added inline comments. INLINE COMMENTS > foldermodeltest.cpp:70 > +delete m_folderDir; > +m_folderDir = 0; > delete m_folderModel; m_folderDir = nullptr > foldermodeltest.cpp:294 > +FolderModel secondFolderModel; > +secondFolderModel.setUrl(m_folderDir->path() + Q

D8493: Make Folder View screen aware

anthonyfieroni added inline comments. INLINE COMMENTS > foldermodel.cpp:163-164 > +if (m_screenMapper) { > +disconnect(m_screenMapper, &ScreenMapper::screensChanged, this, > &FolderModel::invalidateFilter); > +disconnect(m_screenMapper, &ScreenMapper::screenMappingChanged, >

D8561: [d_ptr] Do not harsh destroy QThread

This revision was automatically updated to reflect the committed changes. Closed by commit R161:27c0245b1715: [resources] Nicely quit threads (authored by anthonyfieroni). REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8561?vs=21830&id=21852

D8645: [platforms/drm] Determine the supported transformation on a plane

graesslin created this revision. graesslin added reviewers: KWin, Plasma, subdiff. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The idea behind getting the supported transformations is to tell KScreen which transfo

D8645: [platforms/drm] Determine the supported transformation on a plane

broulik added inline comments. INLINE COMMENTS > drm_object.h:64 > > +bool propHasEnum(int prop, uint64_t value) { > +return m_props[prop]->hasEnum(value); Const > drm_object_plane.cpp:106 > initProp(j, properties, typeNames); > +} else if(j == int(PropertyInd

D8441: Wallpaper: hide color or blur filling options for full filling mode

broulik added a comment. You need to adjust the `config.xml` for that setting to persist. Also, it seems you have pushed an unfinished version of that feature [1] without approval. [1] https://cgit.kde.org/plasma-workspace.git/commit/?id=9923cde1024dc86ab14c200bf745dde308fc9d3f REP

D7747: Added an extra fuzzytime setting - Hobbit Time

ngraham added a comment. @jayturner, what email address should I use for you when I land this? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D7747 To: jayturner, ngraham Cc: jensreuterberg, broulik, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, l

D7424: Very slightly increase text contrast for the default Breeze color scheme

ngraham added a comment. No strong feelings anymore? :-) As this change is now very minimal and subtle, and as it still conforms to standard Breeze colors, can we consider landing it? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7424 To: ngraham, hpereiradacosta,