D8731: [x11] Add support for automatic screen rotation through XRandR

2017-11-08 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D8731#165948, @davidedmundson wrote: > I said on the previous patch that there's a *fundamental* design flaw in the previous patch, which will be even worse on X. > The last patch was pushed regardless..and now there's a patch o

D8460: Refactor kcm_input to enable having multiple backends.

2017-11-08 Thread Xuetian Weng
This revision was automatically updated to reflect the committed changes. Closed by commit R119:40f8edd70f4a: Refactor kcm_input to enable having multiple backends. (authored by xuetianweng). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8460?vs=21675&

Re: Out-of-screen painting for QQuickView ?

2017-11-08 Thread Michail Vourlakos
> We have the exact same bug with our panel freezing after a full screen game is run. We haven't fixed it. this is exactly what the user reported at https://github.com/psifidotos/Latte-Dock/issues/753 . David do you know the bug report in order to have it as a reference in case you come up with a

D8726: [ScrollView] Scroll one page with Shift+wheel

2017-11-08 Thread Kai Uwe Broulik
broulik added a comment. > As a general cross-platform UI convention, Shift+scroll wheel is typically used for horizontal scrolling. Qt does it this way. Alt scrolls horizontally for Qt as you can experience in all KDE widget apps. REPOSITORY R169 Kirigami REVISION DETAIL https://p

Re: Out-of-screen painting for QQuickView ?

2017-11-08 Thread David Edmundson
To explicitly answer your question: >Do you know any way to tell Qt to paint QQuickView objects even when they are out-of-screen? set the GL context current, then call render on the render control. But that probably won't help. We have the exact same bug with our panel freezing after a full scre

D8731: [x11] Add support for automatic screen rotation through XRandR

2017-11-08 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. I said on the previous patch that there's a *fundamental* design flaw in the previous patch, which will be even worse on X. The last patch was pushed regardless..

Re: Need help: vertical screen rotation!

2017-11-08 Thread Martin Flöser
Am 2017-11-07 20:11, schrieb Martin Flöser: Am 2017-11-07 19:03, schrieb Sebastian Kügler: On dinsdag 7 november 2017 18:28:40 CET Martin Flöser wrote: > upside down works, 90 and 270 do nothing on my system. > > Debian Unstable > Linux manta 4.13.0-1-amd64 #1 SMP Debian 4.13.4-1 (2017-10-01) >

D8726: [ScrollView] Scroll one page with Shift+wheel

2017-11-08 Thread Nathaniel Graham
ngraham added a comment. As a general cross-platform UI convention, Shift+scroll wheel is typically used for horizontal scrolling. See the kinds of results returned with the following web search: https://duckduckgo.com/?q=shift+scroll Using just Ctrl for this should be fine though. REPO

D8731: [x11] Add support for automatic screen rotation through XRandR

2017-11-08 Thread Martin Flöser
graesslin added inline comments. INLINE COMMENTS > screens_xrandr.cpp:315 > + > +Xcb::RandR::SetCrtcConfig(m_internalCrtc, resources->timestamp, > resources->config_timestamp, info->x, info->y, info->mode, newTransformation, > info->num_outputs, info.outputs()); > +} I think something is s

D8731: [x11] Add support for automatic screen rotation through XRandR

2017-11-08 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma, sebas. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The XRandRScreens detects whether a screen is internal and supports transformations and

Out-of-screen painting for QQuickView ?

2017-11-08 Thread Michail Vourlakos
Hello everyone, an encyclopedic question, a QQuickView when is out of screen is not painted at all. This creates some rare issues with Latte because of its animations and tasks updates. You can read at: https://github.com/ psifidotos/Latte-Dock/issues/753 Do you know any way to tell Qt to paint Q

[Breeze] [Bug 371276] Only black screen with breeze plymouth theme in plasma 5.8.2

2017-11-08 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=371276 Harald Sitter changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

D8699: Support automatic screen rotation based on orientation sensor

2017-11-08 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:9df1744830a0: Support automatic screen rotation based on orientation sensor (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8699?vs=22037&id=22

D8645: [platforms/drm] Determine the supported transformation on a plane

2017-11-08 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:99b6f6150d04: [platforms/drm] Determine the supported transformation on a plane (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8645?vs=21858&i

[Breeze] [Bug 371276] Only black screen with breeze plymouth theme in plasma 5.8.2

2017-11-08 Thread Rex Dieter
https://bugs.kde.org/show_bug.cgi?id=371276 --- Comment #11 from Rex Dieter --- our findings were that the plymouth script is used preferentially (if it exists), and the dracut stuff is only a fallback. either way, stock plymouth and dracut scripts do not support subdirs. -- You are receiving

[Breeze] [Bug 371276] Only black screen with breeze plymouth theme in plasma 5.8.2

2017-11-08 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=371276 Harald Sitter changed: What|Removed |Added Assignee|plasma-b...@kde.org |plasma-devel@kde.org --- Comment #10 from Haral

D8578: [platforms/drm] Forward the mode changes to the OutputInterface

2017-11-08 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:59f7ed9c780a: [platforms/drm] Forward the mode changes to the OutputInterface (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8578?vs=21660&id=

[Breeze] [Bug 371276] Only black screen with breeze plymouth theme in plasma 5.8.2

2017-11-08 Thread Sebastian Kügler
https://bugs.kde.org/show_bug.cgi?id=371276 Sebastian Kügler changed: What|Removed |Added Assignee|plasma-devel@kde.org|plasma-b...@kde.org CC|

D8726: [ScrollView] Scroll one page with Shift+wheel

2017-11-08 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, mart. Restricted Application added projects: Plasma, Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is what QAbstractSlider does. TEST PLAN Inspired by qabstractslider.cpp:704ff I ha

D8725: [PageRow] Navigate between levels with mouse back/forward buttons

2017-11-08 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, mart. Restricted Application added projects: Plasma, Kirigami. Restricted Application added a subscriber: plasma-devel. TEST PLAN I can now go back and forward in System Settings' sidebar with my mouse back and forward keys Un

[Breeze] [Bug 371276] Only black screen with breeze plymouth theme in plasma 5.8.2

2017-11-08 Thread Rex Dieter
https://bugs.kde.org/show_bug.cgi?id=371276 Rex Dieter changed: What|Removed |Added Version|5.8.2 |5.11.3 -- You are receiving this mail because: Yo

[Breeze] [Bug 371276] Only black screen with breeze plymouth theme in plasma 5.8.2

2017-11-08 Thread Rex Dieter
https://bugs.kde.org/show_bug.cgi?id=371276 Rex Dieter changed: What|Removed |Added Ever confirmed|0 |1 Status|RESOLVED|

D8723: When used by QML, only populate after component is complete

2017-11-08 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D8723 To: hein, #plasma, davidedmundson, mart Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-m

D8524: Add a signal notifying a change in the names of running activities.

2017-11-08 Thread Eike Hein
hein added a comment. Please re-review, my above comment and diff update were submitted together. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8524 To: hein, #plasma Cc: anthonyfieroni, ivan, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jen

D8524: Add a signal notifying a change in the names of running activities.

2017-11-08 Thread Eike Hein
hein added inline comments. INLINE COMMENTS > anthonyfieroni wrote in activityinfo.cpp:81-86 > They should emit also numberOfRunnigActivitiesChanges, no? They don't need to. It's emitted in response to &KActivities::Consumer::runningActivitiesChanged. Actually, doing the reverse might make mor

D8524: Add a signal notifying a change in the names of running activities.

2017-11-08 Thread Eike Hein
hein updated this revision to Diff 22084. hein added a comment. Don't connect too rowsInserted/rowsRemoved. This is already handled by connecting to KActivities::Consumer::runningActivitiesChanged. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D8723: When used by QML, only populate after component is complete

2017-11-08 Thread Eike Hein
hein updated this revision to Diff 22083. hein added a comment. Fix review comments by David and Kai. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8723?vs=22078&id=22083 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8723 AFFEC

Re: Regarding the outputdevice Wayland protocol

2017-11-08 Thread Sebastian Kügler
Hi Drew, On woensdag 8 november 2017 15:12:03 CET Drew DeVault wrote: > Thanks for the info, guys! > > My main use-case for this protocol is to be able to share an > arandr-like tool between KDE and any compositor using wlroots (Sway, > way-cooler, waymonad, etc). > > Did you guys write a screen

D8723: When used by QML, only populate after component is complete

2017-11-08 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > tasksmodel.h:814 > > +void classBegin(); > +void componentComplete(); `override` REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8723 To: hein, #plasma, davidedmundson, mart Cc: broulik, plasma-devel,

D8525: Refresh when the names of the running activities change.

2017-11-08 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D8525 To: hein, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreute

D8723: When used by QML, only populate after component is complete

2017-11-08 Thread David Edmundson
davidedmundson added a comment. > I'm not super happy with this behavior change for C++ users, I've seen other people export a subclass for QtQuick that sets the usedByQml flag. I love QQmlParserStatus so +1 INLINE COMMENTS > tasksmodel.cpp:632 > { > +qDebug() << usedByQml <<

[Breeze] [Bug 371276] Only black screen with breeze plymouth theme in plasma 5.8.2

2017-11-08 Thread Rex Dieter
https://bugs.kde.org/show_bug.cgi?id=371276 Rex Dieter changed: What|Removed |Added CC||rdie...@gmail.com --- Comment #8 from Rex Dieter

D8524: Add a signal notifying a change in the names of running activities.

2017-11-08 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > activityinfo.cpp:81-86 > +connect(d->activitiesModel, &KActivities::ActivitiesModel::rowsInserted, > +this, &ActivityInfo::namesOfRunningActivitiesChanged); > +connect(d->activitiesModel, &KActivities::ActivitiesModel::rowsRe

D8525: Refresh when the names of the running activities change.

2017-11-08 Thread Eike Hein
hein added a reviewer: Plasma. hein added a comment. ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8525 To: hein, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8524: Add a signal notifying a change in the names of running activities.

2017-11-08 Thread Eike Hein
hein added a comment. ping? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8524 To: hein, #plasma Cc: ivan, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8460: Refactor kcm_input to enable having multiple backends.

2017-11-08 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works great for me. Nice work, I can't wait to see this whole thing finished and get proper libinput support. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://

D8723: When used by QML, only populate after component is complete

2017-11-08 Thread Eike Hein
hein created this revision. hein added reviewers: Plasma, davidedmundson, mart. Restricted Application added a project: Plasma. REVISION SUMMARY This introduces the use of QQmlParserStatus to delay populating the model until all properties have been set, to avoid delegate churn. TasksMo

D8721: fix overlapping labels on systems with different window sizes

2017-11-08 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY it is not quite clear to me why a Window may have a Y != 0 to begin with, but it happens and can in fact happ

D8441: Wallpaper: hide color or blur filling options for full filling mode

2017-11-08 Thread Yunhe Guo
guoyunhe added a comment. In https://phabricator.kde.org/D8441#164149, @broulik wrote: > You need to adjust the `config.xml` for that setting to persist. > > Also, it seems you have pushed an unfinished version of that feature [1] without approval. > > [1] https://cgit.kde.org/pl

D8707: Adapt to changes in KWindowSystem

2017-11-08 Thread Aleix Pol Gonzalez
apol closed this revision. apol added a comment. Submitted both to Plasma/5.11 and master. remote: https://commits.kde.org/plasma-workspace/ad130ff3bb1fc046713aee6190a9ce3d9c474e9a remote: https://commits.kde.org/plasma-workspace/9f7d482172ae0c1e3260cba0ba470bd16d0178f5 REPOSITORY R120

D8711: Possibly no need to have klipper executed by default

2017-11-08 Thread Aleix Pol Gonzalez
apol abandoned this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8711 To: apol, #plasma Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart