D8756: Forbid more syscalls which could modify the filesystem

2017-11-10 Thread David Kahles
This revision was automatically updated to reflect the committed changes. Closed by commit R133:7720e8486337: Forbid more syscalls which could modify the filesystem (authored by davidk). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8756?vs=22174=22176

D8754: Baloo KCM text improvements

2017-11-10 Thread Burkhard Lück
lueck added inline comments. INLINE COMMENTS > index.docbook:18-19 > > 2017-07-28 > Plasma 5.10 > Please bump date + releaseinfo REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8754 To: ngraham, #vdg, #plasma, abetts Cc: lueck, apol, plasma-devel,

D8756: Forbid more syscalls which could modify the filesystem

2017-11-10 Thread Martin Flöser
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R133 KScreenLocker BRANCH seccomp REVISION DETAIL https://phabricator.kde.org/D8756 To: davidk, graesslin Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D8748: [libinput] Find screen for touch screen devices and calibrate accordingly

2017-11-10 Thread Martin Flöser
graesslin updated this revision to Diff 22175. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Use screens()->geometry() instead of size REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8748?vs=22152=22175 BRANCH

D8756: Forbid more syscalls which could modify the filesystem

2017-11-10 Thread David Kahles
davidk added a reviewer: graesslin. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D8756 To: davidk, graesslin Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8756: Forbid more syscalls which could modify the filesystem

2017-11-10 Thread David Kahles
davidk created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Forbid more syscalls. An malicious theme could create directories with the password as name, or encode the password in chmod bits. Also,

D8754: Baloo KCM text improvements

2017-11-10 Thread Nathaniel Graham
ngraham added a comment. I kind of think all of those are worse than what we already have, to be honest. "Do not search in these locations" is a pretty clear and user-friendly text string IMHO. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8754 To:

D8754: Baloo KCM text improvements

2017-11-10 Thread Andres Betts
abetts added a comment. I think that people these days understand that indexing your files is a component of searching. If the word indexing is not liked, maybe it could be Capture file content data Read file content data Record file content data Etc. I would also suggest

D8755: User Manager KCM text changes and UI modernization

2017-11-10 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R128:5c072eab10bd: User Manager KCM text changes and UI modernization (authored by ngraham). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8755?vs=22167=22168

D8755: User Manager KCM text changes and UI modernization

2017-11-10 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R128 User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D8755 To: ngraham, abetts, #vdg, #plasma, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8754: Baloo KCM text improvements

2017-11-10 Thread Aleix Pol Gonzalez
apol added a comment. Why does the user need to know about the indexing? isn't it an implementation detail? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8754 To: ngraham, #vdg, #plasma, abetts Cc: apol, plasma-devel, abetts, ZrenBot, progwolff,

D8524: Add a signal notifying a change in the names of running activities.

2017-11-10 Thread Eike Hein
hein added a comment. Ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8524 To: hein, #plasma Cc: anthonyfieroni, ivan, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8755: User Manager KCM text changes and UI modernization

2017-11-10 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D8755 To: ngraham, abetts, #vdg, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8755: User Manager KCM text changes and UI modernization

2017-11-10 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: abetts, VDG, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 386635 Improve some strings and use a more modern checkboxes-on-the-left-side design

D8754: Baloo KCM text improvements

2017-11-10 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma, abetts. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 386634 Implement @abetts' proposed text changes for the Baloo KCM TEST PLAN Tested

D8692: QML mouse cursor KCM and components

2017-11-10 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8692 To: mart, #plasma Cc: januz, ngraham, subdiff, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8748: [libinput] Find screen for touch screen devices and calibrate accordingly

2017-11-10 Thread Martin Flöser
graesslin marked an inline comment as done. graesslin added inline comments. INLINE COMMENTS > graesslin wrote in connection.cpp:395 > It's failing to compile in tests/ directory. There I don't have the > mockscreens, so I didn't think of it. Will try with the mockscreens. Thanks > for the

D8748: [libinput] Find screen for touch screen devices and calibrate accordingly

2017-11-10 Thread Martin Flöser
graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in connection.cpp:395 > not that it's a problem, but why? > You have screens mocked already. It's failing to compile in tests/ directory. There I don't have the mockscreens, so I didn't think of it. Will try with the

D8752: [platforms/drm] At safety checks for the properties

2017-11-10 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma, fvogt, subdiff. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The AMS code accesses elements in a vector which might not be valid. This

D8748: [libinput] Find screen for touch screen devices and calibrate accordingly

2017-11-10 Thread David Edmundson
davidedmundson added a comment. One minor comment (the third one), otherwise all good. INLINE COMMENTS > connection.cpp:395 > case LIBINPUT_EVENT_TOUCH_DOWN: { > +#ifndef KWIN_BUILD_TESTING > TouchEvent *te = static_cast(event.data()); not that

D8731: [x11] Add support for automatic screen rotation through XRandR

2017-11-10 Thread Martin Flöser
graesslin added a comment. > Yet we're putting this sensor stuff in kwin instead, then having to come up with extra interfaces to fix the problems we're creating. The main reason is that I wanted to support the phone case (hwcomposer) where we don't have the OutputConfigurationInterface

D8731: [x11] Add support for automatic screen rotation through XRandR

2017-11-10 Thread Martin Flöser
graesslin updated this revision to Diff 22153. graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. Fixup arc failure REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8731?vs=22151=22153 BRANCH

D8748: [libinput] Find screen for touch screen devices and calibrate accordingly

2017-11-10 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY This change finds the screen for a touch screen device based on: - number available screens

D8731: [x11] Add support for automatic screen rotation through XRandR

2017-11-10 Thread Martin Flöser
graesslin updated this revision to Diff 22151. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. - [libinput] Find screen for touch screen devices and calibrate accordingly REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D8731: [x11] Add support for automatic screen rotation through XRandR

2017-11-10 Thread David Edmundson
davidedmundson added a comment. > I hope this addresses your concerns and can us allow to unblock this change. It could work, so I won't block it. But I still don't understand the design rationale. We have a component that is in charge of handling all screen management. It has

D8744: Use Qt.callLater instead of creating a Timer

2017-11-10 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN This is new in Qt 5.8. The kicker dialogs are properly destroyed. I didn't actually see the one in

D8441: Wallpaper: hide color or blur filling options for full filling mode

2017-11-10 Thread Nathaniel Graham
ngraham added a comment. A neat idea, but yeah, I think it probably wouldn't even occur to most people to try to use a transparent image! If you approve, would you mind formally accepting it? I'm willing to triage and handle any bugs that come in saying "Hey, you broke my transparent

D8743: Add dynamic QML visual results

2017-11-10 Thread Aditya Mehra
This revision was automatically updated to reflect the committed changes. Closed by commit R846:b5e85c3e4b9f: Add dynamic QML visual results (authored by Aiix). REPOSITORY R846 Mycroft Plasma integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8743?vs=22143=22144 REVISION

D8743: Add dynamic QML visual results

2017-11-10 Thread Aditya Mehra
Aiix created this revision. Aiix added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Ref https://phabricator.kde.org/T7433 Added LoaderType which displays dynamically generated QML template results

Re: Out-of-screen painting for QQuickView ?

2017-11-10 Thread David Edmundson
bug ​353983

D8692: QML mouse cursor KCM and components

2017-11-10 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D8692#165286, @subdiff wrote: > - Open the kcm with kcmshell5 kcm_cursortheme opens it in a very small view with only one column can you try it now with the last commit? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D8692: QML mouse cursor KCM and components

2017-11-10 Thread Marco Martin
mart updated this revision to Diff 22142. mart added a comment. - ensure at least 2 columns are visible REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8692?vs=22026=22142 BRANCH kcm-redesign/cursorTheme REVISION DETAIL

D8441: Wallpaper: hide color or blur filling options for full filling mode

2017-11-10 Thread Jens Reuterberg
jensreuterberg added a comment. Heh I may be the one who used transparent images - the idea being that you could, in theory set colour of an entire wallpaper based on icon colour using the correct kind of transparent image (essentially making darker parts less transparent meaning the

D8692: QML mouse cursor KCM and components

2017-11-10 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D8692#165286, @subdiff wrote: > - Open the kcm with kcmshell5 kcm_cursortheme opens it in a very small view with only one column is the case of just few pixels too little to do a second column, to fix it it would need for

D8691: add some metadata

2017-11-10 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R296:ae8d97bb5274: add some metadata (authored by mart). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8691?vs=22022=22141 REVISION DETAIL