D8050: Expose wl_display_set_global_filter as a virtual method

This revision was automatically updated to reflect the committed changes. Closed by commit R127:7cb71d002b72: Expose wl_display_set_global_filter as a virtual method (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8050?vs=20560&id=22503#toc REPOSITORY R127

D8493: Make Folder View screen aware

amantia added a comment. Ok, let's wait for Eike and for the DND patches to be ready. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8493 To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson, apol, mwolff Cc: anthonyfieroni, ngraham, m

D8598: FolderView: position files at drop event target position

amantia accepted this revision. amantia added a comment. This revision is now accepted and ready to land. Looks good for me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8598 To: mwolff, hein, amantia Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mo

D8598: FolderView: position files at drop event target position

amantia requested changes to this revision. amantia added a comment. This revision now requires changes to proceed. Sorry, found two small issues :) INLINE COMMENTS > foldermodel.cpp:1076 > +// remember drop target position for target URL and forget about the > source URL > +

D8840: XRandR: Clear EDID data when monitor is disconnected from an output

This revision was automatically updated to reflect the committed changes. Closed by commit R110:a9683661f856: XRandR: Clear EDID data when monitor is disconnected from an output (authored by dvratil). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8840

D8849: [Folder View Filter Config] Use TableView for mime types

broulik added a comment. How about this? F5495201: Screenshot_20171117_104353.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8849 To: broulik, #plasma, #vdg, hein Cc: abetts, plasma-devel, ZrenBot, progwolff, lesl

D8796: Support dynamic output enabling/disabling from KScreen

davidedmundson updated this revision to Diff 22508. davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed KWin. Make sure we always enable monitors before disabling them Never remove the final screen REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D8524: Add a signal notifying a change in the names of running activities.

ivan added a comment. The activities cache is a private class meant to communicate directly to KAMD. The signals it contains are in the form `(activity id, something)` and are meant to be private. The `KActivities::Info` class was meant to wrap these signals into a nice OO API where an activ

D8845: Create tooltipManager on demand

broulik abandoned this revision. broulik added a comment. https://phabricator.kde.org/D8851 gives virtually the same benefit without having to adjust the applications themselves REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D8845 To: broulik, mart Cc: david

D8524: Add a signal notifying a change in the names of running activities.

hein added a comment. Such a class would imho be pretty redundant to the model class, so now it's back to whether David wants to accept this patch or not. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8524 To: hein, #plasma, davidedmundson Cc: davidedmund

D8849: [Folder View Filter Config] Use TableView for mime types

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. If the default sorting isn't on the checkbox, then I'm OK with and accept the original ver (not-so-fond of the variant). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.

D8441: Wallpaper: hide color or blur filling options for full filling mode

broulik added a comment. From what I can tell the wallpaper itself doesn't respect this so we still end up loading the blurry image on the wallpaper, no? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8441 To: guoyunhe, ngraham, jensreuterberg Cc: jensreut

D8849: [Folder View Filter Config] Use TableView for mime types

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7e4f16e8ddfa: [Folder View Filter Config] Use TableView for mime types (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8849?vs=22470&id

D8864: RFC: [MouseEventListener] Allow accepting mouse event

broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY This will keep the event from propagating. Accepting a press event will also not

D8796: Support dynamic output enabling/disabling from KScreen

graesslin added inline comments. INLINE COMMENTS > drm_backend.cpp:553 > +qCWarning(KWIN_DRM) << "Could NOT find DrmOutput matching " > << it.key()->uuid(); > +return; > +} why return? Shouldn't it be a continue? REPOSITORY R108 KWin REVISION DETA

D8866: [Applet Configuration] Switch page on press instead of click

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY That's how `KPageDialog` does it. TEST PLAN Pressed on category, switched to KCM. The "do you want to save

D8864: RFC: [MouseEventListener] Allow accepting mouse event

apol added inline comments. INLINE COMMENTS > mouseeventlistener.h:73 > > +bool accepted() const { return m_accepted; } > +void setAccepted(bool accepted) { `isAccepted`? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D8864 To: broulik, #plasma, hein Cc

D8796: Support dynamic output enabling/disabling from KScreen

davidedmundson added inline comments. INLINE COMMENTS > graesslin wrote in drm_backend.cpp:553 > why return? Shouldn't it be a continue? Can do. Though I'd want to change the existing loop too to keep it consistent. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8796 To

D8869: Don't use a scrollview to display package changelogs

ngraham created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 387036 Don't put the package changelogs in a scrollview, because it introduces some usability issues (see the bug for details) TEST

D8869: Don't use a scrollview to display package changelogs

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. ngraham added reviewers: Discover Software Store, apol. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D8869 To: ngraham, #discover_software_store, apol Cc: plasm

D8869: Don't use a scrollview to display package changelogs

broulik added a comment. Can't the changelog become utterly long? Perhaps a popup/overlay sheet thing would be more appropriate REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D8869 To: ngraham, #discover_software_store, apol Cc: broulik, plasma-devel

D8869: Don't use a scrollview to display package changelogs

apol added a comment. Won't this introduce other usability issues? :/ WRT the patch, it's fine, just remove the RowLayout and put its properties into the label REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D8869 To: ngraham, #discover_software_

D8869: Don't use a scrollview to display package changelogs

ngraham added a comment. If the changelog is like a thousand lines long, you can always just close it again. And I think it would actually be easier to read as one huge box than a tiny scrollview that only shows like 5 lines at a time. Another option would be that clicking on a package t

D8869: Don't use a scrollview to display package changelogs

abetts added a comment. What's the point of having the "open" button if this scrollview is accepted? After all, you won't see much more if you click open and an install button and a package description. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/

D8869: Don't use a scrollview to display package changelogs

ngraham added a comment. IMHO the open button is superfluous for package updates anyway. It takes you to a view that doesn't even show you the changelogs. Perhaps what we should do is the following: - Get rid of the Open button - Make clicking on the package take you to the view th

D8869: Don't use a scrollview to display package changelogs

ngraham updated this revision to Diff 22528. ngraham added a comment. Updating diff REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8869?vs=22526&id=22528 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8869 AFFECTED FILES

D8692: QML mouse cursor KCM and components

mart updated this revision to Diff 22529. mart added a comment. - internal GridView implementation put the whole logic for cell sizes and the background painting as well in a separed control (todo: will then need to be different in plasma mobile) REPOSITORY R119 Plasma Desktop CHANGE

D8692: QML mouse cursor KCM and components

ngraham added a comment. In https://phabricator.kde.org/D8692#168596, @mart wrote: > or perhaps relayout to 2 lines... Yes, that would work too. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8692 To: mart, #plasma Cc: aspotashev, januz, ngraham,

D8526: add a background in ScrollView

mart added a comment. tried a version which provides its own component in the kcm controls for the background problem, still not happy about it. https://phabricator.kde.org/D8692 REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D8526 To: m

D8870: Synchronize the component with the one in Kirigami

apol created this revision. apol added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Using the height property together with paintedHeight had binding loops. REPOSITORY R242 P

D8870: Synchronize the component with the one in Kirigami

broulik added a comment. Are you sure this results in the same "bottom gap" below the item? Perhaps `bottomPadding` (new in Qt 5.6) could help here? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8870 To: apol, #plasma Cc: broulik, plasma-devel,

D8869: Don't use a scrollview to display package changelogs

ngraham updated this revision to Diff 22532. ngraham added a comment. Add a frame around the text if the box is extended REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8869?vs=22528&id=22532 BRANCH master REVISION DETAIL https://phabri

D8869: Don't use a scrollview to display package changelogs

ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D8869 To: ngraham, #discover_software_store, apol Cc: abetts, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol,

D8870: Synchronize the component with the one in Kirigami

apol added a comment. Yes, this works, the code in question was in SystemTray, it looks just fine there. Also I've been using Heading in Discover for months and never saw this issue. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8870 To: apol,

D8869: Don't use a scrollview to display package changelogs

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Okay, let's give it a try and see where this takes us. REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D8869 To: ngraham, #discover_sof

D8869: Don't use a scrollview to display package changelogs

ngraham updated this revision to Diff 22533. ngraham added a comment. Also change "Open" button to say "More Information..." (it's not clear what you were opening before) REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8869?vs=22532&id=22533

D8869: Don't use a scrollview to display package changelogs

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D8869 To: ngraham, #discover_software_store, apol Cc: abetts, broulik, plasma-devel, ZrenBot, prog

D8692: QML mouse cursor KCM and components

mart updated this revision to Diff 22534. mart added a comment. - two rows toolbar if needed REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8692?vs=22529&id=22534 BRANCH kcm-redesign/cursorTheme REVISION DETAIL https://phabricator.kde.org/D8692

D8869: Don't use a scrollview to display package changelogs

ngraham added a comment. @apol Thanks! I made one more change (the text of the "Info") button; does your approval still hold? REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D8869 To: ngraham, #discover_software_store, apol Cc: abetts

D8869: Don't use a scrollview to display package changelogs

apol accepted this revision. apol added a comment. Go for it, master branch. REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D8869 To: ngraham, #discover_software_store, apol Cc: abetts, broulik, plasma-devel, ZrenBot, progwolff, lesli

D8869: Don't use a scrollview to display package changelogs

This revision was automatically updated to reflect the committed changes. Closed by commit R134:732a0ffb2ab0: Don't use a scrollview to display package changelogs (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8869?vs=225

D8706: Fix build with a KWindowSystem framework that doesn't pull QWidget

This revision was automatically updated to reflect the committed changes. Closed by commit R108:db6c7e17e615: Fix build with a KWindowSystem framework that doesn't pull QWidget (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8706?vs=22053&id=22536#toc REPOSITORY R108

D8798: Add xf86-input-libinput support for X11 mouse backend.

ngraham added a comment. @ xuetianweng any update? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8798 To: xuetianweng, ngraham, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8798: Add xf86-input-libinput support for X11 mouse backend.

ngraham added a comment. @xuetianweng any update? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8798 To: xuetianweng, ngraham, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8798: Add xf86-input-libinput support for X11 mouse backend.

xuetianweng updated this revision to Diff 22543. xuetianweng added a comment. Fix based on comment REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8798?vs=22284&id=22543 BRANCH mouse REVISION DETAIL https://phabricator.kde.org/D8798 AFFECTED FI

D8798: Add xf86-input-libinput support for X11 mouse backend.

ngraham accepted this revision. ngraham added a subscriber: rkflx. ngraham added a comment. This revision is now accepted and ready to land. Thanks, looks good. Might wanna wait for at least one more review before committing. Ready for the next patch! REPOSITORY R119 Plasma Desktop BR

D8798: Add xf86-input-libinput support for X11 mouse backend.

apol added a comment. I wanted to test it, but I'm not sure how to. `kcmshell5 input` doesn't give me anything, am I looking at the right place? REPOSITORY R119 Plasma Desktop BRANCH mouse REVISION DETAIL https://phabricator.kde.org/D8798 To: xuetianweng, ngraham, #plasma Cc: apol,

D8870: Synchronize the component with the one in Kirigami

apol updated this revision to Diff 22545. apol added a comment. unrelated things REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8870?vs=22544&id=22545 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8870 AFFECTED FILES

D8858: Fix testWaylandFullscreenShell.

cgiboudeaux updated this revision to Diff 22546. cgiboudeaux added a comment. Add message if the executable wasn't found REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8858?vs=22492&id=22546 BRANCH master REVISION DETAIL https://phabricator.kde.org/D

D8870: Synchronize the component with the one in Kirigami

apol updated this revision to Diff 22544. apol added a comment. Search all frameworks together as components REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8870?vs=22531&id=22544 BRANCH master REVISION DETAIL https://phabricator.kde

D8798: Add xf86-input-libinput support for X11 mouse backend.

ngraham added a comment. $ kcmshell5 touchpad kcm_touchpad: Using X11 backend The file on disk is at `/usr/lib/x86_64-linux-gnu/qt5/plugins/kded_touchpad.so` (on KDE Neon and other Ubuntu-based distros) REPOSITORY R119 Plasma Desktop BRANCH mouse REVISION DETAIL https://ph

D8798: Add xf86-input-libinput support for X11 mouse backend.

apol added a comment. In https://phabricator.kde.org/D8798#169155, @ngraham wrote: > $ kcmshell5 touchpad > kcm_touchpad: Using X11 backend > > > The file on disk is at `/usr/lib/x86_64-linux-gnu/qt5/plugins/kded_touchpad.so` (on KDE Neon and other Ubuntu-based distros)

D8798: Add xf86-input-libinput support for X11 mouse backend.

xuetianweng added a comment. In https://phabricator.kde.org/D8798#169156, @apol wrote: > In https://phabricator.kde.org/D8798#169155, @ngraham wrote: > > > $ kcmshell5 touchpad > > kcm_touchpad: Using X11 backend > > > > > > The file on disk is at `/usr/lib/x86_64-linux-gn