D5931: ColorCorrect Library - for configuring KWin's native color correction (in particular Night Color)

anthonyfieroni added a comment. Ship it in master for 5.12? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5931 To: subdiff, #plasma, davidedmundson Cc: anthonyfieroni, evpokp, davidedmundson, HuShifang, leezu, plasma-devel, ZrenBot, progwolff, lesliezhai,

D8850: Support drag and drop between shared folder view containments

mwolff requested changes to this revision. mwolff added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > foldermodel.cpp:1126 > +// the targetUrl file:// path to a desktop:/ path for mapping > +auto destPath = dropTargetUrl.path();

D8850: Support drag and drop between shared folder view containments

amantia updated this revision to Diff 22679. amantia added a comment. Drop the items to the right screen when dragging from outside of the folder view. I admit it is not the nicest code for finding the final URL (that will be returned by KDirModel), ideas are welcome to improve it. CH

D8850: Support drag and drop between shared folder view containments

amantia updated this revision to Diff 22677. amantia added a comment. - More stricter detection for moving between screens to fix issue when a file is moved/copied out from within a folder of the desktop. - Enable the code only when the folder view is used in a containment Bugs t

D8919: Add explicit AppMenu protocol

graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in appmenu.cpp:178 > Wayland strings can be UTF-8 but DBus service names and object paths can only > be ASCII. > > I figured it was best to avoid any potential locale issues. Fair enough. I wasn't aware of the DBus restric

D8919: Add explicit AppMenu protocol

davidedmundson added inline comments. INLINE COMMENTS > graesslin wrote in appmenu.cpp:178 > why toLatin1? I would expect a toUtf8? Wayland strings can be UTF-8 but DBus service names and object paths can only be ASCII. I figured it was best to avoid any potential locale issues. > graesslin w

D8919: Add explicit AppMenu protocol

broulik added a comment. lgtm REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8919 To: davidedmundson, #plasma Cc: broulik, graesslin, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas,

D8915: Update the proxy to source and source to proxy mapping correctly

mwolff accepted this revision. mwolff added a comment. This revision is now accepted and ready to land. lgtm, but @hein should have a look too BRANCH master REVISION DETAIL https://phabricator.kde.org/D8915 To: amantia, #plasma, hein, mwolff Cc: plasma-devel, ZrenBot, progwolff, lesliezh

D8919: Add explicit AppMenu protocol

graesslin added a comment. Looks good, just a few minor comments. INLINE COMMENTS > appmenu.cpp:178 > +Q_ASSERT(isValid()); > +org_kde_kwin_appmenu_set_address(d->appmenu, serviceName.toLatin1(), > objectPath.toLatin1()); > +} why toLatin1? I would expect a toUtf8? > appmenu.xml:6-

D8916: QML port of fonts kcm

ngraham added a comment. Can you mark this as resolving https://phabricator.kde.org/T7244, so that task will be automatically closed when this goes in? FWIW, the list of all KCM redesign tasks can be found at https://phabricator.kde.org/tag/plasma_kcm_redesign/ REPOSITORY R119 Plasma

D8733: DBus activate KActivityManagerd

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R161 KActivity Manager Service BRANCH master REVISION DETAIL https://phabricator.kde.org/D8733 To: davidedmundson, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D8919: Add explicit AppMenu protocol

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY A protocol that attaches to a surface and contains two strings

D8796: Support dynamic output enabling/disabling from KScreen

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D8796 To: davidedmundson, #plasma, graesslin Cc: ngraham, luebking, broulik, graesslin, plasma-devel, kwin, #kwin, bwowk, Zren

D8816: Show root items in kicker menu

mart added a comment. as it changes the behavior, can you provide a screenshot? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8816 To: lopatin, #plasma Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D8915: Update the proxy to source and source to proxy mapping correctly

amantia updated this revision to Diff 22665. amantia added a comment. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Add uniqueness testing for the maps CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8915?vs=22659&id=22665 BR

D8917: Reduce the amount of spurious property changes on ColorScope

apol created this revision. apol added reviewers: Plasma, mart. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY At the moment whenever something changed we were emitting colorGroupChanged and then e

D8916: QML port of fonts kcm

mart created this revision. mart added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY port the fonts kcm to QML, reviving an old branch. UI based upon https://phabricator.kde.org/M112/411/ make

D8850: Support drag and drop between shared folder view containments

amantia retitled this revision from "WIP: support drag and drop between shared folder view containments" to "Support drag and drop between shared folder view containments". amantia edited the summary of this revision. amantia added reviewers: Plasma, hein. REVISION DETAIL https://phabricator.k

D8914: Remove duplicate boilerplate code

This revision was automatically updated to reflect the committed changes. Closed by commit R242:3e17a2d0a207: Remove duplicate boilerplate code (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8914?vs=22655&id=22660 REVISI

D8914: Remove duplicate boilerplate code

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D8914 To: apol, #plasma, #frameworks, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jens

D8692: QML mouse cursor KCM and components

mart updated this revision to Diff 22658. mart added a comment. - restore Q_DECL_OVERRIDE REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8692?vs=22656&id=22658 BRANCH kcm-redesign/cursorTheme REVISION DETAIL https://phabricator.kde.org/D8692 A

D8850: WIP: support drag and drop between shared folder view containments

amantia updated this revision to Diff 22657. amantia added a comment. Move out fix for proxy to source and remove the change from updateMap CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8850?vs=22632&id=22657 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8850 AFF

D8692: QML mouse cursor KCM and components

mart updated this revision to Diff 22656. mart added a comment. - Merge branch 'master' into kcm-redesign/cursorTheme - remove spurious changes to resync with master REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8692?vs=22649&id=22656 BRANCH kc

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

abetts added a comment. I am ok with that idea. I agree that it is redundant. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart, abetts Cc: ngraham, davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8914: Remove duplicate boilerplate code

apol created this revision. apol added reviewers: Plasma, Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Don't replicate logic present in ::colorGroup for every color() call REPOSITORY R242 Plasm

D8449: Have a default backend (if one available)

ngraham added a comment. @ivan? I know you had some reservations about the UI, but can we discuss those and either merge or abandon this? REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D8449 To: cryptodude, ivan, #plasma Cc: nicolasfella, ngraham, plasma-devel

D8692: QML mouse cursor KCM and components

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in thememodel.cpp:305 > why change these QStringLiterals? Is a rebase needed? yeah, it's so long this review is open that doesn't merge cleanly with master anymore :/ REPOSITORY R119 Plasma Desktop REVISION DETAIL https://

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

ngraham added inline comments. INLINE COMMENTS > main.qml:69 > + > +text: i18n("Enable Task Manager notification") > + "Task Manager notification: [checkbox] Enable Task Manager notification" a bit redundant and overly wordy. How about the following? "Task Manager notification: [ch

D8444: Define default Action when we plug unknown monitor

sebas added a comment. @mlaurent What's your plan with this? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent, davidedmundson Cc: sebas, graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreut

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

ngraham added a comment. Can you add "Resolves https://phabricator.kde.org/T7284"; so this it will close that Maniphest task once this goes in? INLINE COMMENTS > main.qml:49 > + > +text: i18n("Startup indication timeout:") > +} As discussed on https://phabricator

D8692: QML mouse cursor KCM and components

davidedmundson added inline comments. INLINE COMMENTS > GridView.qml:32 > + > +implicitWidth: Math.max( Math.min(parent.width, cellWidth * 2 + > scroll.scrollBarSpace) > +, Math.floor(view.availableWidth / cellWidth) * cellWidth + > scroll.scrollBarSpace + 4) It never ever

D8692: QML mouse cursor KCM and components

mart updated this revision to Diff 22649. mart added a comment. - don't implement own background REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8692?vs=22534&id=22649 BRANCH kcm-redesign/cursorTheme REVISION DETAIL https://phabricator.kde.org/D

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

mart added inline comments. INLINE COMMENTS > main.qml:26 > + > +Kirigami.ScrollablePage { > +id: root i would like to have a base component for this (which admittedly doesn't exists yet as i need beforehand to merge the cursrs stuff which introduced the kcm components) tough for now would

D8526: add a background in ScrollView

This revision was automatically updated to reflect the committed changes. Closed by commit R858:e4e46ff4dbee: add a background in ScrollView (authored by mart). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8526?vs=22647&id=22648 R

D8526: add a background in ScrollView

mart updated this revision to Diff 22647. mart added a comment. - component can't be a child of scrollview REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8526?vs=22639&id=22647 BRANCH arcpatch-D8526_1 REVISION DETAIL https:/

D8006: Add edit button to desktop theme

jensreuterberg added a comment. Sry for not pinging back earlier but this sounds awesome. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D8006 To: davidedmundson, #plasma, apol Cc: jensreuterberg, apol, abetts, ngraham, plasma-devel, ZrenBot,

D8909: Fix uninitialized warning on valgrind

This revision was automatically updated to reflect the committed changes. Closed by commit R115:e39f4e0e2b49: Fix uninitialized warning on valgrind (authored by apol). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8909?vs=22640&id=22643 RE

D8909: Fix uninitialized warning on valgrind

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D8909 To: apol, #plasma, drosca Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterber

D8526: add a background in ScrollView

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Can you throw in a tonne of documentation explaining why things are being done the way they are. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH arcpatch-D852

D8870: Synchronize the component with the one in Kirigami

This revision was automatically updated to reflect the committed changes. Closed by commit R242:aa4aa72d6322: Synchronize the component with the one in Kirigami (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8870?vs=22545

D8909: Fix uninitialized warning on valgrind

apol updated this revision to Diff 22640. apol added a comment. PA_INVALID_INDEX REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8909?vs=22622&id=22640 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8909 AFFECTED FILES

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added inline comments. INLINE COMMENTS > davidedmundson wrote in launchfeedback.cpp:169 > how does plasmashell get notified about new TaskbarButtonSettings? KDirWatch on the rc file iirc Note the old business logic doesn't have any anything more there. REPOSITORY R119 Plasma Desktop RE

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added a comment. Review comments: Some of those also apply to the fonts KCM rewrite I based this on, e.g. the broken bindings. Will fix tomorrow, thanks :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart, abetts Cc: davidedmu

D8526: add a background in ScrollView

mart updated this revision to Diff 22639. mart added a comment. fix fix and replace problems REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8526?vs=22638&id=22639 BRANCH arcpatch-D8526_1 REVISION DETAIL https://phabricator.k

D8526: add a background in ScrollView

mart marked 2 inline comments as done. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D8526 To: mart, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, m

D8526: add a background in ScrollView

mart updated this revision to Diff 22638. mart added a comment. frame background REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8526?vs=22637&id=22638 BRANCH arcpatch-D8526_1 REVISION DETAIL https://phabricator.kde.org/D8526

D8526: add a background in ScrollView

mart updated this revision to Diff 22637. mart added a comment. - create the background only after onCompleted REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8526?vs=21441&id=22637 BRANCH arcpatch-D8526_1 REVISION DETAIL htt

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

davidedmundson added a comment. Your Messages.sh doesn't include qml (copy the code in Marco's mouse diff) - Given you're now familiar with this code, can you look through: https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=CONFIRMED&bug_status=ASSIGNED&bug_s

Minutes Monday Plasma Hangout

Minutes and log, voila! -- sebas http://www.kde.org | http://vizZzion.orgPlasma Meeting 20-11-2017 Present: Sho, notmart, d_ed, bshah, sebas Sho: * Rewrote the Launch Feedback KCM in Qt Quick to start helping Marco with the System Settings workload ** Will go on to do some more I guess * Start

D8787: Fix PWD dialog

cryptodude added a comment. Updated to fix the issues. The leading space was intended, indeed. It makes things look a bit nicer. I also clarified the description, and as to the question if its still valuable. The main change is that the original code was intended to not close the

D8787: Fix PWD dialog

cryptodude updated this revision to Diff 22636. cryptodude edited the summary of this revision. REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8787?vs=22262&id=22636 REVISION DETAIL https://phabricator.kde.org/D8787 AFFECTED FILES kded/CMakeLists.txt

D8449: Have a default backend (if one available)

cryptodude added a comment. > What's the status of this patch? The status is that I don't have a developer account and am waiting on someone to merge this. As this change is practically not doing anything more than making the dialog react to the distro/packagers, I can't think of a

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added a reviewer: abetts. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart, abetts Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added a comment. Screenshot: F5499384: Screenshot_20171120_194949.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added a comment. This is on git as branch kcm-redesign/launchfeedback. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apo

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein updated this revision to Diff 22634. hein added a comment. Add missing package. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8911?vs=22633&id=22634 BRANCH kcm-redesign/launchfeedback REVISION DETAIL https://phabricator.kde.org/D8911 AFF

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

broulik added a comment. I don't see any QML files REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein created this revision. hein added reviewers: Plasma, mart. Restricted Application added a project: Plasma. REVISION SUMMARY - Implements VDG mockup https://phabricator.kde.org/M112/364/ - But using "Task Manager" naming for consistency instead of "Taskbar" - Additional UI tweak of u

D8641: FormLayout

hein added a dependent revision: D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D8641 To: mart, #plasma, #kirigami, hein Cc: broulik, colomar, ngraham, davidedmundson, plasma-devel, ZrenBot, progw

D8850: WIP: support drag and drop between shared folder view containments

amantia added inline comments. INLINE COMMENTS > mwolff wrote in positionertest.cpp:219 > second? this is the first and only one in this test, no? There is one coming from init() (m_folderModel) > mwolff wrote in positionertest.cpp:229 > `QVERIFY` the wait, also below Changed, the rest is actu

D8850: WIP: support drag and drop between shared folder view containments

amantia updated this revision to Diff 22632. amantia added a comment. Clean unit test and code: move out the unique testing part (will be moved to a new patch) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8850?vs=22631&id=22632 BRANCH master REVISION DETAIL https://phabricat

D8850: WIP: support drag and drop between shared folder view containments

mwolff requested changes to this revision. mwolff added a comment. This revision now requires changes to proceed. I guess we should split this patch up into three parts: a) add unit test + the fix you found b) (if still required) enforce uniqueness in `Positoiner::updateMaps` + unit tes

D8850: WIP: support drag and drop between shared folder view containments

amantia updated this revision to Diff 22631. amantia added a comment. Fix uploaded diff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8850?vs=22630&id=22631 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8850 AFFECTED FILES containments/desktop/plugins/folder/au

D8850: WIP: support drag and drop between shared folder view containments

amantia commandeered this revision. amantia edited reviewers, added: mwolff; removed: amantia. amantia added a comment. Commandeered and trying to fix the mess now. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8850 To: amantia, mwolff Cc: broulik, plasma-de

D8850: WIP: support drag and drop between shared folder view containments

mwolff planned changes to this revision. mwolff added a comment. andras, please comandeer this change. and I feel your pain re `arc` usability... phabricator with patch series is a nightmare for developers INLINE COMMENTS > FolderViewLayer.qml:192 > + > +onScreenMappingChanged: { > +

D8850: WIP: support drag and drop between shared folder view containments

amantia updated this revision to Diff 22630. amantia added a comment. Fix problem of having ghost items, fix problem of losing items when an item is moved to a screen and back. Add unit test for the positioner when items are moved between screens. Problem: moving multiple items works,

D8796: Support dynamic output enabling/disabling from KScreen

davidedmundson updated this revision to Diff 22629. davidedmundson added a comment. Restricted Application edited projects, added KWin; removed Plasma. skip monitors in changeset that don't exist without aborting REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D8910: Add Plasma Mobile session

davidedmundson added inline comments. INLINE COMMENTS > loader.qml:28 > property bool willing : true > -property int priority : 10 > +property int priority : currentSession == "plasma-mobile" ? 0 : 10 > Not remotely blocking this commit, but does this actually work? In SDDM, (

D8866: [Applet Configuration] Switch page on press instead of click

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8866 To: broulik, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8870: Synchronize the component with the one in Kirigami

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D8870 To: apol, #plasma, mart Cc: broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-moh

D8910: Add Plasma Mobile session

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R20 Plasma Phone Components BRANCH add-session REVISION DETAIL https://phabricator.kde.org/D8910 To: bshah, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D8909: Fix uninitialized warning on valgrind

drosca requested changes to this revision. drosca added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > stream.cpp:28 > : VolumeObject(parent) > +, m_deviceIndex(std::numeric_limits::max()) > , m_clientIndex(PA_INVALID_INDEX) Should be PA_INVALID_I

D8909: Fix uninitialized warning on valgrind

anthonyfieroni added a reviewer: drosca. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D8909 To: apol, #plasma, drosca Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart