januz retitled this revision from "Add font size setting to the digital clock
plasmoid" to "Use a smaller font size for digital clock plasmoid".
januz edited the summary of this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D6764
To: januz, #plasma,
januz updated this revision to Diff 23710.
januz added a comment.
Reducing the scope of this patch a bit, it now sets the clock fontsize to a
fixed value. This prevents all the layout issues from relative scales. The code
changes now are minimal, so it won't add pile more complexity on the
romangg added inline comments.
INLINE COMMENTS
> broulik wrote in ThumbnailStrip.qml:113
> The thumbnail has *always* been clickable.
>
> The open hand cursor is merely an indicator to show that it's draggable, the
> very reason this feature exists.
> The thumbnail has *always* been
broulik added a comment.
> Or should we remove the "Öffnen/Open" button?
Good idea. However, the "Open" button is created by the application itself
and there's no way of knowing to the application whether the notification
server supports that thumbnail strip that is proprietary to
mvourlakos edited the summary of this revision.
mvourlakos edited the test plan for this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9275
To: mvourlakos, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
mvourlakos created this revision.
mvourlakos added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
--PlasmaComponents.ComboBox now highlights correctly
the selected item and on
romangg requested changes to this revision.
romangg added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> ThumbnailStrip.qml:113
> preventStealing: true
> cursorShape: Qt.OpenHandCursor
> +acceptedButtons: Qt.LeftButton | Qt.RightButton
mvourlakos updated this revision to Diff 23708.
mvourlakos added a comment.
- fix typos
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9275?vs=23707=23708
BRANCH
listrtl
REVISION DETAIL
https://phabricator.kde.org/D9275
AFFECTED
mvourlakos created this revision.
mvourlakos added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
--PlasmaComponents3.ComboBox now appears correctly
its list items in RTL
romangg updated this revision to Diff 23701.
romangg added a comment.
Small fixes.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5932?vs=20969=23701
REVISION DETAIL
https://phabricator.kde.org/D5932
AFFECTED FILES
CMakeLists.txt
romangg updated this revision to Diff 23700.
romangg added a comment.
Simplifiy sun timing calculation (match KWin's calculation).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5931?vs=20970=23700
REVISION DETAIL
romangg added inline comments.
INLINE COMMENTS
> graesslin wrote in constants.h:34-39
> What's the license for this? Looking at the linked readme I do not see any
> license. If the Redshift license applies it would be GPLv3+ which is
> something I have not allowed so far in KWin/Core as it
romangg marked an inline comment as done.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D5928
To: romangg, #kwin, graesslin
Cc: evpokp, HuShifang, jriddell, ngraham, leezu, behrmann, cfeck, graesslin,
davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, alexeymin,
romangg updated this revision to Diff 23698.
romangg marked 10 inline comments as done.
romangg added a comment.
- Cover comments,
- simplify sun timing calculation,
- merge current master
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5928?vs=20972=23698
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9226
To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
hein added a comment.
Adding a comment would be nice, otherwise +1.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9226
To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
anthonyfieroni added inline comments.
INLINE COMMENTS
> main.cpp:1092-1093
>
> intnew_argc = 0;
> -char **new_argv = new char * [40];
> +char **new_argv = new char * [40]; //Memory Leak
>
Remove all references to them, they are unused.
> Viewer.cpp:146
>
davidedmundson added inline comments.
INLINE COMMENTS
> Viewer.cpp:140-143
> if (!first) {
> viewer=new KFI::CViewer;
> viewer->show();
> + delete viewer;
that can't be right.
> kcm.cpp:83-85
>
nathanhenry updated this revision to Diff 23692.
nathanhenry added a comment.
Forgot to remove debug statement
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9271?vs=23691=23692
BRANCH
Memory-Leak-Fixes
REVISION DETAIL
nathanhenry created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Fixed memory leak in oldCorr
Fixed memory leak
Fixed memory leak
REPOSITORY
R119 Plasma Desktop
BRANCH
Memory-Leak-Fixes
ngraham added a comment.
After thinking about it for a while, since this is a more general patch for
all notifications with previews, I think it can be tracked separately from the
default set of buttons that Spectacle displays. That is, even with this, we
could potentially still land
Restricted Application edited projects, added KWin; removed Plasma.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D9216
To: mart, #kwin, #plasma, davidedmundson
Cc: ngraham, davidedmundson, broulik, plasma-devel, kwin, bwowk, ZrenBot,
progwolff, lesliezhai, ali-mohamed,
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
global menu automatically enables itself when there is a visualization present
drop the settings kcm altogether
mart added a dependent revision: D9267: remove menubar settings.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D9216
To: mart, #kwin, #plasma, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, kwin, ZrenBot, progwolff,
lesliezhai, ali-mohamed, jensreuterberg,
mart added a dependent revision: D9267: remove menubar settings.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D9215
To: mart, #plasma
Cc: mvourlakos, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol,
mart marked 4 inline comments as done.
mart added inline comments.
Restricted Application edited projects, added Plasma; removed KWin.
INLINE COMMENTS
> davidedmundson wrote in appmenu.cpp:73
> All this needs fixing.
> (and probably other related methods)
value depends from appmenu service
mart updated this revision to Diff 23680.
mart added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
- make enabled depend from the dbus service presence
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9216?vs=23537=23680
BRANCH
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:604aba0e241f: reuse KPackage instance between
PluginLoader and Applet (authored by mart).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a645d1012293: port logout screen to kpackage fileUrl
(authored by mart).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9195?vs=23602=23677
REVISION
29 matches
Mail list logo
