This revision was automatically updated to reflect the committed changes.
Closed by commit R98:092c590f7a96: Properly check for Breeze GTK 3 theme
existence in kconf_update (authored by fvogt).
REPOSITORY
R98 Breeze for Gtk
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9467?vs=24268
jackg accepted this revision.
REPOSITORY
R98 Breeze for Gtk
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9467
To: fvogt, #plasma, jackg, apol
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, mart
BUILD SUCCESS
Build URL
https://build.kde.org/job/Plasma%20plasma-nm%20stable-kf5-qt5%20SUSEQt5.9/10/
Project:
Plasma plasma-nm stable-kf5-qt5 SUSEQt5.9
Date of build:
Fri, 22 Dec 2017 06:23:29 +
Build duration:
2 min 24 sec and counting
JUnit Tests
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma%20plasma-nm%20stable-kf5-qt5%20SUSEQt5.9/9/
Project:
Plasma plasma-nm stable-kf5-qt5 SUSEQt5.9
Date of build:
Fri, 22 Dec 2017 05:33:52 +
Build duration:
3 min 59 sec and counting
CONSOLE OUTPUT
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/33/
Project:
Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9
Date of build:
Fri, 22 Dec 2017 04:56:50 +
Build duration:
9 min 6 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Plasma%20plasma-nm%20kf5-qt5%20SUSEQt5.9/78/
Project:
Plasma plasma-nm kf5-qt5 SUSEQt5.9
Date of build:
Fri, 22 Dec 2017 04:55:25 +
Build duration:
4 min 0 sec and counting
JUnit Tests
Name: (root
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/32/
Project:
Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9
Date of build:
Fri, 22 Dec 2017 04:11:47 +
Build duration:
10 min and counting
CONSOLE OUTPUT
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma%20plasma-nm%20kf5-qt5%20SUSEQt5.9/77/
Project:
Plasma plasma-nm kf5-qt5 SUSEQt5.9
Date of build:
Fri, 22 Dec 2017 04:11:47 +
Build duration:
5 min 6 sec and counting
CONSOLE OUTPUT
[...trun
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
LGTM
REPOSITORY
R98 Breeze for Gtk
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9467
To: fvogt, #plasma, jackg, apol
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai
2017-12-21 17:48 GMT+02:00 Marco Martin :
> On mercoledì 20 dicembre 2017 19:41:08 CET Michail Vourlakos wrote:
> > Hello everyone,
> >
> > I have created the following: https://phabricator.kde.org/T7622
> > in order to track down the info needed in order for Latte Dock to support
> > properly Pla
2017-12-21 13:36 GMT+02:00 Marco Martin :
>
> > Second question: How Plasma is achieving this drag n' drop of plasmoids
> > between panels and desktop? Do you know where I should look at?
>
> it's reparenting the objects between different views, which can't be done
> across processes
>
>
I thought
fvogt updated this revision to Diff 24268.
fvogt added a comment.
Adress review comments.
REPOSITORY
R98 Breeze for Gtk
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9467?vs=24253&id=24268
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9467
AFFECTED FILES
kco
fvogt marked 3 inline comments as done.
fvogt added inline comments.
INLINE COMMENTS
> apol wrote in main.cpp:161
> Does this need fixing too?
No, that's the location of the config file, which is always
`~/.config/gtk-3.0/settings.ini`. Maybe it can be overwritten, but that would
cause other p
apol requested changes to this revision.
apol added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> main.cpp:37
> + */
> +QString isGtk3ThemeInstalled(QString themeName)
> +{
Seems like it would return a bool.
I would change it to `gtk3ThemeInstalledPath()`. I
Repo freeze is today. This means no more massive new repos being
added/removed.
The final list of repositories in releaseme lists:
bluedevil breeze breeze-grub breeze-gtk breeze-plymouth discover drkonqi
kactivitymanagerd kde-cli-tools kdecoration kde-gtk-config kdeplasma-addons
kgamma5 khotkeys
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D9470
To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abet
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This was the pre-5.8 blurry background that we no longer have.
TEST PLAN
F5561551: Screenshot_20171221_180
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
It currently maps to wl_ouptut. It maps to how Qt does it's DPI painting.
> Report sizes in Output's modes unscaled - the modes don't change with
scaling after
This revision was automatically updated to reflect the committed changes.
Closed by commit R99:9615fc3994f9: Fix minimum height of cursor/icon theme
comboboxes (authored by fvogt).
REPOSITORY
R99 KDE Gtk Configuration Tool
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9457?vs=24232&
This revision was automatically updated to reflect the committed changes.
Closed by commit R99:1ba9f200f0fb: Also list GTK 3 themes without
"gtk-3.0" subfolder (authored by fvogt).
REPOSITORY
R99 KDE Gtk Configuration Tool
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9459?vs=24248&
davidedmundson added a comment.
If I have a 2000x2000 montior at scale 2
I want it to appear the same size as a 1000x1000 monitor at scale 1.
Or in other terms:
We want to see things at their logical size, not their device size.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://ph
fvogt created this revision.
fvogt added reviewers: Plasma, jackg.
Restricted Application added a project: Plasma.
REVISION SUMMARY
The gtk-3.0 directory is not mandatory and is gone.
TEST PLAN
Ran kconf_update_bin/gtkbreeze5.5, settings.ini with Breeze as theme gets
created again.
REPOSITO
dvratil added a comment.
If mode reports resolution 1920x1080, but the screen is scaled by 2, then we
want to show the output rectangle in KCM to be 3840x2160 so that it's in the
correct ratio. If you put the scaled output next to a HiDPI output (3840x2160)
in the KCM the rectangles should b
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
iIf we have your patch with the scaled modes, then we woudln't need to divide
here, sure.
But why would we multiply it??
The size should be the size in norma
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
Go for it then, good riddance of that code. :)
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D9460
To: dvratil, sebas, davidedmundson, apol
Cc: apol, plasma-devel, Zr
dvratil added a comment.
In https://phabricator.kde.org/D9460#182151, @apol wrote:
> In https://phabricator.kde.org/D9460#182139, @dvratil wrote:
>
> > QML is clever enough to re-evaluate the function when `item.rotation` or
dimensions change.
>
>
> Not if it's within `_transfor
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R99 KDE Gtk Configuration Tool
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D9459
To: fvogt, #plasma, lbeltrame, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, je
fvogt updated this revision to Diff 24248.
fvogt added a comment.
arc picked two commits at once...
REPOSITORY
R99 KDE Gtk Configuration Tool
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9459?vs=24247&id=24248
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D
fvogt updated this revision to Diff 24247.
fvogt added a comment.
Use const{Begin,End} and a entryList overload.
REPOSITORY
R99 KDE Gtk Configuration Tool
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9459?vs=24234&id=24247
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabrica
apol added a comment.
In https://phabricator.kde.org/D9460#182139, @dvratil wrote:
> QML is clever enough to re-evaluate the function when `item.rotation` or
dimensions change.
Not if it's within `_transformedSize()`
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricato
fvogt added inline comments.
INLINE COMMENTS
> apol wrote in appearancegtk3.cpp:46
> constBegin/constEnd
I did not touch that, should I still change it?
> apol wrote in appearancegtk3.cpp:49
> The name filters can be the first argument here
Indeed, adjusting.
REPOSITORY
R99 KDE Gtk Configur
dvratil added a comment.
QML is clever enough to re-evaluate the function when `item.rotation` or
dimensions change.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D9460
To: dvratil, sebas, davidedmundson
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-m
On mercoledì 20 dicembre 2017 19:41:08 CET Michail Vourlakos wrote:
> Hello everyone,
>
> I have created the following: https://phabricator.kde.org/T7622
> in order to track down the info needed in order for Latte Dock to support
> properly Plasma Look N. Feel packages.
the packages just allow yo
apol added inline comments.
INLINE COMMENTS
> Output.qml:46
> +
> +width: _transformedSize(monitorMouseArea).width
> +height: _transformedSize(monitorMouseArea).height
If you pass item.rotation as an argument, qml will pick up the change
automatically. Can't rotation change?
REPOSITORY
apol added a comment.
Looks good, some nitpicking.
INLINE COMMENTS
> appearancegtk3.cpp:46
> +QStringList gtk3SubdirPattern{QStringLiteral("gtk-3.*")};
> +for(QFileInfoList::iterator it=availableThemes.begin();
> it!=availableThemes.end(); ++it) {
> +QDir themeDir(it->filePat
dvratil added a dependent revision: D9464: KCM: add support for non-integer
output scaling.
REPOSITORY
R110 KScreen Library
REVISION DETAIL
https://phabricator.kde.org/D9463
To: dvratil, sebas, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
ab
dvratil added a dependency: D9463: XRandR: implement scaling support.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D9464
To: dvratil, sebas, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
dvratil created this revision.
dvratil added reviewers: sebas, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The KCM only supported integer scaling factors, but with XRandR we actually
can
(and want to
dvratil created this revision.
dvratil added reviewers: sebas, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Add support for reading and updating output scaling. Unlike Wayland,
XRandR supports non-inte
dvratil added a dependent revision: D9462: KCM: show scaled outputs correctly.
REPOSITORY
R110 KScreen Library
REVISION DETAIL
https://phabricator.kde.org/D9461
To: dvratil, sebas, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, a
dvratil added a dependency: D9461: Report modes unscaled and geometry scaled.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D9462
To: dvratil, sebas, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
dvratil created this revision.
dvratil added reviewers: sebas, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Since the change in libkscreen modes are now always unscaled, so there's no
need to divide th
This revision was automatically updated to reflect the committed changes.
Closed by commit R133:4180796cd389: Whitelist Switch keyboard layout to
shortcuts (authored by broulik).
REPOSITORY
R133 KScreenLocker
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5331?vs=24222&id=24242
REVI
dvratil created this revision.
dvratil added reviewers: sebas, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Report sizes in Output's modes unscaled - the modes don't change with scaling
after
all. On
dvratil created this revision.
dvratil added reviewers: sebas, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Removes the need for calling QMLOutput::updateRootProperties() from
arbitrary places. This wa
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D5331
To: broulik, #plasma, graesslin
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, ap
fvogt created this revision.
fvogt added reviewers: Plasma, lbeltrame, apol.
Restricted Application added a project: Plasma.
REVISION SUMMARY
It is valid to have themes without support for gtk3 < 3.14.
TEST PLAN
Ran kcmshell5 kde-gtk-config with breeze-gtk from git installed. Now it
appears.
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R99 KDE Gtk Configuration Tool
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D9457
To: fvogt, #plasma, apol, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,
fvogt created this revision.
fvogt added reviewers: Plasma, apol.
Restricted Application added a project: Plasma.
REVISION SUMMARY
The manually specified min height of the group box was smaller than
the default one, so just remove it.
TEST PLAN
Tiny comoboxes before, normalsized comboboxes
broulik updated this revision to Diff 24222.
broulik retitled this revision from "Whitelist all Keyboard Layout Switcher
shortcuts" to "Whitelist Switch keyboard layout to shortcuts shortcuts".
broulik edited the summary of this revision.
REPOSITORY
R133 KScreenLocker
CHANGES SINCE LAST UPDATE
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
In the logout screen we use `activeFocus` to determin which action will be
triggered.
Here you only have t
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:b96fb9f81c14: [Login / Lock screen] Underline button when
focussed (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9431?vs=24208&id=2
broulik abandoned this revision.
broulik added a comment.
I'll look into fixing `KFileItem`
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D5198
To: broulik, #plasma, markg, hein, dfaure
Cc: markg, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
je
This revision was automatically updated to reflect the committed changes.
Closed by commit R116:02684b9041d7: [Connection Item] Use QtQuick's
built-in HSV color features for cycling… (authored by broulik).
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://pha
davidedmundson accepted this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D9431
To: broulik, #plasma, #vdg, davidedmundson
Cc: fabianr, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
broulik abandoned this revision.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D5330
To: broulik, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
On mercoledì 20 dicembre 2017 19:45:09 CET Michail Vourlakos wrote:
> There are Latte users that requested this (
> https://github.com/psifidotos/Latte-Dock/issues/803) in order to not lose
> their applets configuration when moving them between Desktop, Plasma Panels
> and Latte. I am almost certai
broulik updated this revision to Diff 24208.
broulik retitled this revision from "[Login / Lock screen] Highlight button
when focus or hover" to "[Login / Lock screen] Underline button when focussed".
broulik edited the summary of this revision.
broulik edited the test plan for this revision.
REP
This revision was automatically updated to reflect the committed changes.
Closed by commit R99:f624000f8289: [GTK 3 Preview] Don't explicitly set
black background (authored by broulik).
REPOSITORY
R99 KDE Gtk Configuration Tool
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9433?vs=2
This revision was automatically updated to reflect the committed changes.
Closed by commit R99:90f1eeaf3910: Fix temp GTK3 settings path (authored by
broulik).
REPOSITORY
R99 KDE Gtk Configuration Tool
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9434?vs=24169&id=24205
REVISION DE
anthonyfieroni added a reviewer: mart.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D9338
To: anthonyfieroni, davidedmundson, broulik, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
61 matches
Mail list logo
