Re: Plasma and Frameworks Release issue

2018-01-01 Thread Marco Martin
On Tue, Dec 26, 2017 at 5:57 PM, David Edmundson wrote: > For now options are: > - revert that change and #ifdef use of appmenu protocol in kwin > - delay our beta release for a few days (tagging and tarballs can still > happen on the scheduled day) > > Personally I'd favour option 2. aww, tha

D9391: [effects] Add 'Fullscreen' effect

2018-01-01 Thread Vlad Zagorodniy
zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. So, I've tested this effect on Wayland.. Konsole(XWayland, Qt) = F5611762: fullscreen-konsole-xwayland.mp4 Seems, like cross fad

D9391: [effects] Add 'Fullscreen' effect

2018-01-01 Thread Martin Flöser
graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. >> Due to that I personally would prefer if we don't add this for 5.12 or only for Wayland windows. > > Is it okay to support only Wayland? Personally I would prefer to have the code generi

D9549: Horizontally center shadows and make them bigger

2018-01-01 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment. In https://phabricator.kde.org/D9549#184643, @hpereiradacosta wrote: > Hello, my take on the following suggestions: > > > TL;DR, I'd like to see: > > > > - menu shadow size not affected by config dialog > I think menu shadow size shou

D9549: Horizontally center shadows and make them bigger

2018-01-01 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment. Hello, my take on the following suggestions: > TL;DR, I'd like to see: > > - menu shadow size not affected by config dialog I think menu shadow size should be - smaller than window size - scale with the window size (controlled by the spinbo

D9549: Horizontally center shadows and make them bigger

2018-01-01 Thread Nathaniel Graham
ngraham added a comment. I can make the spinbox not affect menus; good catch. This was a pre-existing bug, but it gets bigger with the patch. Increasing the maximum value makes sense. Will do. I'd rather not make this an option, for all the reasons that have already been articulated

D9549: Horizontally center shadows and make them bigger

2018-01-01 Thread Henrik Fehlauer
rkflx added a comment. New year, new look ;) Great work, this looks impressive and solves the left-side usability problem at the same time. The screenshots above show a different shadow size for windows and menus respectively. This is actually something I like, because having a smaller

D9487: [effects/slide] Handle moving clients

2018-01-01 Thread Vlad Zagorodniy
This revision was automatically updated to reflect the committed changes. Closed by commit R108:20780c6f2144: [effects/slide] Handle moving clients (authored by zzag). Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://p

D9487: [effects/slide] Handle moving clients

2018-01-01 Thread Vlad Zagorodniy
zzag closed this revision. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9487 To: zzag, #kwin, #plasma, graesslin Cc: graesslin, plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, ali-mo

D9382: [effects/slide] Add 'Duration' option

2018-01-01 Thread Vlad Zagorodniy
This revision was automatically updated to reflect the committed changes. Closed by commit R108:8a02a802aedc: [effects/slide] Add 'Duration' option (authored by zzag). Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://p

D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked

2018-01-01 Thread Eike Hein
hein added a comment. Sorry Emirald. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564 To: emateli, plasma-devel, #plasma, #vdg Cc: ngraham, davidedmundson, romangg, hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, s

D9474: [Kickoff / Kicker] Move "Add to favorites" entry to the bottom of the context menu

2018-01-01 Thread Eike Hein
hein added a comment. I'll wait for the screenshot, but in general I agree with and like this. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9474 To: broulik, #plasma, hein, ivan Cc: abetts, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9555: Simulate user activity on fake input events

2018-01-01 Thread Martin Flöser
graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9555#184412, @davidedmundson wrote: > Make sure the CMakeLists.txt is bumped if it's not already. > > Note also my frameworks release issue thread that you've