jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.
I think that even 10 seconds is just fine for showing that you are no longer
connected.
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:3567fd347617: [User Switcher] Fix sessions not updating
(authored by fernando).
REPOSITORY
R114 Plasma Addons
CHANG
graesslin accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added KWin; removed Plasma.
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9776
To: davidedmundson, #plasma, graesslin
Cc: plasma-dev
kossebau updated this revision to Diff 25049.
kossebau marked 2 inline comments as done.
kossebau added a comment.
integrate Kai's feedback
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9751?vs=24977&id=25049
BRANCH
allowconfigureweatherproviderqu
kossebau marked 4 inline comments as done.
kossebau added inline comments.
INLINE COMMENTS
> broulik wrote in configWeatherStation.qml:101
> Can you verify that toggling the MenuItem does not break this binding? It
> shouldn't cause much trouble, though, as you only change selected services in
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.
davidedmundson requested review of this revision.
Restricted Application edited projects, added Plasma; re
BUILD SUCCESS
Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/69/
Project:
Plasma discover kf5-qt5 FreeBSDQt5.9
Date of build:
Wed, 10 Jan 2018 01:51:53 +
Build duration:
5 min 18 sec and counting
JUnit Tests
Name:
abetts added a comment.
In https://phabricator.kde.org/D9773#188482, @tomanderson wrote:
> Thanks Andres. Could you also merge this CL for me? I don't have write
permissions for the repo.
Hey Tom,
Thanks for the comment. I will leave this to the dev team. My vote was as
su
tomanderson added a comment.
Thanks Andres. Could you also merge this CL for me? I don't have write
permissions for the repo.
REPOSITORY
R98 Breeze for Gtk
REVISION DETAIL
https://phabricator.kde.org/D9773
To: tomanderson, #breeze, abetts
Cc: plasma-devel, ZrenBot, ngraham, progwolff,
This revision was automatically updated to reflect the committed changes.
Closed by commit R133:c5575734b56e: Remove double margin in KCM UI (authored by
davidedmundson).
REPOSITORY
R133 KScreenLocker
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9769?vs=25033&id=25046
REVISION DET
abetts accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R98 Breeze for Gtk
REVISION DETAIL
https://phabricator.kde.org/D9773
To: tomanderson, #breeze, abetts
Cc: plasma-devel, ZrenBot, ngraham, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, se
tomanderson added a comment.
Here's an image delta:
https://github.com/KDE/breeze-gtk/pull/3#issuecomment-355097594
REPOSITORY
R98 Breeze for Gtk
REVISION DETAIL
https://phabricator.kde.org/D9773
To: tomanderson, #breeze
Cc: plasma-devel, ZrenBot, ngraham, progwolff, lesliezhai, ali-mo
tomanderson created this revision.
tomanderson added a reviewer: Breeze.
tomanderson added a project: Breeze.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
tomanderson requested review of this revision.
REVISION SUMMARY
This patch fixes
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
It's not like QWidgets have changed much since 2007...
REPOSITORY
R133 KScreenLocker
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9769
To: davidedmundson, #plasma, apol
Cc
Hello,
Just a simple mail to share my experience.
In the past, I coded an UPnP Control Point similar at AIVCtrl
(https://github.com/ptstream/QtUPnP).
This control point could access at Spotify and Qobuz servers (after connection,
browse server contents, manage favorites and playlists, ...).
T
Am 2018-01-08 11:13, schrieb Marco Martin:
On Fri, Jan 5, 2018 at 6:24 PM, Martin Flöser
wrote:
Am 2018-01-05 16:11, schrieb Marco Martin:
debugging a bit what happens currently on my machine, i don't seem to
have any event device which libinput_device_switch_has_switch,
however, when i flip
graesslin added inline comments.
INLINE COMMENTS
> tcberner wrote in abstractlocker.cpp:53
> So something ala
>
> - if logingd-runing then logindmessage
> - if consolekit-running then consolekitmessage
> - else falback message
That would be the ultimate solution ;-)
REPOSITORY
R133 KScreenLo
Am 2018-01-09 13:27, schrieb Marco Martin:
On Fri, Jan 5, 2018 at 6:21 PM, Martin Flöser
wrote:
So I would do something like a small class
class TabletModeManager : public QObject, public InputEventSpy
{
};
I'm starting on this direction now, another thing: libinput has the
event for the m
graesslin added inline comments.
Restricted Application edited projects, added KWin; removed Plasma.
INLINE COMMENTS
> tabletmodemanager.cpp:75
> +{
> +m_spy = new TabletModeInputEventSpy(this);
> +input()->installInputEventSpy(m_spy);
please put into initializer.
Also the spy leaks.
>
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
In https://phabricator.kde.org/D9764#188268, @mart wrote:
> one thing i'm wondering, is how to manage dependencies, as ideally we want
most of our apps to make use of this, but can't ask for sur
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:d2a9232ad34f: Pass SwitchEvent from LibInput through KWin
and add to DebugConsole (authored by graesslin).
Restricted Application edited projects, added Plasma; removed KWin.
REPOSITORY
R108 KWin
CH
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
As per http://agateau.com/2007/setmargin0/ an
This revision was automatically updated to reflect the committed changes.
Closed by commit R858:89760fddd4cb: Cache KColorScheme instances (authored by
apol).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D9768?vs=25031&id=25032#toc
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
C
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9768
To: apol, #frameworks, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensr
apol created this revision.
apol added reviewers: Frameworks, mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.
REVISION SUMMARY
This patch catches the few different KColorScheme we use so that e
drosca accepted this revision.
drosca added a comment.
This revision is now accepted and ready to land.
Alright, thanks for the writeup.
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D9726
To: Zren, #plasma, drosca
Cc: drosca, plasma-devel, ZrenBo
broulik added a comment.
We could also split it and keep the 5 seconds till "you are no longer
connected" (when we don't have an active or activating connection, it usually
still sees the network quickly) and then only after 10 or 15 seconds clear the
"connection before suspend" list
REPOSI
broulik created this revision.
broulik added reviewers: Plasma, jgrulich.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
Network Manager nowadays takes forever to reconnect to a
mart edited the test plan for this revision.
Restricted Application edited projects, added KWin; removed Plasma.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D9764
To: mart, #plasma, #kwin
Cc: davidedmundson, plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot,
progwolff,
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ab007182ad3e: [Desktop Containment] Explicitly reject
Firefox tab drops (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9640?vs=24668&i
mart added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
one thing i'm wondering, is how to manage dependencies, as ideally we want
most of our apps to make use of this, but can't ask for sure to depend from
kwin..., which finding the xml would make it an hard
davidedmundson added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
DBus code is all good.
It would be nice if you can run qdbuscpp2xml on the TabletModeManager and
install that .xml file in /usr/share/dbus-1/services it will allow other
programs to ge
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:3a27995220ac: [Image Wallpaper Configuration] Fix check
state for blur / solid color radios (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kd
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9640
To: broulik, #plasma, hein, mart
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, seb
A first draft is in
https://phabricator.kde.org/D9764
as i can't try the real switch yet, for now the setter is exposed via
dbus, which won't be in the end.
then i want to expose that into plasma (i think libplasma, as a
property in corona) then containments/plasmoids will be able to access
it an
mart added reviewers: Plasma, KWin.
Restricted Application edited projects, added Plasma; removed KWin.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D9764
To: mart, #plasma, #kwin
Cc: plasma-devel, kwin, #kwin, Zren
anthonyfieroni added a comment.
@McPain can you provide some debug info from qCDebug(KSCREEN_XRANDR), i don't
have multi screen setup but we can make better fix.
REPOSITORY
R110 KScreen Library
REVISION DETAIL
https://phabricator.kde.org/D9506
To: McPain, sebas, drosca
Cc: anthonyfieron
davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> image.cpp:147-149
> +if (m_ready) {
> +QTimer::singleShot(200, this, &Image::startSlideshow);
> +}
probably don't need that
davidedmundson added a comment.
Meh. If there's nothing by 5.12.0 push it, but hopefully we can get something
better by then.
At a glance, I'd assume it's failing because onFillModelChanged and
onModelChanged are both called during startup resulting in the second one doing
a fade?
INLI
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
Wait for `m_ready` until doing anything. This keeps the slideshow
broulik edited the test plan for this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D9762
To: broulik, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
This avoids fading the image source, or the fill mode, or the sour
McPain added a comment.
In https://phabricator.kde.org/D9506#188118, @sebas wrote:
> And I'm not sure they should. There's a difference between a monitor going
to sleep and a configuration change of a multi screen setup.
>
> Can you please merge this quickly? I'd like to give it some
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D9761
To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abet
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
> Because I do timer.stop() (lines 101ff) when I start dragging, I dont want
it to ever go away while dragging.
So semantically it's not about whether we restart a runni
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
This fixes none of the radios being selected when solid color was
broulik added a comment.
Cool.
> Anyone any insight whether that is worth filing?
QtQuick Controls 1 is basically dead..
INLINE COMMENTS
> configWeatherStation.qml:101
> +checkable: true
> +checked: model.checked
> +onToggled: {
Can y
On Fri, Jan 5, 2018 at 6:21 PM, Martin Flöser wrote:
>
> So I would do something like a small class
>
> class TabletModeManager : public QObject, public InputEventSpy
> {
> };
>
I'm starting on this direction now, another thing: libinput has the
event for the mode change, but is there a way to qu
sebas accepted this revision.
sebas added a comment.
And I'm not sure they should. There's a difference between a monitor going to
sleep and a configuration change of a multi screen setup.
Can you please merge this quickly? I'd like to give it some real-world
exposure, we can always revi
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R846:ba14d04011c6: Add places delegate and places list type
(authored by Aiix).
REPOSITORY
R846 Mycroft Plasma integratio
Aiix created this revision.
Aiix added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Aiix requested review of this revision.
REVISION SUMMARY
REF https://phabricator.kde.org/T7175 Added places delegate and places obje
broulik created this revision.
broulik added reviewers: Plasma, drosca.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
Keeps it from loading all the models and items on startup.
scarpino updated this revision to Diff 24997.
scarpino added a comment.
Store tokenSecret as secret.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9746?vs=24971&id=24997
REVISION DETAIL
https://phabricator.kde.org/D9746
AFFECTED FILES
vpn/openconnect/nm-openconnect-service.h
broulik created this revision.
broulik added reviewers: Plasma, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
Qt's Drag attached property doesn't like it at all when it ge
broulik edited the summary of this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D9735
To: broulik, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
55 matches
Mail list logo
