D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

graesslin resigned from this revision. graesslin added subscribers: fredrik, davidedmundson, mart. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. I would like to see this reviewed by @fredrik, @mart , @davidedmundson and in general the https://ph

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed KWin. Definitely not for 5.12 material with the release this close, but in general I'm in favour of it with the 4 months of testing we'd get if we went with this soon after branching. In general

D9638: [effects] add 'Slide Desktops' effect

zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9638#190031, @graesslin wrote: > as we had quite positive feedback on the replacement idea: could you please rework the patch to replace the old effect? OK.

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25267. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. Implemented the changes that were suggested by anthonyfieroni REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9848?vs=25253

D9845: Fix source actions in the configuration

This revision was automatically updated to reflect the committed changes. Closed by commit R134:86ab5059134a: Fix source actions in the configuration (authored by fvogt). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9845?vs=25245&id=25268 RE

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth marked 13 inline comments as done. anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. These changes were implemented. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin Cc: anthonyfieroni, m

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > davidedmundson wrote in blur.cpp:186 > m_simpleTarget no longer gets updated on screen changes. What do you mean by this? m_simpleTarget works independently form the vector of ren

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9848#190209, @davidedmundson wrote: > In general, I think it makes sense. Academically the change is sound[1] - and the results certainly look good. > [1]https:

D9859: Fix crash when destroying tabletmodemanager

graesslin created this revision. graesslin added reviewers: KWin, Plasma, mart. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin

[kwin] /: Disable KActivities integration on Wayland

Git commit b8f43618478437e52b5e4f7f5cc50d1c689e6b1c by Martin Flöser. Committed on 13/01/2018 at 15:58. Pushed by graesslin into branch 'master'. Disable KActivities integration on Wayland Once again KActivities causes a delay in the startup of KWin. This is not the first time it happens, that ha

D9638: [effects] add 'Slide Desktops' effect

zzag updated this revision to Diff 25273. zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. Replace old slide effect with this one. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9638?vs=24932&id=25273 BRANCH effects/

D9638: [effects] replace old slide effect with a new one

zzag updated this revision to Diff 25274. zzag retitled this revision from "[effects] add 'Slide Desktops' effect" to "[effects] replace old slide effect with a new one". zzag edited the summary of this revision. zzag edited projects, added Plasma; removed KWin. zzag added a comment. Restricted Ap

D9638: [effects] replace old slide effect with a new one

zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. @graesslin: I did some changes to `reconfigure()`(file `effects/slide/slide.cpp`, lines 59-66). Could you please review them? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9638

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin Cc: zzag, anthonyfieroni, mart, davidedmundson, fredrik, ngraham, plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot, progwo

D9861: Use ellipsis on "Add source" menu item because it opens a dialog

ngraham created this revision. ngraham added reviewers: apol, Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY UI elements that open dialogs should use ell

D9861: Use ellipsis on "Add source" menu item because it opens a dialog

ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9861 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9861: Use ellipsis on "Add Source" menu item because it opens a dialog

ngraham retitled this revision from "Use ellipsis on "Add source" menu item because it opens a dialog" to "Use ellipsis on "Add Source" menu item because it opens a dialog". ngraham edited the summary of this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabrica

D9865: Do not call into NETWinInfo in AbstractClient::setSkipPager

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin. REV

D9866: Add support for initial apply rules for skip (taskbar|pager|switcher)

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin. REV

D9865: Do not call into NETWinInfo in AbstractClient::setSkipPager

graesslin added a dependent revision: D9866: Add support for initial apply rules for skip (taskbar|pager|switcher). REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9865 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jens

D9866: Add support for initial apply rules for skip (taskbar|pager|switcher)

graesslin added a dependency: D9865: Do not call into NETWinInfo in AbstractClient::setSkipPager. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9866 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

zzag added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > blur.cpp:135 > +/** > + * Explanation for the magic numbers: > + * Where did they come from? > blur.cpp:160 > +// Dummy data needed, because the blur strength range

D9638: [effects] replace old slide effect with a new one

graesslin added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > slide.cpp:62 > > -const auto d = animationTime( > -SlideConfig::duration() != 0 ? SlideConfig::duration() : 250); > -mTimeLine.setDuration(d); > +m_timeline

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > zzag wrote in blur.cpp:135 > Where did they come from? I came up with these numbers by testing different iteration and offset values. REPOSITORY R108 KWin REVISION DETAIL ht

D9275: fix RTL appearance for ComboBox

safaalfulaij added a comment. Can you please explain why these are needed? I tested plasmacomponents3 and the combobox was working correctly. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25282. anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. Implementing the changes that were suggested by @zzag REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9848?vs=25267&id=2528

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth marked 6 inline comments as done. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin Cc: zzag, anthonyfieroni, mart, davidedmundson, fredrik, ngraham, plasma-devel, kw

D9638: [effects] replace old slide effect with a new one

zzag updated this revision to Diff 25283. zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. Use default duration value when `Duration` is 0. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9638?vs=25274&id=25283 BRANCH

D9638: [effects] replace old slide effect with a new one

zzag marked an inline comment as done. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9638 To: zzag, #vdg, #kwin, #plasma Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, ZrenBot,

D9275: fix RTL appearance for ComboBox

mvourlakos added a comment. In https://phabricator.kde.org/D9275#190441, @safaalfulaij wrote: > Can you please explain why these are needed? I tested plasmacomponents3 and the combobox was working correctly. It wasnt, use english text in the li

D9275: fix RTL appearance for ComboBox

safaalfulaij added a comment. In https://phabricator.kde.org/D9275#190464, @mvourlakos wrote: > In https://phabricator.kde.org/D9275#190441, @safaalfulaij wrote: > > > Can you please explain why these are needed? I tested plasmacomponents3 and the c

D9861: Use ellipsis on "Add Source" menu item because it opens a dialog

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R134 Discover Software Store BRANCH ellipses REVISION DETAIL https://phabricator.kde.org/D9861 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin Cc: zzag, anthonyfieroni, mart, davidedmundson, fredrik, ngraham, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai,

D9275: fix RTL appearance for ComboBox

mvourlakos added a comment. In https://phabricator.kde.org/D9275#190473, @safaalfulaij wrote: > In https://phabricator.kde.org/D9275#190464, @mvourlakos wrote: > > > In https://phabricator.kde.org/D9275#190441, @safaalfulaij wrote: > > > > > Can you please explain why these are nee

D9861: Use ellipsis on "Add Source" menu item because it opens a dialog

ngraham closed this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9861 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25290. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. Fixed a bug where changing resolution would break the blur effect. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9848?vs=

D9850: Remove redundant changeLog field

ngraham updated this revision to Diff 25291. ngraham added a comment. Rename Discover's "Home" page to "Featured Apps" REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9850?vs=25256&id=25291 BRANCH featured-apps REVISION DETAIL https://p

D9850: Remove redundant changeLog field

ngraham updated this revision to Diff 25292. ngraham added a comment. Revert unintentional addition REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9850?vs=25291&id=25292 BRANCH arcpatch-D9850 REVISION DETAIL https://phabricator.kde.org

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

romangg added a comment. Restricted Application edited projects, added Plasma; removed KWin. I think we talked about your patch on IRC some time ago. I'm very happy that you decided to put it up here in Phab for review. Your Kawase blur looks really good in my opinion. That it is also faster

D9868: Rename Discover's "Home" page to "Featured apps"

ngraham created this revision. ngraham added reviewers: apol, Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY A lot of Discover's users don't seem to get

D9868: Rename Discover's "Home" page to "Featured apps"

ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9868 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9792: even slimmer scrollbars

colomar added a comment. Looks great! My only concern would be that in the mouseover state the contrast between the grip and groove is quite low. This could make the two difficult to distinguish, especially for color blind users. Could perhaps the contrast in terms of brightness be increas

D9792: even slimmer scrollbars

ngraham added a comment. In https://phabricator.kde.org/D9792#190538, @colomar wrote: > Looks great! > My only concern would be that in the mouseover state the contrast between the grip and groove is quite low. This could make the two difficult to distinguish, especially for color bli

D9868: Rename Discover's "Home" page to "Featured apps"

ankits added a comment. +1. In fact I'm one of the users who had no idea that home page was for featured apps. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9868 To: ngraham, apol, #discover_software_store Cc: ankits, plasma-devel, ZrenBot, progwol

KDE CI: Plasma plasma-nm kf5-qt5 SUSEQt5.9 - Build # 86 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20plasma-nm%20kf5-qt5%20SUSEQt5.9/86/ Project: Plasma plasma-nm kf5-qt5 SUSEQt5.9 Date of build: Sun, 14 Jan 2018 05:13:14 + Build duration: 3 min 14 sec and counting JUnit Tests Name: (roo

KDE CI: Plasma kdeplasma-addons stable-kf5-qt5 SUSEQt5.9 - Build # 14 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20kdeplasma-addons%20stable-kf5-qt5%20SUSEQt5.9/14/ Project: Plasma kdeplasma-addons stable-kf5-qt5 SUSEQt5.9 Date of build: Sun, 14 Jan 2018 05:12:52 + Build duration: 2 min 55 sec and counting

KDE CI: Plasma oxygen kf5-qt5 SUSEQt5.9 - Build # 54 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20oxygen%20kf5-qt5%20SUSEQt5.9/54/ Project: Plasma oxygen kf5-qt5 SUSEQt5.9 Date of build: Sun, 14 Jan 2018 05:13:16 + Build duration: 8 min 4 sec and counting JUnit Tests Name: (root) Fail

D9275: fix RTL appearance for ComboBox

safaalfulaij added a comment. In https://phabricator.kde.org/D9275#190497, @mvourlakos wrote: > how did you test it? > > I tried in an qml app (Latte dock) by passing the parameter "--reverse"... > If your system is already using in RTL language, have you tried with --reverse?

D9827: [Task Manager] Let badge become pill-shaped and limit to 0 through 9,999 items

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9827 To: broulik, #plasma, #vdg, hein Cc: davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterb

D9839: [Task Manager] Clear smart launcher data when launcher URL changes

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9839 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9817: Adapt to QQuickWindow hover event synthesis & optimize delegate

This revision was automatically updated to reflect the committed changes. Closed by commit R119:1062a6a25d49: Adapt to QQuickWindow hover event synthesis & optimize delegate (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9817?vs=2515

D9866: Add support for initial apply rules for skip (taskbar|pager|switcher)

hein accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin BRANCH shell-client-skip-rules REVISION DETAIL https://phabricator.kde.org/D9866 To: graesslin, #kwin, #plasma, hein Cc: p

D9865: Do not call into NETWinInfo in AbstractClient::setSkipPager

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Restricted Application edited projects, added KWin; removed Plasma. Makes sense. REPOSITORY R108 KWin BRANCH set-skip-switcher-no-call-to-info REVISION DETAIL https://phabricator.kde.org

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 67 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/67/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 14 Jan 2018 07:35:51 + Build duration: 4 min 44 sec and counting CONSOLE OUTP