Re: Plasma-Mycroft is in kdereview

Hi all, Plasma-Mycroft has been in KDE review over a month, there have been a few additions and bug fixes to the plasmoid but nothing major, all fixes have also been made to the build system which were mentioned by Christophe Giboudeaux, I am hoping plasma-mycroft can complete its review soon a

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 74 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/74/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 17 Jan 2018 04:03:40 + Build duration: 10 min and counting CONSOLE OUTPUT

D9930: Require libinput version 1.9

davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed KWin. Edit: please make sure the CI has this before pushing. REPOSITORY R108 KWin BRANCH require-libinput-1-9 REVISION DETAIL https://phabricator.kde.org/D9930 To: graesslin, #kwin, #plasma,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25511. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. Added the .arcconfig file REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9848?vs=25504&id=25511 BRANCH master REVISION

D9930: Require libinput version 1.9

davidedmundson accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin BRANCH require-libinput-1-9 REVISION DETAIL https://phabricator.kde.org/D9930 To: graesslin, #kwin, #plasma, dav

D1231: Add Remote Access interface to KWayland

ngraham added a comment. @graesslin, would you mind reviewing this so we can push forward with the feature? Thanks! REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc: romangg, ngraham, alexeymin, #frameworks, davidedmun

D1230: GBM remote access support for KWin

ngraham added a comment. @graesslin, would you mind reviewing this so we can push forward with the feature? Thanks! REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson, romangg, #kwin Cc: romangg, ngraham, alexeymin, aacid, kwin

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth marked an inline comment as done. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin Cc: luebking, broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson, fredri

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25504. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. Added a new function to GLRenderTarget called `setRenderTargets` With this function I implemented the changes suggested by @fredrik to remove unnecessary

D1230: GBM remote access support for KWin

Kanedias added a comment. @ngraham I'm still waiting for a review to land this REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson, romangg, #kwin Cc: romangg, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson, plasma-devel

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. @ngraham, yes, he didn't review this after changes were made REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc: romangg, ngraham, alexeymin, #frameworks, davidedmundson, plasma-devel, leezu, Zr

D9930: Require libinput version 1.9

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin. REP

D1230: GBM remote access support for KWin

ngraham added a comment. What's the status of this? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson, romangg, #kwin Cc: romangg, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson, plasma-devel, iodelay, bwowk, leezu, Zr

D1231: Add Remote Access interface to KWayland

ngraham added a comment. What's the status of this? Are we waiting for something other than @graesslin's review? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc: romangg, ngraham, alexeymin, #frameworks, davidedmundso

D9414: Implement OSD to select action when unknown monitors is connected

abetts added a comment. Will this OSD need any kind of styling? Or will we just use what was shown above in the screenshot? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9414 To: dvratil, sebas, davidedmundson, #vdg Cc: abetts, broulik, kamathraghavendra, graessli

D9414: Implement OSD to select action when unknown monitors is connected

graesslin added a comment. I just had a look at all the OSD's used and they all have outputOnly set to true. I have to say the idea here is clearly that OSDs should be non-interactive. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9414 To: dvratil, sebas, davided

D9414: Implement OSD to select action when unknown monitors is connected

graesslin added a comment. In https://phabricator.kde.org/D9414#191973, @broulik wrote: > According to KWin code, windows of type `OnScreenDisplay` do not accept focus and don't take keyboard input but they can still be clicked (unless set to `outputOnly`, obviously). The idea of

Re: LTS and Wayland

Am 2018-01-15 23:58, schrieb David Edmundson: That could simply mean avoiding writing Wayland and LTS in the same sentence. Totally fine with that. The only thing I want to have expressed is that Wayland is no longer exclude in KWin. Cheers Martin

D7246: Tooltips

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. I get compile errors: /home/martin/src/kf5/kde/workspace/kdecoration/autotests/mockbridge.cpp: In member function ‘virtual std::unique_ptr MockBridge::createClient(KD

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth marked 13 inline comments as done. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin Cc: luebking, broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson, fredr

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25490. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. Added a new constructor to GLRenderTarget Added a new function `detachTexture()` to GLRenderTarget Implemented most of the changes suggested by @fredrik

D9891: [Style KCM] Sync KConfig before announcing change

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6ae4277121ab: [Style KCM] Sync KConfig before announcing change (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9891?vs=25398&id=25488

D9914: [Folder View] Don't trash local files

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5551d9be17dd: [Folder View] Don't trash local files (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9914?vs=25448&id=25489 REVISION DE

D9414: Implement OSD to select action when unknown monitors is connected

broulik added a comment. According to KWin code, windows of type `OnScreenDisplay` do not accept focus and don't take keyboard input but they can still be clicked (unless set to `outputOnly`, obviously). REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9414 To: dvra

D9414: Implement OSD to select action when unknown monitors is connected

sebas added a comment. In https://phabricator.kde.org/D9414#191971, @dvratil wrote: > In https://phabricator.kde.org/D9414#191653, @broulik wrote: > > > I think `OnScreenDisplay` implies being non-interactive on Wayland > > > I could interact with the dialog on Wayland, so either

D9414: Implement OSD to select action when unknown monitors is connected

dvratil added a comment. In https://phabricator.kde.org/D9414#191653, @broulik wrote: > I think `OnScreenDisplay` implies being non-interactive on Wayland I could interact with the dialog on Wayland, so either it's not implied, or there's a bug in KWin :-) REPOSITORY R104 KScre

D9908: Wayland: add support for output type detection

This revision was automatically updated to reflect the committed changes. Closed by commit R110:b1428d1381e8: Wayland: add support for output type detection (authored by dvratil). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9908?vs=25431&id=25486 R

D9906: Wayland: don't update output configuration if there are no changes

This revision was automatically updated to reflect the committed changes. Closed by commit R110:daf107948d58: Wayland: don't update output configuration if there are no changes (authored by dvratil). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9906?

D9905: Don't create multiple in-process backend instances

This revision was automatically updated to reflect the committed changes. Closed by commit R110:6e37f3034f6c: Don't create multiple in-process backend instances (authored by dvratil). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9905?vs=25427&id=2548

D9904: Wayland: don't share the same Config between backend and clients

This revision was automatically updated to reflect the committed changes. Closed by commit R110:4abdc5b134a3: Wayland: don't share the same Config between backend and clients (authored by dvratil). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9904?vs

D9903: KDED: respond to output being completely removed

This revision was automatically updated to reflect the committed changes. Closed by commit R104:25d030dd0db1: KDED: respond to output being completely removed (authored by dvratil). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9903?vs=25423&id=25482 REVISIO

D9902: KDED: restore output scale from config

This revision was automatically updated to reflect the committed changes. Closed by commit R104:3129f5089ef2: KDED: restore output scale from config (authored by dvratil). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9902?vs=25422&id=25481 REVISION DETAIL

D9908: Wayland: add support for output type detection

sebas accepted this revision. sebas added a comment. This revision is now accepted and ready to land. Nice! REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D9908 To: dvratil, sebas, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezh

D9906: Wayland: don't update output configuration if there are no changes

sebas accepted this revision. sebas added a comment. This revision is now accepted and ready to land. LGTM. REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D9906 To: dvratil, sebas, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezh

D9904: Wayland: don't share the same Config between backend and clients

sebas accepted this revision. sebas added a comment. This revision is now accepted and ready to land. LGTM as well. REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D9904 To: dvratil, sebas, davidedmundson Cc: plasma-devel, ZrenBot, progwolff,

D9903: KDED: respond to output being completely removed

sebas accepted this revision. sebas added a comment. This revision is now accepted and ready to land. Good catch! REPOSITORY R104 KScreen BRANCH master REVISION DETAIL https://phabricator.kde.org/D9903 To: dvratil, sebas, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai

D9463: XRandR: implement scaling support

sebas accepted this revision. sebas added a comment. This revision is now accepted and ready to land. I'm not suitable to review the X11 bits in here, but since you are the former maintainer, I trust you on those. INLINE COMMENTS > config.h:69 > +PerOutputScaling = 1 << 2, ///< The b

D7681: Update human-readable tier designation in API dox

This revision was automatically updated to reflect the committed changes. Closed by commit R169:8a233471fc54: Update human-readable tier designation in API dox (authored by adridg). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7681?vs=19146&id=25479 REVISI

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > fredrik wrote in blur.cpp:145 > Why is this needed? > > I'm probably missing something here, but it looks to me as if the effect > copies the contents of the framebuffer to the h

D8816: Show root items in kicker menu

hein added a comment. He doesn't (as discussed above). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8816 To: lopatin, #plasma, hein Cc: davidedmundson, ngraham, hein, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D8816: Show root items in kicker menu

davidedmundson added a comment. Do you have commit access? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8816 To: lopatin, #plasma, hein Cc: davidedmundson, ngraham, hein, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abet

D8816: Show root items in kicker menu

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8816 To: lopatin, #plasma, hein Cc: ngraham, hein, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abett

D9914: [Folder View] Don't trash local files

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Nice! This was based on older KDE 4 code ... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9914 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolf

D9917: Add New and Polished Animations

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R846:6963245e8619: Add New and Polished Animations (authored by Aiix). REPOSITORY R846 Mycroft Plasma integration CHANGE

D9917: Add New and Polished Animations

Aiix created this revision. Aiix added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Aiix requested review of this revision. REVISION SUMMARY Ref https://phabricator.kde.org/T7762, https://phabricator.kde.org/T7175

D9019: [Calendar] Adjust the calendar toolbar anchors

This revision was automatically updated to reflect the committed changes. Closed by commit R242:55efe5ae6357: [Calendar] Adjust the calendar toolbar anchors (authored by akulichalexandr). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9019?v

D9914: [Folder View] Don't trash local files

broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Send the actual URL (e.g. `desktop:/foo`) to KIO and let it f

Re: LTS and Wayland

On lunedì 15 gennaio 2018 23:58:40 CET David Edmundson wrote: > I want to stick very clear from writing "our wayland support is LTS" on the > annoucement. > > That could simply mean avoiding writing Wayland and LTS in the same > sentence. +1 for that, we threat it as such, but we don't put it in t

D9892: cmake: Use the official CMake variable for building as a static plugin.

apol added a comment. In https://phabricator.kde.org/D9892#191707, @mart wrote: > In https://phabricator.kde.org/D9892#191590, @apol wrote: > > > I wonder if it would make sense to always ship the qml files as qrc in the plugin. Have you considered it? > > > may make sense...

D9892: cmake: Use the official CMake variable for building as a static plugin.

mart added a comment. In https://phabricator.kde.org/D9892#191590, @apol wrote: > I wonder if it would make sense to always ship the qml files as qrc in the plugin. Have you considered it? may make sense... i would save it for another poatch tough this is big enough already :)

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

fredrik added a comment. Restricted Application edited projects, added Plasma; removed KWin. Don't forget to add your name to the license headers. INLINE COMMENTS > blur.cpp:46 > m_simpleShader = > ShaderManager::instance()->generateShaderFromResources(ShaderTrait::MapTexture, > QStrin

D9506: milti-screen sleep fix

McPain added a comment. I noticed that "shutdown" sequence is not the same as "standby" one. Shutdown for secondary: disconnect -> remove crtc -> connect -> assign crtc Standby for secondary: disconnect -> connect (why?) -> remove crtc -> assign crtc REPOSITORY R110 KScreen Librar