apol added a comment.
LGTM
INLINE COMMENTS
> kuserproxy.cpp:66
> +if (path == m_user.faceIconPath() || path == QDir::homePath() +
> QLatin1String("/.face.icon")
> +|| path == accountsServiceIconPath + QLatin1String("/") +
> m_user.loginName()) {
> // we need to forc
fredrik added inline comments.
Restricted Application edited projects, added KWin; removed Plasma.
INLINE COMMENTS
> blur.cpp:30
> #include
> +#include
>
Is this still needed when qPow() is not used?
> anemeth wrote in blur.cpp:145
> This texture is only used by `copyScreenSampleTexture()`
Kanedias added a dependent revision: D9708: Add progress loading icon to
QtQuick server row.
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETAIL
https://phabricator.kde.org/D9804
To: Kanedias, mart
Cc: alexeymin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jen
cfeck closed this revision.
cfeck added a comment.
Thanks. Next time, please use the 'Differential Revision' line as explained
in our commit templates to automatically close it.
REPOSITORY
R105 KDE SSH Password Dialog
REVISION DETAIL
https://phabricator.kde.org/D9874
To: pali, apol
Cc:
pali added a comment.
done.
REPOSITORY
R105 KDE SSH Password Dialog
REVISION DETAIL
https://phabricator.kde.org/D9874
To: pali, apol
Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
cfeck added a comment.
Please only commit to 5.12 branch if you also merge to master afterwards.
REPOSITORY
R105 KDE SSH Password Dialog
REVISION DETAIL
https://phabricator.kde.org/D9874
To: pali, apol
Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg,
pali added a comment.
Ok, into which branch should I commit this patch? master or Plasma/5.12?
REPOSITORY
R105 KDE SSH Password Dialog
REVISION DETAIL
https://phabricator.kde.org/D9874
To: pali, apol
Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, a
cfeck added a comment.
We assumed you have commit access. If you do not, please state so.
REPOSITORY
R105 KDE SSH Password Dialog
REVISION DETAIL
https://phabricator.kde.org/D9874
To: pali, apol
Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts
pali added a comment.
Anything else is needed for merging it?
REPOSITORY
R105 KDE SSH Password Dialog
REVISION DETAIL
https://phabricator.kde.org/D9874
To: pali, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
Kanedias added a comment.
@romangg , let's go with following approach: I'll upstream all changes I have
left hanging (e.g. https://phabricator.kde.org/D9708) by the end of this week
and will try to come up with some PoC work with PipeWire solution this/next
weekend.
After it is working we'
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
The avatar can also lie in the accounts serv
broulik edited the test plan for this revision.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D9951
To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
broulik edited the test plan for this revision.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D9951
To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
anemeth updated this revision to Diff 25551.
anemeth added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
With one of my previous changes I accidentally introduced an extended blur
effect.
Not it's corrected.
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
Hi,
Valorie, do we have until 23rd with project ideas? I didn't want to mentor
this year because I only was a GSoC student last year, but since there are
not yet many ideas from Plasma/KWin I might do it anyway.
Nate, I want to get a rework of the Wayland Mouse KCM already into Plasma
5.13. But t
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:aa2e5c5f68ca: [AppMenu Applet] Underline mnemonics only
while Alt is pressed (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9948?vs=
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D9948
To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abet
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
This makes for a less cluttered appearance and is what Breeze does
Restricted Application edited projects, added Plasma; removed KWin.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D9944
To: mart, #kwin, #plasma
Cc: ngraham, davidedmundson, plasma-devel, kwin, ZrenBot, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ap
ngraham edited the summary of this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9945
To: hein, #plasma
Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
cfeck added a comment.
This partly fixes the issue. After applying this I can still reproduce by
moving the mouse from the textual list to the favorite icons, or from the list
to the gap between the list and the search box.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabrica
mart added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
api-wise on the dbus side, could also be done that the interface being there
means the switch is possible, otherwise doesn't get registered/destroyed
REPOSITORY
R108 KWin
REVISION DETAIL
https://pha
mart added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
In https://phabricator.kde.org/D9944#192397, @davidedmundson wrote:
> 2. trying to be a canonical source of what mode a device is in from all
information available (which currently happens to be the
hein created this revision.
hein added a reviewer: Plasma.
Restricted Application added a project: Plasma.
hein requested review of this revision.
REVISION SUMMARY
Fixes a refactoring regression from
https://phabricator.kde.org/R119:84f1cb1c18024ed84421ce5afafa87f3b98d3e09.
There's an unre
davidedmundson added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
In terms of goals, is this interface:
1. about exposing the raw switch data that we have from libinput
2. trying to be a canonical source of what mode a device is in from all
informati
McPain updated this revision to Diff 25539.
McPain added a comment.
Fix autotests build
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7246?vs=25145&id=25539
REVISION DETAIL
https://phabricator.kde.org/D7246
AFFECTED FILES
CMakeLists.txt
autotests/mockclient.cpp
autotests/m
hein added a comment.
Nah, I think a config option isn't necessary.
New task.
Unfortunately you narrowly missed 5.12. It was branched with the beta
release, so new features must go to master (5.13) now.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/
lopatin added a comment.
Good! Yes, I do. Some questions:
1. Should I add an option to enable/disable this flag from config?
2. Should I create new task in phabricator or post diff here?
3. Is there any chance that this code will land to Plasma/5.12?
REPOSITORY
R119 Plasma Desktop
romangg added a reviewer: romangg.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D1231
To: Kanedias, graesslin, davidedmundson, romangg
Cc: jgrulich, romangg, ngraham, alexeymin, #frameworks, davidedmundson,
plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-moh
romangg added a comment.
I talked to @graesslin some time ago and he said, that @davidedmundson and I
should do the review.
My plan is to get this review going after 5.12 has landed. For Plasma 5.13
then.
I would like to see at least some progress regarding PipeWire before that
tho
bin/kdesu does not come from us, I guess it's one of those distro
symlink Andreas was talking about
https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20SUSEQt5.9/12/console
On Wed, Jan 17, 2018 at 1:07 PM, Alexey Andreyev
wrote:
> Hello!
>
> command: "which kdesu" returns "/usr/bin/kdesu
On Wed, Jan 17, 2018 at 10:33 AM, Marco Martin wrote:
> Another thing that i think would be needed, is to detect if the tabet mode
> switch is present at all on the hardware (my use case would be wether show
> options related to that on the gui side) is that possible at all, in libinput
> or other
mart created this revision.
mart added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
mart requested review of this revision.
Restricted Application edited projects, added Plasma; removed KWin.
REVISION SUMMARY
Hello!
command: "which kdesu" returns "/usr/bin/kdesu" for my archlinux
command "readlink -f /usr/bin/kdesu" returns "/usr/lib/kf5/kdesu"
so maybe "readlink -f `which kdesu`" is what you are searching for?
2018-01-17 14:43 GMT+03:00 Harald Sitter :
> Moin
>
> I am currently trying to invoke kd
On Wednesday, 17 January 2018 at 12:43, Harald Sitter wrote:
> Should this bugger maybe be in bin/ rather than libexec/?
Historically, it was moved around between bin and libexec at least once, but
ultimately ended up in libexec because 'it should not be available in std.
path'. (Some) distribut
Moin
I am currently trying to invoke kdesu from a script and having some
trouble wrapping my head around how to actually find it in the file
system.
On neon (and all debians) we have it in
/usr/lib/x86_64-linux-gnu/libexec/kf5/kdesu
That is: libexec/kf5 inside the libdir of ECM (I think)
Now ho
sebas added a comment.
@dvratil that's much appreciated (I made that same mistake ;-))
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D9462
To: dvratil, sebas, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, seba
dvratil added a comment.
Indeed, I'll rework the whole scaling thing to abstract away the difference
between scaling in Wayland and in X11 including the UI side (it's not related
to the OSD changes, I'm just trying to work around my silly decision to get a
hi-dpi monitor alongside a regular
sebas added a comment.
Also, any UI change needs screenshots attached how it looks with the change.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D9464
To: dvratil, sebas, davidedmundson
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensre
sebas added a comment.
I agree with David, scaling the output makes the previewed "device" smaller.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D9462
To: dvratil, sebas, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
davidedmundson added a comment.
I handle scaling everyewhere except for Plasma which does it's own thing.
I'm not convinced by this patch:
If this was Qt's devicePixelRatio this would definitely 100% make sense as
there we write all UI code in logical sizes.
But in Pla
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/75/
Project:
Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9
Date of build:
Wed, 17 Jan 2018 09:34:49 +
Build duration:
5 min 35 sec and counting
CONSOLE OUTP
hein added a comment.
It's in! Do you want to work on the follow-up patch to Kicker and Kickoff to
set the property?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8816
To: lopatin, #plasma, hein
Cc: davidedmundson, ngraham, hein, mart, plasma-devel, ZrenBot
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:6108ce125bef: Show root items in kicker menu (authored by
lopatin, committed by hein).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8816?vs=25414&id=25529
On giovedì 4 gennaio 2018 23:22:43 CET Marco Martin wrote:
> Hi all,
> one thing i wanted to look into, is to detect when a trasformable laptop
> goes in tablet mode from applications, so that plasmashell and kirigami
> apps can adapt themselves and do things(tm)
> KWin does that (on wayland) alrea
On mercoledì 17 gennaio 2018 06:46:16 CET Aditya Mehra wrote:
> Hi all,
>
> Plasma-Mycroft has been in KDE review over a month, there have been a few
> additions and bug fixes to the plasmoid but nothing major, all fixes have
> also been made to the build system which were mentioned by Christophe
hein added a reviewer: davidedmundson.
hein added a comment.
I think this needs David
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9286
To: mart, #plasma, davidedmundson
Cc: hein, broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezha
broulik added a comment.
Ping
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9286
To: mart, #plasma
Cc: broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
sebas added a comment.
In https://phabricator.kde.org/D9414#192009, @abetts wrote:
> Will this OSD need any kind of styling? Or will we just use what was shown
above in the screenshot?
We're open to mockups, of course. :)
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabr
49 matches
Mail list logo