D10083: [Look and Feel] Reverse the button order

safaalfulaij added a comment. Yes I do. But shall we ask VDG or not? REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D10083 To: safaalfulaij, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai,

D10092: [Examples] Fix build

broulik edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10092 To: broulik, #plasma, rjvbb Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10092: [Examples] Fix build

broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added reviewers: Plasma, rjvbb. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R242 Plasma Framework (Library) REVISION

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 92 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/92/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 25 Jan 2018 07:00:29 + Build duration: 10 min and counting JUnit Tests

D10083: [Look and Feel] Reverse the button order

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Do you have commit access? REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D10083 To: safaalfulaij, #plasma, davidedmundson

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 91 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/91/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 25 Jan 2018 06:30:07 + Build duration: 3 min 22 sec and counting CONSOLE

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 90 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/90/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 25 Jan 2018 06:19:58 + Build duration: 9 min 32 sec and counting JUnit

D9976: Display version alongside source, and use a combobox to switch between them

ngraham abandoned this revision. ngraham added a comment. Source-and-version-unification patch: https://phabricator.kde.org/D10091 Will produce a ComboBox patch if and when that's accepted, as it doesn't make as much sense without first unifying the source and version. REPOSITORY R134

D10091: Combine source and version into a single piece of metadata

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10091 To: ngraham, apol, #discover_software_store, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D10091: Combine source and version into a single piece of metadata

ngraham created this revision. ngraham added reviewers: apol, Discover Software Store, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Version and Source are linked

D9638: [effects] replace old slide effect with a new one

zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. I think this effect is ready for testing. Yet, I would like to have some clipping but it seems like there is no way to do this with current implementation of `Scene::paintGenericScreen`. REPOSITORY

Re: Fonts KCM translation file renamed

Yuri Chornoivan ha scritto: > Hi, > > Due to the QML migration, it is necessary to rename kde-workspace/kcmfonts.po > into kde-workspace/kcm_fonts.po (kf5-based trunk) to get the KCM translated. > Can somebody move the files accordingly? > I'm going to move it, and CC plasma-devel (it's the

D9638: [effects] replace old slide effect with a new one

zzag updated this revision to Diff 25915. zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. - Rebase onto master - Do not populate a list of fullscreen windows if the 'Slide docks' checkbox is unchecked. REPOSITORY R108 KWin CHANGES SINCE LAST

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 89 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/89/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 24 Jan 2018 21:30:11 + Build duration: 3 min 19 sec and counting CONSOLE

D10080: ensure the rounded rectangle of scrollbard stays round

hpereiradacosta added inline comments. INLINE COMMENTS > breezehelper.cpp:1262 > +const qreal radius( qMin( (qreal)qMin(rect.width(), rect.height() ) > / 2.0, 0.5*Metrics::ScrollBar_SliderWidth ) ); > > // content std::min( { a, b, c } ) would look nicer than qMin( qMin)

D10084: Make the messages translatable

yurchor updated this revision to Diff 25908. yurchor edited the summary of this revision. REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10084?vs=25903=25908 REVISION DETAIL https://phabricator.kde.org/D10084 AFFECTED FILES

D10087: Fix support for Google Apps grouping under Google chrome icon

pecigonzalo edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10087 To: pecigonzalo Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10084: Make the messages translatable

aacid added inline comments. INLINE COMMENTS > CMakeLists.txt:71 > + > +find_package(KF5I18n CONFIG REQUIRED) > +ki18n_install(po) isn't this already on line 41? REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D10084 To: yurchor, #plasma, graesslin,

D10087: Fix support for Google Apps grouping under Google chrome icon

pecigonzalo created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. pecigonzalo requested review of this revision. REVISION SUMMARY I just wanted to share that I found a fix for the issue mentioned here:

D10084: Make the messages translatable

yurchor created this revision. yurchor added reviewers: Plasma, graesslin, Localization. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. yurchor requested review of this revision. REVISION SUMMARY Currently, there is no extraction of

D10083: [Look and Feel] Reverse the button order

safaalfulaij updated this revision to Diff 25902. safaalfulaij added a comment. Leftover REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10083?vs=25901=25902 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10083 AFFECTED FILES

D10083: [Look and Feel] Reverse the button order

safaalfulaij added a comment. Look and feel: F5673030: Screenshot_٢٠١٨٠١٢٤_٢١٠٧٠٢.png Other KCMs: F5673029: Screenshot_٢٠١٨٠١٢٤_٢١٠٧١٠.png REPOSITORY R119 Plasma Desktop REVISION DETAIL

D10083: [Look and Feel] Reverse the button order

safaalfulaij created this revision. safaalfulaij added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. safaalfulaij requested review of this revision. REVISION SUMMARY The look and feel KCM is using a different button

D10040: Add serial number and EISA ID to OutputDevice interface

graesslin requested changes to this revision. graesslin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > outputdevice.xml:104-107 > + + summary="textual representation of serial number"/> > + + summary="textual

D9944: Expose if the tablet mode switch is available

graesslin accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin BRANCH phab/tabletModeSupported REVISION DETAIL https://phabricator.kde.org/D9944 To: mart, #kwin, #plasma,

D9671: Show only available profiles in Pulseaudio KCM

nicolasfella added a comment. Feel free to take over, I can't promise to finish it anytime soon REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D9671 To: nicolasfella, #plasma, drosca Cc: plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai,

D10066: Add touchpad shortcuts to the whitelist

graesslin accepted this revision. graesslin added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > dos wrote in globalaccel.cpp:59 > I've just tested it (with 5.11.95) and it does work on Wayland. In that case: sorry for the noise. REPOSITORY R133

D8481: Adjusted scrollbars to fit the Qt theme

dos reclaimed this revision. dos added a comment. Turns out the scrollbar now got changed indeed and is going to be configurable in 5.13, including extra slim option like the one this implements. So, I'm reopening this now, although it sure will need some adjustments. REPOSITORY R98

D10080: ensure the rounded rectangle of scrollbard stays round

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Great Yaynessings REPOSITORY R31 Breeze BRANCH phab/roudedsmallscroll REVISION DETAIL https://phabricator.kde.org/D10080 To: mart, #plasma, #vdg, hpereiradacosta, hein Cc: hein,

D10080: ensure the rounded rectangle of scrollbard stays round

mart added a comment. F5672295: Spectacle.PE1496.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10080 To: mart, #plasma, #vdg, hpereiradacosta Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10080: ensure the rounded rectangle of scrollbard stays round

mart added a reviewer: hpereiradacosta. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10080 To: mart, #plasma, #vdg, hpereiradacosta Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10080: ensure the rounded rectangle of scrollbard stays round

mart created this revision. mart added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY with the new very slim scrollbars, the rounded rectangle could go to

D10024: Add supportedSchemes feature

mwolff added a comment. In https://phabricator.kde.org/D10024#194708, @mart wrote: > ship it with the extra check Aleix noted Can you guys explain me more what would be required for KIOSK support? REPOSITORY R241 KIO BRANCH master REVISION DETAIL

D10024: Add supportedSchemes feature

mwolff updated this revision to Diff 25891. mwolff added a comment. extend apidox, mention empty list == everything allowed REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10024?vs=25764=25891 BRANCH master REVISION DETAIL

D9976: Display version alongside source, and use a combobox to switch between them

ngraham added inline comments. INLINE COMMENTS > apol wrote in PackageKitResource.cpp:126 > Seems like we are hitting a bug in PackageKit-Qt here, this is not right. I filed a bug on them and they said they expect us to process the string. REPOSITORY R134 Discover Software Store REVISION

D9976: Display version alongside source, and use a combobox to switch between them

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9976 To: ngraham, apol, colomar, abetts, #discover_software_store, #vdg, andreaska Cc: plasma-devel, romangg,

D9976: Display version alongside source, and use a combobox to switch between them

apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. I think it's premature the adoption of the combo box, adding the version could make sense. INLINE COMMENTS > PackageKitResource.cpp:126 > +// PackageKit folks expect us to

D10079: Port baloo krunner plugin to KDBusRunner

kossebau added a dependency: D10078: Add separate lib KF5::DBusRunner. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10079 To: kossebau, davidedmundson, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D10079: Port baloo krunner plugin to KDBusRunner

kossebau created this revision. kossebau added reviewers: davidedmundson, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH

D9976: Display version alongside source, and use a combobox to switch between them

ngraham updated this revision to Diff 25887. ngraham added a comment. - Merge branch 'master' into arcpatch-D9976 REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9976?vs=25692=25887 BRANCH arcpatch-D9976 REVISION DETAIL

D10032: Swap play/pause icons in mediacontroller plasmoid

ngraham added a comment. No, it doesn't have to be in a circle, and now that I think about it, I would probably prefer that it isn't, to further reduce similarity to the icons used for controlling playback. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D10077: [Default Tooltip] Fix sizing

broulik edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10077 To: broulik, #plasma, #vdg Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10077: [Default Tooltip] Fix sizing

broulik created this revision. broulik added reviewers: Plasma, VDG. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. broulik requested review of this revision. REVISION SUMMARY Unset the Label's default height which

D9671: Show only available profiles in Pulseaudio KCM

drosca added a comment. I'd like to have this in, do you think you could finish it? If not, I will take over. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D9671 To: nicolasfella, #plasma, drosca Cc: plasma-devel, #plasma, ZrenBot, progwolff,

D10032: Swap play/pause icons in mediacontroller plasmoid

davidedmundson added a comment. @ngraham Works for me. (it should totally change to http://www.clker.com/cliparts/x/U/a/2/3/I/quarter-rest-black-no-stroke.svg when it's paused /s) Is there a logic behind our current status icon (and the new icon) being in a circle? No other

D10074: parametrize qqc2 version

This revision was automatically updated to reflect the committed changes. Closed by commit R242:f9061787136e: parametrize qqc2 version (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10074?vs=25878=25879 REVISION DETAIL

D10074: parametrize qqc2 version

bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/qqcversion REVISION DETAIL https://phabricator.kde.org/D10074 To: mart, #plasma, bshah Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,

D10074: parametrize qqc2 version

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. mart requested review of this revision. REVISION SUMMARY for styles in order to work at all they need to

D10066: Add touchpad shortcuts to the whitelist

dos added inline comments. INLINE COMMENTS > graesslin wrote in globalaccel.cpp:59 > This won't work on Wayland as there KWin holds the shortcut. I've just tested it (with 5.11.95) and it does work on Wayland. REPOSITORY R133 KScreenLocker REVISION DETAIL

D9944: Expose if the tablet mode switch is available

mart retitled this revision from "[WIP]expose if the tablet mode switch is available" to "Expose if the tablet mode switch is available". Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9944 To: mart,

D9944: [WIP]expose if the tablet mode switch is available

mart marked 3 inline comments as done. mart added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > graesslin wrote in tabletmodemanager.cpp:87-96 > I meant the method setTabletModeAvailable, your reply seems to be for >

D9944: [WIP]expose if the tablet mode switch is available

mart marked an inline comment as done. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9944 To: mart, #kwin, #plasma Cc: graesslin, ngraham, davidedmundson, plasma-devel, kwin, iodelay, bwowk, ZrenBot,

D9944: [WIP]expose if the tablet mode switch is available

mart updated this revision to Diff 25865. mart added a comment. Restricted Application edited projects, added KWin; removed Plasma. - Merge branch 'master' into phab/tabletModeSupported - remove unneeded method REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D10032: Swap play/pause icons in mediacontroller plasmoid

broulik added a comment. I wouldn't recognize a musical note as something "playing", it could be a video. Not very happy with that suggestion, either. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10032 To: nicolasfella, #plasma, #vdg Cc: abetts,

D10025: Use KFileWidget::setSupportedSchemes when available

dfaure accepted this revision. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D10025 To: mwolff, dfaure, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10024: Add supportedSchemes feature

dfaure added inline comments. INLINE COMMENTS > kfilewidget.h:498 > +/** > + * Set the URL schemes that the file widget should allow navigating to. > + * All of these public methods should indicate that the default list is *empty* and that empty means "all schemes are supported". I