apol added inline comments.
INLINE COMMENTS
> ApplicationPage.qml:39
> +readonly property string donationURL: application.donationURL
> +readonly property string version: appInfo.application.isInstalled ?
> appInfo.application.installedVersion : appInfo.application.availableVersion
> +
ngraham edited the test plan for this revision.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D10131
To: ngraham, apol, #discover_software_store
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
ngraham marked 3 inline comments as done.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D10131
To: ngraham, apol, #discover_software_store
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
ngraham updated this revision to Diff 26024.
ngraham added a comment.
- Don't create unnecessary stub functions
- Don't unnecessarily re-define variables ApplicationPage.qml
- Show all the new URLs by default (when available)
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UP
ngraham edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10114
To: ijanssen, #plasma, dfaure
Cc: aacid, broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
aacid added a comment.
autotest possible?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10114
To: ijanssen, #plasma, dfaure
Cc: aacid, broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
apol added inline comments.
INLINE COMMENTS
> ApplicationPage.qml:337
> +readonly property string helpURL: application.helpURL
> +visible: helpURL.length > 0
> +text: helpURL
No need to put it in a separte property. And specially don't add the exac
apol added inline comments.
INLINE COMMENTS
> AbstractResource.h:134
> +///@returns a URL that points to the app's online documentation
> +virtual QUrl helpURL() = 0;
> +///@returns a URL that points to the place where you can file a bug
Maybe they could return an empty u
ngraham added a comment.
(for master, since it includes a string change)
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D10131
To: ngraham, apol, #discover_software_store
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
ngraham edited the test plan for this revision.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D10131
To: ngraham, apol, #discover_software_store
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
ngraham created this revision.
ngraham added reviewers: apol, Discover Software Store.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
Make the help, bug tracker, and donation URL
bshah added subscribers: broulik, hein.
bshah added a comment.
In https://phabricator.kde.org/D10118#196581, @graesslin wrote:
> I never had noticed any problems when compiling the code. Could it be that
the CI system changed (e.g. newer compiler?) I would find it sad to lose this
very u
abetts added a comment.
Is this change purely a conversation of what developers use in code to call
up fonts in their applications? Or does this also include a discussion where
regular users have interfaces that allow changes to font naming? Let's say,
something like System Settings that wou
ngraham edited the summary of this revision.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D9070
To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure
Cc: anthonyfieroni, ngraham, cfeck, fvogt, plasma-devel, ZrenBot, progwolf
ngraham added a comment.
Does anyone have strong objections to landing this?
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D9070
To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure
Cc: anthonyfieroni, ngraham, cfeck, fv
graesslin added a comment.
I never had noticed any problems when compiling the code. Could it be that
the CI system changed (e.g. newer compiler?) I would find it sad to lose this
very useful feature (which might in fact not be exposed enough)
REPOSITORY
R119 Plasma Desktop
REVISION DETAI
zzag added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
I'll try to build Plasma on my host. I hope `startplasmacompositor` will
launch full Plasma session.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D9638
To: zzag, #vdg, #kwin, #p
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
In https://phabricator.kde.org/D9638#196539, @zzag wrote:
> If you know how to start wayland session, please let me know. Till then, I
can't do too much (I'm familiar with effects part only).
amantia closed this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9325
To: amantia, #plasma, mwolff, broulik, hein
Cc: ervin, mlaurent, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:bac2ae0cd272: [Klipper] Force plain text on the edit
dialog (authored by safaalfulaij).
REPOSITORY
R120 Plasma Works
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
portBalooRunnerToKDBusRunner
REVISION DETAIL
https://phabricator.kde.org/D10079
To: kossebau, davidedmundson, broulik, mart
Cc: ngraham, plasma-devel, ZrenBot, progwolff,
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D10055
To: broulik, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.
ok for now (note that we will be able to use qqc2 buttons with icons only
when we can depend at least for plasma-desktop on Qt 5.10)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://
mart added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
+1 from me
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D10057
To: graesslin, #kwin, #plasma
Cc: mart, plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai,
ali-mo
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D10077
To: broulik, #plasma, #vdg, mart
Cc: ngraham, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, j
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10101
To: davidedmundson, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
This revision was automatically updated to reflect the committed changes.
Closed by commit R129:64d9f92f6a87: Make the messages translatable (authored by
yurchor).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D10084?vs=25908&id=25983#toc
REPOSITORY
R129 Window Decoration Library
CHAN
broulik accepted this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D10111
To: safaalfulaij, #plasma, mlaurent, broulik
Cc: mlaurent, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
This revision was not accepted when it landed; it landed in state "Needs
Revision".
This revision was automatically updated to reflect the committed changes.
Closed by commit R133:f1a1c9b22e4f: Fix building autotest on platforms where
syscalls are not available (authored by bshah).
REPOSITORY
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R114 Plasma Addons
BRANCH
dumpcontactsrunner
REVISION DETAIL
https://phabricator.kde.org/D10116
To: kossebau, broulik, jriddell, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali
ngraham added a comment.
Also FWIW we had trouble with hyper-sensitive touchpad scrolling in Gwenview
a few months ago and fixed it with
https://cgit.kde.org/gwenview.git/commit/?id=c4a84dad6292b9c7918bec8d7ed33114d3758730
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.
ngraham added a comment.
Same results as Kai, but I also do not have that Qt patch. Still, this is a
definite improvement for the wheel mouse use case.
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D10102
To: mart, #dolphin, broulik
Cc: ngraham, plasma-devel, ZrenB
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:900a334e72a7: [Look and feel KCM] Destroy and recreate
GHNS button when palette changes (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:aae0d59de766: [Look and feel KCM] Keep cursor size when
applying theme (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10055?vs=25832&i
zzag added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
I would like to test this effect in "full KDE Plasma wayland session", but I
can't start plasma. After splash screen there is only black screen.
Sometimes, there are messages like this
kscreen
mart created this revision.
mart added reviewers: Plasma, Kirigami.
Restricted Application added projects: Plasma, Kirigami.
Restricted Application added a subscriber: plasma-devel.
mart requested review of this revision.
REVISION SUMMARY
Add api in the C++ library that watches the tablet mode p
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:f31e7860d98f: [Default Tooltip] Fix sizing (authored by
broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10077?vs=25885&id=25993
REVISIO
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:595fd8805430: [Examples] Fix build (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10092?vs=25923&id=25992
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:bfe2539aa055: Improve quality of images in notifications
(Bug 385097) (authored by rkron, committed by davidedmundson).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricat
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:2f3bcfa8c61d: Port konsolesessions runner to Plasma5/Qt5
(authored by kossebau).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D10110?vs=25972&id=26016#toc
REPOSITORY
R114 Plasma Addons
CHA
broulik added a comment.
Yes, please!
I agree that shared-mime-info must be fixed to remove the `.bin` extension
but this will take forever and this is a serious regression preventing any
novice user from downloading files properly.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabr
davidedmundson added a comment.
> I can't find anything related to preview on my Arch Linux default Arch
kcm -> layouts -> add layout -> preview
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D10118
To: bshah, #plasma
Cc: davidedmundson, plasma-devel, Zre
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:a19c9118000c: Dump unported code of contactsrunner,
akonadi-search has pimcontactsrunner (authored by kossebau).
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org
Kanedias updated this revision to Diff 25979.
Kanedias added a comment.
- Merge branch 'master' into gbm-vnc
- Fix compilation on Clang
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1230?vs=21211&id=25979
BRANCH
gbm-vnc
REVISION DETAIL
https://phabric
graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
In https://phabricator.kde.org/D9638#196184, @zzag wrote:
> @graesslin: do elevated windows have order? (e.g. docks are above
fullscreen windows, etc)
They are above all other windows.
safaalfulaij updated this revision to Diff 25978.
safaalfulaij added a comment.
setAcceptRichText
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10111?vs=25973&id=25978
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10111
AFFECTE
zzag added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
If you know how to start wayland session, please let me know. Till then, I
can't do too much (I'm familiar with effects part only).
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D
ijanssen added reviewers: Plasma, dfaure.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10114
To: ijanssen, #plasma, dfaure
Cc: plasma-devel, #frameworks, ZrenBot, prog
davidedmundson accepted this revision.
REPOSITORY
R114 Plasma Addons
BRANCH
dumpcontactsrunner
REVISION DETAIL
https://phabricator.kde.org/D10116
To: kossebau, broulik, jriddell, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas,
zzag updated this revision to Diff 26015.
zzag added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
- clip with the PaintClipper
- elevate docks when `Slide docks` is unchecked
- rewritten logic which forces blur and background contrast
(tested only on X
bshah updated this revision to Diff 26004.
bshah added a comment.
add bug in message
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10118?vs=26002&id=26004
BRANCH
bshah/disable-geometry
REVISION DETAIL
https://phabricator.kde.org/D10118
AFFECT
mlaurent requested changes to this revision.
mlaurent added a comment.
This revision now requires changes to proceed.
Indeed it's better. but we need to use setAcceptRichText(false) in edit
otherwise we can set html text by dnd or copy.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
ht
bshah created this revision.
bshah added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
bshah requested review of this revision.
REVISION SUMMARY
it is not clear if this code is functional at this moment or not, given
anthonyfieroni added a comment.
I believe that port away from boost will fix the problem
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D10118
To: bshah, #plasma
Cc: anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, progwolff,
lesliezhai, ali-mohamed, je
Kanedias updated this revision to Diff 25976.
Kanedias edited the test plan for this revision.
Kanedias added a comment.
- Add RemoteAccess interface to KWayland
- Merge branch
- Fix compilation warnings uint -> int
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricato
kossebau created this revision.
kossebau added reviewers: broulik, jriddell, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.
REPOSITORY
R114 Plasma Addons
BRANCH
dumpcontactsru
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
good stuff
REPOSITORY
R114 Plasma Addons
BRANCH
portkonsolesessions
REVISION DETAIL
https://phabricator.kde.org/D10110
To: kossebau, broulik, jriddell, davidedmundso
mart added a comment.
do you have in your qt copy this patch?
https://codereview.qt-project.org/#/c/212398/
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D10102
To: mart, #dolphin, broulik
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
je
kossebau retitled this revision from "Port baloo krunner plugin to KDBusRunner"
to " [Draft] Port baloo krunner plugin to KDBusRunner".
kossebau edited the summary of this revision.
REPOSITORY
R120 Plasma Workspace
BRANCH
portBalooRunnerToKDBusRunner
REVISION DETAIL
https://phabricator.kd
59 matches
Mail list logo
