D10134: Add script to unlock a broken session via ConsoleKit.

tcberner created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. tcberner requested review of this revision. REVISION SUMMARY - Detect ConsoleLit/logind at runtime (logind untested). REPOSITORY R133 KScreenLocker BRANCH

D10134: Add script to unlock a broken session via ConsoleKit.

tcberner abandoned this revision. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D10134 To: tcberner Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9713: Add script to unlock a broken session via ConsoleKit.

tcberner updated this revision to Diff 26031. tcberner added a comment. Use QDbus to query whether ConsoleKit or LoginD is presnet (note, I have not tested LoginD :) ) REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9713?vs=24891&id=26031 BRANCH ma

D6004: Add method to unlock greeter via consolekit.

tcberner abandoned this revision. tcberner added a comment. Continued in https://phabricator.kde.org/D9713 REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D6004 To: tcberner, #freebsd, graesslin, #plasma Cc: PureTryOut, erichameleers, plasma-devel, ZrenBot, prog

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

rjvbb added a comment. > Is this change purely a conversation of what developers use in code to call up fonts in their applications? I think so. > Or does this also include a discussion where regular users have interfaces that allow changes to font naming? Let's say, something l

D9713: Add script to unlock a broken session via ConsoleKit.

tcberner added a reviewer: FreeBSD. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D9713 To: tcberner, graesslin, #freebsd Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9713: Add script to unlock a broken session via ConsoleKit.

tcberner added a reviewer: Plasma. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D9713 To: tcberner, graesslin, #freebsd, #plasma Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

ngraham added a comment. Thanks for the info! So if/hen this goes in, what are the next steps? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9070 To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure Cc: abetts, anthonyf

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

rjvbb added a comment. A diagonally related anecdote that shows this location is a more central point in the font selection process than I thought first: Applications like Qt's Assistant that call for Helvetica often end up using a font that looks pixelated - because it's actually an emb

D10131: Expose more URLs relevant to the app

ngraham updated this revision to Diff 26032. ngraham added a comment. Be smarter about how we find and display the links REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10131?vs=26024&id=26032 BRANCH more-URLs REVISION DETAIL https://p

D10131: Expose more URLs relevant to the app

ngraham marked 2 inline comments as done. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10131 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10131: Expose more URLs relevant to the app

ngraham updated this revision to Diff 26033. ngraham added a comment. Fix unintentional whitespace change REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10131?vs=26032&id=26033 BRANCH more-URLs REVISION DETAIL https://phabricator.kde.o

D10131: Expose more URLs relevant to the app

ngraham edited the summary of this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10131 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10118: Disable keyboard geometry preview code

hein added a comment. This looks up my PC several times a week. I lose work regularly because of it, and often can't finish compiling plasma-desktop successfully. I'm very +1 for killing it. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10118 To: bshah, #p

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

rjvbb added a comment. > Thanks for the info! So if/hen this goes in, what are the next steps? I'd say - decide whether this is an issue you want to solve only for plasma environments, or for all platforms where KF5 applications are supported. - draw up the conditions under which

D10118: Disable keyboard geometry preview code

sitter added a comment. In https://phabricator.kde.org/D10118#196532, @anthonyfieroni wrote: > I believe that port away from boost will fix the problem IIRC the problem isn't with boost at large, it's that the code uses insanely deep recursive templates. REPOSITORY R119 Plasma

D10118: Disable keyboard geometry preview code

hein added a comment. In https://phabricator.kde.org/D10118#196820, @sitter wrote: > In https://phabricator.kde.org/D10118#196532, @anthonyfieroni wrote: > > > I believe that port away from boost will fix the problem > > > IIRC the problem isn't with boost at large, it's that the

D10118: Disable keyboard geometry preview code

davidedmundson added a comment. > it is not clear if this code is functional at this moment or not I'm -1 for disabling if the change is based on a false premise that it doesn't work. Is it something you've already lost several hours into trying to fix? If so this proposal has a lot

D10118: Disable keyboard geometry preview code

bshah added a comment. In https://phabricator.kde.org/D10118#196823, @davidedmundson wrote: > > it is not clear if this code is functional at this moment or not > > I'm -1 for disabling if the change is based on a false premise that it doesn't work. No, this change is not prop

D10118: Disable keyboard geometry preview code

bshah planned changes to this revision. bshah added a comment. That said I've better idea.. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10118 To: bshah, #plasma Cc: sitter, ngraham, hein, broulik, graesslin, anthonyfieroni, davidedmundson, plasma-devel, Z

D10118: Don't unconditionally enable the keyboard geometry parser

bshah updated this revision to Diff 26050. bshah retitled this revision from "Disable keyboard geometry preview code" to "Don't unconditionally enable the keyboard geometry parser". bshah edited the summary of this revision. bshah removed subscribers: sitter, ngraham, hein, broulik, graesslin, an

D10118: Don't unconditionally enable the keyboard geometry parser

bshah added subscribers: sitter, davidedmundson, hein, broulik, graesslin, anthonyfieroni, ngraham. bshah added a comment. Urgh, not sure why phab decided to kick all subscribers, sorry... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10118 To: bshah, #plas

D10118: Don't unconditionally enable the keyboard geometry parser

sitter requested changes to this revision. sitter added a comment. This revision now requires changes to proceed. eek. please use https://cmake.org/cmake/help/v3.0/command/option.html , and maybe add_feature_info (see https://cmake.org/cmake/help/v3.0/module/FeatureSummary.html) instead of th

D10118: Don't unconditionally enable the keyboard geometry parser

bshah added a comment. In https://phabricator.kde.org/D10118#196841, @sitter wrote: > eek. please use https://cmake.org/cmake/help/v3.0/command/option.html , and maybe add_feature_info (see https://cmake.org/cmake/help/v3.0/module/FeatureSummary.html) instead of the message Line

D10118: Don't unconditionally enable the keyboard geometry parser

sitter resigned from this revision. sitter added a comment. So it does. Nevermind the noise. using feature_info instead of message might still be a worthwhile change though. message() cannot be automatically parsed, feature_info can. REPOSITORY R119 Plasma Desktop REVISION DETAIL https:

D10142: [server] Properly handle the situation when the DataSource for a drag gets destroyed

graesslin created this revision. graesslin added reviewers: Frameworks, KWin, Plasma. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added a subscriber: plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, a

D9993: Improve quality of images in notifications (Bug 385097)

rkron updated this revision to Diff 26060. rkron added a comment. BUG: 385097 I'm sorry for all the trouble, but I found the way to produce really clear previews. Notification before current patch to libnotificationshelperplugin.so : F5677244: before.png

D9993: Improve quality of images in notifications (Bug 385097)

rkron reopened this revision. rkron added a comment. This revision is now accepted and ready to land. See my comment with the new patch. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9993 To: rkron, #plasma_workspaces, #plasma, broulik Cc: broulik, ngraham

D9713: Add script to unlock a broken session via ConsoleKit.

graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. I like it! Thanks a lot for adding the runtime checking. REPOSITORY R133 KScreenLocker BRANCH master REVISION DETAIL https://phabricator.kde.org/D9713 To: tcberner, graesslin,

D9993: Improve quality of images in notifications (Bug 385097)

ngraham added a comment. Thanks Randy! Is this in addition to, or instead of your last patch? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9993 To: rkron, #plasma_workspaces, #plasma, broulik Cc: broulik, ngraham, plasma-devel, #plasma_workspaces, #plasma

D9713: Add script to unlock a broken session via ConsoleKit.

pprkut added inline comments. INLINE COMMENTS > CMakeLists.txt:102 > +TYPE RECOMMENDED > +PURPOSE "Needed for emergency unlock in case that the greeter is > broken. In case your distribution does not provide loginctl please contact > plasma-devel@kde.org to discuss alternatives.

D9993: Improve quality of images in notifications (Bug 385097)

rkron added a comment. @ngraham This is in addition to the last patch, Nate. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9993 To: rkron, #plasma_workspaces, #plasma, broulik Cc: broulik, ngraham, plasma-devel, #plasma_workspaces, #plasma, ZrenBot, progw

D10131: Expose more URLs relevant to the app

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Other than that, LGTM. INLINE COMMENTS > ApplicationPage.qml:347 > +Layout.alignment: Qt.AlignRight > +text: i18n("Make a Donation:") > +} Donation:

D9993: Improve quality of images in notifications (Bug 385097)

ngraham added a comment. At this point, I think this easiest thing to do is to make a new patch. Thanks! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9993 To: rkron, #plasma_workspaces, #plasma, broulik Cc: broulik, ngraham, plasma-devel, #plasma_workspa

D10131: Expose more URLs relevant to the app

ngraham added inline comments. INLINE COMMENTS > apol wrote in ApplicationPage.qml:347 > Donation:? Donate:? > > "Make a donation" reads a bit too long to me for such a title. "Donate: sounds good. "Make a Donation:" would probably be 4 lines long in German, anyway. :) REPOSITORY R134 Disco

D10131: Expose more URLs relevant to the app

ngraham marked 2 inline comments as done. REPOSITORY R134 Discover Software Store BRANCH more-URLs REVISION DETAIL https://phabricator.kde.org/D10131 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D10131: Expose more URLs relevant to the app

ngraham updated this revision to Diff 26062. ngraham added a comment. "Make a Donation" -> "Donate" REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10131?vs=26033&id=26062 BRANCH more-URLs REVISION DETAIL https://phabricator.kde.org/D10

D9993: Improve quality of images in notifications (Bug 385097)

rkron added a comment. @ngraham So should I submit this new patch as a new revision? I'm still new to this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9993 To: rkron, #plasma_workspaces, #plasma, broulik Cc: broulik, ngraham, plasma-devel, #plasma_work

D9993: Improve quality of images in notifications (Bug 385097)

ngraham added a comment. No worries! This revision is already closed and associated with a commit, so you should open a new revision to hold the new diff. If you're not using Arcanist to generate patches yet, here's the documentation: https://community.kde.org/Infrastructure/Phabricator#Usin

D9993: Improve quality of images in notifications (Bug 385097)

rkron added a comment. @ngraham Thanks Nathaniel! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9993 To: rkron, #plasma_workspaces, #plasma, broulik Cc: broulik, ngraham, plasma-devel, #plasma_workspaces, #plasma, ZrenBot, progwolff, franciscofernandes, l

D9993: Improve quality of images in notifications (Bug 385097)

rkron closed this revision. rkron added a comment. Submitting new revision. I REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9993 To: rkron, #plasma_workspaces, #plasma, broulik Cc: broulik, ngraham, plasma-devel, #plasma_workspaces, #plasma, ZrenBot, prog

D10131: Expose more URLs relevant to the app

ngraham closed this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10131 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

ngraham added a comment. Thanks René. Regarding those questions, what would your preferences be? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9070 To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure Cc: abetts, anthon

D10146: Further improve quality of images in notifications (Bug 385097)

rkron created this revision. rkron added reviewers: Plasma: Workspaces, Plasma, broulik. rkron added projects: Plasma, Spectacle. rkron requested review of this revision. REVISION SUMMARY BUG: 385097 This revision further improves the quality of images in notifications that was addressed i

D9713: Add script to unlock a broken session via ConsoleKit.

adridg added inline comments. INLINE COMMENTS > abstractlocker.cpp:69 > +text = text_ck; > +} else if (haveService("org.freedesktop.login1.Session")) { > +text = text_ld; Drop ".Session", since the service is registered (Manjaro, KDE Neon) as "org.freedesktop.log

D10148: KCM: Show only available device profiles

drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. drosca requested review of this revision. REVISION SUMMARY ^ CCBUG: 365723 TEST PLAN Unavailable profiles are now filtered

D9671: Show only available profiles in Pulseaudio KCM

This revision was not accepted when it landed; it landed in state "Changes Planned". This revision was automatically updated to reflect the committed changes. Closed by commit R115:206a00f95858: Move availability property from Port to Profile (authored by nicolasfella, committed by drosca). CHAN

D9638: [effects] replace old slide effect with a new one

zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. ... and it didn't work. I'll ask for help on `#plasma` IRC. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9638 To: zzag, #vdg, #kwin, #plasma Cc: mart, graesslin, abetts, ngraham

D10151: Solved bug 382512

carlavilla created this revision. carlavilla added a reviewer: mlaurent. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. carlavilla requested review of this revision. REVISION SUMMARY Solved the bug with the & in the tabs REPOSITORY R10

D6673: [Notifications] Manually remove remote images

aacid added a comment. Any reason we're not doing the filtering at the dataengine level? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6673 To: broulik, #plasma, fvogt Cc: aacid, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, j

D6673: [Notifications] Manually remove remote images

aacid added a comment. To be honest, having a look at https://developer.gnome.org/notification-spec/#markup we should just filter out everything other than b i u a and img with local src What do you think? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org

D6673: [Notifications] Manually remove remote images

broulik added a comment. > should just filter out everything other than b i u a and img with local src Sure, but how would you achieve this? Regular expressions aren't suitable for HTML. It's not like I went this overly complicated way for no reason. REPOSITORY R120 Plasma Workspace R

D6673: [Notifications] Manually remove remote images

aacid added a comment. In https://phabricator.kde.org/D6673#197138, @broulik wrote: > > should just filter out everything other than b i u a and img with local src > > Sure, but how would you achieve this? Regular expressions aren't suitable for HTML. It's not like I went this overly

D6673: [Notifications] Manually remove remote images

davidedmundson added a comment. > This would fail with "invalid but webbrowser-parseable" html, but i guess we don't really care about it either, no? That wouldn't solve anything as without would fail the XML remover but still end up getting loaded. You could need to signal that it w

D6673: [Notifications] Manually remove remote images

broulik added a comment. I think `QXmlStreamReader` may be the way to go, I wasn't aware on how strict the spec is wrt HTML support. David, an `` opening tag is still valid XHTML, you might receive a document ended prematurely error at the end since there won't be a closing tag but defi

D6673: [Notifications] Manually remove remote images

broulik added a comment. Also, if we did the filtering on dataengine side we could easily backport that to 5.8 since it hardly changed in the meantime whereas the applet underwent significant modifications. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D66

D10151: Solved bug 382512

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Thanks for the patch! In general, it's best to title your Phabricator revision with a short description of the change or fix itself, and mention the bug in the Summary section.

D10151: Solved bug 382512

mlaurent added a comment. For patch it seems ok. But Nathaniel is right. Describe how you tested it, add BUG: etc. Otherwise it's a good start :) Thanks. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D10151 To: carlavilla, mlaurent, ngraham Cc: ngraha