D10807: fileindexerconfig: Exclude Vaults by default

2018-02-24 Thread Michael Heidelbach
michaelh added a comment. I was thinking in the same direction. When the mountpoint of a vault is changed (or new) a warning message about baloo's activity should be displayed. The message should be displayed regardless of baloo's enabled state. There's plenty of space for that in the

D10308: Send hoverLeave or hoverMotion after touch up on decoration

2018-02-24 Thread Roman Gilg
romangg accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin BRANCH hover-leave-on-deco-after-touch-5.12 REVISION DETAIL https://phabricator.kde.org/D10308 To: graesslin, #kwin,

D10440: Support modifier mouse/scroll action on internal decorated windows

2018-02-24 Thread Roman Gilg
romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed KWin. Looks fine, but making this behavior dependent on `isDecorated` seems a bit hacky to me. Wouldn't be a separate

D10235: [server] Add support for the frame semantics of Pointer version 5

2018-02-24 Thread Roman Gilg
romangg added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. Shouldn't the sendFrame event sent by the compositor explicitly? The way it's currently send after each event compositors are not able to group these. REPOSITORY R127 KWayland

D10807: fileindexerconfig: Exclude Vaults by default

2018-02-24 Thread Alexey Min
alexeymin added a comment. Maybe when a new vault is configured, it should add itself to baloo exceptions. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham, #plasma Cc: alexeymin, plasma-devel, ivan, nicolasfella,

D10807: fileindexerconfig: Exclude Vaults by default

2018-02-24 Thread Michael Heidelbach
michaelh added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham, #plasma Cc: plasma-devel, ivan,

D10142: [server] Properly handle the situation when the DataSource for a drag gets destroyed

2018-02-24 Thread Roman Gilg
romangg accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. REPOSITORY R127 KWayland BRANCH cancel-drag-on-datasource-destroy REVISION DETAIL https://phabricator.kde.org/D10142 To:

D10549: Don't crash if the cursor theme fails to create

2018-02-24 Thread Roman Gilg
romangg requested changes to this revision. romangg added inline comments. This revision now requires changes to proceed. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > wayland_cursor_theme.cpp:69 > size, m_shm->shm()); >

D9713: Add script to unlock a broken session via ConsoleKit.

2018-02-24 Thread Martin Flöser
graesslin accepted this revision. REPOSITORY R133 KScreenLocker BRANCH master REVISION DETAIL https://phabricator.kde.org/D9713 To: tcberner, graesslin, #freebsd, #plasma Cc: broulik, PureTryOut, adridg, pprkut, graesslin, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D10800: Plasma browser MPRIS canPlay shouldn't depend on the actual playing status

2018-02-24 Thread Nicolas Fella
nicolasfella added a comment. I can confirm that this fixes the glitch REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D10800 To: mtijink, #plasma, broulik Cc: nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D10800: Plasma browser MPRIS canPlay shouldn't depend on the actual playing status

2018-02-24 Thread Nicolas Fella
nicolasfella added a comment. The glitch: F5728155: 20180222_130510_edited (1).mp4 REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D10800 To: mtijink, #plasma, broulik Cc: nicolasfella, plasma-devel,

D10802: Fix the userswitcher when using the mouse for switching

2018-02-24 Thread Fabian Vogt
fvogt created this revision. fvogt added a reviewer: Plasma. Restricted Application added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY Clicking on a button makes Qt grab the pointer, which means the screen can't be locked. As we wait for the screen to be

D10800: Plasma browser MPRIS canPlay shouldn't depend on the actual playing status

2018-02-24 Thread Matthijs Tijink
mtijink created this revision. mtijink added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mtijink requested review of this revision. REVISION SUMMARY At #kde_connect

D10795: [grouping applet] Use "object-group" as icon

2018-02-24 Thread Friedrich W . H . Kossebau
kossebau added a comment. Request for dedicated icon just filed as: https://bugs.kde.org/show_bug.cgi?id=391009 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10795 To: kossebau, davidedmundson Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D10795: [grouping applet] Use "object-group" as icon

2018-02-24 Thread Friedrich W . H . Kossebau
kossebau created this revision. kossebau added a reviewer: davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Until there is a special widget icon, the

D10793: [grouping applet] Add missing Comment entry to metadata

2018-02-24 Thread Friedrich W . H . Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R114:1319b7bfe892: [grouping applet] Add missing Comment entry to metadata (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10793?vs=27915=27925#toc REPOSITORY R114 Plasma

D10793: [grouping applet] Add missing Comment entry to metadata

2018-02-24 Thread Friedrich W . H . Kossebau
kossebau added a comment. In D10793#212670 , @davidedmundson wrote: > Changing i18n in stable as a bug fix is allowed, but CC kde-i18n-doc. Given I just copied the same string as used for the metadata of the internal grouping package

D10793: [grouping applet] Add missing Comment entry to metadata

2018-02-24 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Changing i18n in stable as a bug fix is allowed, but CC kde-i18n-doc. > Has there been already a request for a custom icon be filed Don't think so REPOSITORY

D10793: [grouping applet] Add missing Comment entry to metadata

2018-02-24 Thread Friedrich W . H . Kossebau
kossebau added a comment. Noticed the comment missing in the "Add widget.." picker, appstreamcli also complains about missing summary entry. I picked the string as used with the private implementation version of that widget (no clue on the details though). Fix would be for 5.12

D10793: [grouping applet] Add missing Comment entry to metadata

2018-02-24 Thread Friedrich W . H . Kossebau
kossebau created this revision. kossebau added a reviewer: davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH fixgroupingmissingcomment

D10791: Fixed the Wikimedia Commons Picture of the Day provider

2018-02-24 Thread Nathaniel Graham
ngraham added a comment. No need to abandon the revision, you can just mark it as "Changes Planned". REVISION DETAIL https://phabricator.kde.org/D10791 To: manuelc, #plasma Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10791: Fixed the Wikimedia Commons Picture of the Day provider

2018-02-24 Thread Manuel Caldeira
manuelc abandoned this revision. manuelc added a comment. I'm sorry, I realised I had to look over my changes once more, more closely REVISION DETAIL https://phabricator.kde.org/D10791 To: manuelc, #plasma Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D10628: Optional barcodes in libprison

2018-02-24 Thread Sune Vuorela
This revision was automatically updated to reflect the committed changes. Closed by commit R120:c6e678a274b6: Adapt to further nullpointers from prison (authored by svuorela). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10628?vs=27455=27910

D10791: Fixed the Wikimedia Commons Picture of the Day provider

2018-02-24 Thread Manuel Caldeira
manuelc updated this revision to Diff 27908. manuelc added a comment. I didn't know how important this was and building took a bit long. Also, should these be initialised externally since they never change or is it fine to put them directly into the function? CHANGES SINCE LAST UPDATE

D10791: Fixed the Wikimedia Commons Picture of the Day provider

2018-02-24 Thread Manuel Caldeira
manuelc added a reviewer: Plasma. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10791 To: manuelc, #plasma Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10791: Fixed the Wikimedia Commons Picture of the Day provider

2018-02-24 Thread Manuel Caldeira
manuelc created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. manuelc requested review of this revision. REVISION SUMMARY Since the previously used method is no longer working because the page doesn't exist anymore I

D9713: Add script to unlock a broken session via ConsoleKit.

2018-02-24 Thread Tobias C . Berner
tcberner updated this revision to Diff 27901. tcberner added a comment. - Switch the url to https://github.com/ConsoleKit2/ConsoleKit2 - coble together something less "unfortunate" from the official description: //ConsoleKit2 is a framework for defining and tracking users, login sessions,

D9713: Add script to unlock a broken session via ConsoleKit.

2018-02-24 Thread Heinz Wiesinger
pprkut added inline comments. INLINE COMMENTS > CMakeLists.txt:99 > +set_package_properties(ConsoleKit PROPERTIES > +URL "http://www.freedesktop.org/wiki/Software/ConsoleKit; > +DESCRIPTION "Framework for defining and tracking users" It's probably better to refer to

D9713: Add script to unlock a broken session via ConsoleKit.

2018-02-24 Thread Kai Uwe Broulik
broulik added a comment. > Framework for […] tracking users is a bit of an unfortunate term REPOSITORY R133 KScreenLocker BRANCH master REVISION DETAIL https://phabricator.kde.org/D9713 To: tcberner, graesslin, #freebsd, #plasma Cc: broulik, PureTryOut, adridg, pprkut,

D9713: Add script to unlock a broken session via ConsoleKit.

2018-02-24 Thread Tobias C . Berner
tcberner added a comment. On FreeBSD the configure now looks like: [...] -- Could NOT find loginctl (missing: loginctl_EXECUTABLE) -- Found ConsoleKit: /usr/local/bin/ck-list-sessions [...] * prctl/procctl tracing control, Required for disallowing ptrace on greeter

D9713: Add script to unlock a broken session via ConsoleKit.

2018-02-24 Thread Tobias C . Berner
tcberner updated this revision to Diff 27898. tcberner added a comment. - Fix logind1 dbus path - Improve CMakeLists.txt to only display the feature once REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9713?vs=26031=27898 BRANCH master REVISION