D10938: Enable showing top level items in kicker and kickoff menu

2018-03-04 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R119:e93dbd0e5914: Enable showing top level items in kicker and kickoff menu (authored by lopatin, committed by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D10837: bad textarea width for rename file if filename too short

2018-03-04 Thread Eike Hein
hein added a comment. Could you let me know which real name to use on the commit? REVISION DETAIL https://phabricator.kde.org/D10837 To: painlessroaster, #plasma, hein Cc: anemeth, ngraham, plasma-devel, hein, davidedmundson, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D10890: Don't skip certain recent documents in kicker and taskmanager

2018-03-04 Thread Eike Hein
hein added a comment. Looks good to me, Kai? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10890 To: aleksejshilin, #plasma, broulik, hein Cc: anthonyfieroni, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D10762: Fix the build on armhf/aarch64

2018-03-04 Thread Bhushan Shah
bshah updated this revision to Diff 28659. bshah added a comment. updated to use single header REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10762?vs=28375=28659 BRANCH arcpatch-D10762 REVISION DETAIL https://phabricator.kde.org/D10762 AFFECTED FILES

D10938: Enable showing top level items in kicker and kickoff menu

2018-03-04 Thread Eike Hein
hein added a comment. Will do, thank you for your patch. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10938 To: lopatin, hein Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10938: Enable showing top level items in kicker and kickoff menu

2018-03-04 Thread Eike Hein
hein added a comment. Will do, thanks again! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10938 To: lopatin, hein Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11003: Fix the Add Source dialog

2018-03-04 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R134 Discover Software Store BRANCH fix-add-source-dialog (branched from master) REVISION DETAIL https://phabricator.kde.org/D11003 To: ngraham, #discover_software_store, apol Cc: acrouthamel,

D11009: Make passiveNotifications last longer, so users can actually read them

2018-03-04 Thread Aleix Pol Gonzalez
apol added a comment. Makes sense to me. Maybe we want to have some kind of formula to turn length into time like we do in plasma notifications (AFAIR). REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D11009 To: ngraham, #kirigami, mart Cc: plasma-devel, apol,

D10890: Don't skip certain recent documents in kicker and taskmanager

2018-03-04 Thread Алексей Шилин
aleksejshilin updated this revision to Diff 28639. aleksejshilin added a comment. - Make sure to forget all documents, too REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10890?vs=28626=28639 BRANCH prepare_for_krecentdocument_fix REVISION DETAIL

D11021: [Media controller] Add simple volume control

2018-03-04 Thread Radek Hušek
Pitel retitled this revision from "[Media contoller] Add simple volume control" to "[Media controller] Add simple volume control". REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11021 To: Pitel, #plasma Cc: nicolasfella, plasma-devel, ZrenBot, lesliezhai,

D10195: DrKonqi: Enable DBus-Interface for debugging with KDevelop

2018-03-04 Thread Milian Wolff
mwolff accepted this revision. mwolff added a comment. This revision is now accepted and ready to land. minor style stuff, otherwise lgtm, esp. if it works now INLINE COMMENTS > README:5 > > -[Drkonqi] > +[DrKonqi] > ShowDebugButton=true could be a separate commit >

D10890: Don't skip certain recent documents in kicker and taskmanager

2018-03-04 Thread Anthony Fieroni
anthonyfieroni added a comment. It looks good to me REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10890 To: aleksejshilin, #plasma, broulik, hein Cc: anthonyfieroni, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D10890: Don't skip certain recent documents in kicker and taskmanager

2018-03-04 Thread Алексей Шилин
aleksejshilin retitled this revision from "Prepare for KIO KRecentDocument fix (D10863)" to "Don't skip certain recent documents in kicker and taskmanager". aleksejshilin edited the summary of this revision. aleksejshilin edited the test plan for this revision. REPOSITORY R119 Plasma Desktop

D10890: Prepare for KIO KRecentDocument fix (D10863)

2018-03-04 Thread Алексей Шилин
aleksejshilin updated this revision to Diff 28626. aleksejshilin added a comment. - Clean up and better comment the code REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10890?vs=28398=28626 BRANCH prepare_for_krecentdocument_fix REVISION DETAIL

D11003: Fix the Add Source dialog

2018-03-04 Thread Andrew Crouthamel
acrouthamel added a comment. Nice and clean! I like the change. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D11003 To: ngraham, #discover_software_store, apol Cc: acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D11028: [media controller applet] Fix JS error on no xesam:url data set

2018-03-04 Thread Friedrich W . H . Kossebau
kossebau created this revision. kossebau added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH fixtoStringfromnull REVISION

D10973: [media controller applet] Support MPRIS services where CanPause==false

2018-03-04 Thread Friedrich W . H . Kossebau
kossebau updated this revision to Diff 28619. kossebau added a comment. set PassiveStatus also for state=="stopped" REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10973?vs=28415=28619 BRANCH mpriscontrollersupportnocanpause REVISION DETAIL

D11025: [taskmanager applet] Fix MPRIS buttons in tooltip for CanPause==false

2018-03-04 Thread Friedrich W . H . Kossebau
kossebau added a dependent revision: D10972: [RFC] Exposing slideshow to MPRIS controllers. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11025 To: kossebau, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11025: [taskmanager applet] Fix MPRIS buttons in tooltip for CanPause==false

2018-03-04 Thread Friedrich W . H . Kossebau
kossebau updated this revision to Diff 28616. kossebau added a comment. - also disable play/pause icon, not just mousearea - add needed method in main.qml (addition shared with D11007 ) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D11025: [taskmanager applet] Fix MPRIS buttons in tooltip for CanPause==false

2018-03-04 Thread Friedrich W . H . Kossebau
kossebau created this revision. kossebau added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Currently the media controller in the tooltup only works with

D11007: [taskmanager applet] Fix MPRIS entries in context menu for CanPause==false

2018-03-04 Thread Friedrich W . H . Kossebau
kossebau updated this revision to Diff 28610. kossebau added a comment. cache isPlayingCheck in bool, fix icon update of play/pause menu entry REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11007?vs=28529=28610 BRANCH

D11021: [Media contoller] Add simple volume control

2018-03-04 Thread Radek Hušek
Pitel added a comment. The idea crossed my mind but I rarely use expanded version of the applet and there are two problems to deal with: - Where exactly to place the slider (I am bad at designing UI). - What should upper bound of slider be -- usually 1 is good option but mpris does

D11021: [Media contoller] Add simple volume control

2018-03-04 Thread Nicolas Fella
nicolasfella added a comment. What about a volume slider in the applet? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11021 To: Pitel, #plasma Cc: nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11021: [Media contoller] Add simple volume control

2018-03-04 Thread Radek Hušek
Pitel created this revision. Pitel added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Pitel requested review of this revision. REVISION SUMMARY Add simple volume control to Media Controller applet. Volume can by

D10235: [server] Add support for the frame semantics of Pointer version 5

2018-03-04 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R127:b6bd28ab0492: [server] Add support for the frame semantics of Pointer version 5 (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10235?vs=26336=28563#toc REPOSITORY

D10549: Don't crash if the cursor theme fails to create

2018-03-04 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:2ea5153e1c97: Dont crash if the cursor theme fails to create (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10549?vs=27278=28560 REVISION

D10642: [kcmkwin/rules] Disable detect button on Wayland

2018-03-04 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:6d6576f81932: [kcmkwin/rules] Disable detect button on Wayland (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10642?vs=27555=28561 REVISION

D10440: Support modifier mouse/scroll action on internal decorated windows

2018-03-04 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:b554e54e87b5: Support modifier mouse/scroll action on internal decorated windows (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10440?vs=26910=28559#toc REPOSITORY

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

2018-03-04 Thread Martin Flöser
graesslin updated this revision to Diff 28556. graesslin added a comment. - Reword documentation to make it more clear when it has to be called - rename to detectPlatform REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10816?vs=27985=28556

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

2018-03-04 Thread Martin Flöser
graesslin marked 2 inline comments as done. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10816 To: graesslin, #plasma Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart