fvogt created this revision.
fvogt added reviewers: Plasma, graesslin.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin.
fvogt requested review of this revision.
REVISION SUMMARY
Quickly fix it before anyone relies on this typo.
TEST PLAN
None
broulik created this revision.
broulik added reviewers: Plasma, sebas.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.
TEST PLAN
Tested with
QT_SCREEN_SCALE_FACTORS=1 kcmshell5 kcm_kscreen
fvogt created this revision.
fvogt added reviewers: Plasma, sebas, dvratil.
Restricted Application added a project: Plasma.
fvogt requested review of this revision.
REVISION SUMMARY
This makes it usable on wayland. The Qt Wayland support for subsurfaces
is broken in many ways, producing practi
aleksejshilin edited the test plan for this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D10890
To: aleksejshilin, #plasma, broulik, hein
Cc: anthonyfieroni, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol,
aleksejshilin updated this revision to Diff 28681.
aleksejshilin marked an inline comment as done.
aleksejshilin added a comment.
- Use QString::mid()
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10890?vs=28639&id=28681
BRANCH
prepare_for_krecen
broulik added a comment.
Thanks for your patch! I thought about doing that for a long time, actually.
You can add `BUG: 386588` to your commit message (on its own line) to indiate
that it fixes this bug.
Can you please also implement a volume OSD? We have a
mediaPlayerVolumeChanged in
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
markshortcutpropertiesreadonly
REVISION DETAIL
https://phabricator.kde.org/D11026
To: kossebau, broulik, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterb
broulik added a comment.
lgtm
INLINE COMMENTS
> actionlist.cpp:312
> +if (storageId.startsWith("org.kde.")) {
> +query = query | Agent(storageId.right(storageId.length() - 8));
> +}
I would prefer `mid(8)`
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https
broulik added inline comments.
INLINE COMMENTS
> ToolTipInstance.qml:349
> +if (canPause) {
> +mpris2Source.playPause(mprisSourceName);
> +} else if (playing) {
Same as with media controller, please do not mi
broulik added a reviewer: hein.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D11025
To: kossebau, broulik, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol, mart
broulik added a reviewer: hein.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D11026
To: kossebau, broulik, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol, mart
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.
My approach would have been
var xesamUrl = (metadata["xesam:url"] || "").toString();
but this is fine and more understandable for non-JS developers :)
REPOSITORY
R120 Plasma
101 - 112 of 112 matches
Mail list logo
