D11166: Simplify display when there's only a single input device and a single output device

Zren added inline comments. INLINE COMMENTS > main.qml:420 > Layout.fillWidth: true > -visible: sourceView.count > 0 > +visible: sourceView.count > 1 && > !devicesView.simpleMode > text: i18n("Captu

D11166: Simplify display when there's only a single device

ngraham added a comment. Thanks for all your help! REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D11166 To: ngraham, #plasma, drosca Cc: Zren, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11166: Simplify display when there's only a single device

ngraham updated this revision to Diff 29055. ngraham added a comment. Only show the simple mode when there's exactly one input device and exactly one output device REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11166?vs=29054&id=29055 B

D11166: Simplify display when there's only a single device

Zren added a comment. I remember having trouble binding to stuff in the `___Representation` in the `main.qml` too, but don't remember the specifics. Why not just define it in the `ColumnLayout { id: devicesView }` since it's not really needed elsewhere. `onlyOne: devicesView.simpleMode`, `vi

D11166: Simplify display when there's only a single device

ngraham added a comment. Hmm, I'm seeing that wherever in `main.qml` I define `simpleMode`, it doesn't seem to actually get set. Maybe the listView delegates aren't yet initialized or something? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D1116

D11166: Simplify display when there's only a single device

ngraham added a comment. Hey, that's not a bad idea! REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D11166 To: ngraham, #plasma, drosca Cc: Zren, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11166: Simplify display when there's only a single device

Zren added a comment. Hmmm. So if there was 2 sinks (eg: 3.5mm jack + HDMI) and 1 mic (3.5mm jack) it'd show the sink header, but not the source header? Labelling all 3 as a sink? Might want to create a `bool simpleMode: sinkView.count + sourceView.count <= 2` that is used everywhere in

D11166: Simplify display when there's only a single device

ngraham updated this revision to Diff 29054. ngraham added a comment. Simplify logic REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11166?vs=29053&id=29054 BRANCH simplify-single-device-ui (branched from master) REVISION DETAIL http

D11166: Simplify display when there's only a single device

ngraham created this revision. ngraham added reviewers: Plasma, drosca. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The Audio Volume plasmoid has always seemed a bit too heavy

D10297: Add new "Tools" button above System Monitor's process list

ngraham added reviewers: broulik, mart, hein. ngraham added a comment. I'm a +1, FWIW. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D10297 To: gregormi, #plasma, colomar, kossebau, broulik, mart, hein Cc: anthonyfieroni, andreaska, rkflx, ngraham, plasma-

D10262: [Look and feel KCM] Fix creating a broken colors scheme file in KcmTest

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0b31d9347d09: [Look and feel KCM] Fix creating a broken colors scheme file in KcmTest (authored by kossebau). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D11069: [WIP] refine decoration shadows

zzag added a comment. In D11069#221385 , @hpereiradacosta wrote: > > - What's the best way to share code between KStyle and KDecoration plugin? (currently, I'm symlinking files) > > File links is not an option. (it breaks when you make tarb

D11145: Merge applet packages' /code subdirs into /ui subdirs

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b10f5bc729e7: Merge applet packages' /code subdirs into /ui subdirs (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11145?vs=28980&id=29020#toc REPOSITORY R120 Plasma

D11148: Move applet packages' /code subdirs below /ui subdirs

This revision was automatically updated to reflect the committed changes. Closed by commit R119:600b64eb9ab8: Move applet packages' /code subdirs below /ui subdirs (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11148?vs=28985&id=29019#toc REPOSITORY R119 Plasma

D11069: [WIP] refine decoration shadows

hpereiradacosta added a comment. > Some questions: > > - Do we really need different shadow sizes for menus, etc? Can we use single shadow size in kstyle? I'd say yes, as soon as you provide different shadow sizes for the windows (that also answers the last question) > - Do men

D11069: [WIP] refine decoration shadows

zzag added a comment. So, I'd spent last two hours trying to find good menu shadow params.. HIG guidelines don't say too much about shadows(also, navigating them is hard). F5745942: menu-shadows.png You can help by providing CSS shadows. Some

D11144: Merge applet packages' /code subdirs into /ui subdirs

This revision was automatically updated to reflect the committed changes. Closed by commit R114:c3ccefda4bea: Merge applet packages' /code subdirs into /ui subdirs (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11144?vs=28978&id=29015#toc REPOSITORY R114 Plasma

D11151: [Notifications] Announce body-images capability

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ba0980c640c7: [Notifications] Announce body-images capability (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11151?vs=29003&id=29004

D11151: [Notifications] Announce body-images capability

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY We explicitly allow `` tags so announce that we support this TEST

D11142: Add ConnectionCheck for Dash Cards

Aiix added inline comments. INLINE COMMENTS > yurchor wrote in main.qml:132 > Is it necessary to use "🌐" between "the" and "internet" in this message? > Thanks in advance for your answer. Thanks for reviewing this, I wasn't sure if there is general issue on using Unicode symbols in strings and

D10890: Don't skip certain recent documents in kicker and taskmanager

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ca96f850efbf: Don't skip certain recent documents in kicker and taskmanager (authored by aleksejshilin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10890

D11101: Minor spelling corrections

scarlettclark closed this revision. REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D11101 To: scarlettclark, mvourlakos Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10728: Improve multi-desktop folderview behavior

amantia closed this revision. REVISION DETAIL https://phabricator.kde.org/D10728 To: amantia, #plasma, hein Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10728: Improve multi-desktop folderview behavior

amantia updated this revision to Diff 28998. amantia added a comment. Moved to 5.12 CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10728?vs=27733&id=28998 BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10728 AFFECTED FILES containments/desktop/plugins/folder