KDE CI: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 - Build # 90 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20FreeBSDQt5.9/90/ Project: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 25 Mar 2018 02:07:55 + Build duration: 1 hr 30 min and counting

D11663: Add InlineMessage type and Gallery app example page

hein updated this revision to Diff 30458. hein added a comment. Remove unrelated files. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11663?vs=30446=30458 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11663 AFFECTED FILES

D11661: Fix wrong X-DocPath in kcm_launchfeedback.desktop

hein requested changes to this revision. hein added a comment. This revision now requires changes to proceed. I disagree with this patch - I renamed things for consistency for a reason and emailed i18n-doc, so I expect the docs to get renamed. REPOSITORY R119 Plasma Desktop REVISION

D10454: Translated all texts from the en directory so the extension works in es

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. As per Kai's comments, marking as needs changes REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D10454 To: antlarr,

D11606: [WebBrowser Plasmoid] Support opening external links

davidedmundson added a comment. In general fine. INLINE COMMENTS > main.qml:65-67 > +// button itself adds sufficient visual padding > +Layout.leftMargin: -parent.spacing > +Layout.rightMargin: -parent.spacing You can find a better solution. Especially as

D11665: Make Select/Deselect All operate on the filtered rows.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b49b73dee7d1: Make Select/Deselect All operate on the filtered rows. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11665?vs=30450=30456

D11590: Add mutex round static member used in a thread

This revision was automatically updated to reflect the committed changes. Closed by commit R120:52ceb2454be4: Add mutex round static member used in a thread (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D11591: Remove anchors in layout in wallpaper config

This revision was automatically updated to reflect the committed changes. Closed by commit R120:21d97beb28be: Remove anchors in layout in wallpaper config (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11591?vs=30265=30454#toc REPOSITORY R120 Plasma

D11665: Make Select/Deselect All operate on the filtered rows.

hein created this revision. hein added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY BUG:392264 REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D11665

D11663: Add InlineMessage type and Gallery app example page

hein added a comment. I have no strong preference as far as the visuals are concerned. I would be OK with the rounded + colored version, too. It's also fairly close to KMessageWidget, which would make it quite easy to make KMessageWidget look similar (other than spacing). If this version

D11663: Add InlineMessage type and Gallery app example page

ngraham added a comment. Big +1 on the version with the colored borders and background. That looks really classy IMHO. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D11663 To: hein, #kirigami, mart Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein

D11663: Add InlineMessage type and Gallery app example page

hein updated this revision to Diff 30446. hein added a comment. Get rid of an unnecessary extra Rectangle. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11663?vs=30445=30446 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11663 AFFECTED

D11663: Add InlineMessage type and Gallery app example page

hein added a comment. Quick hacks for alternate appearances based on VDG chat brainstorming: F5765210: inlinemessages4.png F5765212: inlinemessages5.png On this last one the inside corners are not

D11663: Add InlineMessage type and Gallery app example page

hein updated this revision to Diff 30445. hein added a comment. Don't use redundant default value in API documentation code example. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11663?vs=30444=30445 BRANCH master REVISION DETAIL

D11663: Add InlineMessage type and Gallery app example page

hein updated this revision to Diff 30444. hein added a comment. Add more defaults to API documentation. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11663?vs=30442=30444 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11663 AFFECTED

D11663: Add InlineMessage type and Gallery app example page

hein added a comment. Additional note: The missing icons in the Material Gallery screenshot are because the Gallery app build system seems to refuse to extract them from Breeze for unknown reasons (perhaps missing sizes). REPOSITORY R169 Kirigami REVISION DETAIL

D11663: Add InlineMessage type and Gallery app example page

hein added a comment. This component is needed to complete task T7247 . REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D11663 To: hein, #kirigami, mart Cc: plasma-devel, apol, davidedmundson, mart, hein

D11663: Add InlineMessage type and Gallery app example page

hein updated this revision to Diff 30442. hein added a comment. Fix typo in Gallery error message example text. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11663?vs=30441=30442 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11663

D11663: Add InlineMessage type and Gallery app example page

hein added a comment. Kirigami Gallery app, desktop style: F5765163: inlinemessages1.png Kirigami Gallery app, desktop style, after the actions are used: F5765167: inlinemessages2.png Kirigami

D11663: Add InlineMessage type and Gallery app example page

hein created this revision. hein added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. hein requested review of this revision. REVISION SUMMARY InlineMessage can be used to show various messages to the user,

D11662: Minor cleanup.

hein created this revision. hein added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. hein requested review of this revision. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL

D11661: Fix wrong X-DocPath in kcm_launchfeedback.desktop

lueck created this revision. lueck added reviewers: Plasma, Localization, Documentation. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. lueck requested review of this revision. REVISION SUMMARY kcms/launch/kcm_launchfeedback.desktop

D11660: Update systemsettings cursortheme docbook

lueck created this revision. lueck added reviewers: Plasma, Documentation. Restricted Application added a project: Plasma. Restricted Application added subscribers: kde-doc-english, plasma-devel. lueck requested review of this revision. REVISION SUMMARY proofread + update bump date +

D11659: Update systemsettings fonts docbook to 5.12

lueck added a comment. The kcm_fonts.desktop file has an entry X-DocPath=kcontrol/fonts/index.html, but the Help button in the QML module is disabled REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11659 To: lueck, #plasma, #documentation Cc: plasma-devel,

D11659: Update systemsettings fonts docbook to 5.12

lueck added a comment. F5765097: main.png F5765096: adjust-all.png New updated screenshots REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11659 To: lueck, #plasma,

D11659: Update systemsettings fonts docbook to 5.12

lueck created this revision. lueck added reviewers: Plasma, Documentation. Restricted Application added a project: Plasma. Restricted Application added subscribers: kde-doc-english, plasma-devel. lueck requested review of this revision. REVISION SUMMARY proofread + update to match the new GUI

Re: KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9 - Build # 15 - Failure!

On Sun, Mar 25, 2018 at 6:59 AM, Martin Flöser wrote: > Hi Ben, Hi Martin, > > I pushed a possible fix. No guarnatees as this code obviously compiled on my > system. Thanks. That has fixed the issue. > > Could the compiler settings please be adjusted so that we have

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

fvogt added a comment. In D10816#233088 , @graesslin wrote: > In D10816#233074 , @fvogt wrote: > > > `XDG_SESSION_TYPE` is not set if you run `startplasmacompositor` from a tty - so should this

KDE CI: Plasma systemsettings kf5-qt5 FreeBSDQt5.9 - Build # 34 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20systemsettings%20kf5-qt5%20FreeBSDQt5.9/34/ Project: Plasma systemsettings kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 24 Mar 2018 18:49:12 + Build duration: 3 min 33 sec and counting

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

graesslin added a comment. In D10816#233074 , @fvogt wrote: > `XDG_SESSION_TYPE` is not set if you run `startplasmacompositor` from a tty - so should this also check for `WAYLAND_DISPLAY` or `startplasmacompositor` set

D11607: Update systemsettings docbook to 5.12

This revision was automatically updated to reflect the committed changes. Closed by commit R124:b73b544a1281: Update systemsettings docbook to 5.12 (authored by lueck). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11607?vs=30300=30423 REVISION

D11561: fix typos in UI strings

ivan added a comment. > "can't" should not be used in formal writings. Not sure how formal documentation is considered to be. Heh, I was thought that as well, and then had to search'n'replace my whole book to replace with *n't forms of everything. ;) Thanks for this patch!

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

fvogt added a comment. `XDG_SESSION_TYPE` is not set if you run `startplasmacompositor` from a tty - so should this also check for `WAYLAND_DISPLAY` or `startplasmacompositor` set `XDG_SESSION_TYPE=wayland`? REPOSITORY R120 Plasma Workspace REVISION DETAIL

KDE CI: Plasma kwindowsystem stable-kf5-qt5 FreeBSDQt5.9 - Build # 17 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20kwindowsystem%20stable-kf5-qt5%20FreeBSDQt5.9/17/ Project: Plasma kwindowsystem stable-kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 24 Mar 2018 17:54:55 + Build duration: 3 min 29 sec and counting

Re: KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9 - Build # 15 - Failure!

Hi Ben, I pushed a possible fix. No guarnatees as this code obviously compiled on my system. Could the compiler settings please be adjusted so that we have warnings be warnings on all ci systems and not fail on randomly? This was rather unexpected for me and makes it quite difficult to

KDE CI: Plasma kwindowsystem kf5-qt5 FreeBSDQt5.9 - Build # 15 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.9/15/ Project: Plasma kwindowsystem kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 24 Mar 2018 17:54:55 + Build duration: 2 min 57 sec and counting JUnit Tests

D11220: option to force FolderView icon-only presentation

mvourlakos added a comment. In D11220#232803 , @hein wrote: > If it's the only way to end this debate, could you instead implement the patch that uses the icon size setting as switch threshold? I created the following:

D11651: FolderView applet respect panel maxIcon size

mvourlakos updated this revision to Diff 30420. mvourlakos added a comment. - fix typo to iconSizeHints REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11651?vs=30413=30420 BRANCH folderview REVISION DETAIL https://phabricator.kde.org/D11651

D11651: FolderView applet respect panel maxIcon size

mvourlakos created this revision. mvourlakos added reviewers: Plasma, hein, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mvourlakos requested review of this revision. REVISION SUMMARY --FolderView takes into account the

KDE CI: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 - Build # 89 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20FreeBSDQt5.9/89/ Project: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 24 Mar 2018 13:36:55 + Build duration: 48 min and counting

KDE CI: Plasma kwindowsystem kf5-qt5 FreeBSDQt5.9 - Build # 14 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.9/14/ Project: Plasma kwindowsystem kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 24 Mar 2018 13:36:22 + Build duration: 45 min and counting CONSOLE OUTPUT

KDE CI: Plasma kwindowsystem stable-kf5-qt5 FreeBSDQt5.9 - Build # 16 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwindowsystem%20stable-kf5-qt5%20FreeBSDQt5.9/16/ Project: Plasma kwindowsystem stable-kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 24 Mar 2018 13:36:22 + Build duration: 44 min and counting

[kdeplasma-addons] applets: Revert "use plasma_install_bundled_package"

Git commit db0bc0e3116986850f9d6b304b739698caef39d6 by Friedrich W. H. Kossebau. Committed on 24/03/2018 at 14:06. Pushed by kossebau into branch 'master'. Revert "use plasma_install_bundled_package" This reverts commit c505a726b3f1fff95c382e46377b495016d04786. Quoting David Edmundson from

D10251: [RFC] Use mipmap filtering in window thumbnails

ngraham added a comment. Could we land this? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10251 To: fredrik, #plasma, #vdg, davidedmundson Cc: progwolff, broulik, ngraham, hein, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai,

D11631: Fix pixelated icon scaling for HiDPI screens

acrouthamel added a comment. In D11631#232788 , @rkflx wrote: > @acrouthamel Awesome, you made it! Thanks to you and @broulik :) REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde.org/D11631 To: acrouthamel,

D11220: option to force FolderView icon-only presentation

hein added a comment. I really think this is ugly and don't want it :/ If it's the only way to end this debate, could you instead implement the patch that uses the icon size setting as switch threshold? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D11631: Fix pixelated icon scaling for HiDPI screens

This revision was automatically updated to reflect the committed changes. Closed by commit R103:e8e3c0f8e4a1: Fix pixelated icon scaling for HiDPI screens (authored by acrouthamel, committed by rkflx). REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE

D11631: Fixes pixelated icon scaling for HiDPI screens

rkflx accepted this revision. rkflx added a comment. @acrouthamel Awesome, you made it! In D11631#232691 , @cfeck wrote: > Does it still need KIconThemes framework elsewhere? If not, the dependency could be removed. E.g.

Re: KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9 - Build # 15 - Failure!

Hi Martin, Please see below. Could you please fix this as soon as possible? This is blocking all FreeBSD Dependency builds meaning any change to the binary compatibility state of the FreeBSD platform will break the whole CI system on FreeBSD. Cheers, Ben On Wed, Mar 21, 2018 at 6:51 PM, CI

D11639: delete COPYING-ICONS

zzag created this revision. zzag added a reviewer: Breeze. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY Icons are not a part of this repo anymore so delete corresponding COPYING

D11638: modernize: delete redundant return statements

zzag created this revision. zzag added a reviewer: Breeze. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY All these return statements are at the end of functions which return

D11636: modernize: delete redundant void args

zzag created this revision. zzag added a reviewer: Breeze. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY Redundant void args are deleted with clang-tidy. See

D11635: modernize: use nullptr

zzag created this revision. zzag added a reviewer: Breeze. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY The old null pointer constants(NULL, 0, etc) are converted to the the

[plasma-workspace] applets: Revert "use plasma_install_bundled_package"

Git commit 450ef5884d9e93e6f0a2df48aae82f9ed239b394 by David Edmundson. Committed on 24/03/2018 at 07:31. Pushed by davidedmundson into branch 'master'. Revert "use plasma_install_bundled_package" This reverts commit e37156b404bffd4dc6fd0d1b2dbb5dc1ae0ddfa4. Concept is fine, but currently we

D11631: Fixes pixelated icon scaling for HiDPI screens

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. thanks REPOSITORY R103 KMenu Editor BRANCH fix-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D11631 To: acrouthamel, rkflx, broulik,

D11631: Fixes pixelated icon scaling for HiDPI screens

cfeck added a comment. Does it still need KIconThemes framework elsewhere? If not, the dependency could be removed. REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde.org/D11631 To: acrouthamel, rkflx, broulik Cc: cfeck, ngraham, plasma-devel, ZrenBot, lesliezhai,